From: Masahiro Yamada <masahiroy@kernel.org>
To: Liangcai Fan <fanliangcai9@gmail.com>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
zhang.lyra@gmail.com, gengcixi@gmail.com, orson.zhai@unisoc.com,
Liangcai Fan <liangcai.fan@unisoc.com>
Subject: Re: [PATCH] use bash instead of sh to run mkcompile_h
Date: Thu, 26 Dec 2019 18:25:12 +0900 [thread overview]
Message-ID: <CAK7LNAS7Jj0=abxAH4K41BkBfrOLjygBo0KvXyVUO2b240bCww@mail.gmail.com> (raw)
In-Reply-To: <1577253483-24358-1-git-send-email-fanliangcai9@gmail.com>
On Wed, Dec 25, 2019 at 2:58 PM Liangcai Fan <fanliangcai9@gmail.com> wrote:
>
> From: Liangcai Fan <liangcai.fan@unisoc.com>
>
> Use sh to run mkcompile_h, compilation would fail if whoami contains
> backslash, since sh uses dash. The reason is that the echo command would
> interpret backslash to escapes, so the LINUX_COMPILE_BY definition was
> incorrect.
>
> Parse mkcompile_h with bash, the echo command would not see backslash as
> escapes, then there is no error with the definition of LINUX_COMPILE_BY.
>
> Signed-off-by: Liangcai Fan <liangcai.fan@unisoc.com>
> Signed-off-by: Liangcai Fan <fanliangcai9@gmail.com>
> ---
This problem was fixed by
commit c8f3dea90e38194dae542c5d56e05d30447e58cb
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2019-12-26 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 5:58 [PATCH] use bash instead of sh to run mkcompile_h Liangcai Fan
2019-12-26 9:25 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAS7Jj0=abxAH4K41BkBfrOLjygBo0KvXyVUO2b240bCww@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=fanliangcai9@gmail.com \
--cc=gengcixi@gmail.com \
--cc=liangcai.fan@unisoc.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=orson.zhai@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.