All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] libfdt: replace ARCH_FIXUP_FDT with ARCH_FIXUP_FDT_MEMORY
Date: Wed, 5 Oct 2016 12:27:09 +0900	[thread overview]
Message-ID: <CAK7LNASCJhariLQuRSwae1MqaqyAePcMBWYHLnQy-hhS260USQ@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ0kQyB42tMGtSd7V5AVbXEar7vT25k1pN55oRPZsUjPeQ@mail.gmail.com>

Hi Simon,

2016-10-05 0:37 GMT+09:00 Simon Glass <sjg@chromium.org>:

>> diff --git a/common/image-fdt.c b/common/image-fdt.c
>> index 3d23608..91970d4 100644
>> --- a/common/image-fdt.c
>> +++ b/common/image-fdt.c
>> @@ -458,6 +458,11 @@ __weak int ft_verify_fdt(void *fdt)
>>         return 1;
>>  }
>>
>> +__weak int arch_fixup_fdt(void *blob)
>> +{
>> +       return 0;
>> +}
>
> Do we have to have a weak function? I was hoping we could avoid these
> since they make it hard to figure out at build time what code is
> executed.
>


This hunk is just reverting Michal's commit e2f88dfd2d9671.

Is it better to add an empty stub to every architecture that may call it?




-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2016-10-05  3:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 12:03 [U-Boot] [PATCH] libfdt: replace ARCH_FIXUP_FDT with ARCH_FIXUP_FDT_MEMORY Masahiro Yamada
2016-10-04 15:37 ` Simon Glass
2016-10-05  3:27   ` Masahiro Yamada [this message]
2016-10-05 16:09     ` Simon Glass
2016-10-20  0:26       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNASCJhariLQuRSwae1MqaqyAePcMBWYHLnQy-hhS260USQ@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.