All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Jeff Johnson <jjohnson@codeaurora.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Prasad Sodagudi <psodagud@quicinc.com>,
	Elliot Berman <eberman@quicinc.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Mahesh Kumar Kalikot Veetil <mkalikot@codeaurora.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists
Date: Sat, 16 Jan 2021 06:53:29 +0900	[thread overview]
Message-ID: <CAK7LNASLQWiSfY_iGs8hv8mo_yQaKXPpKo7u0BxPpANwkRatQA@mail.gmail.com> (raw)
In-Reply-To: <4c02050c4e95e4cb8cc04282695f8404@codeaurora.org>

On Sat, Jan 16, 2021 at 5:15 AM <jjohnson@codeaurora.org> wrote:
>
> On 2021-01-14 17:12, Masahiro Yamada wrote:
> > On Fri, Jan 15, 2021 at 6:50 AM Jeff Johnson <jjohnson@codeaurora.org>
> > wrote:
> >>
> >> From: Mahesh Kumar Kalikot Veetil <mkalikot@codeaurora.org>
> >>
> >> Modules with a large number of compilation units may be
> >> exceeding AR and LD command argument list. Handle this gracefully by
> >> writing the long argument list in a file. The command line options
> >> read from file are inserted in place of the original @file option.
> >>
> >> The usage is well documented at
> >> https://www.gnu.org/software/make/manual/html_node/File-Function.html
> >>
> >> Signed-off-by: Mahesh Kumar Kalikot Veetil <mkalikot@codeaurora.org>
> >> Signed-off-by: Jeff Johnson <jjohnson@codeaurora.org>
> >> ---
> >
> >
> >
> >
> > First, is this a real problem?
> > If so, which module is exceeding the command line limit?
>
> On 2021-01-14 17:12, Masahiro Yamada wrote:
> > First, is this a real problem?
> > If so, which module is exceeding the command line limit?
>
> Mahesh & I appreciate all of the feedback.
>
> The issue is seen in an Android environment with an out-of-tree
> driver. The combination of long path names and a large number
> of source files is leading to the issue.
>
> Since Mahesh & I are not Kbuild gurus, is there an alternative
> solution to this issue?
>
> Jeff


I see.

The support for out-of-tree modules
is not nice in this regard, but fixing it
would need many changes.


The long-term solution might be to upstream your driver,
but it might not be possible.






One cheesy workaround might be to point the module path
via a symbolic link.


Let's say your module is located in a very deep
directory,
/home/foo/long/long/.../path/to/your/module


 make M=/home/foo/long/long/.../path/to/your/module modules

would fail due to the too long command line.




First, create a symbolic link as follows:

 ln -s /home/foo/long/long/.../path/to/your/module mod_dir


Then, pass the symbolic link to M= option.

 make M=mod_dir modules




-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2021-01-15 21:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13  1:18 [PATCH 1/2] kbuild: simplify cmd_mod Jeff Johnson
2021-01-13  1:18 ` [PATCH 2/2] kbuild: handle excessively long argument lists Jeff Johnson
2021-01-14 21:07   ` Nick Desaulniers
2021-01-14 21:32     ` jjohnson
2021-01-14 21:49   ` [PATCH v2 " Jeff Johnson
2021-01-15  1:00     ` Nick Desaulniers
2021-01-15  1:25       ` Masahiro Yamada
2021-01-15  1:12     ` Masahiro Yamada
2021-01-15 20:15       ` jjohnson
2021-01-15 21:53         ` Masahiro Yamada [this message]
2021-01-19 20:02           ` mkalikot
2021-01-15  1:07 ` [PATCH 1/2] kbuild: simplify cmd_mod Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNASLQWiSfY_iGs8hv8mo_yQaKXPpKo7u0BxPpANwkRatQA@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=eberman@quicinc.com \
    --cc=jjohnson@codeaurora.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mkalikot@codeaurora.org \
    --cc=ndesaulniers@google.com \
    --cc=psodagud@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.