All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] armv8: fix #if around spin-table code in start.S
Date: Mon, 16 Jan 2017 10:19:46 +0900	[thread overview]
Message-ID: <CAK7LNASQNgSDpSJy9_w9Ro1YhM3HJk8GyNg-FCspAe5cUg3ysQ@mail.gmail.com> (raw)
In-Reply-To: <20170115182938.GP19689@bill-the-cat>

Hi Tom.


2017-01-16 3:29 GMT+09:00 Tom Rini <trini@konsulko.com>:
> On Tue, Dec 27, 2016 at 11:19:43AM +0200, Oded Gabbay wrote:
>
>> Using CONFIG_IS_ENABLED() doesn't work in SPL. This patch replaces the only
>> occurrence of CONFIG_IS_ENABLED() in start.S to a regular #if defined().
>> It also adds "&& !defined(CONFIG_SPL_BUILD)" to that #if statement because
>> the spin-table code can't currently work in SPL, and the spin-table file
>> isn't even compiled in SPL.
>>
>> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
>
> Applied to u-boot/master, thanks!
>
> --
> Tom
>


I had not noticed this patch until it was applied.

At least, the statement in the git-log
"Using CONFIG_IS_ENABLED() doesn't work in SPL" is wrong.
So, when I saw the git history today, I wondered what was going on.
Then, I found this discussion in the ML.

It does not matter to either apply or discard this patch
because it is a matter of taste.


If you decide to apply it,
the git-log should have been replaced with Oded's comment:

--------
You need to go to kconfig.h, read the comments there to
understand how CONFIG_IS_ENABLED is working with SPL, which is more
tiresome than just doing straight #ifdef. It is definitely more
confusing for a newbee.

In addition, this patch makes the code more consistent, because all
other configuration checks in start.S use a straight #ifdef and not
CONFIG_IS_ENABLED.
----------


It is too late this time, but please take care of it next time.



-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2017-01-16  1:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-27  9:19 [U-Boot] [PATCH] armv8: fix #if around spin-table code in start.S Oded Gabbay
2017-01-10 23:14 ` Tom Rini
2017-01-11  8:11   ` Oded Gabbay
2017-01-15 18:29 ` [U-Boot] " Tom Rini
2017-01-16  1:19   ` Masahiro Yamada [this message]
2017-01-17  1:22     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNASQNgSDpSJy9_w9Ro1YhM3HJk8GyNg-FCspAe5cUg3ysQ@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.