From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752498AbdKUDE3 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Nov 2017 22:04:29 -0500
Received: from conssluserg-04.nifty.com ([210.131.2.83]:47082 "EHLO
        conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752262AbdKUDE1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Nov 2017 22:04:27 -0500
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com vAL34EaX009407
X-Nifty-SrcIP: [209.85.213.175]
X-Google-Smtp-Source: AGs4zMaGUl0wiHsqZbcWWyzsK6z5OlAD/ELNoRveLjFY9cH9tjZR4CqglgGxp5LZjC10fU7W50STyzTwKppXKYR1/vw=
MIME-Version: 1.0
In-Reply-To: <20171120203125.nbtaeqpwk4zg6fxz@ninjato>
References: <1510042172-27220-1-git-send-email-yamada.masahiro@socionext.com>
 <1510042172-27220-2-git-send-email-yamada.masahiro@socionext.com> <20171120203125.nbtaeqpwk4zg6fxz@ninjato>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Tue, 21 Nov 2017 12:03:33 +0900
X-Gmail-Original-Message-ID: <CAK7LNASRK+2vr2TSB-M7OM0NWehEM58pZc_8g2reLHDCx26x1Q@mail.gmail.com>
Message-ID: <CAK7LNASRK+2vr2TSB-M7OM0NWehEM58pZc_8g2reLHDCx26x1Q@mail.gmail.com>
Subject: Re: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Simon Horman <simon.horman@netronome.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2017-11-21 5:31 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>:
>
>> -             ret = PTR_ERR(priv->clk);
>> -             dev_err(&pdev->dev, "cannot get clock: %d\n", ret);
>> -             goto eprobe;
>> +             dev_err(&pdev->dev, "cannot get clock\n");
>> +             return PTR_ERR(priv->clk);
>
> Why dropping the 'ret' printout? Will it be printed by the core?
>

No.
I just wanted to save "ret = PTR_ERR(priv->clk)" line.


I will restore the printout as follows:

priv->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(priv->clk)) {
        ret = PTR_ERR(priv->clk);
        dev_err(&pdev->dev, "cannot get clock: %d\n", ret);
        return ret;
}



-- 
Best Regards
Masahiro Yamada