From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Arseny Maslennikov <ar@cs.msu.ru>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
Riku Voipio <riku.voipio@linaro.org>
Subject: Re: [PATCH v2 2/3] scripts/package/mkdebian: avoid implicit effects
Date: Sun, 17 Mar 2019 12:02:57 +0900 [thread overview]
Message-ID: <CAK7LNASRctWUMXG5PSUSG2FMGkQV7jNNcUieUKzxho9r81TU1A@mail.gmail.com> (raw)
In-Reply-To: <20190309154307.23039-2-ar@cs.msu.ru>
On Sun, Mar 10, 2019 at 12:44 AM Arseny Maslennikov <ar@cs.msu.ru> wrote:
>
> * The man page for dpkg-source(1) notes:
>
> > -b, --build directory [format-specific-parameters]
> > Build a source package (--build since dpkg 1.17.14).
> > <...>
> >
> > dpkg-source will build the source package with the first
> > format found in this ordered list: the format indicated
> > with the --format command line option, the format
> > indicated in debian/source/format, “1.0”. The fallback
> > to “1.0” is deprecated and will be removed at some point
> > in the future, you should always document the desired
> > source format in debian/source/format. See section
> > SOURCE PACKAGE FORMATS for an extensive description of
> > the various source package formats.
>
> Thus it would be more foolproof to explicitly use 1.0 (as we always
> did) than to rely on dpkg-source's defaults.
>
> * In a similar vein, debian/rules is not made executable by mkdebian,
> and dpkg-source warns about that but still silently fixes the file.
> Let's be explicit once again.
>
> Signed-off-by: Arseny Maslennikov <ar@cs.msu.ru>
> ---
Applied to linux-kbuild. Thanks.
> scripts/package/mkdebian | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index f030961c5165..d276eb671a27 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -132,7 +132,9 @@ else
> echo >&2 "Install lsb-release or set \$KDEB_CHANGELOG_DIST explicitly"
> fi
>
> -mkdir -p debian/
> +mkdir -p debian/source/
> +echo "1.0" > debian/source/format
> +
> echo $debarch > debian/arch
>
> # Generate a simple changelog template
> @@ -221,5 +223,6 @@ clean:
>
> binary: binary-arch
> EOF
> +chmod +x debian/rules
>
> exit 0
> --
> 2.20.1
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-03-17 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 15:43 [PATCH v2 1/3] scripts/package/Makefile: put proper config in source tarball Arseny Maslennikov
2019-03-09 15:43 ` [PATCH v2 2/3] scripts/package/mkdebian: avoid implicit effects Arseny Maslennikov
2019-03-17 3:02 ` Masahiro Yamada [this message]
2019-03-09 15:43 ` [PATCH v2 3/3] package: {mkdebian,Makefile}: ignore .config in dpkg-source diffs Arseny Maslennikov
2019-03-09 16:47 ` [PATCH v2 1/3] scripts/package/Makefile: put proper config in source tarball Arseny Maslennikov
2019-03-11 17:43 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASRctWUMXG5PSUSG2FMGkQV7jNNcUieUKzxho9r81TU1A@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=ar@cs.msu.ru \
--cc=ben@decadent.org.uk \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.