From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57681C433E0 for ; Tue, 30 Jun 2020 02:50:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E0EF2071A for ; Tue, 30 Jun 2020 02:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593485432; bh=j41GRa5NWDDLcN2iPLGZ+gNDaFJ+B0mdsTtqVkpOqb4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=WvLnR2oaqx1ptkEUdJjdyjA7ABmR5yhro/aW9qz/RMdEv2JasD2J3NiHTNxZK0rqu ITuoBjZOZLqQswVmlHFkcNQ7MTuPTFmuryLIEBg995eJjza9VA2cqrGJ65fxjk6uYV KGtOQz1Omy2BSxE+MiHa7nI0ECLQ/9ZPrnRaN1zE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbgF3Cub (ORCPT ); Mon, 29 Jun 2020 22:50:31 -0400 Received: from conssluserg-03.nifty.com ([210.131.2.82]:62879 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728816AbgF3Cua (ORCPT ); Mon, 29 Jun 2020 22:50:30 -0400 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) (authenticated) by conssluserg-03.nifty.com with ESMTP id 05U2o19Z021640; Tue, 30 Jun 2020 11:50:02 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 05U2o19Z021640 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1593485402; bh=BA2eIyq2Y+jYf/ti3GO+cZXuKicFpz1r5ISiK8LSAvY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tMce/cNtrkGVxiWEh8CgHYjMe0oRiNnwcAzc0t/BMSkUwoG6qtrSCb2eugH6xo+5u nYlgB9VwjZUyqp8oB3qUkliBy5rwmil62gyP8b5Bn4XwBxNXzZoL8QsfUKe/YQ2l/1 HN/aOaSupth3Af3yhfCw6TqazE84KWco1P7JMVwVbKppqZBmn2TNhv1odNIc08fA/j IsImtGcPcn6pbujzxkae4oJ5OCbmtPd78jqiyPcBp9dpwaBxyIyOI4fYNs7QUFNX6C eubo58ZQHzSXpjShKNDj73Hb0GrusMcr+WhZcmlr3qjp1FRMJlBdPNcj2DgD7Gbsyn 2P2kaKbDOyW+A== X-Nifty-SrcIP: [209.85.217.49] Received: by mail-vs1-f49.google.com with SMTP id v1so10363731vsb.10; Mon, 29 Jun 2020 19:50:02 -0700 (PDT) X-Gm-Message-State: AOAM532+/WLMl6dA5bq+hBim2bZlT63mCImoRIZLvdCuR6/szAhPiYNt BU1hIH0pjYK8PzOdHEaQFXE4wAYIEmET964F7ps= X-Google-Smtp-Source: ABdhPJxUjiFgHFY42gUiJ+UxJkAVVtD4/yV/4lUjDX13AR+eCOVO2Q7jks6yDec71QFY4h0OZ7PuDegZhK6fvQ1g5bg= X-Received: by 2002:a67:1342:: with SMTP id 63mr1729209vst.54.1593485400898; Mon, 29 Jun 2020 19:50:00 -0700 (PDT) MIME-Version: 1.0 References: <45fa5ad583de1766de6169366df1df5837c5dc7c.1593423060.git.mchehab+huawei@kernel.org> In-Reply-To: <45fa5ad583de1766de6169366df1df5837c5dc7c.1593423060.git.mchehab+huawei@kernel.org> From: Masahiro Yamada Date: Tue, 30 Jun 2020 11:49:24 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] kconfig: qconf: navigate menus on hyperlinks To: Mauro Carvalho Chehab Cc: Maxim Levitsky , Linux Kbuild mailing list , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 6:35 PM Mauro Carvalho Chehab wrote: > > Instead of just changing the helper window to show a > dependency, also navigate to it at the config and menu > widgets. > > Signed-off-by: Mauro Carvalho Chehab Thanks, I think this is a nice improvement. When I click a link, both the previous config and the new one are highlighted. Is this intentional behavior? For example, put the following simple Kconfig at the top-level. >From the info window of FOO, click the 'select BAR' link, and then both FOO and BAR are highlighted. ------------>8--------------- config FOO bool "foo" select BAR default y config BAR bool "bar" default y ------------>8----------------- > --- > scripts/kconfig/qconf.cc | 24 +++++------------------- > 1 file changed, 5 insertions(+), 19 deletions(-) > > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc > index 49f0688fceb8..d8870b15a178 100644 > --- a/scripts/kconfig/qconf.cc > +++ b/scripts/kconfig/qconf.cc > @@ -1232,7 +1232,6 @@ void ConfigInfoView::clicked(const QUrl &url) > char *data = new char[count + 1]; > struct symbol **result; > struct menu *m = NULL; > - char type; > > if (count < 1) { > qInfo() << "Clicked link is empty"; > @@ -1242,7 +1241,6 @@ void ConfigInfoView::clicked(const QUrl &url) > > memcpy(data, str.constData(), count); > data[count] = '\0'; > - type = data[0]; > > /* Seek for exact match */ > data[0] = '^'; > @@ -1255,15 +1253,8 @@ void ConfigInfoView::clicked(const QUrl &url) > } > > sym = *result; > - if (type == 's') { > - symbolInfo(); > - emit showDebugChanged(true); > - free(result); > - delete data; > - return; > - } > > - /* URL is a menu */ > + /* Seek for the menu which holds the symbol */ > for (struct property *prop = sym->prop; prop; prop = prop->next) { > if (prop->type != P_PROMPT && prop->type != P_MENU) > continue; > @@ -1271,17 +1262,11 @@ void ConfigInfoView::clicked(const QUrl &url) > break; > } > > - if (!m) { > + if (!m) > qInfo() << "Clicked menu is invalid:" << data; > - free(result); > - delete data; > - return; > - } > + else > + emit menuSelected(m); > > - _menu = m; > - menuInfo(); > - > - emit showDebugChanged(true); > free(result); > delete data; > } > @@ -1750,6 +1735,7 @@ void ConfigMainWindow::setMenuLink(struct menu *menu) > item->setSelected(true); > list->scrollToItem(item); > list->setFocus(); > + helpText->setInfo(menu); > } > } > } > -- > 2.26.2 > -- Best Regards Masahiro Yamada