All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Richard Weinberger <richard@nod.at>,
	Ley Foon Tan <lftan@altera.com>, Michal Simek <monstr@monstr.eu>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	linux-um@lists.infradead.org, linux-arch@lists.infradead.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: include architecture Kconfig files from top-level Kconfig v3
Date: Fri, 27 Jul 2018 10:32:19 +0900	[thread overview]
Message-ID: <CAK7LNASd0YCj4wwmT9-6GYiBz=wDoXkmQW2F_5XjbCzS9-weUw@mail.gmail.com> (raw)
In-Reply-To: <20180726172143.GA9836@lst.de>

2018-07-27 2:21 GMT+09:00 Christoph Hellwig <hch@lst.de>:
> On Wed, Jul 25, 2018 at 01:30:24PM +0900, Masahiro Yamada wrote:
>> Could you check the difference of CONFIG_PREEMPT_COUNT, please?
>>
>>
>> For alpha, hexagon, um,
>> CONFIG_PREEMPT_COUNT was previously never enabled
>> because kernel/Kconfig.preempt was not included.
>>
>> Now, CONFIG_PREEMPT_COUNT can be enabled
>> if it is select'ed by someone.
>>
>> I guess this change will be OK, but
>> I'd like you and Randy to double-check it just in case.
>
> It might be fine, but with this little fix folded in we should be
> safer:
>
> diff --git a/kernel/Kconfig.preempt b/kernel/Kconfig.preempt
> index cd1655122ec0..1321a4a7a677 100644
> --- a/kernel/Kconfig.preempt
> +++ b/kernel/Kconfig.preempt
> @@ -57,4 +57,5 @@ config PREEMPT
>  endchoice
>
>  config PREEMPT_COUNT
> -       bool
> \ No newline at end of file
> +       depends on !ARCH_NO_PREEMPT
> +       bool
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



This will just add a new unmet dependency warning.
CONFIG_PREEMPT_COUNT will be still selected.


$ make ARCH=alpha allyesconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  YACC    scripts/kconfig/zconf.tab.c
  LEX     scripts/kconfig/zconf.lex.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
scripts/kconfig/conf  --allyesconfig Kconfig

WARNING: unmet direct dependencies detected for PREEMPT_COUNT
  Depends on [n]: !ARCH_NO_PREEMPT [=y]
  Selected by [y]:
  - DEBUG_ATOMIC_SLEEP [=y] && DEBUG_KERNEL [=y]
#
# configuration written to .config
#






-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2018-07-27  1:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 17:56 include architecture Kconfig files from top-level Kconfig v3 Christoph Hellwig
2018-07-24 17:56 ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 01/10] um: stop abusing KBUILD_KCONFIG Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 02/10] um: cleanup Kconfig files Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 03/10] um: create a proper drivers Kconfig Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 04/10] kconfig: remove duplicate SWAP symbol defintions Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 05/10] kconfig: include common Kconfig files from top-level Kconfig Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 06/10] Kconfig: consolidate the "Kernel hacking" menu Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 07/10] kconfig: include kernel/Kconfig.preempt from init/Kconfig Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 08/10] kconfig: use a menu in arch/Kconfig to reduce clutter Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 09/10] kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-24 17:56 ` [PATCH 10/10] kconfig: add a Memory Management options" menu Christoph Hellwig
2018-07-24 17:56   ` Christoph Hellwig
2018-07-25  4:30 ` include architecture Kconfig files from top-level Kconfig v3 Masahiro Yamada
2018-07-25  4:30   ` Masahiro Yamada
2018-07-26 17:21   ` Christoph Hellwig
2018-07-26 17:21     ` Christoph Hellwig
2018-07-27  1:32     ` Masahiro Yamada [this message]
2018-07-27  7:48       ` Christoph Hellwig
2018-07-28  0:50         ` Masahiro Yamada
2018-07-28  0:50           ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNASd0YCj4wwmT9-6GYiBz=wDoXkmQW2F_5XjbCzS9-weUw@mail.gmail.com' \
    --to=yamada.masahiro@socionext.com \
    --cc=hch@lst.de \
    --cc=lftan@altera.com \
    --cc=linux-arch@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=monstr@monstr.eu \
    --cc=rdunlap@infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.