linux-next: build failure after merge of the kbuild tree

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

cc1: fatal error: FORCE: No such file or directory
compilation terminated.

Presuably caused by commit

  15bb90419621 ("arch: syscalls: add missing FORCE and fix 'targets' to make if_changed work")

I have used the kbuild tree from next-20210219 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Hi Stephen,

On Mon, Feb 22, 2021 at 6:33 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> cc1: fatal error: FORCE: No such file or directory
> compilation terminated.
>
> Presuably caused by commit
>
>   15bb90419621 ("arch: syscalls: add missing FORCE and fix 'targets' to make if_changed work")

Sorry, this happens only when CONFIG_XEN=y,
and I did not cover all cases.

I will fix it for tomorrow's linux-next.


If it is not too late, you can apply the following locally.



diff --git a/arch/x86/entry/syscalls/Makefile b/arch/x86/entry/syscalls/Makefile
index e1c7ddb7546b..ea6ffb51b9a3 100644
--- a/arch/x86/entry/syscalls/Makefile
+++ b/arch/x86/entry/syscalls/Makefile
@@ -21,7 +21,7 @@ quiet_cmd_systbl = SYSTBL  $@
       cmd_systbl = $(CONFIG_SHELL) '$(systbl)' $< $@

 quiet_cmd_hypercalls = HYPERCALLS $@
-      cmd_hypercalls = $(CONFIG_SHELL) '$<' $@ $(filter-out $<,$^)
+      cmd_hypercalls = $(CONFIG_SHELL) '$<' $@ $(filter-out $<,$(real-prereqs))

 syshdr_abi_unistd_32 := i386
 $(uapi)/unistd_32.h: $(syscall32) $(syshdr) FORCE






> I have used the kbuild tree from next-20210219 for today.
>
> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Fri, Oct 14, 2022 at 10:42 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (i386 defconfig)
> failed like this:
>
> In file included from arch/x86/kernel/head_32.S:29:
> arch/x86/include/asm/pgtable_32.h:68:5: error: "PTRS_PER_PMD" is not defined, evaluates to 0 [-Werror=undef]
>    68 | #if PTRS_PER_PMD > 1
>       |     ^~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Exposed by commit
>
>   0a7606a9832a ("kbuild: move -Wundef from KBUILD_CFLAGS to KBUILD_CPPFLAGS")
>
> I have no idea what the root cause is. :-(
>
> It is a great pity that this commit was not in linux-next before the
> merge window opened. :-(



Sorry for the annoyance again.

I gave up this patch for now.

I will drop it and need to sort out warnings.





>
> I have applied the following hack for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 14 Oct 2022 12:34:34 +1100
> Subject: [PATCH] i386: hack for "kbuild: move -Wundef from KBUILD_CFLAGS to KBUILD_CPPFLAGS"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/x86/include/asm/pgtable_32.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/pgtable_32.h b/arch/x86/include/asm/pgtable_32.h
> index 7c9c968a42ef..0f3f186ca140 100644
> --- a/arch/x86/include/asm/pgtable_32.h
> +++ b/arch/x86/include/asm/pgtable_32.h
> @@ -65,7 +65,7 @@ do {                                          \
>   * With PAE paging (PTRS_PER_PMD > 1), we allocate PTRS_PER_PGD == 4 pages for
>   * the PMD's in addition to the pages required for the last level pagetables.
>   */
> -#if PTRS_PER_PMD > 1
> +#if defined(PTRS_PER_PMD) && (PTRS_PER_PMD > 1)
>  #define PAGE_TABLE_SIZE(pages) (((pages) / PTRS_PER_PMD) + PTRS_PER_PGD)
>  #else
>  #define PAGE_TABLE_SIZE(pages) ((pages) / PTRS_PER_PGD)
> --
> 2.35.1
>
> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (i386 defconfig)
failed like this:

In file included from arch/x86/kernel/head_32.S:29:
arch/x86/include/asm/pgtable_32.h:68:5: error: "PTRS_PER_PMD" is not defined, evaluates to 0 [-Werror=undef]
   68 | #if PTRS_PER_PMD > 1
      |     ^~~~~~~~~~~~
cc1: all warnings being treated as errors

Exposed by commit

  0a7606a9832a ("kbuild: move -Wundef from KBUILD_CFLAGS to KBUILD_CPPFLAGS")

I have no idea what the root cause is. :-(

It is a great pity that this commit was not in linux-next before the
merge window opened. :-(

I have applied the following hack for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 14 Oct 2022 12:34:34 +1100
Subject: [PATCH] i386: hack for "kbuild: move -Wundef from KBUILD_CFLAGS to KBUILD_CPPFLAGS"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/include/asm/pgtable_32.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/pgtable_32.h b/arch/x86/include/asm/pgtable_32.h
index 7c9c968a42ef..0f3f186ca140 100644
--- a/arch/x86/include/asm/pgtable_32.h
+++ b/arch/x86/include/asm/pgtable_32.h
@@ -65,7 +65,7 @@ do {						\
  * With PAE paging (PTRS_PER_PMD > 1), we allocate PTRS_PER_PGD == 4 pages for
  * the PMD's in addition to the pages required for the last level pagetables.
  */
-#if PTRS_PER_PMD > 1
+#if defined(PTRS_PER_PMD) && (PTRS_PER_PMD > 1)
 #define PAGE_TABLE_SIZE(pages) (((pages) / PTRS_PER_PMD) + PTRS_PER_PGD)
 #else
 #define PAGE_TABLE_SIZE(pages) ((pages) / PTRS_PER_PGD)
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

Hi Masahiro,

On Thu, 13 Oct 2022 07:34:21 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Or, if it is not too late,
> can you revert only commit 61168a974a16?

Sorry, too late.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Thu, Oct 13, 2022 at 7:17 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
>
> Exposed by commit
>
>   61168a974a16 ("Makefile: add implicit enum-conversion check for compile build")
>
> We don't add compiler flags that produce more warnings/errors without
> first fixing the known problems.  This was the example of what would
> happen that was cited in the commit message.
>
> I have used the kbuild tree from next-20221012 for today.
>
> Is this new stuff really destined for 6.1?
>
> The actual error was caused by commits
>
>   5fc11598166d ("drm/amd/display: expand dml structs")
>   d478667253f9 ("drm/amd/display: use odm combine for YCbCr420 timing with h_active greater than 4096")
>
> which entered Linus' tree during this merge window.
>
> --
> Cheers,
> Stephen Rothwell


Or, if it is not too late,
can you revert only commit 61168a974a16?


I will drop it for tomorrow's linux-next.




-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:


Exposed by commit

  61168a974a16 ("Makefile: add implicit enum-conversion check for compile build")

We don't add compiler flags that produce more warnings/errors without
first fixing the known problems.  This was the example of what would
happen that was cited in the commit message.

I have used the kbuild tree from next-20221012 for today.

Is this new stuff really destined for 6.1?

The actual error was caused by commits

  5fc11598166d ("drm/amd/display: expand dml structs")
  d478667253f9 ("drm/amd/display: use odm combine for YCbCr420 timing with h_active greater than 4096")

which entered Linus' tree during this merge window.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi Masahiro,

On Mon, 12 Sep 2022 14:06:01 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> BTW, as you may have noticed already,
> sub-directories are now listed in ./Kbuild.
> 
> 
> So, you will need to move the rust/ entry accordingly.
> 
> obj-$(CONFIG_IO_URING)  += io_uring/
> obj-$(CONFIG_RUST)      += rust/              <--- Move from Makefile
> obj-y                   += drivers/
> 
> I have not tested the merge result, though.

Thanks for the heads up.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Mon, Sep 12, 2022 at 8:59 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Masahiro,
>
> On Fri, 9 Sep 2022 19:30:24 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > The following fix will make it working again.
> >
>  diff --git a/Makefile b/Makefile
> > index b459e3d0fc5a..c8fba03ec93c 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1151,7 +1151,6 @@ quiet_cmd_autoksyms_h = GEN     $@
> >  $(autoksyms_h):
> >         $(call cmd,autoksyms_h)
> >
> > -targets += vmlinux.o
> >  vmlinux.o: autoksyms_recursive $(KBUILD_VMLINUX_OBJS)
> > $(KBUILD_VMLINUX_LIBS) FORCE
> >         $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.vmlinux_o
>
> Thank you.  The kbuild tree merge builds fine again.
>
> --
> Cheers,
> Stephen Rothwell



That is good news.




BTW, as you may have noticed already,
sub-directories are now listed in ./Kbuild.


So, you will need to move the rust/ entry accordingly.




obj-$(CONFIG_IO_URING)  += io_uring/
obj-$(CONFIG_RUST)      += rust/              <--- Move from Makefile
obj-y                   += drivers/



I have not tested the merge result, though.






--
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi Masahiro,

On Fri, 9 Sep 2022 19:30:24 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> The following fix will make it working again.
> 
 diff --git a/Makefile b/Makefile
> index b459e3d0fc5a..c8fba03ec93c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1151,7 +1151,6 @@ quiet_cmd_autoksyms_h = GEN     $@
>  $(autoksyms_h):
>         $(call cmd,autoksyms_h)
> 
> -targets += vmlinux.o
>  vmlinux.o: autoksyms_recursive $(KBUILD_VMLINUX_OBJS)
> $(KBUILD_VMLINUX_LIBS) FORCE
>         $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.vmlinux_o

Thank you.  The kbuild tree merge builds fine again.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

Hi,

On Fri, 9 Sep 2022 15:48:55 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> > $ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../obj -j15 -O
> > make[1]: Entering directory '/home/sfr/kernels/obj'
> >   GEN     Makefile
> > make[1]: Leaving directory '/home/sfr/kernels/obj'
> > make[1]: Entering directory '/home/sfr/kernels/obj'
> >   UPD     include/generated/compile.h
> > make[1]: Leaving directory '/home/sfr/kernels/obj'  
> 
> 
> Weird 'Entering/Leaving directory' logs.

That is because I pass -O to make.

Without -O, I get:

$ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../obj -j15
make[1]: Entering directory '/home/sfr/kernels/obj'
  GEN     Makefile
  DESCEND objtool
make[2]: *** No rule to make target 'objtool/objtool'.  Stop.
make[1]: *** [/home/sfr/kernels/test/Makefile:1351: tools/objtool/objtool] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/home/sfr/kernels/obj'
make: *** [Makefile:222: __sub-make] Error 2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Hi,

On Fri, 9 Sep 2022 15:48:55 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
>> I tried this.
> 
> I built fa8e6bb658f682ff63b3af3dd4c5e4d3b43f4ffd (pending-fixes) first,
> then merged b326faa3e125.

I don't have b326faa3e125 in my tree at all ... the kbuild/for-next
branch I fetched this morning is commit

  99ea8da56dca "kbuild: use objtool-args-y to clean up objtool arguments"

Commit b326faa3e125 looks like it is your "foo3" branch which does
*not* contain your for-next branch.

I presume your builds are on an x86_64 machine?

I did a bisect which lead me to commit

f96f5ad080fe kbuild: move vmlinux.o rule to the top Makefile

So, I did:

build pending-fixes
merge f96f5ad080fe^
build again - which works fine

reset to pending-fixes and rebuild
merge f96f5ad080fe
build fails

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Fri, Sep 9, 2022 at 3:14 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi,
>
> On Fri, 9 Sep 2022 15:24:53 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 9 Sep 2022 14:10:06 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> > >
> > > Hmm, I am testing allmodconfig in my tree,
> > > but it is not reproducible so far.
> > >
> > > Do you have any more hint?
> > > (which commit exactly?, and what build command did you use? etc.)
> >
> > I was trying your top of tree commit
> >
> >   99ea8da56dca "kbuild: use objtool-args-y to clean up objtool arguments"
> >
> > (merged with Linus' tree and some fix patches).
> >
> > I am doing a cross build with an out of tree object directory:
> >
> > $ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../x86_64_allmodconfig -s allmodconfig
> > $ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../x86_64_allmodconfig -j100 -O -s
>
> So it seems to be related to doing an incremental build.  I have just
> built my "pending-fixes" branch (which I have pushed out to the
> linux-next tree on git.kernel.org), then merged your tree and then
> built again:

I tried this.

I built fa8e6bb658f682ff63b3af3dd4c5e4d3b43f4ffd (pending-fixes) first,
then merged b326faa3e125.



masahiro@oscar:~/ref/linux-next$ git show --pretty=fuller
commit ca2e36215ba55dab29160cfe0512b5a8a172efe0 (HEAD -> merge-kbuild)
Merge: fa8e6bb658f6 b326faa3e125
Author:     Masahiro Yamada <masahiroy@kernel.org>
AuthorDate: Fri Sep 9 15:41:07 2022 +0900
Commit:     Masahiro Yamada <masahiroy@kernel.org>
CommitDate: Fri Sep 9 15:41:07 2022 +0900

    Merge ../../workspace/linux-kbuild into merge-kbuild



>
> $ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../obj -j15 -O
> make[1]: Entering directory '/home/sfr/kernels/obj'
>   GEN     Makefile
> make[1]: Leaving directory '/home/sfr/kernels/obj'
> make[1]: Entering directory '/home/sfr/kernels/obj'
>   UPD     include/generated/compile.h
> make[1]: Leaving directory '/home/sfr/kernels/obj'


Weird 'Entering/Leaving directory' logs.






In my case, it went quite normally.

I see only one 'Entering directory', with no error.



masahiro@oscar:~/ref/linux-next$ make ARCH=x86_64
CROSS_COMPILE=x86_64-linux-gnu- O=../obj  -j24
make[1]: Entering directory '/home/masahiro/ref/obj'
  GEN     Makefile
  DESCEND objtool
  CALL    /home/masahiro/ref/linux-next/scripts/atomic/check-atomics.sh
  CALL    /home/masahiro/ref/linux-next/scripts/checksyscalls.sh
  CHK     include/generated/compile.h










>   DESCEND objtool
> make[2]: *** No rule to make target 'objtool/objtool'.  Stop.
> make[1]: *** [/home/sfr/kernels/test/Makefile:1361: tools/objtool/objtool] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:222: __sub-make] Error 2
>
> (I actually did this on my laptop rather than my build machine, but the
> compiles are still cross compiles - just from arm64 instead of
> powerpc64le).
> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

Hi,

On Fri, 9 Sep 2022 15:24:53 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 9 Sep 2022 14:10:06 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Hmm, I am testing allmodconfig in my tree,
> > but it is not reproducible so far.
> > 
> > Do you have any more hint?
> > (which commit exactly?, and what build command did you use? etc.)  
> 
> I was trying your top of tree commit
> 
>   99ea8da56dca "kbuild: use objtool-args-y to clean up objtool arguments"
> 
> (merged with Linus' tree and some fix patches).
> 
> I am doing a cross build with an out of tree object directory:
> 
> $ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../x86_64_allmodconfig -s allmodconfig
> $ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../x86_64_allmodconfig -j100 -O -s

So it seems to be related to doing an incremental build.  I have just
built my "pending-fixes" branch (which I have pushed out to the
linux-next tree on git.kernel.org), then merged your tree and then
built again:

$ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../obj -j15 -O
make[1]: Entering directory '/home/sfr/kernels/obj'
  GEN     Makefile
make[1]: Leaving directory '/home/sfr/kernels/obj'
make[1]: Entering directory '/home/sfr/kernels/obj'
  UPD     include/generated/compile.h
make[1]: Leaving directory '/home/sfr/kernels/obj'
  DESCEND objtool
make[2]: *** No rule to make target 'objtool/objtool'.  Stop.
make[1]: *** [/home/sfr/kernels/test/Makefile:1361: tools/objtool/objtool] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:222: __sub-make] Error 2

(I actually did this on my laptop rather than my build machine, but the
compiles are still cross compiles - just from arm64 instead of
powerpc64le).
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

Hi,

On Fri, 9 Sep 2022 14:10:06 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Hmm, I am testing allmodconfig in my tree,
> but it is not reproducible so far.
> 
> Do you have any more hint?
> (which commit exactly?, and what build command did you use? etc.)

I was trying your top of tree commit

  99ea8da56dca "kbuild: use objtool-args-y to clean up objtool arguments"

(merged with Linus' tree and some fix patches).

I am doing a cross build with an out of tree object directory:

$ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../x86_64_allmodconfig -s allmodconfig
$ make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- O=../x86_64_allmodconfig -j100 -O -s

$ x86_64-linux-gnu-gcc --version
x86_64-linux-gnu-gcc (Debian 11.2.0-9) 11.2.0
$ x86_64-linux-gnu-ld --version
GNU ld (GNU Binutils for Debian) 2.37
$ make --version
GNU Make 4.3
Built for powerpc64le-unknown-linux-gnu

> > make[2]: *** No rule to make target 'objtool/objtool'.  Stop.  
> 
> Presumably, it is failing in tools/Makefile,
> but I do not know how this can happen...

Right, I could not see what caused this, either.  I tried reverting
that top commit, but that did not help.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Fri, Sep 9, 2022 at 8:00 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:



Hmm, I am testing allmodconfig in my tree,
but it is not reproducible so far.

Do you have any more hint?
(which commit exactly?, and what build command did you use? etc.)



> make[2]: *** No rule to make target 'objtool/objtool'.  Stop.


Presumably, it is failing in tools/Makefile,
but I do not know how this can happen...






> make[1]: *** [/home/sfr/next/next/Makefile:1361: tools/objtool/objtool] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:222: __sub-make] Error 2
>
> I have used the kbuild tree from next-20220907 again (with the last 4
> commits reverted).
>
> --
> Cheers,
> Stephen Rothwell













--
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

make[2]: *** No rule to make target 'objtool/objtool'.  Stop.
make[1]: *** [/home/sfr/next/next/Makefile:1361: tools/objtool/objtool] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:222: __sub-make] Error 2

I have used the kbuild tree from next-20220907 again (with the last 4
commits reverted).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Thu, Sep 8, 2022 at 9:06 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ld: vmlinux.a: member arch/powerpc/kernel/prom_init_check in archive is not an object
> make[2]: *** [scripts/Makefile.vmlinux_o:61: vmlinux.o] Error 1
> make[1]: *** [Makefile:1166: vmlinux.o] Error 2
> make: *** [Makefile:222: __sub-make] Error 2
> Command exited with non-zero status 2
>
> I don't know what caused this.
>
> I have used the kbuild tree from next-20220907 with the top 4 commits
> reverted again.
>
> --
> Cheers,
> Stephen Rothwell



Sorry, it was a mis-conversion.
I will fix it up as follows:






diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
index f264d9b2cb63..ad3decb9f20b 100644
--- a/arch/powerpc/kernel/Makefile
+++ b/arch/powerpc/kernel/Makefile
@@ -203,7 +203,7 @@ obj-$(CONFIG_ALTIVEC)               += vector.o
 obj-$(CONFIG_PPC64)            += entry_64.o
 obj-$(CONFIG_PPC_OF_BOOT_TRAMPOLINE)   += prom_init.o

-obj-$(CONFIG_PPC_OF_BOOT_TRAMPOLINE)   += prom_init_check
+extra-$(CONFIG_PPC_OF_BOOT_TRAMPOLINE) += prom_init_check

 quiet_cmd_prom_init_check = PROMCHK $@
       cmd_prom_init_check = $(CONFIG_SHELL) $< "$(NM)"
$(obj)/prom_init.o; touch $@





-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: vmlinux.a: member arch/powerpc/kernel/prom_init_check in archive is not an object
make[2]: *** [scripts/Makefile.vmlinux_o:61: vmlinux.o] Error 1
make[1]: *** [Makefile:1166: vmlinux.o] Error 2
make: *** [Makefile:222: __sub-make] Error 2
Command exited with non-zero status 2

I don't know what caused this.

I have used the kbuild tree from next-20220907 with the top 4 commits
reverted again.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Wed, Sep 7, 2022 at 9:35 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> /home/sfr/next/next/scripts/mkuboot.sh: line 23: 153700 Bus error               ${MKIMAGE} "$@"
>
> Caused by commit
>
>   c4a7f46f7105 ("kbuild: build init/built-in.a just once")
>
> Reverting that commit (and the following ones) fixes the problem. It
> looks like UIMAGE_NAME gets corrupted in scripts/Makefile.lib as the
> arguments to mkuboot.sh change from
>
> A ppc -O linux -T kernel -C gzip -a 0x00700000 -e 0x007015a4 -n Linux-6.0.0-rc4 -d arch/powerpc/boot/cuImage.sam440ep.gz arch/powerpc/boot/cuImage.sam440ep
>
> to
>
> -A ppc -O linux -T kernel -C gzip -a 0x00700000 -e 0x007015a4 -n Linux-6.0.0-rc4 6.0.0-rc4 -d arch/powerpc/boot/cuImage.sam440ep.gz arch/powerpc/boot/cuImage.sam440ep
>
> (note the extra "6.0.0-rc4") when the above commit is present.
>
> So I have reverted commit c4a7f46f7105 and all the following commits in
> the kbuild tree for today.
>
> I had to do the above build with -j40 to make it consistently fail.
>
> --
> Cheers,
> Stephen Rothwell


Thanks.
arch/powerpc/boot/wrapper searches for the version string in vmlinux,
but now it gets two lines.

I will fix up as follows:


diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index 55978f32fa77..5bdd4dd20bbb 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -433,7 +433,7 @@ fi
 # Extract kernel version information, some platforms want to include
 # it in the image header
 version=`${CROSS}strings "$kernel" | grep '^Linux version [-0-9.]' | \
-    cut -d' ' -f3`
+    head -n1 | cut -d' ' -f3`
 if [ -n "$version" ]; then
     uboot_version="-n Linux-$version"
 fi


-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

/home/sfr/next/next/scripts/mkuboot.sh: line 23: 153700 Bus error               ${MKIMAGE} "$@"

Caused by commit

  c4a7f46f7105 ("kbuild: build init/built-in.a just once")

Reverting that commit (and the following ones) fixes the problem. It
looks like UIMAGE_NAME gets corrupted in scripts/Makefile.lib as the
arguments to mkuboot.sh change from

A ppc -O linux -T kernel -C gzip -a 0x00700000 -e 0x007015a4 -n Linux-6.0.0-rc4 -d arch/powerpc/boot/cuImage.sam440ep.gz arch/powerpc/boot/cuImage.sam440ep

to

-A ppc -O linux -T kernel -C gzip -a 0x00700000 -e 0x007015a4 -n Linux-6.0.0-rc4 6.0.0-rc4 -d arch/powerpc/boot/cuImage.sam440ep.gz arch/powerpc/boot/cuImage.sam440ep

(note the extra "6.0.0-rc4") when the above commit is present.

So I have reverted commit c4a7f46f7105 and all the following commits in
the kbuild tree for today.

I had to do the above build with -j40 to make it consistently fail.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Mon, May 23, 2022 at 7:59 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (sparc64
> defconfig) failed like this:
>
> make[3]: *** Deleting file 'arch/sparc/vdso/vclock_gettime.o'
> scripts/check-local-export: line 36: symbol_types[${name}]: bad array subscript
>
> Caused by commit
>
>   86e4cdec74f0 ("kbuild: check static EXPORT_SYMBOL* by script instead of modpost")
>
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell


Thanks.
I fixed my branch.
I confirmed a successful build for sparc64 defconfig.




-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (sparc64
defconfig) failed like this:

make[3]: *** Deleting file 'arch/sparc/vdso/vclock_gettime.o'
scripts/check-local-export: line 36: symbol_types[${name}]: bad array subscript

Caused by commit

  86e4cdec74f0 ("kbuild: check static EXPORT_SYMBOL* by script instead of modpost")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Fri, Aug 27, 2021 at 10:50 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Masahiro,
>
> On Fri, 27 Aug 2021 09:52:18 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > On Thu, Aug 26, 2021 at 6:13 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the kbuild tree, today's linux-next build (x86_64
> > > allnoconfig) failed like this:
> > >
> > > make[2]: *** No rule to make target 'scripts/mod/empty.o', needed by '__build'.
> > >
> > > Caused by commit
> > >
> > >   624a912f84bc ("kbuild: detect objtool changes correctly and remove .SECONDEXPANSION")
> > >
> > > (at least, reverting that commit fixes it)
> > >
> > > I use a separate object directory and, in this case, it is newly created.
> > >
> > > A build with V=1 and -s removed (and no -j) gives this around the
> > > failure:
> > >
> > > make -f /home/sfr/next/next/scripts/Makefile.build obj=scripts/mod
> > > make[2]: *** No rule to make target 'scripts/mod/empty.o', needed by '__build'.  Stop.
> > > make[1]: *** [/home/sfr/next/next/Makefile:1309: prepare0] Error 2
> > >
> > > I have reverted that commit for today.
> >
> >
> > Hmm, it is strange.
> >
> >
> > I re-applied that commit based on today's linux-next
> > (git cherry-pick  624a912f84bc)
> >
> > allnoconfig built successfully.
> >
> >
> > My build log is as follows.
> >
> > Can you tell the exact steps to reproduce the error?
> >
> >
> >
> > masahiro@grover:~/ref/linux-next$ git log -2 --oneline
> > 5046c6516ca2 (HEAD -> tmp) kbuild: detect objtool changes correctly
> > and remove .SECONDEXPANSION
> > 88fac11862d3 (tag: next-20210826, origin/master, origin/HEAD) Add
> > linux-next specific files for 20210826
> > masahiro@grover:~/ref/linux-next$ rm -rf /tmp/foo
> > masahiro@grover:~/ref/linux-next$ make O=/tmp/foo  allnoconfig all
>
> I did more or less the same:
>
> $ rm -rf ../x86_64_allnoconfig
> $ mkdir ../x86_64_allnoconfig
> $ make ARCH=x86_64 O=../x86_64_allnoconfig CROSS_COMPILE=x86_64-linux-gnu- allnoconfig
> $ make V=1 ARCH=x86_64 O=../x86_64_allnoconfig CROSS_COMPILE=x86_64-linux-gnu- -O
>
> I do cross builds hosted on a PowerPC LE host.
>
> --
> Cheers,
> Stephen Rothwell




Ah, OK.
Now I understood what was happening.

scripts/mod/ is built before objtool, so
the dependency is not met.

I was previously not able to reproduce it
because a stale objtool was remaining in my source tree.
'make clean' cannot clean up objtool.

I will fix it by tomorrow's linux-next.



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2051 bytes --]

Hi Masahiro,

On Fri, 27 Aug 2021 09:52:18 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Thu, Aug 26, 2021 at 6:13 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the kbuild tree, today's linux-next build (x86_64
> > allnoconfig) failed like this:
> >
> > make[2]: *** No rule to make target 'scripts/mod/empty.o', needed by '__build'.
> >
> > Caused by commit
> >
> >   624a912f84bc ("kbuild: detect objtool changes correctly and remove .SECONDEXPANSION")
> >
> > (at least, reverting that commit fixes it)
> >
> > I use a separate object directory and, in this case, it is newly created.
> >
> > A build with V=1 and -s removed (and no -j) gives this around the
> > failure:
> >
> > make -f /home/sfr/next/next/scripts/Makefile.build obj=scripts/mod
> > make[2]: *** No rule to make target 'scripts/mod/empty.o', needed by '__build'.  Stop.
> > make[1]: *** [/home/sfr/next/next/Makefile:1309: prepare0] Error 2
> >
> > I have reverted that commit for today.
> 
> 
> Hmm, it is strange.
> 
> 
> I re-applied that commit based on today's linux-next
> (git cherry-pick  624a912f84bc)
> 
> allnoconfig built successfully.
> 
> 
> My build log is as follows.
> 
> Can you tell the exact steps to reproduce the error?
> 
> 
> 
> masahiro@grover:~/ref/linux-next$ git log -2 --oneline
> 5046c6516ca2 (HEAD -> tmp) kbuild: detect objtool changes correctly
> and remove .SECONDEXPANSION
> 88fac11862d3 (tag: next-20210826, origin/master, origin/HEAD) Add
> linux-next specific files for 20210826
> masahiro@grover:~/ref/linux-next$ rm -rf /tmp/foo
> masahiro@grover:~/ref/linux-next$ make O=/tmp/foo  allnoconfig all

I did more or less the same:

$ rm -rf ../x86_64_allnoconfig
$ mkdir ../x86_64_allnoconfig
$ make ARCH=x86_64 O=../x86_64_allnoconfig CROSS_COMPILE=x86_64-linux-gnu- allnoconfig
$ make V=1 ARCH=x86_64 O=../x86_64_allnoconfig CROSS_COMPILE=x86_64-linux-gnu- -O

I do cross builds hosted on a PowerPC LE host.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Thu, Aug 26, 2021 at 6:13 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allnoconfig) failed like this:
>
> make[2]: *** No rule to make target 'scripts/mod/empty.o', needed by '__build'.
>
> Caused by commit
>
>   624a912f84bc ("kbuild: detect objtool changes correctly and remove .SECONDEXPANSION")
>
> (at least, reverting that commit fixes it)
>
> I use a separate object directory and, in this case, it is newly created.
>
> A build with V=1 and -s removed (and no -j) gives this around the
> failure:
>
> make -f /home/sfr/next/next/scripts/Makefile.build obj=scripts/mod
> make[2]: *** No rule to make target 'scripts/mod/empty.o', needed by '__build'.  Stop.
> make[1]: *** [/home/sfr/next/next/Makefile:1309: prepare0] Error 2
>
> I have reverted that commit for today.
> --
> Cheers,
> Stephen Rothwell



Hmm, it is strange.


I re-applied that commit based on today's linux-next
(git cherry-pick  624a912f84bc)

allnoconfig built successfully.


My build log is as follows.

Can you tell the exact steps to reproduce the error?



masahiro@grover:~/ref/linux-next$ git log -2 --oneline
5046c6516ca2 (HEAD -> tmp) kbuild: detect objtool changes correctly
and remove .SECONDEXPANSION
88fac11862d3 (tag: next-20210826, origin/master, origin/HEAD) Add
linux-next specific files for 20210826
masahiro@grover:~/ref/linux-next$ rm -rf /tmp/foo
masahiro@grover:~/ref/linux-next$ make O=/tmp/foo  allnoconfig all
make[1]: Entering directory '/tmp/foo'
  GEN     Makefile
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  HOSTCC  scripts/kconfig/confdata.o
  HOSTCC  scripts/kconfig/expr.o
  LEX     scripts/kconfig/lexer.lex.c
  YACC    scripts/kconfig/parser.tab.[ch]
  HOSTCC  scripts/kconfig/lexer.lex.o
  HOSTCC  scripts/kconfig/menu.o
  HOSTCC  scripts/kconfig/parser.tab.o
  HOSTCC  scripts/kconfig/preprocess.o
  HOSTCC  scripts/kconfig/symbol.o
  HOSTCC  scripts/kconfig/util.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
  GEN     Makefile
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_32.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_64.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_x32.h
  SYSTBL  arch/x86/include/generated/asm/syscalls_32.h
  HOSTCC  arch/x86/tools/relocs_32.o
  HOSTCC  arch/x86/tools/relocs_64.o
  HOSTCC  arch/x86/tools/relocs_common.o
  HOSTLD  arch/x86/tools/relocs
  HOSTCC  scripts/kallsyms
  HOSTCC  scripts/sorttable
  WRAP    arch/x86/include/generated/uapi/asm/bpf_perf_event.h
  WRAP    arch/x86/include/generated/uapi/asm/errno.h
  WRAP    arch/x86/include/generated/uapi/asm/fcntl.h
  WRAP    arch/x86/include/generated/uapi/asm/ioctl.h
  WRAP    arch/x86/include/generated/uapi/asm/ioctls.h
  WRAP    arch/x86/include/generated/uapi/asm/ipcbuf.h
  WRAP    arch/x86/include/generated/uapi/asm/param.h
  WRAP    arch/x86/include/generated/uapi/asm/poll.h
  WRAP    arch/x86/include/generated/uapi/asm/resource.h
  WRAP    arch/x86/include/generated/uapi/asm/socket.h
  WRAP    arch/x86/include/generated/uapi/asm/sockios.h
  WRAP    arch/x86/include/generated/uapi/asm/termbits.h
  WRAP    arch/x86/include/generated/uapi/asm/termios.h
  WRAP    arch/x86/include/generated/uapi/asm/types.h
  WRAP    arch/x86/include/generated/asm/early_ioremap.h
  WRAP    arch/x86/include/generated/asm/export.h
  WRAP    arch/x86/include/generated/asm/mcs_spinlock.h
  WRAP    arch/x86/include/generated/asm/irq_regs.h
  WRAP    arch/x86/include/generated/asm/kmap_size.h
  WRAP    arch/x86/include/generated/asm/local64.h
  WRAP    arch/x86/include/generated/asm/mmiowb.h
  WRAP    arch/x86/include/generated/asm/module.lds.h
  WRAP    arch/x86/include/generated/asm/rwonce.h
  WRAP    arch/x86/include/generated/asm/unaligned.h
  UPD     include/config/kernel.release
  UPD     include/generated/uapi/linux/version.h
  UPD     include/generated/utsrelease.h
  CC      scripts/mod/empty.o
  HOSTCC  scripts/mod/mk_elfconfig
  MKELF   scripts/mod/elfconfig.h
  HOSTCC  scripts/mod/modpost.o
  CC      scripts/mod/devicetable-offsets.s
  UPD     scripts/mod/devicetable-offsets.h
  HOSTCC  scripts/mod/file2alias.o
  HOSTCC  scripts/mod/sumversion.o
  HOSTLD  scripts/mod/modpost
  CC      kernel/bounds.s
  UPD     include/generated/bounds.h
  UPD     include/generated/timeconst.h
  CC      arch/x86/kernel/asm-offsets.s
  UPD     include/generated/asm-offsets.h
  CALL    /home/masahiro/ref/linux-next/scripts/checksyscalls.sh
  CALL    /home/masahiro/ref/linux-next/scripts/atomic/check-atomics.sh
  CC      init/main.o
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      init/version.o
  CC      init/do_mounts.o
  CC      init/noinitramfs.o
  CC      init/calibrate.o
  CC      init/init_task.o
  AR      init/built-in.a
  AR      usr/built-in.a
  CC      arch/x86/entry/vdso/vma.o
  CC      arch/x86/entry/vdso/extable.o
  CC      arch/x86/entry/vdso/vdso32-setup.o
  LDS     arch/x86/entry/vdso/vdso32/vdso32.lds
  AS      arch/x86/entry/vdso/vdso32/note.o
  AS      arch/x86/entry/vdso/vdso32/system_call.o
  AS      arch/x86/entry/vdso/vdso32/sigreturn.o
  CC      arch/x86/entry/vdso/vdso32/vclock_gettime.o
  VDSO    arch/x86/entry/vdso/vdso32.so.dbg
/home/masahiro/ref/linux-next/arch/x86/entry/vdso/Makefile:135: FORCE
prerequisite is missing
  OBJCOPY arch/x86/entry/vdso/vdso32.so
  HOSTCC  arch/x86/entry/vdso/vdso2c
  VDSO2C  arch/x86/entry/vdso/vdso-image-32.c
  CC      arch/x86/entry/vdso/vdso-image-32.o
  AR      arch/x86/entry/vdso/built-in.a

  [snip]



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (x86_64
allnoconfig) failed like this:

make[2]: *** No rule to make target 'scripts/mod/empty.o', needed by '__build'.

Caused by commit

  624a912f84bc ("kbuild: detect objtool changes correctly and remove .SECONDEXPANSION")

(at least, reverting that commit fixes it)

I use a separate object directory and, in this case, it is newly created.

A build with V=1 and -s removed (and no -j) gives this around the
failure:

make -f /home/sfr/next/next/scripts/Makefile.build obj=scripts/mod
make[2]: *** No rule to make target 'scripts/mod/empty.o', needed by '__build'.  Stop.
make[1]: *** [/home/sfr/next/next/Makefile:1309: prepare0] Error 2

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Hi Stephen,

On Mon, Jul 13, 2020 at 10:56 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Tue, 7 Jul 2020 17:07:20 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the kbuild tree, today's linux-next build (powerpc
> > ppc44x_defconfig) failed like this:
> >
> > cc1: fatal error: opening output file arch/powerpc/boot/dts/.ebony.dtb.dts.tmp: No such file or directory
> >
> > and directory arch/powerpc/boot/dts/ does, indeed, not exist in the
> > separate object directory.
> >
> > Caused by commit
> >
> >   ea4679253288 ("kbuild: always create directories of targets")
> >
> > at least, reverting that commit makes the build work again.
>
> I am still reverting that commit.


Sorry, I missed the previous email.
I will fix it soon.


-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

Hi all,

On Tue, 7 Jul 2020 17:07:20 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> cc1: fatal error: opening output file arch/powerpc/boot/dts/.ebony.dtb.dts.tmp: No such file or directory
> 
> and directory arch/powerpc/boot/dts/ does, indeed, not exist in the
> separate object directory.
> 
> Caused by commit
> 
>   ea4679253288 ("kbuild: always create directories of targets")
> 
> at least, reverting that commit makes the build work again.

I am still reverting that commit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

cc1: fatal error: opening output file arch/powerpc/boot/dts/.ebony.dtb.dts.tmp: No such file or directory

and directory arch/powerpc/boot/dts/ does, indeed, not exist in the
separate object directory.

Caused by commit

  ea4679253288 ("kbuild: always create directories of targets")

at least, reverting that commit makes the build work again.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

On Mon, Apr 6, 2020 at 11:34 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (powercp
> allyesconfig) failed like this:
>
> In file included from net/netfilter/nft_set_pipapo.c:342:
> net/netfilter/nft_set_pipapo_avx2.h:4:10: fatal error: asm/fpu/xstate.h: No such file or directory
>     4 | #include <asm/fpu/xstate.h>
>       |          ^~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   b851fc367202 ("x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2")
>
> I have reverted that commit for today.

I will fix as follows:


diff --git a/net/netfilter/nft_set_pipapo_avx2.h
b/net/netfilter/nft_set_pipapo_avx2.h
index 8467337c5f4c..a1cde35fdad6 100644
--- a/net/netfilter/nft_set_pipapo_avx2.h
+++ b/net/netfilter/nft_set_pipapo_avx2.h
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 #ifndef _NFT_SET_PIPAPO_AVX2_H

+#ifdef CONFIG_X86_64
 #include <asm/fpu/xstate.h>
 #define NFT_PIPAPO_ALIGN       (XSAVE_YMM_SIZE / BITS_PER_BYTE)

@@ -8,4 +9,6 @@ bool nft_pipapo_avx2_lookup(const struct net *net,
const struct nft_set *set,
                            const u32 *key, const struct nft_set_ext **ext);
 bool nft_pipapo_avx2_estimate(const struct nft_set_desc *desc, u32 features,
                              struct nft_set_estimate *est);
+#endif /* CONFIG_X86_64 */
+
 #endif /* _NFT_SET_PIPAPO_AVX2_H */



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (powercp
allyesconfig) failed like this:

In file included from net/netfilter/nft_set_pipapo.c:342:
net/netfilter/nft_set_pipapo_avx2.h:4:10: fatal error: asm/fpu/xstate.h: No such file or directory
    4 | #include <asm/fpu/xstate.h>
      |          ^~~~~~~~~~~~~~~~~~

Caused by commit

  b851fc367202 ("x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Stephen,

On Wed, Mar 11, 2020 at 7:53 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> x86_64-linux-gnu-ld: net/core/devlink.o: in function `devlink_trap_report':
> (.text+0x4e7e): undefined reference to `net_dm_hw_report'
>
> Caused by commit
>
>   af20db858358 ("kconfig: allow symbols implied by y to become m")
>
> At least, reverting that commit (and commit
>
>   d590d0a6e6fe ("kconfig: make 'imply' obey the direct dependency"))
>
> allows the build to work.
>
> Advice, please.  Does someone need to audit all the uses of "imply"?


The following patch should fix the build error.


index 2ab668461463..f68bc373544a 100644
--- a/include/net/drop_monitor.h
+++ b/include/net/drop_monitor.h
@@ -19,7 +19,7 @@ struct net_dm_hw_metadata {
        struct net_device *input_dev;
 };

-#if IS_ENABLED(CONFIG_NET_DROP_MONITOR)
+#if IS_REACHABLE(CONFIG_NET_DROP_MONITOR)
 void net_dm_hw_report(struct sk_buff *skb,
                      const struct net_dm_hw_metadata *hw_metadata);
 #else




I will propose this fix-up in the net ML.



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

x86_64-linux-gnu-ld: net/core/devlink.o: in function `devlink_trap_report':
(.text+0x4e7e): undefined reference to `net_dm_hw_report'

Caused by commit

  af20db858358 ("kconfig: allow symbols implied by y to become m")

At least, reverting that commit (and commit

  d590d0a6e6fe ("kconfig: make 'imply' obey the direct dependency"))

allows the build to work.

Advice, please.  Does someone need to audit all the uses of "imply"?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

Hi Masahiro,

On Tue, 16 Jul 2019 13:59:51 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> For the build error, I will fix it as follows for tomorrow's linux-next:

Thanks for the quick response.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Hi Stephen,

On Tue, Jul 16, 2019 at 1:31 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allnoconfig) failed like this:
>
> make[1]: *** No rule to make target 'modules.order', needed by 'autoksyms_recursive'.  Stop.
>
> Starting with commit
>
>   656c0ac3cb4b ("kbuild: modpost: read modules.order instead of $(MODVERDIR)/*.mod")
>
> i.e. after reverting just:
>
> 25a55e249bc0 Revert "kbuild: create *.mod with full directory path and remove MODVERDIR"
> 15657d9eceb6 Revert "kbuild: remove the first line of *.mod files"
> 8c21f4122839 Revert "kbuild: remove 'prepare1' target"
> 35bc41d44d2d Revert "kbuild: split out *.mod out of {single,multi}-used-m rules"
>
> I get
>
> cat: modules.order: No such file or directory
>
> near the end of the allnoconfig build (but it does not fail).
>
> and when I remove 25a55e249bc0 i.e. stop reverting
>
>   0539f970a842 ("kbuild: create *.mod with full directory path and remove MODVERDIR")
>
> the build fails.
>
> So, for today I have reverted these 4 commits:
>
>   56dce8121e97 ("kbuild: split out *.mod out of {single,multi}-used-m rules")
>   fbe0b5eb7890 ("kbuild: remove 'prepare1' target")
>   008fa222d268 ("kbuild: remove the first line of *.mod files")
>   0539f970a842 ("kbuild: create *.mod with full directory path and remove MODVERDIR")
>


Ugh, sorry for the breakage.


For the build error, I will fix it as follows for tomorrow's linux-next:

diff --git a/Makefile b/Makefile
index bfb08cc647f8..5f3daca90862 100644
--- a/Makefile
+++ b/Makefile
@@ -1028,8 +1028,8 @@ vmlinux-deps := $(KBUILD_LDS)
$(KBUILD_VMLINUX_OBJS) $(KBUILD_VMLINUX_LIBS)

 # Recurse until adjust_autoksyms.sh is satisfied
 PHONY += autoksyms_recursive
-autoksyms_recursive: $(vmlinux-deps) modules.order
 ifdef CONFIG_TRIM_UNUSED_KSYMS
+autoksyms_recursive: $(vmlinux-deps) modules.order
        $(Q)$(CONFIG_SHELL) $(srctree)/scripts/adjust_autoksyms.sh \
          "$(MAKE) -f $(srctree)/Makefile vmlinux"
 endif



For the warning, I will fix it as follows for tomorrow's linux-next:

diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index 3e229d4f4d72..6b19c1a4eae5 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -64,7 +64,9 @@ modulesymfile := $(firstword $(KBUILD_EXTMOD))/Module.symvers
 modorder := $(if $(KBUILD_EXTMOD),$(KBUILD_EXTMOD)/)modules.order

 # Step 1), find all modules listed in modules.order
+ifdef CONFIG_MODULES
 modules := $(sort $(shell cat $(modorder)))
+endif

 # Stop after building .o files if NOFINAL is set. Makes compile tests quicker
 _modpost: $(if $(KBUILD_MODPOST_NOFINAL), $(modules:.ko:.o),$(modules))


Thanks!

-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (x86_64
allnoconfig) failed like this:

make[1]: *** No rule to make target 'modules.order', needed by 'autoksyms_recursive'.  Stop.

Starting with commit

  656c0ac3cb4b ("kbuild: modpost: read modules.order instead of $(MODVERDIR)/*.mod")

i.e. after reverting just:

25a55e249bc0 Revert "kbuild: create *.mod with full directory path and remove MODVERDIR"
15657d9eceb6 Revert "kbuild: remove the first line of *.mod files"
8c21f4122839 Revert "kbuild: remove 'prepare1' target"
35bc41d44d2d Revert "kbuild: split out *.mod out of {single,multi}-used-m rules"

I get

cat: modules.order: No such file or directory

near the end of the allnoconfig build (but it does not fail).

and when I remove 25a55e249bc0 i.e. stop reverting

  0539f970a842 ("kbuild: create *.mod with full directory path and remove MODVERDIR")

the build fails.

So, for today I have reverted these 4 commits:

  56dce8121e97 ("kbuild: split out *.mod out of {single,multi}-used-m rules")
  fbe0b5eb7890 ("kbuild: remove 'prepare1' target")
  008fa222d268 ("kbuild: remove the first line of *.mod files")
  0539f970a842 ("kbuild: create *.mod with full directory path and remove MODVERDIR")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Hi Michael,

On Sat, Jul 6, 2019 at 9:05 AM Michael Kelley <mikelley@microsoft.com> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>  Sent: Friday, July 5, 2019 1:31 AM
> >
> > After merging the kbuild tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > In file included from <command-line>:
> > include/clocksource/hyperv_timer.h:18:10: fatal error: asm/mshyperv.h: No such file or
> > directory
> >  #include <asm/mshyperv.h>
> >           ^~~~~~~~~~~~~~~~
> >
> > Caused by commit
> >
> >   34085aeb5816 ("kbuild: compile-test kernel headers to ensure they are self-contained")
> >
> > interacting with commit
> >
> >   dd2cb348613b ("clocksource/drivers: Continue making Hyper-V clocksource ISA agnostic")
> >
> > from the tip tree.
> >
>
> Thomas -- let's remove my two clocksource patches from your 'tip' tree.  I'll need
> a little time to fully understand the self-contained header requirements and restructure
> hyperv_timer.h to avoid this problem.

I do not think you have to drop your patches.

Since <asm/mshyperv.h> only exists in x86,
guarding it by CONFIG_X86 is OK.
So, I think Stephen's patch is OK as-is.

Perhaps, Kbuild is imposing too much burden,
but I'd like to try it and see how it goes.


-- 
Best Regards
Masahiro Yamada

RE: linux-next: build failure after merge of the kbuild tree

[Michael Kelley]

From: Stephen Rothwell <sfr@canb.auug.org.au>  Sent: Friday, July 5, 2019 1:31 AM
> 
> After merging the kbuild tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from <command-line>:
> include/clocksource/hyperv_timer.h:18:10: fatal error: asm/mshyperv.h: No such file or
> directory
>  #include <asm/mshyperv.h>
>           ^~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   34085aeb5816 ("kbuild: compile-test kernel headers to ensure they are self-contained")
> 
> interacting with commit
> 
>   dd2cb348613b ("clocksource/drivers: Continue making Hyper-V clocksource ISA agnostic")
> 
> from the tip tree.
> 

Thomas -- let's remove my two clocksource patches from your 'tip' tree.  I'll need
a little time to fully understand the self-contained header requirements and restructure
hyperv_timer.h to avoid this problem.

Michael

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from <command-line>:
include/clocksource/hyperv_timer.h:18:10: fatal error: asm/mshyperv.h: No such file or directory
 #include <asm/mshyperv.h>
          ^~~~~~~~~~~~~~~~

Caused by commit

  34085aeb5816 ("kbuild: compile-test kernel headers to ensure they are self-contained")

interacting with commit

  dd2cb348613b ("clocksource/drivers: Continue making Hyper-V clocksource ISA agnostic")

from the tip tree.

I have added the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 5 Jul 2019 18:17:44 +1000
Subject: [PATCH] kbuild: only compile test clocksource/hyperv_timer.h on X86

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/Kbuild b/include/Kbuild
index 4f9524d92a75..a7ab060552c2 100644
--- a/include/Kbuild
+++ b/include/Kbuild
@@ -29,6 +29,7 @@ header-test-			+= acpi/platform/acintel.h
 header-test-			+= acpi/platform/aclinux.h
 header-test-			+= acpi/platform/aclinuxex.h
 header-test-			+= acpi/processor.h
+header-test-$(CONFIG_X86)	+= clocksource/hyperv_timer.h
 header-test-			+= clocksource/timer-sp804.h
 header-test-			+= crypto/cast_common.h
 header-test-			+= crypto/internal/cryptouser.h
-- 
2.20.1



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/module.h:18,
                 from drivers/mfd/omap-usb-tll.c:21:
drivers/mfd/omap-usb-tll.c:462:26: error: expected ',' or ';' before 'USBHS_DRIVER_NAME'
 MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
                          ^~~~~~~~~~~~~~~~~
include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
   = __MODULE_INFO_PREFIX __stringify(tag) "=" info
                                               ^~~~
include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
                              ^~~~~~~~~~~
drivers/mfd/omap-usb-tll.c:462:1: note: in expansion of macro 'MODULE_ALIAS'
 MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
 ^~~~~~~~~~~~

Caused by commit

  6a26793a7891 ("moduleparam: Save information about built-in modules in separate file")

USBHS_DRIVER_NAME is not defined and this kbuild tree change has
exposed it. It has been this way since commit

  16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")

From v3.7-rc1 in 2012.

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 6 May 2019 09:39:14 +1000
Subject: [PATCH] mfd: omap: remove unused MODULE_ALIAS from omap-usb-tll.c

USBHS_DRIVER_NAME has never been defined, so this cannot have ever
been used.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mfd/omap-usb-tll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 446713dbee27..1cc8937e8bec 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -459,7 +459,7 @@ EXPORT_SYMBOL_GPL(omap_tll_disable);
 
 MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
 MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
-MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
+// MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");
 
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/module.h:18,
                 from drivers/clocksource/timer-ti-dm.c:40:
drivers/clocksource/timer-ti-dm.c:973:26: error: expected ',' or ';' before 'DRIVER_NAME'
 MODULE_ALIAS("platform:" DRIVER_NAME);
                          ^~~~~~~~~~~
include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
   = __MODULE_INFO_PREFIX __stringify(tag) "=" info
                                               ^~~~
include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
                              ^~~~~~~~~~~
drivers/clocksource/timer-ti-dm.c:973:1: note: in expansion of macro 'MODULE_ALIAS'
 MODULE_ALIAS("platform:" DRIVER_NAME);
 ^~~~~~~~~~~~

Caused by commit

  6a26793a7891 ("moduleparam: Save information about built-in modules in separate file")

DRIVER_NAME is not defined and this kbuild tree change has exposed it.
It has been this way since commit

  df28472a1b28 ("ARM: OMAP: dmtimer: platform driver")

From v3.2-rc1 in 2011.

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 6 May 2019 09:26:24 +1000
Subject: [PATCH] arm: omap: remove unused MODULE_ALIAS from timer-ti-dm.c

DRIVER_NAME has never been defined, so this cannot have ever been used.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/clocksource/timer-ti-dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index ee8ec5a8cb16..b357bd56ba63 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -970,5 +970,5 @@ module_platform_driver(omap_dm_timer_driver);
 
 MODULE_DESCRIPTION("OMAP Dual-Mode Timer Driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:" DRIVER_NAME);
+// MODULE_ALIAS("platform:" DRIVER_NAME);
 MODULE_AUTHOR("Texas Instruments Inc");
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2193 bytes --]

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/module.h:18,
                 from arch/arm/plat-omap/dma.c:28:
arch/arm/plat-omap/dma.c:1452:26: error: expected ',' or ';' before 'DRIVER_NAME'
 MODULE_ALIAS("platform:" DRIVER_NAME);
                          ^~~~~~~~~~~
include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
   = __MODULE_INFO_PREFIX __stringify(tag) "=" info
                                               ^~~~
include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
                              ^~~~~~~~~~~
arch/arm/plat-omap/dma.c:1452:1: note: in expansion of macro 'MODULE_ALIAS'
 MODULE_ALIAS("platform:" DRIVER_NAME);
 ^~~~~~~~~~~~

Presumably caused by commit

  6a26793a7891 ("moduleparam: Save information about built-in modules in separate file")

(since that is the only change from Friday, I thnk)

DRIVER_NAME is not defined and this kbuild tree change has exposed it.  It has been this way since commit

  f31cc9622d75 ("OMAP: DMA: Convert DMA library into platform driver")

From v2.6.38-rc1 in 2012.

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 6 May 2019 08:35:02 +1000
Subject: [PATCH] arm: omap: remove unused MODULE_ALIAS from dma.c

DRIVER_NAME has nevern been defined, so this cannot have ever been used.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/arm/plat-omap/dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index d4012d6c0dcb..4c6d9f4b43b7 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -1449,7 +1449,7 @@ static void __exit omap_system_dma_exit(void)
 
 MODULE_DESCRIPTION("OMAP SYSTEM DMA DRIVER");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:" DRIVER_NAME);
+// MODULE_ALIAS("platform:" DRIVER_NAME);
 MODULE_AUTHOR("Texas Instruments Inc");
 
 /*
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Hi Stephen,

2018-08-23 7:35 GMT+09:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ld: failed to merge target specific data of file drivers/input/mouse/alps.o
> ld: drivers/input/mouse/byd.o: compiled for a big endian system and target is little endian
> ld: failed to merge target specific data of file drivers/input/mouse/byd.o
>
> and many, many more like this.
>
> Sorry, I can't easily tell what caused this.
>
> I have used the kbuild tree from next-20180822 for today.



Sorry, will fix.

I missed to change link-vmlinux.sh




diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index 4bf811c..c8cf453 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -75,7 +75,7 @@ modpost_link()
                ${KBUILD_VMLINUX_LIBS}                          \
                --end-group"

-       ${LD} ${LDFLAGS} -r -o ${1} ${objects}
+       ${LD} ${KBUILD_LDFLAGS} -r -o ${1} ${objects}
 }

 # Link of vmlinux
@@ -95,7 +95,7 @@ vmlinux_link()
                        --end-group                             \
                        ${1}"

-               ${LD} ${LDFLAGS} ${LDFLAGS_vmlinux} -o ${2}     \
+               ${LD} ${KBUILD_LDFLAGS} ${LDFLAGS_vmlinux} -o ${2}      \
                        -T ${lds} ${objects}
        else
                objects="-Wl,--whole-archive                    \



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: failed to merge target specific data of file drivers/input/mouse/alps.o
ld: drivers/input/mouse/byd.o: compiled for a big endian system and target is little endian
ld: failed to merge target specific data of file drivers/input/mouse/byd.o

and many, many more like this.

Sorry, I can't easily tell what caused this.

I have used the kbuild tree from next-20180822 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

2018-05-30 10:29 GMT+09:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> make was continually spawning test compiles.
>
> I used the kbuild tree from next-20180529 for today.
>
> A (partial) strace seemed to show that it was testing for compiler flags
> (some more than once).
>

My bad - I need to insert some patches from Nicholas Piggin.

I will fix it for tomorrows' release.

Thanks for the report!




-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

make was continually spawning test compiles.

I used the kbuild tree from next-20180529 for today.

A (partial) strace seemed to show that it was testing for compiler flags
(some more than once).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Stephen,

2018-05-16 16:26 GMT+09:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Masahiro,
>
> On Wed, 16 May 2018 15:01:38 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>>
>> How should I handle your fix-up?
>>
>> May I squash into the original one if you ack to do it,
>> or is it better to keep it as a separate patch?
>
> Either way is fine by me, but the former reduces the bisection gap.  So
> it depends on whether you want to rebase your tree or not.
>
> Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
>

Thanks!  Squashed now.




> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi Masahiro,

On Wed, 16 May 2018 15:01:38 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> How should I handle your fix-up?
> 
> May I squash into the original one if you ack to do it,
> or is it better to keep it as a separate patch?

Either way is fine by me, but the former reduces the bisection gap.  So
it depends on whether you want to rebase your tree or not.

Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Stephen,


2018-05-15 14:50 GMT+09:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> modules_install) failed like this:
>
> Usage: scripts/depmod.sh /sbin/depmod <kernelrelease> <symbolprefix>
> Makefile:1314: recipe for target '_modinst_post' failed
>
> Caused by commit
>
>   ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
>
> I added the following fix for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 15 May 2018 15:47:33 +1000
> Subject: [PATCH] depmod.sh: fix syntax check and uage message
>
> fixes: ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---


Thanks for catching this.

How should I handle your fix-up?

May I squash into the original one if you ack to do it,
or is it better to keep it as a separate patch?




>  scripts/depmod.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/depmod.sh b/scripts/depmod.sh
> index 421d1aa01304..1a6f85e0e6e1 100755
> --- a/scripts/depmod.sh
> +++ b/scripts/depmod.sh
> @@ -3,8 +3,8 @@
>  #
>  # A depmod wrapper used by the toplevel Makefile
>
> -if test $# -ne 3; then
> -       echo "Usage: $0 /sbin/depmod <kernelrelease> <symbolprefix>" >&2
> +if test $# -ne 2; then
> +       echo "Usage: $0 /sbin/depmod <kernelrelease>" >&2
>         exit 1
>  fi
>  DEPMOD=$1
> --
> 2.17.0
>
> --
> Cheers,
> Stephen Rothwell



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (x86_64
modules_install) failed like this:

Usage: scripts/depmod.sh /sbin/depmod <kernelrelease> <symbolprefix>
Makefile:1314: recipe for target '_modinst_post' failed

Caused by commit

  ea7ad9856a2c ("depmod.sh: remove symbol prefix support")

I added the following fix for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 15 May 2018 15:47:33 +1000
Subject: [PATCH] depmod.sh: fix syntax check and uage message

fixes: ea7ad9856a2c ("depmod.sh: remove symbol prefix support")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 scripts/depmod.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/depmod.sh b/scripts/depmod.sh
index 421d1aa01304..1a6f85e0e6e1 100755
--- a/scripts/depmod.sh
+++ b/scripts/depmod.sh
@@ -3,8 +3,8 @@
 #
 # A depmod wrapper used by the toplevel Makefile
 
-if test $# -ne 3; then
-	echo "Usage: $0 /sbin/depmod <kernelrelease> <symbolprefix>" >&2
+if test $# -ne 2; then
+	echo "Usage: $0 /sbin/depmod <kernelrelease>" >&2
 	exit 1
 fi
 DEPMOD=$1
-- 
2.17.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Masahiro Yamada]

Hi Stephen,

2018-03-29 6:58 GMT+09:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> net/ipv4/netfilter/nf_nat_snmp_basic_main.c:57:10: fatal err
> or: nf_nat_snmp_basic.asn1.h: No such file or directory
>  #include "nf_nat_snmp_basic.asn1.h"
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Presuambly caused by commit
>
>   9ee1b1bb8743 ("kbuild: rename *-asn1.[ch] to *.asn1.[ch]")
>
> though I am not sure why it didn't fail yesterday.
>
> I reverted that commit (and the following one because of a conflict)
> for today.
>
> --
> Cheers,
> Stephen Rothwell


Thanks for the report.

I think my patch is just a coincidence.

The netfilter Makefile seems weird.

I queued up the following fix-up to my kbuild tree.
Hopefully linux-next will be OK tomorrow.






commit 28913ee8191adf4bbc01cbfb9ee18cca782ab141
Author: Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Thu Mar 29 09:24:28 2018 +0900

    netfilter: nf_nat_snmp_basic: add correct dependency to Makefile

    nf_nat_snmp_basic_main.c includes a generated header, but the
    necessary dependency is missing in Makefile. This could cause
    build error in parallel building.

    Remove a weird line, and add a correct one.

    Fixes: cc2d58634e0f ("netfilter: nf_nat_snmp_basic: use asn1
decoder library")
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
index 2dad20e..9bd19cd 100644
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -29,7 +29,7 @@ obj-$(CONFIG_NF_NAT_H323) += nf_nat_h323.o
 obj-$(CONFIG_NF_NAT_PPTP) += nf_nat_pptp.o

 nf_nat_snmp_basic-y := nf_nat_snmp_basic-asn1.o nf_nat_snmp_basic_main.o
-nf_nat_snmp_basic-y : nf_nat_snmp_basic-asn1.h nf_nat_snmp_basic-asn1.c
+$(obj)/nf_nat_snmp_basic_main.o: $(obj)/nf_nat_snmp_basic-asn1.h
 obj-$(CONFIG_NF_NAT_SNMP_BASIC) += nf_nat_snmp_basic.o
 clean-files := nf_nat_snmp_basic-asn1.c nf_nat_snmp_basic-asn1.h



-- 
Best Regards
Masahiro Yamada

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Hi Masahiro,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/ipv4/netfilter/nf_nat_snmp_basic_main.c:57:10: fatal err
or: nf_nat_snmp_basic.asn1.h: No such file or directory
 #include "nf_nat_snmp_basic.asn1.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~

Presuambly caused by commit

  9ee1b1bb8743 ("kbuild: rename *-asn1.[ch] to *.asn1.[ch]")

though I am not sure why it didn't fail yesterday.

I reverted that commit (and the following one because of a conflict)
for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Michal Marek]

On 2016-09-15 08:08, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dax-misc tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages':
> (___ksymtab+clear_pages+0x0): undefined reference to `clear_pages'
> 
> Caused by commit
> 
>   9445aa1a3062 ("ppc: move exports to definitions")
> 
> I applied the following fix patch:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 15 Sep 2016 16:04:12 +1000
> Subject: [PATCH] ppc: there is no clear_pages to export
> 
> Fixes: 9445aa1a3062 ("ppc: move exports to definitions")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Applied to kbuild.git#kbuild now.

Thanks,
Michal

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

Hi all,

After merging the dax-misc tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `__ksymtab_clear_pages':
(___ksymtab+clear_pages+0x0): undefined reference to `clear_pages'

Caused by commit

  9445aa1a3062 ("ppc: move exports to definitions")

I applied the following fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 15 Sep 2016 16:04:12 +1000
Subject: [PATCH] ppc: there is no clear_pages to export

Fixes: 9445aa1a3062 ("ppc: move exports to definitions")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/kernel/misc_32.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index ea26a9181586..f5156105c5f3 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -453,7 +453,6 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE)
 	stw	r7,8(r3);	\
 	stw	r8,12(r3);	\
 	stwu	r9,16(r3)
-EXPORT_SYMBOL(clear_pages)
 
 _GLOBAL(copy_page)
 	addi	r3,r3,-4
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

[Michael Ellerman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Michal,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
...
> arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
>   else if IS_ENABLED(CONFIG_PPC_NATIVE)
>           ^
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
>
> from the powerpc tree interacting with commit
>
>   5e8754fd80b0 ("kconfig.h: allow to use IS_{ENABLE,REACHABLE} in macro expansion")
>
> from the kbuild tree.

**expletive deleted**

I was wary of IS_ENABLED(), I should have trusted my instincts.

> I have applied the following fix patch (that should be applied to the
> powerpc tree):

Applied, thanks.

cheers

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

Hi Michal,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from <command-line>:0:0:
arch/powerpc/mm/hash_utils_64.c: In function 'hash__early_init_mmu':
include/linux/kconfig.h:19:65: error: expected '(' before numeric constant
 #define ____or(arg1_or_junk, y)  __take_second_arg(arg1_or_junk 1, y)
                                                                 ^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
 #define __take_second_arg(__ignored, val, ...) val
                                                ^
include/linux/kconfig.h:18:23: note: in expansion of macro '____or'
 #define ___or(x, y)   ____or(__ARG_PLACEHOLDER_##x, y)
                       ^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
 #define __or(x, y)   ___or(x, y)   
                      ^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
 #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
                            ^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
  else if IS_ENABLED(CONFIG_PPC_NATIVE)
          ^
include/linux/kconfig.h:19:65: error: statement with no effect [-Werror=unused-value]
 #define ____or(arg1_or_junk, y)  __take_second_arg(arg1_or_junk 1, y)
                                                                 ^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
 #define __take_second_arg(__ignored, val, ...) val
                                                ^
include/linux/kconfig.h:18:23: note: in expansion of macro '____or'
 #define ___or(x, y)   ____or(__ARG_PLACEHOLDER_##x, y)
                       ^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
 #define __or(x, y)   ___or(x, y)   
                      ^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
 #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
                            ^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
  else if IS_ENABLED(CONFIG_PPC_NATIVE)
          ^
cc1: all warnings being treated as errors

Caused by commit

  7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")

from the powerpc tree interacting with commit

  5e8754fd80b0 ("kconfig.h: allow to use IS_{ENABLE,REACHABLE} in macro expansion")

from the kbuild tree.

I have applied the following fix patch (that should be applied to the
powerpc tree):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 Jul 2016 12:03:25 +1000
Subject: [PATCH] powerpc/mm: parenthesise the if condition

The breakage here used to be hidden by the macro expansion.

Fixes: 7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/mm/hash_utils_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 1ff11c1bb182..b78b5d211278 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -926,7 +926,7 @@ void __init hash__early_init_mmu(void)
 		ps3_early_mm_init();
 	else if (firmware_has_feature(FW_FEATURE_LPAR))
 		hpte_init_pseries();
-	else if IS_ENABLED(CONFIG_PPC_NATIVE)
+	else if (IS_ENABLED(CONFIG_PPC_NATIVE))
 		hpte_init_native();
 
 	if (!mmu_hash_ops.hpte_insert)
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

Hi Michal,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from <command-line>:0:0:
arch/powerpc/mm/hash_utils_64.c: In function 'hash__early_init_mmu':
include/linux/kconfig.h:19:65: error: expected '(' before numeric constant
 #define ____or(arg1_or_junk, y)  __take_second_arg(arg1_or_junk 1, y)
                                                                 ^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
 #define __take_second_arg(__ignored, val, ...) val
                                                ^
include/linux/kconfig.h:18:23: note: in expansion of macro '____or'
 #define ___or(x, y)   ____or(__ARG_PLACEHOLDER_##x, y)
                       ^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
 #define __or(x, y)   ___or(x, y)   
                      ^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
 #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
                            ^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
  else if IS_ENABLED(CONFIG_PPC_NATIVE)
          ^
include/linux/kconfig.h:19:65: error: statement with no effect [-Werror=unused-value]
 #define ____or(arg1_or_junk, y)  __take_second_arg(arg1_or_junk 1, y)
                                                                 ^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
 #define __take_second_arg(__ignored, val, ...) val
                                                ^
include/linux/kconfig.h:18:23: note: in expansion of macro '____or'
 #define ___or(x, y)   ____or(__ARG_PLACEHOLDER_##x, y)
                       ^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
 #define __or(x, y)   ___or(x, y)   
                      ^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
 #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
                            ^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
  else if IS_ENABLED(CONFIG_PPC_NATIVE)
          ^
cc1: all warnings being treated as errors

Caused by commit

  7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")

from the powerpc tree interacting with commit

  5e8754fd80b0 ("kconfig.h: allow to use IS_{ENABLE,REACHABLE} in macro expansion")

from the kbuild tree.

I have applied the following fix patch (that should be applied to the
powerpc tree):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 Jul 2016 12:03:25 +1000
Subject: [PATCH] powerpc/mm: parenthesise the if condition

The breakage here used to be hidden by the macro expansion.

Fixes: 7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/mm/hash_utils_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 1ff11c1bb182..b78b5d211278 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -926,7 +926,7 @@ void __init hash__early_init_mmu(void)
 		ps3_early_mm_init();
 	else if (firmware_has_feature(FW_FEATURE_LPAR))
 		hpte_init_pseries();
-	else if IS_ENABLED(CONFIG_PPC_NATIVE)
+	else if (IS_ENABLED(CONFIG_PPC_NATIVE))
 		hpte_init_native();
 
 	if (!mmu_hash_ops.hpte_insert)
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

[Michal Marek]

On 2016-03-16 12:29, Stephen Rothwell wrote:
> Hi Michal,
> 
> On Wed, 16 Mar 2016 08:56:50 +0100 Michal Marek <mmarek@suse.cz> wrote:
>>
>> Right. Stephen, could you perhaps move the kbuild tree down in your list
>> a bit, so that the fixes are present?
> 
> Done.
> 
> Now you just need to make sure Linus gets them in the right order :-)

That's the plan :).

Michal

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

Hi Michal,

On Wed, 16 Mar 2016 08:56:50 +0100 Michal Marek <mmarek@suse.cz> wrote:
>
> Right. Stephen, could you perhaps move the kbuild tree down in your list
> a bit, so that the fixes are present?

Done.

Now you just need to make sure Linus gets them in the right order :-)
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

[Michal Marek]

On 2016-03-16 08:53, Daniel Wagner wrote:
> Hi,
> 
> On 03/16/2016 12:58 AM, Stephen Rothwell wrote:
>> After merging the kbuild tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>>   .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
>>                                        ^
>>
>> Caused by commit
>>
>>   ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into error")
> 
> 
> A fix should be on the way via drm-misc:

Right. Stephen, could you perhaps move the kbuild tree down in your list
a bit, so that the fixes are present?

Thanks,
Michal

Re: linux-next: build failure after merge of the kbuild tree

[Daniel Wagner]

Hi,

On 03/16/2016 12:58 AM, Stephen Rothwell wrote:
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
>                                        ^
> 
> Caused by commit
> 
>   ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into error")


A fix should be on the way via drm-misc:

https://lkml.org/lkml/2016/2/25/397

Though I don't know what the exact status is (and I haven't really
understood the flow of the patches as far)

cheers,
daniel

Re: linux-next: build failure after merge of the kbuild tree

[Daniel Wagner]

Hi,

On 03/16/2016 12:58 AM, Stephen Rothwell wrote:
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
>                                        ^
> 
> Caused by commit
> 
>   ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into error")


A fix should be on the way via drm-misc:

https://lkml.org/lkml/2016/2/25/397

Though I don't know what the exact status is (and I haven't really
understood the flow of the patches as far)

cheers,
daniel

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

Hi Michal,

After merging the kbuild tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .dpms = /*drm_helper_connector_dpms*/mdfld_dsi_connector_dpms,
                                       ^

Caused by commit

  ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check into error")

Maybe this needs to be optional?

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the kbuild tree

[Michal Marek]

On 25.2.2013 11:58, Stephen Rothwell wrote:
> ----------------------------------------------------------------------
> $ ls -l /bin/sh
> lrwxrwxrwx 1 root root 4 Jul  7  2010 /bin/sh -> bash
> $ bash --version
> GNU bash, version 4.2.20(1)-release (x86_64-pc-linux-gnu)
[...]
> But bash in sh mode does not work:
> 
> $ cat xtst.sh
> #!/bin/sh
> 
> cd /scratch/sfr/powerpc_ppc64_defconfig
> 
> . .config
> 
> exit 0
> $ ./xtst.sh
> ./xtst.sh: line 5: .: .config: file not found

Ah, so it's a too new bash that causes this. I can also reproduce it now.

Michal

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

On Mon, 25 Feb 2013 21:58:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> But bash in sh mode does not work:

The bash manual says:

       .  filename [arguments]
       source filename [arguments]
              Read and execute commands from filename  in  the  current  shell
              environment  and return the exit status of the last command exe‐
              cuted from filename.  If filename does not contain a slash, file
              names  in  PATH  are used to find the directory containing file‐
              name.  The file searched for in PATH  need  not  be  executable.
              When  bash  is  not  in  posix  mode,  the  current directory is
              searched if no file is found in PATH.  If the sourcepath  option
              to  the  shopt  builtin  command  is turned off, the PATH is not
              searched.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1965 bytes --]

Hi Michal,

On Mon, 25 Feb 2013 11:28:40 +0100 Michal Marek <mmarek@suse.cz> wrote:
>
> On 25.2.2013 00:56, Stephen Rothwell wrote:
> > 
> > After merging the kbuild tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > scripts/link-vmlinux.sh: line 135: .: .config: file not found
> > 
> > Presumably caused by commit 03b25b47e0f4 ("scripts/link-vmlinux.sh:
> > source variables from KCONFIG_CONFIG").
> 
> Strange, I did a couple of testbuilds before pushing the new branch.
> Wild guess: what version of what shell are you using on the
> buildmachine? It is probably the missing ./ that makes the difference.

I am using a Debian Testing machine (its not quite up to date):

----------------------------------------------------------------------
$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Jul  7  2010 /bin/sh -> bash
$ bash --version
GNU bash, version 4.2.20(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
----------------------------------------------------------------------

I am also using a cross compiler and O= on the command line if that
matters.  '.' is not in my path and .config is not executable.  If I cd
to the object directory, then ". .config" works fine.

But bash in sh mode does not work:

$ cat xtst.sh
#!/bin/sh

cd /scratch/sfr/powerpc_ppc64_defconfig

. .config

exit 0
$ ./xtst.sh
./xtst.sh: line 5: .: .config: file not found
$ ls -l /scratch/sfr/powerpc_ppc64_defconfig/.config
-rw-r--r-- 1 sfr users 79005 Feb 25 15:45 /scratch/sfr/powerpc_ppc64_defconfig/.config

Changing the ". .config" to ". ./.config" makes it work.

Anything else?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Michal Marek]

On 25.2.2013 00:56, Stephen Rothwell wrote:
> Hi Michal,
> 
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> scripts/link-vmlinux.sh: line 135: .: .config: file not found
> 
> Presumably caused by commit 03b25b47e0f4 ("scripts/link-vmlinux.sh:
> source variables from KCONFIG_CONFIG").

Strange, I did a couple of testbuilds before pushing the new branch.
Wild guess: what version of what shell are you using on the
buildmachine? It is probably the missing ./ that makes the difference.

Thanks,
Michal

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi Michal,

After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

scripts/link-vmlinux.sh: line 135: .: .config: file not found

Presumably caused by commit 03b25b47e0f4 ("scripts/link-vmlinux.sh:
source variables from KCONFIG_CONFIG").

I have used the kbuild tree from next-20130222 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Michal Marek]

On Wed, Apr 20, 2011 at 08:25:14AM +1000, Stephen Rothwell wrote:
> Hi Michal,
> 
> After merging the kbuild tree, today's linux-next build (s390 allnoconfig)
> failed like this:
> 
> /opt/crosstool/gcc-4.3.2-nolibc/bin/s390x-linux-ar: illegal option -- D
> 
> Caused by commit 09ff9fecc039 ("kbuild: Use the deterministic mode of ar").
> 
> $ /opt/crosstool/gcc-4.3.2-nolibc/bin/s390x-linux-ar --version
> GNU ar (GNU Binutils) 2.19
> 
> I presume that this version of ar is now too old to build the kernel?
> Documentation/Changes only mentions Binutils verion 2.12.

Sorry about that, the following patch should fix it.

Michal


Subject: [PATCH] kbuild: Fix build with binutils <= 2.19

The D option of ar is only available in newer versions.

Signed-off-by: Michal Marek <mmarek@suse.cz>

diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
index 5d145bb..40e082b 100644
--- a/Documentation/kbuild/makefiles.txt
+++ b/Documentation/kbuild/makefiles.txt
@@ -955,6 +955,11 @@ When kbuild executes, the following steps are followed (roughly):
 	used when linking modules. This is often a linker script.
 	From commandline LDFLAGS_MODULE shall be used (see kbuild.txt).
 
+    KBUILD_ARFLAGS   Options for $(AR) when creating archives
+
+	$(KBUILD_ARFLAGS) set by the top level Makefile to "D" (deterministic
+	mode) if this option is supported by $(AR).
+
 --- 6.2 Add prerequisites to archprepare:
 
 	The archprepare: rule is used to list prerequisites that need to be
diff --git a/Makefile b/Makefile
index c3bd316..d7c4231 100644
--- a/Makefile
+++ b/Makefile
@@ -382,6 +382,7 @@ export KBUILD_CFLAGS CFLAGS_KERNEL CFLAGS_MODULE CFLAGS_GCOV
 export KBUILD_AFLAGS AFLAGS_KERNEL AFLAGS_MODULE
 export KBUILD_AFLAGS_MODULE KBUILD_CFLAGS_MODULE KBUILD_LDFLAGS_MODULE
 export KBUILD_AFLAGS_KERNEL KBUILD_CFLAGS_KERNEL
+export KBUILD_ARFLAGS
 
 # When compiling out-of-tree modules, put MODVERDIR in the module
 # tree rather than in the kernel tree. The kernel tree might
@@ -612,6 +613,9 @@ KBUILD_CFLAGS	+= $(call cc-option,-fno-strict-overflow)
 # conserve stack if available
 KBUILD_CFLAGS   += $(call cc-option,-fconserve-stack)
 
+# use the deterministic mode of AR if available
+KBUILD_ARFLAGS := $(call ar-option,D)
+
 # check for 'asm goto'
 ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
 	KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index ed2773e..fae2d8d 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -141,6 +141,11 @@ cc-ldoption = $(call try-run,\
 ld-option = $(call try-run,\
 	$(CC) /dev/null -c -o "$$TMPO" ; $(LD) $(1) "$$TMPO" -o "$$TMP",$(1),$(2))
 
+# ar-option
+# Usage: KBUILD_ARFLAGS := $(call ar-option,D)
+# Important: no spaces around options
+ar-option = $(call try-run, $(AR) rc$(1) "$$TMP",$(1),$(2))
+
 ######
 
 ###
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 5f87d37..e1244ef 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -345,7 +345,7 @@ quiet_cmd_link_o_target = LD      $@
 cmd_link_o_target = $(if $(strip $(obj-y)),\
 		      $(LD) $(ld_flags) -r -o $@ $(filter $(obj-y), $^) \
 		      $(cmd_secanalysis),\
-		      rm -f $@; $(AR) rcsD $@)
+		      rm -f $@; $(AR) rcs$(KBUILD_ARFLAGS) $@)
 
 $(builtin-target): $(obj-y) FORCE
 	$(call if_changed,link_o_target)
@@ -371,7 +371,7 @@ $(modorder-target): $(subdir-ym) FORCE
 #
 ifdef lib-target
 quiet_cmd_link_l_target = AR      $@
-cmd_link_l_target = rm -f $@; $(AR) rcsD $@ $(lib-y)
+cmd_link_l_target = rm -f $@; $(AR) rcs$(KBUILD_ARFLAGS) $@ $(lib-y)
 
 $(lib-target): $(lib-y) FORCE
 	$(call if_changed,link_l_target)

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

Hi Michal,

On Wed, 20 Apr 2011 08:25:14 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the kbuild tree, today's linux-next build (s390 allnoconfig)
> failed like this:
> 
> /opt/crosstool/gcc-4.3.2-nolibc/bin/s390x-linux-ar: illegal option -- D
> 
> Caused by commit 09ff9fecc039 ("kbuild: Use the deterministic mode of ar").
> 
> $ /opt/crosstool/gcc-4.3.2-nolibc/bin/s390x-linux-ar --version
> GNU ar (GNU Binutils) 2.19
> 
> I presume that this version of ar is now too old to build the kernel?
> Documentation/Changes only mentions Binutils verion 2.12.

This actually broke nearly all my overnight builds.  Version 2.19.1 is also
not new enough, but 2.20 is ok.

I am going to have to try to revert that commit today or go back to the
kbuild tree from next-20110418.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi Michal,

After merging the kbuild tree, today's linux-next build (s390 allnoconfig)
failed like this:

/opt/crosstool/gcc-4.3.2-nolibc/bin/s390x-linux-ar: illegal option -- D

Caused by commit 09ff9fecc039 ("kbuild: Use the deterministic mode of ar").

$ /opt/crosstool/gcc-4.3.2-nolibc/bin/s390x-linux-ar --version
GNU ar (GNU Binutils) 2.19

I presume that this version of ar is now too old to build the kernel?
Documentation/Changes only mentions Binutils verion 2.12.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi Michal,

After merging the kbuild tree, a build like
"make modules modules_install" failed like this:

cp: cannot stat `/home/sfr/kernels/ntest.obj/modules.builtin': No such file or directory

Caused by commit a6c366324cacd5f71107dd01362b995a1c67b1ad ("kbuild: Do
not unnecessarily regenerate modules.builtin").  I have reverted that
commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]