Re: [PATCH 3/4] kbuild: create object directories simpler and faster

From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Sam Ravnborg <sam@ravnborg.org>,
	Douglas Anderson <dianders@chromium.org>,
	Michal Marek <mmarek@suse.com>, X86 ML <x86@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Lutomirski <luto@amacapital.net>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 3/4] kbuild: create object directories simpler and faster
Date: Mon, 13 Nov 2017 17:48:55 +0900	[thread overview]
Message-ID: <CAK7LNASeMMxcXymwDVo1zGjyAOC+iEAvcZcVscyuESe2Yqm4NA@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNARs0_DFH5RO=Q8Gsn8xagO+7dPJ8217d56DAgSw5GYHsg@mail.gmail.com>

2017-11-10 18:21 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Cao,
>
>
> 2017-11-10 17:45 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>
>>> +ifneq ($(KBUILD_SRC),)
>>> +# Create directories for object files if directory does not exist
>>> +obj-dirs := $(sort $(obj) $(patsubst %/,%, $(dir $(targets))))
>>> +$(shell mkdir -p $(obj-dirs))
>>> +endif
>>> +
>>
>> I just take a quick glance: is "$(obj)" here necessary? I think all
>> $(targets) are under directory $(obj) when we descend into $(obj) to
>> recursive make, if I don't miss anything.
>
> Good catch!
>
> I agree that $(obj) is unnecessary.
> I will remove it if I see no problem in testing.
>
> Thanks!

I take back this comment.

I was testing it, and in fact
Kbuild failed to create modules.order
due to missing $(obj) directory.

-- 
Best Regards
Masahiro Yamada