From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A40C43381 for ; Thu, 14 Mar 2019 08:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EBEF2184C for ; Thu, 14 Mar 2019 08:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="Umy3ipo4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727307AbfCNIZe (ORCPT ); Thu, 14 Mar 2019 04:25:34 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:44009 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726624AbfCNIZd (ORCPT ); Thu, 14 Mar 2019 04:25:33 -0400 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) (authenticated) by conssluserg-04.nifty.com with ESMTP id x2E8PJGw010449 for ; Thu, 14 Mar 2019 17:25:19 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com x2E8PJGw010449 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1552551920; bh=e9evzMJ+uYgsiNQQS23HsBEHSxwMxqUkSnjbOuWeCO0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Umy3ipo4ci5Upbl0Mhb5E5QR93Vl3uYM7Gi7L0wyLL2WYhOUGAy2oPJWa/cBxkCAM OzuBuLywCniMsFDEXJKHFAELXYoBvyAqYbGgHP0115HcRvvST8EuUnkWxEPrgPHnhS ERi8IjJlx+6BnHrbSP7GaJlfsXWw5HV87/pn8LJ9jOZIyMr/G8R1CKliAPx5tXf6Hn KRhukGeietHB+Ldp+FirNKWtK+fjvex8l2PZO/27mJnMJO4Gd5jAFKzB5IbWTWH+MU sC+VbiyK9LVBbK52MNZOQBdnOZmv9toEymyPhOFlr+0tajiKlS5cW4a1bR+y7uY7Jq sMQPo7LaNaqDg== X-Nifty-SrcIP: [209.85.217.42] Received: by mail-vs1-f42.google.com with SMTP id c189so2702656vsd.9 for ; Thu, 14 Mar 2019 01:25:19 -0700 (PDT) X-Gm-Message-State: APjAAAVFFY94g8tW774S4hg+xtyNO9tyKftAhU1Q6aGjPt3O3Ev2oAmF 6B+DWpRq11bqttri1j8KoTo6lMgr40kHz5fg3nA= X-Google-Smtp-Source: APXvYqwZk4wBESJvvoYIyvcTIIgfT0pyq1xMF0FcpmWaYXxTvL+yKZZG1iWMytyinJVe0Kz9d7rMGDfOjOuIx82FTcY= X-Received: by 2002:a67:7c04:: with SMTP id x4mr25724602vsc.155.1552551918500; Thu, 14 Mar 2019 01:25:18 -0700 (PDT) MIME-Version: 1.0 References: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> <1552380290-19951-3-git-send-email-yamada.masahiro@socionext.com> <20190312112811.1af0bb00@xps13> <20190312115425.612bcdf2@xps13> <20190312141327.31c6af3f@xps13> In-Reply-To: <20190312141327.31c6af3f@xps13> From: Masahiro Yamada Date: Thu, 14 Mar 2019 17:24:41 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/9] mtd: rawnand: denali: refactor syndrome layout handling for raw access To: Miquel Raynal Cc: Boris Brezillon , Richard Weinberger , Linux Kernel Mailing List , Marek Vasut , linux-mtd , Brian Norris , David Woodhouse Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On Tue, Mar 12, 2019 at 10:13 PM Miquel Raynal wrote: > > Hi Masahiro, > > Masahiro Yamada wrote on Tue, 12 Mar > 2019 20:07:27 +0900: > > > Hi Miquel, > > > > > > On Tue, Mar 12, 2019 at 7:54 PM Miquel Raynal wrote: > > > > > > Hi Masahiro, > > > > > > Masahiro Yamada wrote on Tue, 12 Mar > > > 2019 19:51:21 +0900: > > > > > > > On Tue, Mar 12, 2019 at 7:28 PM Miquel Raynal wrote: > > > > > > > > > > Hi Masahiro, > > > > > > > > > > Masahiro Yamada wrote on Tue, 12 = Mar > > > > > 2019 17:44:43 +0900: > > > > > > > > > > > The Denali IP adopts the syndrome page layout (payload and ECC = are > > > > > > interleaved). The *_page_raw() and *_oob() callbacks are compli= cated > > > > > > because they must hide the underlying layout used by the hardwa= re, > > > > > > and always return contiguous in-band and out-of-band data. > > > > > > > > > > > > Currently, similar code is duplicated to reorganize the data la= yout. > > > > > > For example, denali_read_page_raw() and denali_write_page_raw()= look > > > > > > almost the same. > > > > > > > > > > > > The idea for refactoring is to split the code into two parts: > > > > > > [1] conversion of page layout > > > > > > [2] what to do at every ECC chunk boundary > > > > > > > > > > > > For [1], I wrote denali_raw_payload_op() and denali_raw_oob_op(= ). > > > > > > They manipulate data for the Denali controller's specific page = layout > > > > > > of in-band, out-of-band, respectively. > > > > > > > > > > > > The difference between write and read is just the operation at > > > > > > ECC chunk boundaries. For example, denali_read_oob() calls > > > > > > nand_change_read_column_op(), whereas denali_write_oob() calls > > > > > > nand_change_write_column_op(). So, I implemented [2] as a callb= ack > > > > > > passed into [1]. > > > > > > > > > > > > Signed-off-by: Masahiro Yamada > > > > > > --- > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > static int denali_read_page_raw(struct nand_chip *chip, uint8_= t *buf, > > > > > > int oob_required, int page) > > > > > > { > > > > > > + struct denali_nand_info *denali =3D to_denali(chip); > > > > > > struct mtd_info *mtd =3D nand_to_mtd(chip); > > > > > > - struct denali_nand_info *denali =3D mtd_to_denali(mtd); > > > > > > - int writesize =3D mtd->writesize; > > > > > > - int oobsize =3D mtd->oobsize; > > > > > > - int ecc_steps =3D chip->ecc.steps; > > > > > > - int ecc_size =3D chip->ecc.size; > > > > > > - int ecc_bytes =3D chip->ecc.bytes; > > > > > > void *tmp_buf =3D denali->buf; > > > > > > - int oob_skip =3D denali->oob_skip_bytes; > > > > > > - size_t size =3D writesize + oobsize; > > > > > > - int ret, i, pos, len; > > > > > > + size_t size =3D mtd->writesize + mtd->oobsize; > > > > > > + int ret; > > > > > > + > > > > > > + if (!buf) > > > > > > + return -EINVAL; > > > > > > > > > > > > ret =3D denali_data_xfer(chip, tmp_buf, size, page, 1, 0)= ; > > > > > > if (ret) > > > > > > return ret; > > > > > > > > > > > > - /* Arrange the buffer for syndrome payload/ecc layout */ > > > > > > - if (buf) { > > > > > > - for (i =3D 0; i < ecc_steps; i++) { > > > > > > - pos =3D i * (ecc_size + ecc_bytes); > > > > > > - len =3D ecc_size; > > > > > > - > > > > > > - if (pos >=3D writesize) > > > > > > - pos +=3D oob_skip; > > > > > > - else if (pos + len > writesize) > > > > > > - len =3D writesize - pos; > > > > > > - > > > > > > - memcpy(buf, tmp_buf + pos, len); > > > > > > - buf +=3D len; > > > > > > - if (len < ecc_size) { > > > > > > - len =3D ecc_size - len; > > > > > > - memcpy(buf, tmp_buf + writesize += oob_skip, > > > > > > - len); > > > > > > - buf +=3D len; > > > > > > - } > > > > > > - } > > > > > > - } > > > > > > + ret =3D denali_raw_payload_op(chip, buf, denali_memcpy_in= , tmp_buf); > > > > > > > > > > Honestly, I still don't like passing denali_memcpy_in/out as para= meter. > > > > > > > > > > Besides that, once you'll have added helpers to avoid abusing the > > > > > ternary operator in 4/9, the rest looks fine by me. > > > > > > > > > > > > > > > > > Do you have any suggestion? > > > > > > Maybe register these two helpers at probe as controller specific hook= s, > > > then just pass an in/out boolean to the function? > > > > > > > Sorry, I do not understand. > > > > Are you suggesting to do like follows in probe ? > > > > denali->change_column_read_raw =3D denali_memcpy_in; > > denali->change_column_write_raw =3D denali_memcpy_out; > > denali->change_column_read_oob =3D denali_change_read_column_op; > > denali->change_column_write_oob =3D denali_change_write_column_op; > > > > > > All the 4 hooks are always needed > > regardless of any probed features. > > > > > > The result is just textual replacement > > denali_* with denali->*. > > > > What's the point of copying fixed function addresses > > to denali structure? > > > > > > What I don't like is the function pointer as a function parameter. This is a usual way to handle callback. > You > can use the functions defined statically if you prefer as long as the > parameter is just a boolean for instance? I still do not understand your concern, but if you ban the use of function pointer, the following is the best I can do since there are 4 hooks depending on the combination of oob/raw, write/read. if (oob) { if (write) return nand_change_write_column_op(chip, offset, buf, len, false); else return nand_change_read_column_op(chip, offset, buf, len, false); } if (write) memcpy(denali->buf + offset, buf, len); else memcpy(buf, denali->buf + offset, len); return 0; BTW, when are .read_page_raw / .write_page_raw used? Currently, I use "whole page access && memcpy" for better performance. If those hooks are rarely used, I use nand_change_write_column_op / nand_change_read_column_op, which will reduce the if-conditional. > > Thanks, > Miqu=C3=A8l > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ --=20 Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CAFC43381 for ; Thu, 14 Mar 2019 08:26:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31C8C217F5 for ; Thu, 14 Mar 2019 08:26:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t0TWj1T9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="Umy3ipo4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31C8C217F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MLUAsWJHWchifCVR3DhmC9kvVJvfSNM6SLg7PiEZMVI=; b=t0TWj1T9ulujXA kOX9+3yQHCJ1ZjqiTXq0u+kytYeDoBE1tsmg0MoITS8i9AGSiHSniM6bSXqEj7nO0bGVnBbaQqYPR b1af9cjM5mxvdNqyZ7r4urkBL2h/qLp8FvCTNn5MjDkf3fT3kueHnds9gef1IKeH7jnjBIQOPGRgw ni4ukNiIBpIyMk7QJIY1zKJZ1vTMFTCzlArYpA3GQs0tEPZya9LW5c86mGm3HgO7jWje3gtWKeB5W 6MtnPwscKus8garTlPl9ivp1A9AOul6AaMMnkEreqHTrVrj7+3Ju19Q7JFRHlsmHyxQPsLOjyFRUi BODlsi4gtInyrnzkQ73A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Lgn-000114-Dz; Thu, 14 Mar 2019 08:26:09 +0000 Received: from conssluserg-05.nifty.com ([210.131.2.90]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Lge-0000lz-SE for linux-mtd@lists.infradead.org; Thu, 14 Mar 2019 08:26:06 +0000 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) (authenticated) by conssluserg-05.nifty.com with ESMTP id x2E8PJ5I030647 for ; Thu, 14 Mar 2019 17:25:19 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com x2E8PJ5I030647 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1552551920; bh=e9evzMJ+uYgsiNQQS23HsBEHSxwMxqUkSnjbOuWeCO0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Umy3ipo4ci5Upbl0Mhb5E5QR93Vl3uYM7Gi7L0wyLL2WYhOUGAy2oPJWa/cBxkCAM OzuBuLywCniMsFDEXJKHFAELXYoBvyAqYbGgHP0115HcRvvST8EuUnkWxEPrgPHnhS ERi8IjJlx+6BnHrbSP7GaJlfsXWw5HV87/pn8LJ9jOZIyMr/G8R1CKliAPx5tXf6Hn KRhukGeietHB+Ldp+FirNKWtK+fjvex8l2PZO/27mJnMJO4Gd5jAFKzB5IbWTWH+MU sC+VbiyK9LVBbK52MNZOQBdnOZmv9toEymyPhOFlr+0tajiKlS5cW4a1bR+y7uY7Jq sMQPo7LaNaqDg== X-Nifty-SrcIP: [209.85.217.47] Received: by mail-vs1-f47.google.com with SMTP id b8so2697295vsq.11 for ; Thu, 14 Mar 2019 01:25:19 -0700 (PDT) X-Gm-Message-State: APjAAAVNpwLmjq2R398tfpyHe+kEGuNmSxKNhJqtEcZDg+ahU/1a7VdB fiKZSs8T1QU3tJDYRm47k1anbUSzXNo8IZU5GgY= X-Google-Smtp-Source: APXvYqwZk4wBESJvvoYIyvcTIIgfT0pyq1xMF0FcpmWaYXxTvL+yKZZG1iWMytyinJVe0Kz9d7rMGDfOjOuIx82FTcY= X-Received: by 2002:a67:7c04:: with SMTP id x4mr25724602vsc.155.1552551918500; Thu, 14 Mar 2019 01:25:18 -0700 (PDT) MIME-Version: 1.0 References: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> <1552380290-19951-3-git-send-email-yamada.masahiro@socionext.com> <20190312112811.1af0bb00@xps13> <20190312115425.612bcdf2@xps13> <20190312141327.31c6af3f@xps13> In-Reply-To: <20190312141327.31c6af3f@xps13> From: Masahiro Yamada Date: Thu, 14 Mar 2019 17:24:41 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/9] mtd: rawnand: denali: refactor syndrome layout handling for raw access To: Miquel Raynal X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_012601_581243_6592BC71 X-CRM114-Status: GOOD ( 30.72 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , Linux Kernel Mailing List , Marek Vasut , linux-mtd , Brian Norris , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKT24gVHVlLCBNYXIgMTIsIDIwMTkgYXQgMTA6MTMgUE0gTWlxdWVsIFJheW5h bAo8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4gd3JvdGU6Cj4KPiBIaSBNYXNhaGlybywKPgo+ IE1hc2FoaXJvIFlhbWFkYSA8eWFtYWRhLm1hc2FoaXJvQHNvY2lvbmV4dC5jb20+IHdyb3RlIG9u IFR1ZSwgMTIgTWFyCj4gMjAxOSAyMDowNzoyNyArMDkwMDoKPgo+ID4gSGkgTWlxdWVsLAo+ID4K PiA+Cj4gPiBPbiBUdWUsIE1hciAxMiwgMjAxOSBhdCA3OjU0IFBNIE1pcXVlbCBSYXluYWwgPG1p cXVlbC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBIaSBNYXNhaGlybywK PiA+ID4KPiA+ID4gTWFzYWhpcm8gWWFtYWRhIDx5YW1hZGEubWFzYWhpcm9Ac29jaW9uZXh0LmNv bT4gd3JvdGUgb24gVHVlLCAxMiBNYXIKPiA+ID4gMjAxOSAxOTo1MToyMSArMDkwMDoKPiA+ID4K PiA+ID4gPiBPbiBUdWUsIE1hciAxMiwgMjAxOSBhdCA3OjI4IFBNIE1pcXVlbCBSYXluYWwgPG1p cXVlbC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3RlOgo+ID4gPiA+ID4KPiA+ID4gPiA+IEhpIE1h c2FoaXJvLAo+ID4gPiA+ID4KPiA+ID4gPiA+IE1hc2FoaXJvIFlhbWFkYSA8eWFtYWRhLm1hc2Fo aXJvQHNvY2lvbmV4dC5jb20+IHdyb3RlIG9uIFR1ZSwgMTIgTWFyCj4gPiA+ID4gPiAyMDE5IDE3 OjQ0OjQzICswOTAwOgo+ID4gPiA+ID4KPiA+ID4gPiA+ID4gVGhlIERlbmFsaSBJUCBhZG9wdHMg dGhlIHN5bmRyb21lIHBhZ2UgbGF5b3V0IChwYXlsb2FkIGFuZCBFQ0MgYXJlCj4gPiA+ID4gPiA+ IGludGVybGVhdmVkKS4gVGhlICpfcGFnZV9yYXcoKSBhbmQgKl9vb2IoKSBjYWxsYmFja3MgYXJl IGNvbXBsaWNhdGVkCj4gPiA+ID4gPiA+IGJlY2F1c2UgdGhleSBtdXN0IGhpZGUgdGhlIHVuZGVy bHlpbmcgbGF5b3V0IHVzZWQgYnkgdGhlIGhhcmR3YXJlLAo+ID4gPiA+ID4gPiBhbmQgYWx3YXlz IHJldHVybiBjb250aWd1b3VzIGluLWJhbmQgYW5kIG91dC1vZi1iYW5kIGRhdGEuCj4gPiA+ID4g PiA+Cj4gPiA+ID4gPiA+IEN1cnJlbnRseSwgc2ltaWxhciBjb2RlIGlzIGR1cGxpY2F0ZWQgdG8g cmVvcmdhbml6ZSB0aGUgZGF0YSBsYXlvdXQuCj4gPiA+ID4gPiA+IEZvciBleGFtcGxlLCBkZW5h bGlfcmVhZF9wYWdlX3JhdygpIGFuZCBkZW5hbGlfd3JpdGVfcGFnZV9yYXcoKSBsb29rCj4gPiA+ ID4gPiA+IGFsbW9zdCB0aGUgc2FtZS4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gVGhlIGlkZWEg Zm9yIHJlZmFjdG9yaW5nIGlzIHRvIHNwbGl0IHRoZSBjb2RlIGludG8gdHdvIHBhcnRzOgo+ID4g PiA+ID4gPiAgIFsxXSBjb252ZXJzaW9uIG9mIHBhZ2UgbGF5b3V0Cj4gPiA+ID4gPiA+ICAgWzJd IHdoYXQgdG8gZG8gYXQgZXZlcnkgRUNDIGNodW5rIGJvdW5kYXJ5Cj4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+IEZvciBbMV0sIEkgd3JvdGUgZGVuYWxpX3Jhd19wYXlsb2FkX29wKCkgYW5kIGRlbmFs aV9yYXdfb29iX29wKCkuCj4gPiA+ID4gPiA+IFRoZXkgbWFuaXB1bGF0ZSBkYXRhIGZvciB0aGUg RGVuYWxpIGNvbnRyb2xsZXIncyBzcGVjaWZpYyBwYWdlIGxheW91dAo+ID4gPiA+ID4gPiBvZiBp bi1iYW5kLCBvdXQtb2YtYmFuZCwgcmVzcGVjdGl2ZWx5Lgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiBUaGUgZGlmZmVyZW5jZSBiZXR3ZWVuIHdyaXRlIGFuZCByZWFkIGlzIGp1c3QgdGhlIG9wZXJh dGlvbiBhdAo+ID4gPiA+ID4gPiBFQ0MgY2h1bmsgYm91bmRhcmllcy4gRm9yIGV4YW1wbGUsIGRl bmFsaV9yZWFkX29vYigpIGNhbGxzCj4gPiA+ID4gPiA+IG5hbmRfY2hhbmdlX3JlYWRfY29sdW1u X29wKCksIHdoZXJlYXMgZGVuYWxpX3dyaXRlX29vYigpIGNhbGxzCj4gPiA+ID4gPiA+IG5hbmRf Y2hhbmdlX3dyaXRlX2NvbHVtbl9vcCgpLiBTbywgSSBpbXBsZW1lbnRlZCBbMl0gYXMgYSBjYWxs YmFjawo+ID4gPiA+ID4gPiBwYXNzZWQgaW50byBbMV0uCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ IFNpZ25lZC1vZmYtYnk6IE1hc2FoaXJvIFlhbWFkYSA8eWFtYWRhLm1hc2FoaXJvQHNvY2lvbmV4 dC5jb20+Cj4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+IFsu Li5dCj4gPiA+ID4gPgo+ID4gPiA+ID4gPiAgc3RhdGljIGludCBkZW5hbGlfcmVhZF9wYWdlX3Jh dyhzdHJ1Y3QgbmFuZF9jaGlwICpjaGlwLCB1aW50OF90ICpidWYsCj4gPiA+ID4gPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGludCBvb2JfcmVxdWlyZWQsIGludCBwYWdlKQo+ID4g PiA+ID4gPiAgewo+ID4gPiA+ID4gPiArICAgICBzdHJ1Y3QgZGVuYWxpX25hbmRfaW5mbyAqZGVu YWxpID0gdG9fZGVuYWxpKGNoaXApOwo+ID4gPiA+ID4gPiAgICAgICBzdHJ1Y3QgbXRkX2luZm8g Km10ZCA9IG5hbmRfdG9fbXRkKGNoaXApOwo+ID4gPiA+ID4gPiAtICAgICBzdHJ1Y3QgZGVuYWxp X25hbmRfaW5mbyAqZGVuYWxpID0gbXRkX3RvX2RlbmFsaShtdGQpOwo+ID4gPiA+ID4gPiAtICAg ICBpbnQgd3JpdGVzaXplID0gbXRkLT53cml0ZXNpemU7Cj4gPiA+ID4gPiA+IC0gICAgIGludCBv b2JzaXplID0gbXRkLT5vb2JzaXplOwo+ID4gPiA+ID4gPiAtICAgICBpbnQgZWNjX3N0ZXBzID0g Y2hpcC0+ZWNjLnN0ZXBzOwo+ID4gPiA+ID4gPiAtICAgICBpbnQgZWNjX3NpemUgPSBjaGlwLT5l Y2Muc2l6ZTsKPiA+ID4gPiA+ID4gLSAgICAgaW50IGVjY19ieXRlcyA9IGNoaXAtPmVjYy5ieXRl czsKPiA+ID4gPiA+ID4gICAgICAgdm9pZCAqdG1wX2J1ZiA9IGRlbmFsaS0+YnVmOwo+ID4gPiA+ ID4gPiAtICAgICBpbnQgb29iX3NraXAgPSBkZW5hbGktPm9vYl9za2lwX2J5dGVzOwo+ID4gPiA+ ID4gPiAtICAgICBzaXplX3Qgc2l6ZSA9IHdyaXRlc2l6ZSArIG9vYnNpemU7Cj4gPiA+ID4gPiA+ IC0gICAgIGludCByZXQsIGksIHBvcywgbGVuOwo+ID4gPiA+ID4gPiArICAgICBzaXplX3Qgc2l6 ZSA9IG10ZC0+d3JpdGVzaXplICsgbXRkLT5vb2JzaXplOwo+ID4gPiA+ID4gPiArICAgICBpbnQg cmV0Owo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICsgICAgIGlmICghYnVmKQo+ID4gPiA+ID4g PiArICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiAg ICAgICByZXQgPSBkZW5hbGlfZGF0YV94ZmVyKGNoaXAsIHRtcF9idWYsIHNpemUsIHBhZ2UsIDEs IDApOwo+ID4gPiA+ID4gPiAgICAgICBpZiAocmV0KQo+ID4gPiA+ID4gPiAgICAgICAgICAgICAg IHJldHVybiByZXQ7Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IC0gICAgIC8qIEFycmFuZ2UgdGhl IGJ1ZmZlciBmb3Igc3luZHJvbWUgcGF5bG9hZC9lY2MgbGF5b3V0ICovCj4gPiA+ID4gPiA+IC0g ICAgIGlmIChidWYpIHsKPiA+ID4gPiA+ID4gLSAgICAgICAgICAgICBmb3IgKGkgPSAwOyBpIDwg ZWNjX3N0ZXBzOyBpKyspIHsKPiA+ID4gPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgIHBvcyA9 IGkgKiAoZWNjX3NpemUgKyBlY2NfYnl0ZXMpOwo+ID4gPiA+ID4gPiAtICAgICAgICAgICAgICAg ICAgICAgbGVuID0gZWNjX3NpemU7Cj4gPiA+ID4gPiA+IC0KPiA+ID4gPiA+ID4gLSAgICAgICAg ICAgICAgICAgICAgIGlmIChwb3MgPj0gd3JpdGVzaXplKQo+ID4gPiA+ID4gPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBwb3MgKz0gb29iX3NraXA7Cj4gPiA+ID4gPiA+IC0gICAgICAg ICAgICAgICAgICAgICBlbHNlIGlmIChwb3MgKyBsZW4gPiB3cml0ZXNpemUpCj4gPiA+ID4gPiA+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxlbiA9IHdyaXRlc2l6ZSAtIHBvczsKPiA+ ID4gPiA+ID4gLQo+ID4gPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgbWVtY3B5KGJ1Ziwg dG1wX2J1ZiArIHBvcywgbGVuKTsKPiA+ID4gPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgIGJ1 ZiArPSBsZW47Cj4gPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICBpZiAobGVuIDwgZWNj X3NpemUpIHsKPiA+ID4gPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGVuID0g ZWNjX3NpemUgLSBsZW47Cj4gPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg IG1lbWNweShidWYsIHRtcF9idWYgKyB3cml0ZXNpemUgKyBvb2Jfc2tpcCwKPiA+ID4gPiA+ID4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxlbik7Cj4gPiA+ID4gPiA+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ1ZiArPSBsZW47Cj4gPiA+ID4gPiA+IC0gICAg ICAgICAgICAgICAgICAgICB9Cj4gPiA+ID4gPiA+IC0gICAgICAgICAgICAgfQo+ID4gPiA+ID4g PiAtICAgICB9Cj4gPiA+ID4gPiA+ICsgICAgIHJldCA9IGRlbmFsaV9yYXdfcGF5bG9hZF9vcChj aGlwLCBidWYsIGRlbmFsaV9tZW1jcHlfaW4sIHRtcF9idWYpOwo+ID4gPiA+ID4KPiA+ID4gPiA+ IEhvbmVzdGx5LCBJIHN0aWxsIGRvbid0IGxpa2UgcGFzc2luZyBkZW5hbGlfbWVtY3B5X2luL291 dCBhcyBwYXJhbWV0ZXIuCj4gPiA+ID4gPgo+ID4gPiA+ID4gQmVzaWRlcyB0aGF0LCBvbmNlIHlv dSdsbCBoYXZlIGFkZGVkIGhlbHBlcnMgdG8gYXZvaWQgYWJ1c2luZyB0aGUKPiA+ID4gPiA+IHRl cm5hcnkgb3BlcmF0b3IgaW4gNC85LCB0aGUgcmVzdCBsb29rcyBmaW5lIGJ5IG1lLgo+ID4gPiA+ ID4KPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4gRG8geW91IGhhdmUgYW55IHN1Z2dlc3Rpb24/Cj4g PiA+Cj4gPiA+IE1heWJlIHJlZ2lzdGVyIHRoZXNlIHR3byBoZWxwZXJzIGF0IHByb2JlIGFzIGNv bnRyb2xsZXIgc3BlY2lmaWMgaG9va3MsCj4gPiA+IHRoZW4ganVzdCBwYXNzIGFuIGluL291dCBi b29sZWFuIHRvIHRoZSBmdW5jdGlvbj8KPiA+ID4KPiA+Cj4gPiBTb3JyeSwgSSBkbyBub3QgdW5k ZXJzdGFuZC4KPiA+Cj4gPiBBcmUgeW91IHN1Z2dlc3RpbmcgdG8gZG8gbGlrZSBmb2xsb3dzIGlu IHByb2JlID8KPiA+Cj4gPiBkZW5hbGktPmNoYW5nZV9jb2x1bW5fcmVhZF9yYXcgPSBkZW5hbGlf bWVtY3B5X2luOwo+ID4gZGVuYWxpLT5jaGFuZ2VfY29sdW1uX3dyaXRlX3JhdyA9IGRlbmFsaV9t ZW1jcHlfb3V0Owo+ID4gZGVuYWxpLT5jaGFuZ2VfY29sdW1uX3JlYWRfb29iID0gZGVuYWxpX2No YW5nZV9yZWFkX2NvbHVtbl9vcDsKPiA+IGRlbmFsaS0+Y2hhbmdlX2NvbHVtbl93cml0ZV9vb2Ig PSBkZW5hbGlfY2hhbmdlX3dyaXRlX2NvbHVtbl9vcDsKPiA+Cj4gPgo+ID4gQWxsIHRoZSA0IGhv b2tzIGFyZSBhbHdheXMgbmVlZGVkCj4gPiByZWdhcmRsZXNzIG9mIGFueSBwcm9iZWQgZmVhdHVy ZXMuCj4gPgo+ID4KPiA+IFRoZSByZXN1bHQgaXMganVzdCB0ZXh0dWFsIHJlcGxhY2VtZW50Cj4g PiBkZW5hbGlfKiB3aXRoIGRlbmFsaS0+Ki4KPiA+Cj4gPiBXaGF0J3MgdGhlIHBvaW50IG9mIGNv cHlpbmcgZml4ZWQgZnVuY3Rpb24gYWRkcmVzc2VzCj4gPiB0byBkZW5hbGkgc3RydWN0dXJlPwo+ ID4KPiA+Cj4KPiBXaGF0IEkgZG9uJ3QgbGlrZSBpcyB0aGUgZnVuY3Rpb24gcG9pbnRlciBhcyBh IGZ1bmN0aW9uIHBhcmFtZXRlci4KClRoaXMgaXMgYSB1c3VhbCB3YXkgdG8gaGFuZGxlIGNhbGxi YWNrLgoKPiBZb3UKPiBjYW4gdXNlIHRoZSBmdW5jdGlvbnMgZGVmaW5lZCBzdGF0aWNhbGx5IGlm IHlvdSBwcmVmZXIgYXMgbG9uZyBhcyB0aGUKPiBwYXJhbWV0ZXIgaXMganVzdCBhIGJvb2xlYW4g Zm9yIGluc3RhbmNlPwoKCgpJIHN0aWxsIGRvIG5vdCB1bmRlcnN0YW5kIHlvdXIgY29uY2VybiwK YnV0IGlmIHlvdSBiYW4gdGhlIHVzZSBvZiBmdW5jdGlvbiBwb2ludGVyLAp0aGUgZm9sbG93aW5n IGlzIHRoZSBiZXN0IEkgY2FuIGRvCnNpbmNlIHRoZXJlIGFyZSA0IGhvb2tzIGRlcGVuZGluZyBv biB0aGUKY29tYmluYXRpb24gb2Ygb29iL3Jhdywgd3JpdGUvcmVhZC4KCgoKaWYgKG9vYikgewog ICAgICAgIGlmICh3cml0ZSkKICAgICAgICAgICAgICAgIHJldHVybiBuYW5kX2NoYW5nZV93cml0 ZV9jb2x1bW5fb3AoY2hpcCwgb2Zmc2V0LCBidWYsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGxlbiwgZmFsc2UpOwogICAgICAgIGVsc2UKICAgICAg ICAgICAgICAgIHJldHVybiBuYW5kX2NoYW5nZV9yZWFkX2NvbHVtbl9vcChjaGlwLCBvZmZzZXQs IGJ1ZiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs ZW4sIGZhbHNlKTsKfQoKaWYgKHdyaXRlKQogICAgICAgIG1lbWNweShkZW5hbGktPmJ1ZiArIG9m ZnNldCwgYnVmLCBsZW4pOwplbHNlCiAgICAgICAgbWVtY3B5KGJ1ZiwgZGVuYWxpLT5idWYgKyBv ZmZzZXQsIGxlbik7CgpyZXR1cm4gMDsKCgoKCkJUVywgd2hlbiBhcmUgLnJlYWRfcGFnZV9yYXcg LyAud3JpdGVfcGFnZV9yYXcgdXNlZD8KCkN1cnJlbnRseSwgSSB1c2UgIndob2xlIHBhZ2UgYWNj ZXNzICYmIG1lbWNweSIgZm9yIGJldHRlciBwZXJmb3JtYW5jZS4KCklmIHRob3NlIGhvb2tzIGFy ZSByYXJlbHkgdXNlZCwgSSB1c2UKbmFuZF9jaGFuZ2Vfd3JpdGVfY29sdW1uX29wIC8gbmFuZF9j aGFuZ2VfcmVhZF9jb2x1bW5fb3AsCndoaWNoIHdpbGwgcmVkdWNlIHRoZSBpZi1jb25kaXRpb25h bC4KCgoKCj4KPiBUaGFua3MsCj4gTWlxdcOobAo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gTGludXggTVREIGRpc2N1c3Npb24gbWFp bGluZyBsaXN0Cj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1tdGQvCgoKCi0tIApCZXN0IFJlZ2FyZHMKTWFzYWhpcm8gWWFtYWRhCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRp c2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtbXRkLwo=