From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ACBBC6778F for ; Wed, 25 Jul 2018 14:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFE4720843 for ; Wed, 25 Jul 2018 14:17:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="eOYCMmgn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFE4720843 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729078AbeGYP3g (ORCPT ); Wed, 25 Jul 2018 11:29:36 -0400 Received: from conssluserg-06.nifty.com ([210.131.2.91]:43553 "EHLO conssluserg-06.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728486AbeGYP3g (ORCPT ); Wed, 25 Jul 2018 11:29:36 -0400 Received: from mail-ua0-f174.google.com (mail-ua0-f174.google.com [209.85.217.174]) (authenticated) by conssluserg-06.nifty.com with ESMTP id w6PEHLCI027475 for ; Wed, 25 Jul 2018 23:17:22 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com w6PEHLCI027475 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1532528242; bh=eN8CwJzALhkb91FU1zpceBAhTpUEfIqrr/L+E9rTR3Y=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=eOYCMmgnurHieBuc75pLW3RMb03316PJ8Hg2tj1TSDQdfs1Lwepikt7uxqgNujGVE PfesDvQqVJkdprmBi8LQycXZouW967djGy7V4Mzc3j1ApD0+400riMEqQDjfzXrtW6 Tdnsnurv5rUPUudvMv2MyWqYNeao7Un37+HBVw7edG+H0SCkNwpyvikVmeOBmk3s81 oCsxLdGVAPIURuDFA/fcvbBLN4tFK2k6dJ/xwXF7Rr/91GawXvB+ek4o3DbFFWnnnJ YSD3rAguLNCtHebu8aV3cXKihkf3m/RoegQJPUTB4nW1iwAnIw0U4dvmKvPSo862bT v5hGLJBrTSWuA== X-Nifty-SrcIP: [209.85.217.174] Received: by mail-ua0-f174.google.com with SMTP id t14-v6so5148887uao.8 for ; Wed, 25 Jul 2018 07:17:22 -0700 (PDT) X-Gm-Message-State: AOUpUlEf8nmVeLqXv7VuEHdxi5VBbrgi51l6p/M2slIHi0NlCEQN04LG wVLFJ34aQtXrUJn0R5LrsH894BqMspV71hFS0Nk= X-Google-Smtp-Source: AAOMgpea8mQP8l+2/NduFqbQ63PFn9JWBEgw75Ef+XcMH9CirdwS2mElqRwy4JCP+XB1TOISdqHdZJ+FFFNELzc7xiw= X-Received: by 2002:ab0:70a9:: with SMTP id q9-v6mr14567740ual.141.1532528241304; Wed, 25 Jul 2018 07:17:21 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:7289:0:0:0:0:0 with HTTP; Wed, 25 Jul 2018 07:16:40 -0700 (PDT) In-Reply-To: <20180725144717.604d3197@xps13> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-5-miquel.raynal@bootlin.com> <20180725115116.1fb38fe3@bbrezillon> <20180725144717.604d3197@xps13> From: Masahiro Yamada Date: Wed, 25 Jul 2018 23:16:40 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan() To: Miquel Raynal Cc: Boris Brezillon , Alexandre Belloni , Mans Rullgard , Maxime Ripard , Stefan Agner , Nicolas Ferre , linux-mtd , Kamal Dasu , Josh Wu , Tudor Ambarus , Marek Vasut , Chen-Yu Tsai , Broadcom Kernel Feedback List , Sylvain Lemieux , Wenyou Yang , Marc Gonzalez , Vladimir Zapolskiy , Harvey Hunt , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Han Xu , Xiaolei Li , linux-arm-kernel , Linux Kernel Mailing List , Richard Weinberger , Brian Norris , David Woodhouse Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-07-25 21:47 GMT+09:00 Miquel Raynal : > Hi Boris, > > Boris Brezillon wrote on Wed, 25 Jul 2018 > 11:51:16 +0200: > >> On Wed, 25 Jul 2018 18:42:44 +0900 >> Masahiro Yamada wrote: >> >> > >> > You need to remove kfree(denali->buf) >> > from denali_remove(), right? >> >> Absolutely. >> >> > >> > void denali_remove(struct denali_nand_info *denali) >> > { >> > struct mtd_info *mtd =3D nand_to_mtd(&denali->nand); >> > >> > nand_release(mtd); >> > kfree(denali->buf); <---- REMOVE !! >> > denali_disable_irq(denali); >> > } >> > >> > >> > Otherwise, denali_remove() will free denali->buf twice >> > because kfree(denali->buf) is called from denali_detach_chip(). >> > > Absolutely, thanks for reviewing! > > I'll apply with this changed. > > Miqu=C3=A8l Assuming you will fix this, Acked-by: Masahiro Yamada --=20 Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 In-Reply-To: <20180725144717.604d3197@xps13> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-5-miquel.raynal@bootlin.com> <20180725115116.1fb38fe3@bbrezillon> <20180725144717.604d3197@xps13> From: Masahiro Yamada Date: Wed, 25 Jul 2018 23:16:40 +0900 Message-ID: Subject: Re: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan() To: Miquel Raynal Cc: Boris Brezillon , Alexandre Belloni , Mans Rullgard , Maxime Ripard , Stefan Agner , Nicolas Ferre , linux-mtd , Kamal Dasu , Josh Wu , Tudor Ambarus , Marek Vasut , Chen-Yu Tsai , Broadcom Kernel Feedback List , Sylvain Lemieux , Wenyou Yang , Marc Gonzalez , Vladimir Zapolskiy , Harvey Hunt , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Han Xu , Xiaolei Li , linux-arm-kernel , Linux Kernel Mailing List , Richard Weinberger , Brian Norris , David Woodhouse Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , 2018-07-25 21:47 GMT+09:00 Miquel Raynal : > Hi Boris, > > Boris Brezillon wrote on Wed, 25 Jul 2018 > 11:51:16 +0200: > >> On Wed, 25 Jul 2018 18:42:44 +0900 >> Masahiro Yamada wrote: >> >> > >> > You need to remove kfree(denali->buf) >> > from denali_remove(), right? >> >> Absolutely. >> >> > >> > void denali_remove(struct denali_nand_info *denali) >> > { >> > struct mtd_info *mtd =3D nand_to_mtd(&denali->nand); >> > >> > nand_release(mtd); >> > kfree(denali->buf); <---- REMOVE !! >> > denali_disable_irq(denali); >> > } >> > >> > >> > Otherwise, denali_remove() will free denali->buf twice >> > because kfree(denali->buf) is called from denali_detach_chip(). >> > > Absolutely, thanks for reviewing! > > I'll apply with this changed. > > Miqu=C3=A8l Assuming you will fix this, Acked-by: Masahiro Yamada --=20 Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Subject: Re: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan() Date: Wed, 25 Jul 2018 23:16:40 +0900 Message-ID: References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-5-miquel.raynal@bootlin.com> <20180725115116.1fb38fe3@bbrezillon> <20180725144717.604d3197@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20180725144717.604d3197@xps13> Sender: linux-kernel-owner@vger.kernel.org To: Miquel Raynal Cc: Boris Brezillon , Alexandre Belloni , Mans Rullgard , Maxime Ripard , Stefan Agner , Nicolas Ferre , linux-mtd , Kamal Dasu , Josh Wu , Tudor Ambarus , Marek Vasut , Chen-Yu Tsai , Broadcom Kernel Feedback List , Sylvain Lemieux , Wenyou Yang , Marc Gonzalez , Vladimir Zapolskiy , Harvey Hunt List-Id: linux-mediatek@lists.infradead.org 2018-07-25 21:47 GMT+09:00 Miquel Raynal : > Hi Boris, > > Boris Brezillon wrote on Wed, 25 Jul 2018 > 11:51:16 +0200: > >> On Wed, 25 Jul 2018 18:42:44 +0900 >> Masahiro Yamada wrote: >> >> > >> > You need to remove kfree(denali->buf) >> > from denali_remove(), right? >> >> Absolutely. >> >> > >> > void denali_remove(struct denali_nand_info *denali) >> > { >> > struct mtd_info *mtd =3D nand_to_mtd(&denali->nand); >> > >> > nand_release(mtd); >> > kfree(denali->buf); <---- REMOVE !! >> > denali_disable_irq(denali); >> > } >> > >> > >> > Otherwise, denali_remove() will free denali->buf twice >> > because kfree(denali->buf) is called from denali_detach_chip(). >> > > Absolutely, thanks for reviewing! > > I'll apply with this changed. > > Miqu=C3=A8l Assuming you will fix this, Acked-by: Masahiro Yamada --=20 Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro@socionext.com (Masahiro Yamada) Date: Wed, 25 Jul 2018 23:16:40 +0900 Subject: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan() In-Reply-To: <20180725144717.604d3197@xps13> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-5-miquel.raynal@bootlin.com> <20180725115116.1fb38fe3@bbrezillon> <20180725144717.604d3197@xps13> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2018-07-25 21:47 GMT+09:00 Miquel Raynal : > Hi Boris, > > Boris Brezillon wrote on Wed, 25 Jul 2018 > 11:51:16 +0200: > >> On Wed, 25 Jul 2018 18:42:44 +0900 >> Masahiro Yamada wrote: >> >> > >> > You need to remove kfree(denali->buf) >> > from denali_remove(), right? >> >> Absolutely. >> >> > >> > void denali_remove(struct denali_nand_info *denali) >> > { >> > struct mtd_info *mtd = nand_to_mtd(&denali->nand); >> > >> > nand_release(mtd); >> > kfree(denali->buf); <---- REMOVE !! >> > denali_disable_irq(denali); >> > } >> > >> > >> > Otherwise, denali_remove() will free denali->buf twice >> > because kfree(denali->buf) is called from denali_detach_chip(). >> > > Absolutely, thanks for reviewing! > > I'll apply with this changed. > > Miqu?l Assuming you will fix this, Acked-by: Masahiro Yamada -- Best Regards Masahiro Yamada