All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	arnd@arndb.de, akpm@linux-foundation.org, eugene.loh@oracle.com,
	kris.van.hees@oracle.com
Subject: Re: [PATCH v10 03/13] kbuild: add tristate checker
Date: Mon, 6 Mar 2023 00:10:22 +0900	[thread overview]
Message-ID: <CAK7LNASpkAY=t3uOmehTDD7o1-MY9Kzm1C=V2+i0XhHmjjJdUQ@mail.gmail.com> (raw)
In-Reply-To: <20221205163157.269335-4-nick.alcock@oracle.com>

On Tue, Dec 6, 2022 at 1:32 AM Nick Alcock <nick.alcock@oracle.com> wrote:
>
> This new check target uses the tristate.conf machinery just added, and
> modules.builtin.objs, to identify source files that have MODULE_*
> declarations despite not being modules according to Kconfig.  After
> commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), all such declarations will cause
> modprobe to misidentify their containing object file as a module when it
> is not, which might cause it to spuriously fail when trying to load
> something that is built in to the kernel.




Having false-positives in modules.builtin should be OK.


Also, scripts/check-tristates.mk is just a rename of
scripts/Makefile.modbuiltin.


NACK.





--
Best Regards


Masahiro Yamada

  reply	other threads:[~2023-03-05 15:11 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 16:31 [PATCH modules-next v10 00/13] kallsyms: reliable symbol->address lookup with /proc/kallmodsyms Nick Alcock
2022-12-05 16:31 ` [PATCH v10 01/13] kbuild: add modules.builtin.objs Nick Alcock
2022-12-05 16:31 ` [PATCH v10 02/13] kbuild: bring back tristate.conf Nick Alcock
2023-03-05  8:10   ` Masahiro Yamada
2022-12-05 16:31 ` [PATCH v10 03/13] kbuild: add tristate checker Nick Alcock
2023-03-05 15:10   ` Masahiro Yamada [this message]
2022-12-05 16:31 ` [PATCH v10 04/13] kbuild: fix up substitutions in makefiles to allow for " Nick Alcock
2023-03-05 15:11   ` Masahiro Yamada
2022-12-05 16:31 ` [PATCH v10 05/13] kbuild: remove MODULE_LICENSE/AUTHOR/DESCRIPTION in non-modules Nick Alcock
2022-12-06  9:11   ` Geert Uytterhoeven
2022-12-06 20:03     ` Nick Alcock
2022-12-06 21:02       ` Arnd Bergmann
2022-12-07  5:03         ` Luis Chamberlain
2022-12-07  5:10           ` Luis Chamberlain
2022-12-07  8:21           ` Christoph Hellwig
2023-03-05  8:09           ` Masahiro Yamada
2022-12-05 16:31 ` [PATCH v10 06/13] build: add a simple iterator over modules.builtin.objs Nick Alcock
2022-12-05 16:31 ` [PATCH v10 07/13] kbuild: generate an address ranges map at vmlinux link time Nick Alcock
2022-12-05 16:31 ` [PATCH v10 08/13] kbuild: make address ranges map work with IBT Nick Alcock
2022-12-05 16:31 ` [PATCH v10 09/13] kallsyms: introduce sections needed to map symbols to built-in modules Nick Alcock
2022-12-05 16:31 ` [PATCH v10 10/13] kallsyms: optimize .kallsyms_modules* Nick Alcock
2022-12-05 16:31 ` [PATCH v10 11/13] kallsyms: distinguish text symbols fully using object file names Nick Alcock
2022-12-05 16:31 ` [PATCH v10 12/13] kallsyms: add /proc/kallmodsyms for text symbol disambiguation Nick Alcock
2022-12-05 16:31 ` [PATCH v10 13/13] perf: proof-of-concept kallmodsyms support Nick Alcock
2022-12-16 15:21 ` [PING] [PATCH modules-next v10 00/13] kallsyms: reliable symbol->address lookup with /proc/kallmodsyms Nick Alcock
2023-01-17 19:51 ` Luis Chamberlain
2023-02-09 16:54   ` Nick Alcock
2023-02-09 23:53     ` Nick Alcock
2023-02-21 21:48       ` Luis Chamberlain
2023-02-22 12:08         ` Nick Alcock
2023-02-22 22:25           ` Luis Chamberlain
2023-04-07 23:21 ` Josh Poimboeuf
2023-04-10 13:08   ` Joe Lawrence
2023-04-24 19:47   ` Luis Chamberlain
2023-04-25  8:27     ` Petr Mladek
2023-05-08 22:06 ` Steven Rostedt
2023-05-19 15:50   ` Alexander Lobakin
2023-05-22 23:21     ` Luis Chamberlain
2023-05-24 15:02     ` Nick Alcock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNASpkAY=t3uOmehTDD7o1-MY9Kzm1C=V2+i0XhHmjjJdUQ@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=eugene.loh@oracle.com \
    --cc=kris.van.hees@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.