From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Date: Mon, 23 Apr 2018 13:50:49 +0900 Subject: [U-Boot] [PATCH 2/4] dm: ofnode: add ofnode_device_is_compatible() helper In-Reply-To: References: <1524019125-26287-1-git-send-email-yamada.masahiro@socionext.com> <1524019125-26287-3-git-send-email-yamada.masahiro@socionext.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de 2018-04-23 5:11 GMT+09:00 Simon Glass : > Hi Masahiro, > > On 17 April 2018 at 20:38, Masahiro Yamada > wrote: >> device_is_compatible() takes udevice, but there is no such a helper >> that takes ofnode. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> drivers/core/device.c | 8 +------- >> drivers/core/ofnode.c | 11 +++++++++++ >> include/dm/ofnode.h | 11 +++++++++++ >> 3 files changed, 23 insertions(+), 7 deletions(-) > > Please can you add a call to this to a test? > No. I do not see any ofnode helper test in test/dm/. You are requesting additional work beyond this patch. It is unfair. This helper is tested indirectly by other tests. Of course, you (and anybody) are free to add per-helper grained tests, but this is not a good reason to block this patch. -- Best Regards Masahiro Yamada