From mboxrd@z Thu Jan  1 00:00:00 1970
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Tue, 21 Apr 2015 18:23:19 +0900
Subject: [U-Boot] [patch] socfpga: move configuration options to config
	file
In-Reply-To: <20150420123048.GA24149@amd>
References: <20150420123048.GA24149@amd>
Message-ID: <CAK7LNASr9pz9goxuqU99gO6T62ytE-Y+toq9_DMfrZGdz4b8MQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

2015-04-20 21:30 GMT+09:00 Pavel Machek <pavel@denx.de>:
> Setting configuration options in header file leads to incosistency
> between .config user sees, and .config he has. What is worse, a lot of
> compile warnings is presented for any such config option user sets in
> .config.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
>
> diff --git a/configs/socfpga_cyclone5_defconfig b/configs/socfpga_cyclone5_defconfig
> index 0ebfbfc..762b937 100644
> --- a/configs/socfpga_cyclone5_defconfig
> +++ b/configs/socfpga_cyclone5_defconfig
> @@ -6,3 +6,19 @@ CONFIG_DEFAULT_DEVICE_TREE="socfpga_cyclone5_socdk"
>  CONFIG_DM=y
>  CONFIG_DM_SPI=y
>  CONFIG_DM_SPI_FLASH=y
> +CONFIG_CMD_ASKENV=y
> +CONFIG_CMD_BOOTZ=y
> +CONFIG_CMD_CACHE=y
> +CONFIG_CMD_DFU=y
> +CONFIG_CMD_DHCP=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_EXT4_WRITE=y
> +CONFIG_CMD_FAT=y
> +CONFIG_CMD_FS_GENERIC=y
> +CONFIG_CMD_GREPENV=y
> +CONFIG_CMD_MII=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_PING=y
> +CONFIG_CMD_SETEXPR=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y

You need to add these to common/Kconfig
as well as to your defconfig.

Otherwise, they do not appear in the .config file.

There exist CMD_RUN, CMD_PING, CMD_USB in common/Kconfig,
but most of the others are missing.


-- 
Best Regards
Masahiro Yamada