From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Date: Tue, 10 Jan 2017 19:57:22 +0900 Subject: [U-Boot] [PATCH v2 7/7] ARM: sunxi: remove bare default for CONFIG_MMC In-Reply-To: <20170110080424.4k5cwxhdpjawkzl4@lukather> References: <1484022728-9340-1-git-send-email-yamada.masahiro@socionext.com> <1484022728-9340-8-git-send-email-yamada.masahiro@socionext.com> <20170110080424.4k5cwxhdpjawkzl4@lukather> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de 2017-01-10 17:04 GMT+09:00 Maxime Ripard : > Hi, > > On Tue, Jan 10, 2017 at 01:32:08PM +0900, Masahiro Yamada wrote: >> The bare default entry is wrong. Just remove it since the (real) >> entry in drivers/mmc/Kconfig has "default ARM || PPC || SANDBOX". >> >> Signed-off-by: Masahiro Yamada >> Reviewed-by: Marek Vasut >> --- >> >> Changes in v2: None >> >> board/sunxi/Kconfig | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig >> index e1d4ab1..11eb82a 100644 >> --- a/board/sunxi/Kconfig >> +++ b/board/sunxi/Kconfig >> @@ -291,10 +291,6 @@ config OLD_SUNXI_KERNEL_COMPAT >> Set this to enable various workarounds for old kernels, this results in >> sub-optimal settings for newer kernels, only enable if needed. >> >> -config MMC >> - depends on !UART0_PORT_F >> - default y if ARCH_SUNXI >> - > > The default might be useless, but the additional depends on is really > not. This is wrong anyway. If you want to disable MMC, the following seems better. config MMC_SUNXI depends on ARCH_SUNXI && !UART0_PORT_F BTW, UART0_PORT_F seems SUNXI specific. If this symbol is useful, I'd like to recommend to rename it to ARCH_SUNXI_UART0_PORT_F or something. -- Best Regards Masahiro Yamada