All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	"David S. Miller" <davem@davemloft.net>,
	Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpfilter: document build requirements for bpfilter_umh
Date: Sat, 9 May 2020 16:51:00 +0900	[thread overview]
Message-ID: <CAK7LNAT2xMR9fq+bJCc=1wLuEM99fPNagDc=NkFoDKNi-YCpDg@mail.gmail.com> (raw)
In-Reply-To: <131136.1588999639@turing-police>

On Sat, May 9, 2020 at 1:47 PM Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
>
> It's not intuitively obvious that bpfilter_umh is a statically linked binary.
> Mention the toolchain requirement in the Kconfig help, so people
> have an easier time figuring out what's needed.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>

Applied to linux-kbuild.
Thanks.


> diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
> index fed9290e3b41..0ec6c7958c20 100644
> --- a/net/bpfilter/Kconfig
> +++ b/net/bpfilter/Kconfig
> @@ -13,4 +13,8 @@ config BPFILTER_UMH
>         default m
>         help
>           This builds bpfilter kernel module with embedded user mode helper
> +
> +         Note: your toolchain must support building static binaries, since
> +         rootfs isn't mounted at the time when __init functions are called
> +         and do_execv won't be able to find the elf interpreter.
>  endif
>


-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2020-05-09  7:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  4:47 [PATCH] bpfilter: document build requirements for bpfilter_umh Valdis Klētnieks
2020-05-09  7:51 ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNAT2xMR9fq+bJCc=1wLuEM99fPNagDc=NkFoDKNi-YCpDg@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.