From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932825AbcHXSXp (ORCPT ); Wed, 24 Aug 2016 14:23:45 -0400 Received: from condef001-v.nifty.com ([210.131.4.238]:42267 "EHLO condef001-v.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753440AbcHXSXl (ORCPT ); Wed, 24 Aug 2016 14:23:41 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com u7OIIu91014366 X-Nifty-SrcIP: [209.85.161.181] MIME-Version: 1.0 In-Reply-To: <20643424.8eBLZWavEG@wuerfel> References: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de> <20643424.8eBLZWavEG@wuerfel> From: Masahiro Yamada Date: Thu, 25 Aug 2016 03:18:55 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/10] reset: ath79: add driver Kconfig option To: Arnd Bergmann Cc: Philipp Zabel , Axel Lin , Hans de Goede , Linux Kernel Mailing List , Alban Bedel , Maxime Ripard , Lee Jones , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, 2016-08-25 0:51 GMT+09:00 Arnd Bergmann : > On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote: >> if RESET_CONTROLLER >> >> +config RESET_ATH79 >> + bool "AR71xx Reset Driver" if COMPILE_TEST >> + default ATH79 >> + help >> + This enables the ATH79 reset controller driver that supports the >> + AR71xx SoC reset controller. >> + >> > > Nice series! > > Just note that there is one possible problem with COMPILE_TEST > when the platforms are enabled, as you can then disable a driver > that is normally there, and that can in turn cause problems in > rare cases, e.g. when the driver has a global function that is > called from platform code. I don't know if any of the drivers > do that, but if they do, you'd have to use > > config RESET_ATH79 > bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79 > default ATH79 > > to ensure that it's impossible to disable the driver on platforms > that require it. Hmm, Can we do this only when we really have to do so? I think we should not care about such a rare case that may not happen. Let's start with only "if COMPILE_TEST", and take a look at it if a build error is detected. Anyway, depending on platform code is a sign of weird implementation. It might be better to find a potential issue rather than hide it. -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro@socionext.com (Masahiro Yamada) Date: Thu, 25 Aug 2016 03:18:55 +0900 Subject: [PATCH 01/10] reset: ath79: add driver Kconfig option In-Reply-To: <20643424.8eBLZWavEG@wuerfel> References: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de> <20643424.8eBLZWavEG@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, 2016-08-25 0:51 GMT+09:00 Arnd Bergmann : > On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote: >> if RESET_CONTROLLER >> >> +config RESET_ATH79 >> + bool "AR71xx Reset Driver" if COMPILE_TEST >> + default ATH79 >> + help >> + This enables the ATH79 reset controller driver that supports the >> + AR71xx SoC reset controller. >> + >> > > Nice series! > > Just note that there is one possible problem with COMPILE_TEST > when the platforms are enabled, as you can then disable a driver > that is normally there, and that can in turn cause problems in > rare cases, e.g. when the driver has a global function that is > called from platform code. I don't know if any of the drivers > do that, but if they do, you'd have to use > > config RESET_ATH79 > bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79 > default ATH79 > > to ensure that it's impossible to disable the driver on platforms > that require it. Hmm, Can we do this only when we really have to do so? I think we should not care about such a rare case that may not happen. Let's start with only "if COMPILE_TEST", and take a look at it if a build error is detected. Anyway, depending on platform code is a sign of weird implementation. It might be better to find a potential issue rather than hide it. -- Best Regards Masahiro Yamada