From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbeDEFAr (ORCPT ); Thu, 5 Apr 2018 01:00:47 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:40636 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbeDEFAp (ORCPT ); Thu, 5 Apr 2018 01:00:45 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com w3550dYm032478 X-Nifty-SrcIP: [209.85.217.171] X-Google-Smtp-Source: AIpwx48jUCXJslM1mpGqX+nIGfz45J2op5Q71hxGM5stpIH/lu2M7+kjMbBDjxH4fp971ycpyJS5mkqU9ix6QSW4C0o= MIME-Version: 1.0 In-Reply-To: <20180329004805.7278-4-labbott@redhat.com> References: <20180329004805.7278-1-labbott@redhat.com> <20180329004805.7278-4-labbott@redhat.com> From: Masahiro Yamada Date: Thu, 5 Apr 2018 13:59:58 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] kbuild: Allow passing additional HOSTCFLAGS and HOSTLDFLAGS To: Laura Abbott Cc: Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Josh Poimboeuf Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-03-29 9:48 GMT+09:00 Laura Abbott : > > Similar to AFLAGS_KBUILD, there may be uses (e.g. hardening) for passing in > additional flags to host programs. Allow these to be passed in from the > environment. > > Signed-off-by: Laura Abbott > --- > Documentation/kbuild/kbuild.txt | 9 +++++++++ > Makefile | 3 +++ > 2 files changed, 12 insertions(+) > > diff --git a/Documentation/kbuild/kbuild.txt b/Documentation/kbuild/kbuild.txt > index ac2363ea05c5..3751a4bc8596 100644 > --- a/Documentation/kbuild/kbuild.txt > +++ b/Documentation/kbuild/kbuild.txt > @@ -24,6 +24,15 @@ KAFLAGS > -------------------------------------------------- > Additional options to the assembler (for built-in and modules). > > +AFLAGS_HOSTCFLAGS > +-------------------------------------------------- > +Additional options passed to the compiler when building host programs. > + > +AFLAGS_HOSTLDFLAGS > +-------------------------------------------------- > +Additional options passed to the linker (through the compiler) when buidling > +host programs. > + I am afraid you misunderstood the meaning of 'AFLAGS'. AFLAGS is not 'Additional flags', but 'Assembler flags' that are used for compiling *.S files. AFLAGS for host programs is weird. I see similar proposals from different people. I replied like follows: https://lkml.org/lkml/2018/2/28/178 However, Robin seems busy lately. I will wait a bit, then if nobody does this, I may do it. > AFLAGS_MODULE > -------------------------------------------------- > Additional module specific options to use for $(AS). > diff --git a/Makefile b/Makefile > index 7ba478ab8c82..2cab3f8d489c 100644 > --- a/Makefile > +++ b/Makefile > @@ -367,6 +367,9 @@ HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) > HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) > HOST_LOADLIBES := $(HOST_LFS_LIBS) > > +HOSTCFLAGS += $(AFLAGS_HOSTCFLAGS) > +HOSTLDFLAGS += $(AFLAGS_HOSTLDFLAGS) > + > # Make variables (CC, etc...) > AS = $(CROSS_COMPILE)as > LD = $(CROSS_COMPILE)ld > -- > 2.16.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada