From: Masahiro Yamada <masahiroy@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Kortan <kortanzh@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
llvm@lists.linux.dev,
clang-built-linux <clang-built-linux@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gen_compile_commands: fix missing 'sys' package
Date: Thu, 9 Sep 2021 20:01:11 +0900 [thread overview]
Message-ID: <CAK7LNATA2-4jSfOCmdtgQ+cuAyXhyLCBuVEZkZ3nONZFV8z3EA@mail.gmail.com> (raw)
In-Reply-To: <YTjt5C7xTqNLUSl/@archlinux-ax161>
On Thu, Sep 9, 2021 at 2:07 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Wed, Sep 08, 2021 at 11:28:48AM +0800, Kortan wrote:
> > We need to import the 'sys' package since the script has called
> > sys.exit() method.
> >
> > Signed-off-by: Kortan <kortanzh@gmail.com>
>
> Thank you for making those changes!
>
> I should have mentioned that this probably warrants a Fixes: tag, which
> can be generated by running:
>
> $ git show -s --format='Fixes: %h ("%s")' 6ad7cbc01527223f3f92baac9b122f15651cf76b
> Fixes: 6ad7cbc01527 ("Makefile: Add clang-tidy and static analyzer support to makefile")
>
> as that was the patch that introduced this issue. I personally have a
> git alias for this as it comes up enough.
>
> $ git config --get alias.fixes
> show -s --format="Fixes: %h (\"%s\")"
>
> I do not think this warrants a v3, just something to keep in mind for
> the future.
>
> Fixes: 6ad7cbc01527 ("Makefile: Add clang-tidy and static analyzer support to makefile")
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Applied to linux-kbuild
with Fixes and Nathan's Reviewed-by.
Thanks.
> > ---
> > Changes v1 -> v2:
> > * Fix commit title.
> > * Improve commit message.
> >
> > scripts/clang-tools/gen_compile_commands.py | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
> > index 0033eedce003..1d1bde1fd45e 100755
> > --- a/scripts/clang-tools/gen_compile_commands.py
> > +++ b/scripts/clang-tools/gen_compile_commands.py
> > @@ -13,6 +13,7 @@ import logging
> > import os
> > import re
> > import subprocess
> > +import sys
> >
> > _DEFAULT_OUTPUT = 'compile_commands.json'
> > _DEFAULT_LOG_LEVEL = 'WARNING'
> > --
> > 2.33.0
> >
> >
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2021-09-09 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 3:28 [PATCH v2] gen_compile_commands: fix missing 'sys' package Kortan
2021-09-08 17:07 ` Nathan Chancellor
2021-09-09 11:01 ` Masahiro Yamada [this message]
2021-09-09 17:22 ` Nick Desaulniers
2021-09-09 17:22 ` Nick Desaulniers
2021-09-09 19:28 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNATA2-4jSfOCmdtgQ+cuAyXhyLCBuVEZkZ3nONZFV8z3EA@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=kortanzh@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.