From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D695DC48BD1 for ; Wed, 9 Jun 2021 13:55:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C30DE61351 for ; Wed, 9 Jun 2021 13:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236900AbhFIN5u (ORCPT ); Wed, 9 Jun 2021 09:57:50 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:39980 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236898AbhFIN5r (ORCPT ); Wed, 9 Jun 2021 09:57:47 -0400 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 159DtXZJ012079; Wed, 9 Jun 2021 22:55:35 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 159DtXZJ012079 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1623246936; bh=hcr+Eu7cFxCqa4ADxNq7akOPtlDexVyc+1o3NpX/RWk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jvFWkPSptMfJTrrkoeGd30Rren9o4EvU5Fc+6JP/Ylx1OL7VnGZ32aWNt++QK7qc6 aUw+FOCCBkgjnOvlcLIqYbsUZIgSzh8r2hN74mkTj7xwSQ2jX0gOhCnlkuNhnvZnCD 6jhnICuVlV1Nm65TFycloc9hwAsn8FM74OtyQkdm0kNli6GlIEI2BCGUyKO0RyDpih YQ433ZPcwXbB6zdPYv2pcOYlGfCox56hOXW4ocPcKNCP6i9WdwQ41GwP1sWttPj51+ AsHz/3satssGfMLy0ijEyalQ/CzxwvkcfzlLbZ6I+/2I81cZUC+L4Zv+421dCK4rag shfyaIUtop84A== X-Nifty-SrcIP: [209.85.215.179] Received: by mail-pg1-f179.google.com with SMTP id o9so16697526pgd.2; Wed, 09 Jun 2021 06:55:35 -0700 (PDT) X-Gm-Message-State: AOAM532uNIlIuu0VAcJR7mlhkNGPQzLDIw4nR+9VqQLgf3XcC8oxo4Vy yLv8TfjIQ68GKY2XsApE7Nl2J76x5IsWNxHHpcQ= X-Google-Smtp-Source: ABdhPJxxsiDDGnMiEXR9YbCZEl42/5e351UXFxCRbhTOvbkPUPqmTgbPDyunkL0JkaGGSxpa4JEWwB9yRtSxAn+69Uk= X-Received: by 2002:a63:6841:: with SMTP id d62mr3995000pgc.7.1623246931360; Wed, 09 Jun 2021 06:55:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Masahiro Yamada Date: Wed, 9 Jun 2021 22:54:54 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Makefile: make modules install output To: Julia Lawall Cc: Linux Kbuild mailing list , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 9, 2021 at 7:16 PM Julia Lawall wrote: > > make modules install used to end up with something like > > INSTALL sound/usb/usx2y/snd-usb-usx2y.ko > INSTALL sound/x86/snd-hdmi-lpe-audio.ko > INSTALL sound/xen/snd_xen_front.ko > INSTALL virt/lib/irqbypass.ko > DEPMOD 5.12.0-rc2myfix-00015-gc6f886546cb8 > > From v5.13-rc1, it gives: > > STRIP /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko > STRIP /lib/modules/5.13.0-rc1myfix/kernel/fs/xfs/xfs.ko > STRIP /lib/modules/5.13.0-rc1myfix/kernel/net/mac80211/mac80211.ko > STRIP /lib/modules/5.13.0-rc1myfix/kernel/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko > STRIP /lib/modules/5.13.0-rc1myfix/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko > DEPMOD /lib/modules/5.13.0-rc1myfix > > Is the full path name considered to be an improvement? I think so. It is clear where the files are being installed to. Another motivation was rather to make it aligned with the convention. Kbuild log convention is this form: [ACTION] [DESTINATION] For example, when Kbuild is building kernel/foo.c into kernel/foo.o CC kernel/foo.o is shown. In this case, Kbuild is installing kernel/fs/btrfs/btrfs.ko to /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko So, I think it is more consistent to show the destination rather than the source. > For the names of > the modules, it doesn't much matter, but the DEPMOD line was a convenient > way to get the full kernel name for subsequent rebooting. > > thanks, > julia -- Best Regards Masahiro Yamada