From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21758C76195 for ; Sun, 21 Jul 2019 03:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED1A3208E4 for ; Sun, 21 Jul 2019 03:46:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="rWZqNizH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726360AbfGUDpj (ORCPT ); Sat, 20 Jul 2019 23:45:39 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:49690 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbfGUDpj (ORCPT ); Sat, 20 Jul 2019 23:45:39 -0400 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) (authenticated) by conssluserg-04.nifty.com with ESMTP id x6L3jTUn006757; Sun, 21 Jul 2019 12:45:30 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com x6L3jTUn006757 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1563680730; bh=+i1P1EOzIYuFKSpLhOGGexoKtgfai1r9bg5dNGXa6F0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=rWZqNizHxDGhLXiH5RLEM1t/LUAvsgmp8EZk2jKss2AVNYPU4fdHNbMwigsoLYMLs UZE0/gzjudBE3rzE/Qh1bAbbpWMWEBhqyxX07k+ibiY0tTJQtkLW5cZ0Drmt9Um1Mi +W1GvIBSh8z6IG/egE0QRACea1V6Ej3N06iCH29ThBUqz+5siQ63qPpIm7qQUdBIly NaJ1C47+JSnH+6eArNrZ3vK40VJWjRfNyGrrP+SfXCyvkbDp8BYoqSrMQAym9DMf8s 3Z5FWGq6CI5Pqv2Zwz+2nXV3vKgrK14OVX41zB8MGi8vl8Jmv28l9R5CefDW9rghK+ Fyh6qQNdBFl2g== X-Nifty-SrcIP: [209.85.217.49] Received: by mail-vs1-f49.google.com with SMTP id a186so22376498vsd.7; Sat, 20 Jul 2019 20:45:30 -0700 (PDT) X-Gm-Message-State: APjAAAVUWjvL/brrK+krPala2k4FqbnTWkuFgGUuE7Gg4qzyKBVEE4S9 klFJGiCZK/xGwdjiLruUFc8Vz2p8k9NRn5ESKjM= X-Google-Smtp-Source: APXvYqyXn4LIVIGhGfe4GQcWn8jAhDg5lBZ7sWrCxxc9wSyaVu8Ptfm6hbnzjFDumV0Hyo1hL7V34uRrK01YyrMzJ7Y= X-Received: by 2002:a67:8e0a:: with SMTP id q10mr15137391vsd.215.1563680729320; Sat, 20 Jul 2019 20:45:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Masahiro Yamada Date: Sun, 21 Jul 2019 12:44:53 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Question] orphan platform data header To: Arnd Bergmann Cc: Linux Kernel Mailing List , Linus Torvalds , Greg Kroah-Hartman , DTML , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Sat, Jul 20, 2019 at 10:55 PM Arnd Bergmann wrote: > > On Sat, Jul 20, 2019 at 5:26 AM Masahiro Yamada > wrote: > > > > masahiro@grover:~/ref/linux$ git grep netxbig_led_platform_data > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata, > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata) > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata) > > drivers/leds/leds-netxbig.c: struct netxbig_led_platform_data > > *pdata = dev_get_platdata(&pdev->dev); > > include/linux/platform_data/leds-kirkwood-netxbig.h:struct > > netxbig_led_platform_data { > > > > > > > > So, what shall we do? > > > > Drop the board-file support? Or, keep it > > in case somebody is still using their board-files > > in downstream? > > Generally speaking, I'd remove the board file support in another > case like this, but it's worth looking at when it was last used and by > what. > > For this file, all boards got converted to DT, and the old setup > code removed in commit ebc278f15759 ("ARM: mvebu: remove static > LED setup for netxbig boards"), four years ago, so it's a fairly > easy decision to make it DT only. Thanks. I see another case, which is difficult to make a decision. For example, drivers/spi/spi-tle62x0.c This driver supports only board-file, but the board-file is not found in upstream. Unless I am terribly missing something, there is no one who passes tle62x0_pdata to this driver. $ git grep tle62x0_pdata drivers/spi/spi-tle62x0.c: struct tle62x0_pdata *pdata; include/linux/spi/tle62x0.h:struct tle62x0_pdata { But, removing board-file support makes this driver completely useless... -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Subject: Re: [Question] orphan platform data header Date: Sun, 21 Jul 2019 12:44:53 +0900 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: Greg Kroah-Hartman , Linus Torvalds , Linux Kernel Mailing List , linux-arm-kernel , DTML List-Id: devicetree@vger.kernel.org Hi Arnd, On Sat, Jul 20, 2019 at 10:55 PM Arnd Bergmann wrote: > > On Sat, Jul 20, 2019 at 5:26 AM Masahiro Yamada > wrote: > > > > masahiro@grover:~/ref/linux$ git grep netxbig_led_platform_data > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata, > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata) > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata) > > drivers/leds/leds-netxbig.c: struct netxbig_led_platform_data > > *pdata = dev_get_platdata(&pdev->dev); > > include/linux/platform_data/leds-kirkwood-netxbig.h:struct > > netxbig_led_platform_data { > > > > > > > > So, what shall we do? > > > > Drop the board-file support? Or, keep it > > in case somebody is still using their board-files > > in downstream? > > Generally speaking, I'd remove the board file support in another > case like this, but it's worth looking at when it was last used and by > what. > > For this file, all boards got converted to DT, and the old setup > code removed in commit ebc278f15759 ("ARM: mvebu: remove static > LED setup for netxbig boards"), four years ago, so it's a fairly > easy decision to make it DT only. Thanks. I see another case, which is difficult to make a decision. For example, drivers/spi/spi-tle62x0.c This driver supports only board-file, but the board-file is not found in upstream. Unless I am terribly missing something, there is no one who passes tle62x0_pdata to this driver. $ git grep tle62x0_pdata drivers/spi/spi-tle62x0.c: struct tle62x0_pdata *pdata; include/linux/spi/tle62x0.h:struct tle62x0_pdata { But, removing board-file support makes this driver completely useless... -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F14C76188 for ; Sun, 21 Jul 2019 03:46:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFD1A20823 for ; Sun, 21 Jul 2019 03:46:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IMwiY2m6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="rWZqNizH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFD1A20823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Tgr7mxgX9Qa9XQDxsPOaFI472dfrUCWX3PQDhSeU/o=; b=IMwiY2m6f9Uk4i ufqM9zUKOZSfbKFyiyF/74ScSCKh+mfZ2EeUjOe7hGX024WlMqJifAJ/T9dDSXoPM3QctKg3PYXZY cqBLrcXvNrzVbf46irECP/XzZAHDd0VHqHynSWeuVj35o5l5bIy3pfTHOsGHsY/BE/FYriHpWaiHw fQMG7p8+cpCt6HVem7m7dzlGwn5FM1W1rQAdMZa+GrwRHBMMNycyvTqdeQ2X5qBXVhWhvg4mg8OKv wgpNipSjLcidWdQ+eyJMKXSxSN11UMRAY2FVsPOIKxjo5Z0GyLJvxkM++0gXpg5nmIy9vUHHDUyPU fZtAfmOu7IJKpKBFSpUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hp2nV-0006Hv-TD; Sun, 21 Jul 2019 03:46:05 +0000 Received: from conssluserg-05.nifty.com ([210.131.2.90]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hp2nR-0006HS-QL for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2019 03:46:03 +0000 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (authenticated) by conssluserg-05.nifty.com with ESMTP id x6L3jTba007895 for ; Sun, 21 Jul 2019 12:45:30 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com x6L3jTba007895 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1563680730; bh=+i1P1EOzIYuFKSpLhOGGexoKtgfai1r9bg5dNGXa6F0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=rWZqNizHxDGhLXiH5RLEM1t/LUAvsgmp8EZk2jKss2AVNYPU4fdHNbMwigsoLYMLs UZE0/gzjudBE3rzE/Qh1bAbbpWMWEBhqyxX07k+ibiY0tTJQtkLW5cZ0Drmt9Um1Mi +W1GvIBSh8z6IG/egE0QRACea1V6Ej3N06iCH29ThBUqz+5siQ63qPpIm7qQUdBIly NaJ1C47+JSnH+6eArNrZ3vK40VJWjRfNyGrrP+SfXCyvkbDp8BYoqSrMQAym9DMf8s 3Z5FWGq6CI5Pqv2Zwz+2nXV3vKgrK14OVX41zB8MGi8vl8Jmv28l9R5CefDW9rghK+ Fyh6qQNdBFl2g== X-Nifty-SrcIP: [209.85.217.43] Received: by mail-vs1-f43.google.com with SMTP id m23so24026174vso.1 for ; Sat, 20 Jul 2019 20:45:30 -0700 (PDT) X-Gm-Message-State: APjAAAWvUK9tgjhvPpuwNQmfcmU1UPQ26JkiMg+QnIl7fa80nlrLuhyl CxFTltU1I3KzBLVIkg+NGolGj8Km4VNHkgY7K5Y= X-Google-Smtp-Source: APXvYqyXn4LIVIGhGfe4GQcWn8jAhDg5lBZ7sWrCxxc9wSyaVu8Ptfm6hbnzjFDumV0Hyo1hL7V34uRrK01YyrMzJ7Y= X-Received: by 2002:a67:8e0a:: with SMTP id q10mr15137391vsd.215.1563680729320; Sat, 20 Jul 2019 20:45:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Masahiro Yamada Date: Sun, 21 Jul 2019 12:44:53 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Question] orphan platform data header To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190720_204602_075536_EDD59629 X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Linus Torvalds , Linux Kernel Mailing List , linux-arm-kernel , DTML Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Sat, Jul 20, 2019 at 10:55 PM Arnd Bergmann wrote: > > On Sat, Jul 20, 2019 at 5:26 AM Masahiro Yamada > wrote: > > > > masahiro@grover:~/ref/linux$ git grep netxbig_led_platform_data > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata, > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata) > > drivers/leds/leds-netxbig.c: struct > > netxbig_led_platform_data *pdata) > > drivers/leds/leds-netxbig.c: struct netxbig_led_platform_data > > *pdata = dev_get_platdata(&pdev->dev); > > include/linux/platform_data/leds-kirkwood-netxbig.h:struct > > netxbig_led_platform_data { > > > > > > > > So, what shall we do? > > > > Drop the board-file support? Or, keep it > > in case somebody is still using their board-files > > in downstream? > > Generally speaking, I'd remove the board file support in another > case like this, but it's worth looking at when it was last used and by > what. > > For this file, all boards got converted to DT, and the old setup > code removed in commit ebc278f15759 ("ARM: mvebu: remove static > LED setup for netxbig boards"), four years ago, so it's a fairly > easy decision to make it DT only. Thanks. I see another case, which is difficult to make a decision. For example, drivers/spi/spi-tle62x0.c This driver supports only board-file, but the board-file is not found in upstream. Unless I am terribly missing something, there is no one who passes tle62x0_pdata to this driver. $ git grep tle62x0_pdata drivers/spi/spi-tle62x0.c: struct tle62x0_pdata *pdata; include/linux/spi/tle62x0.h:struct tle62x0_pdata { But, removing board-file support makes this driver completely useless... -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel