Re: [PATCH] kbuild: Do not use hyphen in exported variable name

[Masahiro Yamada <yamada.masahiro@socionext.com>]

Hi Ben,


2017-04-23 16:23 GMT+09:00 Ben Hutchings <ben@decadent.org.uk>:
> On Sun, 2017-04-23 at 15:47 +0900, Masahiro Yamada wrote:
> [...]
>> I tested dtbs_install once again by myself, but
>> dtbinst-root is exported to the sub make
>> and the vendor directories are created correctly.
>>
>>
>> I checked the debian's forum you gave
>> > References: https://bugs.debian.org/833561
>>
>> In there, you mentioned:
>> "This looks like a bug in make, but we can at least work around it by
>> using a non-hyphenated variable name."
>>
>>
>> Does this issue happen on a specific Make version?
>>
>> I tested GNU make 3.81, 3.82, 4.0, 4.1, 4.2,
>> but I was not hit by the problem.
>
> I don't think this is make version dependent.  I can't reproduce the
> issue today with make 4.1.  But I would have been using the same
> version in August when I wrote that.
>
> What more can I say?  Clearly the hyphenated variable gets passed to
> the sub-make in most cases.  But it's not totally reliable because last
> year it wasn't working for us.
>
>> In the last post in the thread, you concluded:
>> "We believe that the bug you reported is fixed in the latest version of
>> linux, which is due to be installed in the Debian FTP archive."
>
> I didn't write that, it's a standard message generated for bugs marked
> as closed in a package changelog. :-)
>
>> If so, why is this patch here?
>> How is the dtbs_install procedure different in the Debian package?
>
> This is the patch I applied to the package.
>

Do you still need this patch for Debian?

If so, I can pick it up because it is apparently harmless
(maybe safer as you said).

However, I may add the following excuse in the git-log:

[masahiro
 I cound not reproduce the issue, but at least this patch is harmless.]




-- 
Best Regards
Masahiro Yamada