* Missing closing files in linux/scripts/kconfig/confdata.c
@ 2021-12-30 3:11 Ryan Cai
2021-12-31 6:43 ` Masahiro Yamada
2022-01-14 7:41 ` Masahiro Yamada
0 siblings, 2 replies; 3+ messages in thread
From: Ryan Cai @ 2021-12-30 3:11 UTC (permalink / raw)
To: masahiroy; +Cc: linux-kbuild, linux-kernel
Dear Kernel maintainers,
1. In linux/scripts/kconfig/confdata.c (conf_write_autoconf_cmd), the file opened at Line 946 may not closed when going to Line 981.
Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L964-L981
2. In linux/scripts/kconfig/confdata.c (__conf_write_autoconf), the file opened at Line1081 may not closed when going to Line 1095,
Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L1081-L1095
I think, the fix is inserting fclose before the returning. Should it be a bug? I can send a patch for these.
Best,
Ryan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Missing closing files in linux/scripts/kconfig/confdata.c
2021-12-30 3:11 Missing closing files in linux/scripts/kconfig/confdata.c Ryan Cai
@ 2021-12-31 6:43 ` Masahiro Yamada
2022-01-14 7:41 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2021-12-31 6:43 UTC (permalink / raw)
To: Ryan Cai; +Cc: Linux Kbuild mailing list, Linux Kernel Mailing List
On Thu, Dec 30, 2021 at 12:11 PM Ryan Cai <ycaibb@gmail.com> wrote:
>
> Dear Kernel maintainers,
>
> 1. In linux/scripts/kconfig/confdata.c (conf_write_autoconf_cmd), the file opened at Line 946 may not closed when going to Line 981.
> Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L964-L981
>
> 2. In linux/scripts/kconfig/confdata.c (__conf_write_autoconf), the file opened at Line1081 may not closed when going to Line 1095,
> Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L1081-L1095
>
> I think, the fix is inserting fclose before the returning. Should it be a bug? I can send a patch for these.
>
Yes, they are both bugs.
Thanks for catching them.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Missing closing files in linux/scripts/kconfig/confdata.c
2021-12-30 3:11 Missing closing files in linux/scripts/kconfig/confdata.c Ryan Cai
2021-12-31 6:43 ` Masahiro Yamada
@ 2022-01-14 7:41 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2022-01-14 7:41 UTC (permalink / raw)
To: Ryan Cai; +Cc: Linux Kbuild mailing list, Linux Kernel Mailing List
On Thu, Dec 30, 2021 at 12:11 PM Ryan Cai <ycaibb@gmail.com> wrote:
>
> Dear Kernel maintainers,
>
> 1. In linux/scripts/kconfig/confdata.c (conf_write_autoconf_cmd), the file opened at Line 946 may not closed when going to Line 981.
> Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L964-L981
>
> 2. In linux/scripts/kconfig/confdata.c (__conf_write_autoconf), the file opened at Line1081 may not closed when going to Line 1095,
> Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L1081-L1095
>
> I think, the fix is inserting fclose before the returning. Should it be a bug? I can send a patch for these.
>
>
> Best,
> Ryan
>
>
Can you send a patch,
or do you want me to do it?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-14 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30 3:11 Missing closing files in linux/scripts/kconfig/confdata.c Ryan Cai
2021-12-31 6:43 ` Masahiro Yamada
2022-01-14 7:41 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.