All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Zhang Yanmin <yanmin.zhang@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] linux/kernel.h: use 'short' to define USHRT_MAX, SHRT_MAX, SHRT_MIN
Date: Sun, 3 Feb 2019 10:09:14 +0900	[thread overview]
Message-ID: <CAK7LNATbDOAei0spqUVa2u3buKwS4uEPD5fXMLpEqcB-UapLTw@mail.gmail.com> (raw)
In-Reply-To: <20190202163105.GA28518@avx2>

On Sun, Feb 3, 2019 at 1:33 AM Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> On Sun, Feb 03, 2019 at 01:06:24AM +0900, Masahiro Yamada wrote:
> > The log of commit 44f564a4bf6a ("ipc: add definitions of USHORT_MAX
> > and others") did not explain why it used (s16) and (u16) instead of
> > (short) and (unsigned short).
> >
> > Let's use (short) and (unsigned short), which is more sensible, and
> > more consistent with the other MAX/MIN defines.
> >
> > As you see in include/uapi/asm-generic/int-ll64.h, s16/u16 are
> > typedef'ed as signed/unsigned short. So, this commit does not have
> > a functional change.
>
> > -#define USHRT_MAX    ((u16)(~0U))
> > -#define SHRT_MAX     ((s16)(USHRT_MAX>>1))
> > -#define SHRT_MIN     ((s16)(-SHRT_MAX - 1))
> > +#define USHRT_MAX    ((unsigned short)(~0U))
>                                          ^   ^
>                                          +---+
>                                            unnecessary ()


Thanks, I will remove it in v2.




> > +#define SHRT_MAX     ((short)(USHRT_MAX>>1))
> > +#define SHRT_MIN     ((short)(-SHRT_MAX - 1))
>
> "short" and "unsigned short" are probably the most useless C types.
> I doubt their usage should be promoted.



-- 
Best Regards
Masahiro Yamada

      parent reply	other threads:[~2019-02-03  1:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02 16:06 [PATCH 1/2] linux/kernel.h: use 'short' to define USHRT_MAX, SHRT_MAX, SHRT_MIN Masahiro Yamada
2019-02-02 16:06 ` [PATCH 2/2] linux/kernel.h: split *_MAX and *_MIN macros into <linux/limits.h> Masahiro Yamada
2019-02-02 16:31 ` [PATCH 1/2] linux/kernel.h: use 'short' to define USHRT_MAX, SHRT_MAX, SHRT_MIN Alexey Dobriyan
2019-02-02 16:36   ` Alexey Dobriyan
2019-02-03  1:09   ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNATbDOAei0spqUVa2u3buKwS4uEPD5fXMLpEqcB-UapLTw@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yanmin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.