From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00454C04A6B for ; Sat, 11 May 2019 00:53:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C72AC21841 for ; Sat, 11 May 2019 00:53:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="umIRC7/3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728387AbfEKAxM (ORCPT ); Fri, 10 May 2019 20:53:12 -0400 Received: from conssluserg-06.nifty.com ([210.131.2.91]:31960 "EHLO conssluserg-06.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727961AbfEKAxL (ORCPT ); Fri, 10 May 2019 20:53:11 -0400 Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) (authenticated) by conssluserg-06.nifty.com with ESMTP id x4B0qe6p032760; Sat, 11 May 2019 09:52:41 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com x4B0qe6p032760 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557535961; bh=iUxXS+30vplKGahUoVQhsc/083rdodKyu7vjq55D8xg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=umIRC7/3lNRLSfK+GHljh9R3w0EjQ+AonhIXa9BSr4osEJ1qBhMgzY50aI+8ebY8u L9oNE/JlHyZaHMcd4m+0yEm/5oI6h4wmSJrCCbPCcO6F9NuHKAdyqzbvVIY2k5Zfna ca9coS/3yMGwaZA736aNpG0ktBbgblls2W8ptdUMGkfOK9RM3DESUXB6IPNXsx8FcL 6cLIBKpJx7B2GacYkS186Z1oQ7b2X3Kyns+i1GE9ZBw8huUIgJvfsFJxpyQD6mWtwX 8rv9pykSnmYRazTLtdNBM/Z8HlK0+Kr7FWfwHPrYo4ncv0T60fUsm0CodN3bh5sY9g MN3rUi7l+Az+g== X-Nifty-SrcIP: [209.85.217.50] Received: by mail-vs1-f50.google.com with SMTP id j184so4668136vsd.11; Fri, 10 May 2019 17:52:41 -0700 (PDT) X-Gm-Message-State: APjAAAULBF5NbSY/oTiCb/RjkNEBAhB22SJO/v3+qos7RudpzuklxxXC Lhu7f7D8vgA6EXESGRF3FFMdGYNbrcSYB9DiltI= X-Google-Smtp-Source: APXvYqyUc+v7TtnlTZkAvl+FZ1vVEt3lE7J6HYJX7L39IUWk68P03S3ownrv/zhg9Wxx1qmb65a+wPCgt1rx7T1DAls= X-Received: by 2002:a67:fd89:: with SMTP id k9mr7848953vsq.54.1557535960078; Fri, 10 May 2019 17:52:40 -0700 (PDT) MIME-Version: 1.0 References: <20190510210243.152808-1-joel@joelfernandes.org> <20190510210243.152808-4-joel@joelfernandes.org> In-Reply-To: <20190510210243.152808-4-joel@joelfernandes.org> From: Masahiro Yamada Date: Sat, 11 May 2019 09:52:04 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] kheaders: Make it depend on sysfs To: "Joel Fernandes (Google)" Cc: Linux Kernel Mailing List , Adrian Ratiu , Alexei Starovoitov , Andrew Morton , atish patra , bpf@vger.kernel.org, Brendan Gregg , Brendan Gregg , Daniel Colascione , Daniel Borkmann , Dan Williams , Dietmar Eggemann , duyuchao , Greg Kroah-Hartman , Guenter Roeck , Jonathan Corbet , Karim Yaghmour , Kees Cook , "Cc: Android Kernel" , "open list:DOCUMENTATION" , "open list:KERNEL SELFTEST FRAMEWORK" , linux-trace-devel@vger.kernel.org, Manjo Raja Rao , Masami Hiramatsu , =?UTF-8?Q?Micha=C5=82_Gregorczyk?= , Michal Gregorczyk , Mohammad Husain , Olof Johansson , Qais Yousef , Randy Dunlap , Steven Rostedt , Shuah Khan , Srinivas Ramana , Tamir Carmeli , Yonghong Song Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google) wrote: > > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it > depend on SYSFS as it makes no sense to enable this feature without it. And, it also makes no sense to break the feature by 1/3, then fix it by 3/3. Why don't you squash this? > > Suggested-by: Masahiro Yamada > Signed-off-by: Joel Fernandes (Google) > --- > init/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/init/Kconfig b/init/Kconfig > index ce08adf0f637..f27138a8cf28 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -581,6 +581,7 @@ config IKCONFIG_PROC > > config IKHEADERS > tristate "Enable kernel headers through /sys/kernel/kheaders.tar.xz" > + depends on SYSFS > help > This option enables access to the in-kernel headers that are generated during > the build process. These can be used to build eBPF tracing programs, > -- > 2.21.0.1020.gf2820cf01a-goog > -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro at socionext.com (Masahiro Yamada) Date: Sat, 11 May 2019 09:52:04 +0900 Subject: [PATCH 3/3] kheaders: Make it depend on sysfs In-Reply-To: <20190510210243.152808-4-joel@joelfernandes.org> References: <20190510210243.152808-1-joel@joelfernandes.org> <20190510210243.152808-4-joel@joelfernandes.org> Message-ID: On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google) wrote: > > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it > depend on SYSFS as it makes no sense to enable this feature without it. And, it also makes no sense to break the feature by 1/3, then fix it by 3/3. Why don't you squash this? > > Suggested-by: Masahiro Yamada > Signed-off-by: Joel Fernandes (Google) > --- > init/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/init/Kconfig b/init/Kconfig > index ce08adf0f637..f27138a8cf28 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -581,6 +581,7 @@ config IKCONFIG_PROC > > config IKHEADERS > tristate "Enable kernel headers through /sys/kernel/kheaders.tar.xz" > + depends on SYSFS > help > This option enables access to the in-kernel headers that are generated during > the build process. These can be used to build eBPF tracing programs, > -- > 2.21.0.1020.gf2820cf01a-goog > -- Best Regards Masahiro Yamada From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamada.masahiro@socionext.com (Masahiro Yamada) Date: Sat, 11 May 2019 09:52:04 +0900 Subject: [PATCH 3/3] kheaders: Make it depend on sysfs In-Reply-To: <20190510210243.152808-4-joel@joelfernandes.org> References: <20190510210243.152808-1-joel@joelfernandes.org> <20190510210243.152808-4-joel@joelfernandes.org> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190511005204.BeWgD1feSiOtPIN3GGUNS0kqGL0amFrC4iKEKSUtyRE@z> On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google) wrote: > > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it > depend on SYSFS as it makes no sense to enable this feature without it. And, it also makes no sense to break the feature by 1/3, then fix it by 3/3. Why don't you squash this? > > Suggested-by: Masahiro Yamada > Signed-off-by: Joel Fernandes (Google) > --- > init/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/init/Kconfig b/init/Kconfig > index ce08adf0f637..f27138a8cf28 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -581,6 +581,7 @@ config IKCONFIG_PROC > > config IKHEADERS > tristate "Enable kernel headers through /sys/kernel/kheaders.tar.xz" > + depends on SYSFS > help > This option enables access to the in-kernel headers that are generated during > the build process. These can be used to build eBPF tracing programs, > -- > 2.21.0.1020.gf2820cf01a-goog > -- Best Regards Masahiro Yamada