All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	David Gibson <david@gibson.dropbear.id.au>,
	Frank Rowand <frowand.list@gmail.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Anmar Oueja <anmar.oueja@linaro.org>,
	Bill Mills <bill.mills@linaro.org>, Rob Herring <robh@kernel.org>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V10 2/5] kbuild: Add generic rule to apply fdtoverlay
Date: Wed, 10 Mar 2021 01:27:58 +0900	[thread overview]
Message-ID: <CAK7LNATebzcDXvdq0K5Y2f7tHw7i0429fDTSga8Qqkd5emjP_g@mail.gmail.com> (raw)
In-Reply-To: <c6dea8f363725c069e26031ec7c7c5f27850103b.1615199908.git.viresh.kumar@linaro.org>

On Mon, Mar 8, 2021 at 7:45 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> From: Rob Herring <robh@kernel.org>
>
> Add a generic rule to apply fdtoverlay in Makefile.lib, so every
> platform doesn't need to carry the complex rule. This also automatically
> adds "DTC_FLAGS_foo_base += -@" for all base files.
>
> The platform's Makefile only needs to have this now:
>
>  foo-dtbs := foo_base.dtb foo_overlay1.dtbo foo_overlay2.dtbo
>  dtb-y := foo.dtb
>
> We don't want to run schema checks on foo.dtb (as foo.dts doesn't exist)
> and the Makefile is updated accordingly.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Co-developed-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Acked-by: Masahiro Yamada <masahiroy@kernel.org>



> ---
>  scripts/Makefile.lib | 26 ++++++++++++++++++++++++--
>  1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index a2658242d956..bc045a54a34e 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -75,11 +75,24 @@ always-y += $(userprogs-always-y) $(userprogs-always-m)
>  # If CONFIG_OF_ALL_DTBS is enabled, all DT blobs are built
>  dtb-$(CONFIG_OF_ALL_DTBS)       += $(dtb-)
>
> +# List all dtbs to be generated by fdtoverlay
> +overlay-y := $(foreach m,$(dtb-y), $(if $(strip $($(m:.dtb=-dtbs))),$(m),))
> +
> +# Generate symbols for the base files so overlays can be applied to them.
> +$(foreach m,$(overlay-y), $(eval DTC_FLAGS_$(basename $(firstword $($(m:.dtb=-dtbs)))) += -@))
> +
> +# Add base dtb and overlay dtbo
> +dtb-y += $(foreach m,$(overlay-y), $($(m:.dtb=-dtbs)))
> +
>  always-y                       += $(dtb-y)
>
>  ifneq ($(CHECK_DTBS),)
> -always-y += $(patsubst %.dtb,%.dt.yaml, $(dtb-y))
> -always-y += $(patsubst %.dtbo,%.dt.yaml, $(dtb-y))
> +# Don't run schema checks for dtbs created by fdtoverlay as they don't
> +# have corresponding dts files.
> +dt-yaml-y := $(filter-out $(overlay-y),$(dtb-y))
> +
> +always-y += $(patsubst %.dtb,%.dt.yaml, $(dt-yaml-y))
> +always-y += $(patsubst %.dtbo,%.dt.yaml, $(dt-yaml-y))
>  endif
>
>  # Add subdir path
> @@ -337,6 +350,15 @@ $(obj)/%.dtb: $(src)/%.dts $(DTC) FORCE
>  $(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
>         $(call if_changed_dep,dtc)
>
> +overlay-y := $(addprefix $(obj)/, $(overlay-y))
> +
> +quiet_cmd_fdtoverlay = DTOVL   $@
> +      cmd_fdtoverlay = $(objtree)/scripts/dtc/fdtoverlay -o $@ -i $(real-prereqs)
> +
> +$(overlay-y): FORCE
> +       $(call if_changed,fdtoverlay)
> +$(call multi_depend, $(overlay-y), .dtb, -dtbs)
> +
>  DT_CHECKER ?= dt-validate
>  DT_BINDING_DIR := Documentation/devicetree/bindings
>  # DT_TMP_SCHEMA may be overridden from Documentation/devicetree/bindings/Makefile
> --
> 2.25.0.rc1.19.g042ed3e048af
>


-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2021-03-09 16:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 10:45 [PATCH V10 0/5] dt: Add fdtoverlay rule and statically build unittest Viresh Kumar
2021-03-08 10:45 ` [PATCH V10 1/5] kbuild: Simplify builds with CONFIG_OF_ALL_DTBS Viresh Kumar
2021-03-08 10:45 ` [PATCH V10 2/5] kbuild: Add generic rule to apply fdtoverlay Viresh Kumar
2021-03-09 16:27   ` Masahiro Yamada [this message]
2021-03-08 10:45 ` [PATCH V10 3/5] kbuild: Allow .dtso format for overlay source files Viresh Kumar
2021-03-08 10:45 ` [PATCH V10 4/5] of: unittest: Create overlay_common.dtsi and testcases_common.dtsi Viresh Kumar
2021-03-10  2:22   ` Rob Herring
2021-03-08 10:45 ` [PATCH V10 5/5] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNATebzcDXvdq0K5Y2f7tHw7i0429fDTSga8Qqkd5emjP_g@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=anmar.oueja@linaro.org \
    --cc=bill.mills@linaro.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=frowand.list@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=michal.simek@xilinx.com \
    --cc=robh@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.