From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] common: add a prototype for mach_cpu_init()
Date: Thu, 8 Mar 2018 09:57:58 +0900 [thread overview]
Message-ID: <CAK7LNATmp4d-xy6ACsjnDKUtYE7PO5vyx8BMXnAQkRtQ-gU=eA@mail.gmail.com> (raw)
In-Reply-To: <20180307144548.GU22474@bill-the-cat.ec.rr.com>
2018-03-07 23:45 GMT+09:00 Tom Rini <trini@konsulko.com>:
> On Wed, Mar 07, 2018 at 03:28:20PM +0100, Patrick Delaunay wrote:
>
>> avoid warning: no previous prototype for ‘mach_cpu_init’
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> --
People tend to put all sort of misc thingy into common.h
but this is one of the ugliest parts in U-Boot.
Most of files parse <common.h> that contains
unrelated / unnecessary defines.
Please realize this madness.
I have tried to slim it down several times,
but people have added more and more. So this task never ends.
How about splitting out platform init hooks?
(<init.h> or anything suitable is OK.)
Also, I'd like to ban new additions to <common.h>
like we do for config_whitelist.txt
(for example, record the number of lines of <common.h>
then build fails if somebody increases it.)
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-03-08 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 14:28 [U-Boot] [PATCH v2] common: add a prototype for mach_cpu_init() Patrick Delaunay
2018-03-07 14:45 ` Tom Rini
2018-03-08 0:57 ` Masahiro Yamada [this message]
2018-03-09 14:29 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATmp4d-xy6ACsjnDKUtYE7PO5vyx8BMXnAQkRtQ-gU=eA@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.