On Tue, 21 Mar 2023 at 20:38, Supreet= h Venkatesh <supreeth.venk= atesh@amd.com> wrote:

On 3/21/23 05:40, Patrick Williams wrote:
> On Tue, Mar 21, 2023 at 12:14:45AM -0500, Supreeth Venkatesh wrote: >
>> #### Alternatives Considered
>>
>> In-band mechanisms using System Management Mode (SMM) exists.
>>
>> However, out of band method to gather RAS data is processor specif= ic.
>>
> How does this compare with existing implementations in
> phosphor-debug-collector.
Thanks for your feedback. See below.
> I believe there was some attempt to extend
> P-D-C previously to handle Intel's crashdump behavior.
Intel's crashdump interface uses com.intel.crashdump.
We have implemented com.amd.crashdump based on that reference. However, can this be made generic?

PoC below:

busctl tree com.amd.crashdump

=E2=94=94=E2=94=80/com
=C2=A0=C2=A0 =E2=94=94=E2=94=80/com/amd
=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=94=E2=94=80/com/amd/crashdump
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/1=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/2=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/3=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/4=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/5=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/6=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/7=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=9C=E2=94=80/com/amd/crashdump/8=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=94=94=E2=94=80/com/amd/crashdump/9=

> The repository
> currently handles IBM's processors, I think, or maybe that is cove= red by
> openpower-debug-collector.
>
> In any case, I think you should look at the existing D-Bus interfaces<= br> > (and associated Redfish implementation) of these repositories and
> determine if you can use those approaches (or document why now).
I could not find an existing D-Bus interface for RAS in
xyz/openbmc_project/.
It would be helpful if you could point me to it.

<= /div>

There is an interface for the dumps generated from the host, whic= h can be used for these kinds of dumps

https://github.com/openbmc/phosphor-dbus-i= nterfaces/blob/master/yaml/xyz/openbmc_project/Dump/Entry/System.interface.= yaml

The fault log also provides similar d= umps

https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/o= penbmc_project/Dump/Entry/FaultLog.interface.yaml

The tree for the dump manager looks like this

`= -/xyz
=C2=A0 `-/xyz/openbmc_project
=C2=A0 =C2=A0 `-/xyz/openbmc_proj= ect/dump
=C2=A0 =C2=A0 =C2=A0 |-/xyz/openbmc_project/dump/bmc
=C2=A0 = =C2=A0 =C2=A0 | `-/xyz/openbmc_project/dump/bmc/entry
=C2=A0 =C2=A0 =C2= =A0 | =C2=A0 |-/xyz/openbmc_project/dump/bmc/entry/1
=C2=A0 =C2=A0 =C2= =A0 | =C2=A0 |-/xyz/openbmc_project/dump/bmc/entry/2
=C2=A0 =C2=A0 =C2= =A0 | =C2=A0 |-/xyz/openbmc_project/dump/bmc/entry/3
=C2=A0 =C2=A0 =C2= =A0 | =C2=A0 `-/xyz/openbmc_project/dump/bmc/entry/4
=C2=A0 =C2=A0 =C2= =A0 |-/xyz/openbmc_project/dump/faultlog
=C2=A0 =C2=A0 =C2=A0 |-/xyz/ope= nbmc_project/dump/hardware
=C2=A0 =C2=A0 =C2=A0 |-/xyz/openbmc_project/d= ump/hostboot
=C2=A0 =C2=A0 =C2=A0 |-/xyz/openbmc_project/dump/internal=C2=A0 =C2=A0 =C2=A0 | `-/xyz/openbmc_project/dump/internal/manager
= =C2=A0 =C2=A0 =C2=A0 |-/xyz/openbmc_project/dump/resource
=C2=A0 =C2=A0 = =C2=A0 |-/xyz/openbmc_project/dump/sbe

=C2=A0 =C2=A0 =C2=A0 `-/xyz/= openbmc_project/dump/system=C2=A0

There are references to com.intel.crashdump in bmcweb code, but the
interface itself does not exist in yaml/com/intel/
we can add com.amd.crashdump as a start or even come up with a new
generic Dbus interface.
As far as Redfish implementation is concerned, we are following the
specification.
redfish/v1/Systems/system/LogServices/Crashdump schema is being used.

{

"@oda= ta.id": "/redfish/v1/Systems/system/LogServices/Crashdump/Ent= ries",
"@odata.type": "#LogEntryCollection.LogEntryCollection"= ,
"Description": "Collection of Crashdump Entries",
"Members":
=C2=A0=C2=A0[
{"@od= ata.id": "/redfish/v1/Systems/system/LogServices/Crashdump/En= tries/0",
"@odata.type": "#LogEntry.v1_7_0.LogEntry",
"AdditionalDataURI":
"/redfish/v1/Systems/system/LogServices/Crashdump/Entries/0/ras-error0= .cper",
"Created": "1970-1-1T0:4:12Z",
"DiagnosticDataType": "OEM",
"EntryType": "Oem",
"Id": "0",
"Name": "CPU Crashdump",
"OEMDiagnosticDataType": "APMLCrashdump"
},
{"@od= ata.id": "/redfish/v1/Systems/system/LogServices/Crashdump/En= tries/1",
"@odata.type": "#LogEntry.v1_7_0.LogEntry",
"AdditionalDataURI":
"/redfish/v1/Systems/system/LogServices/Crashdump/Entries/1/ras-error1= .cper",
"Created": "1970-1-1T0:4:12Z",
"DiagnosticDataType": "OEM",
"EntryType": "Oem",
"Id": "1",
"Name": "CPU Crashdump",
"OEMDiagnosticDataType": "APMLCrashdump"
},
],
"Members@odata.count": 2,
"Name": "Open BMC Crashdump Entries"}
>

--= ------------
Dhruvaraj S

--0000000000004076e205f76b82c8--