From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43ED1C433F5 for ; Thu, 26 May 2022 14:16:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239152AbiEZOQF (ORCPT ); Thu, 26 May 2022 10:16:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231984AbiEZOQE (ORCPT ); Thu, 26 May 2022 10:16:04 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCF2CC1ED0; Thu, 26 May 2022 07:16:02 -0700 (PDT) Received: from mail-yw1-f174.google.com ([209.85.128.174]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M3lsh-1ntOvz1Vy7-000rKD; Thu, 26 May 2022 16:16:00 +0200 Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-2ff155c239bso17177847b3.2; Thu, 26 May 2022 07:16:00 -0700 (PDT) X-Gm-Message-State: AOAM5307xjAyu0OQOFml0YHA23S0Z3xP+ubiEKHOC+fpK+qJuhgqXwWW vP3Fuhyhym8GcnujVlcVYFQJF7CBykZ7Rzvc1Eg= X-Google-Smtp-Source: ABdhPJyAAOpo6yFajFCvrIHqTtBMm4tvkS2NHFN9Xg0y0jG/KcngNugF09iZUwy8bO8ACtegwHiStisrRhGqLmovbuA= X-Received: by 2002:a0d:fc83:0:b0:2e5:b0f4:c125 with SMTP id m125-20020a0dfc83000000b002e5b0f4c125mr39416409ywf.347.1653574558921; Thu, 26 May 2022 07:15:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Thu, 26 May 2022 16:15:42 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Yegor Yefremov Cc: Ard Biesheuvel , Tony Lindgren , Arnd Bergmann , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:iHbnG/WKqos6Alp3Wc++Khp0vPz+Z9M0VSipOYQJ4kVejc2yGTt /9U9HOgTPv/Dfy2PNr1oP9N6aXlgngk90H9AH0dUlDyj+4tFHPHgeucHjj1cYVHL3FSHWG3 c2Ru9XHf2TI6tw2SPTZMf8tI3F2BdSzbey3XMqkF7/zZ55HqF93LMaI+rvVIHhp3MWZq6ql drqbYJ8nJFTOT0VGpLbhw== X-UI-Out-Filterresults: notjunk:1;V03:K0:GadTwN7iHo8=:g5QiAaD6x0spOsOgerUMOQ dkS+hCLXqc8isLsQdxTpW5fVxx6YTJSHYRXyk8pQetcwSeKMvtvPJZt00Mk33CF8cLIStzoQX WcWsCFq7eIBm7eY/QA19ft7lrRvlsT1OTXzZlFOdzEChmdlamcpNBD6g+6R4R3iwlN3LRJj5m G7WyTbzvTbszT2czBNSa2bVBoOpQXKASjlDACavkpmlC31VUbM63FEzkbyTM9Ayn2J7sR+x48 Fh6mkwa1Re53UlLhqDZKh6UCSuQRimO4MvugN/fR+b5HVe7E3yi8Pdi6lueUDTKwPCgVXDrYy UGiFrofMjOORwx1diyNs+6nREHUSbCmnk6SIVgyFh409oecGZ4S31vyPFbJbPykvfXEDOK9m/ LyW/loRgYfAkmX82or8kB86FgGePMICcf+jaWqxSIK0K7wc67p+09xKY85Zu2XVjuxgK+AusV RfC0p0D1CgQbFeiQg3ZNiNHOZl4pYf3f7ywP2EhDrN0TBmFVp7rYSqs/CXEEPjG5tO+oPtYHS 5qDLe7MICRKQGhavem0V6u1Djo6zm3CtPU39SDHB53uxy6Ka7Mol77yDErpyNw49yls6chljD 4tYTE80tOmSjvefxrJzelrEAhPXJHk2tHFvF2Ri6oPC+cAkhDKBmi4fxStq0Fbbkl28ocgjK4 y9CIlSKfmiDfVvL1ph78Xw0GPFsvz95T2bmSdYRsFGPC/PbsmPnskV7qmS7ANGOISgKBxeFt+ DjwNGjXK3hBwNLgCfQKMuoJ8v7LKJg6eULtKO+kcKwdaIhFL0sY8xRgmZu4zB9OoVNvohBVNL 81WX7ESVjNDxf7ZpLWXX6kqTDXrAYqQh671noAbZfaC+kNN2vLSTgu5odZfRlLMMkRYM6S3EE 74jYHZZis+PCh98M6tMg== Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, May 26, 2022 at 2:37 PM Yegor Yefremov wrote: > On Thu, May 26, 2022 at 10:19 AM Ard Biesheuvel wrote: > > > > On Thu, 26 May 2022 at 08:20, Tony Lindgren wrote: > > > > > > * Yegor Yefremov [220526 05:45]: > > > > On Tue, May 24, 2022 at 4:19 PM Tony Lindgren wrote: > > > > > Maybe also try with CONFIG_MUSB_PIO_ONLY=y to see if it makes things > > > > > better or worse :) > > > > > > > > PIO is always the last resort :-) And now it proves it again. With > > > > PIO_ONLY the system doesn't stall. > > > > > > OK great :) So it has something to do with drivers/dma/ti/cppi41.c, or > > > with drivers/usb/musb/cppi_dma.c or whatever the dma for am335x here > > > is. Or maybe there's something using stack for buffers being passed to > > > dma again that breaks with vmap stack. > > > > > > > In order to confirm this theory, could you please try rebuilding your > > kernel with CONFIG_VMAP_STACK disabled, and leave everything else as > > before? > > I have disabled the CONFIG_VMAP_STACK option: > > # zcat /proc/config.gz | grep VMAP_STACK > CONFIG_HAVE_ARCH_VMAP_STACK=y > # CONFIG_VMAP_STACK is not set > > The system stalls. Ok, I guess that means we can stop looking for invalid DMA buffers on stacks. Out of the original commits you listed as possible causes, we can also rule out 23d9a9280efe ("ARM: 9177/1: disable vmap'ed stacks on suspend-capable SMP configs") and cafc0eab1689 ("ARM: v7m: enable support for IRQ stacks"). It could still be 9c46929e7989 ("ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems") and 5fe41793bc78 ("ARM: 9176/1: avoid literal references in inline assembly") or possibly the merge. Can you post the whole .config file somewhere for reference? In particular, do you have CONFIG_SMP, CONFIG_LD_IS_LLD or CURRENT_POINTER_IN_TPIDRURO set? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E3F5C433EF for ; Thu, 26 May 2022 14:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cfa6X4U73zCIrJlpIXu8J0PqCTdIzBTQZjawNNevAcs=; b=LpqctJ5arsfo8Y eBvuB4/UuZL3baurEkkzf5zLVKZHmDfQ805s/g/GrHAVJB26fTNuGxMeTRe4KGEkz3sVyNr1nqb8g eKf4GwlQfz/ECK6sX00bbQzxMBo8HovCeBnGd0HE+0nLWs14Ks58ufWYh00XatEV+OsZFiKypGaTj llEFMmhbCeM+PqF9wkIze059BEr7+Wj+arGjk2uOz8CVipTCsR/lV8V4/nS9FaUidwjy9TNgAywvD BXKPRPNtg8k5mTcvHavXTMYGcw4UWRkhYMUCfBkpMUbibkg+4LaiW1MAbyP5lNjs9iZvD8225yGo8 dgkplXU2SX2+Wd89K0Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuEHW-00F6UF-Fq; Thu, 26 May 2022 14:16:06 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuEHT-00F6TV-8j for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 14:16:04 +0000 Received: from mail-yw1-f170.google.com ([209.85.128.170]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MRC3Y-1oFDc42gNg-00NDwb for ; Thu, 26 May 2022 16:16:00 +0200 Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-2f83983782fso16720577b3.6 for ; Thu, 26 May 2022 07:16:00 -0700 (PDT) X-Gm-Message-State: AOAM530TVC7gO72pT7CLj3lMLw9M5j4rkGIty3/Lg32gf/H8eKEib6J+ sWZidj0ztydmQfzDIlv/CPR6qJkmPVykp1J2nas= X-Google-Smtp-Source: ABdhPJyAAOpo6yFajFCvrIHqTtBMm4tvkS2NHFN9Xg0y0jG/KcngNugF09iZUwy8bO8ACtegwHiStisrRhGqLmovbuA= X-Received: by 2002:a0d:fc83:0:b0:2e5:b0f4:c125 with SMTP id m125-20020a0dfc83000000b002e5b0f4c125mr39416409ywf.347.1653574558921; Thu, 26 May 2022 07:15:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Thu, 26 May 2022 16:15:42 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Yegor Yefremov Cc: Ard Biesheuvel , Tony Lindgren , Arnd Bergmann , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM X-Provags-ID: V03:K1:Jn0fw+LW9aUg++4OSal1LYJp96quvNZ4QryEzkNRkh0i4zbSP5d Uhh7kt8yXUIaQo/owF75nlEF0QARO9UYKKnaFiGy5PM7hGmiZkbOfOe8UY31r24Nh0y3j2P Okjs+5V9jahqbp0mzBa66nW6bluvbq4fvqJjTeJrkfA3BOHLEdND7QTshS7cH/1jmSRLbGM 9xi9LYkDcOio7JavRHd8w== X-UI-Out-Filterresults: notjunk:1;V03:K0:2hD3LQOVLi8=:nZAoWTDFcR3UM8psbgshwU lCmD61u/2+6XXIbebPS8vxMD8gNEaZUhi+EI+FGqIHDH1Cr1qrvuQ/nZ5CMP6Iho/PxY6wrbz L3qA+lRTZFeMnZCukMIjU0h6CXnQgdhO/3So6ZIY1rBl24ZrWsMDhFxyatFEoFcU+yieAcrzN UGe5wY5S6Y4ULV6d4V1o5ig8hUfj/7HCSWiAfZPc0N06mi4CkdSsKHbFabR7STxHNwKYd9qj4 SsE6ZlEwPfCSjLk9UZEVXKMfeUhSju2tH+eu0p9037KSXCqueW2xa/QmtMlGyVVhc9LfQS40D w0qWgkQSVtHnwV3OWaGjUMcg1mQGzulw0WDaVrN/q4Hbf2vypHqbVUQfXC/1cvIkSeDfl9UK5 v7nxIhEIdeVSMj3wjdRcUC3Fp5fo6IAD5tzTUIqr2gdPgWz2Z23ogJs6xAVV5v7OR2hsiKO+V a+rItRCgseujwH84dgyLncXGu+x+HctQQOPdyJ6VxHNdtYHPg7cLjv5EERXbyXYzFbUpDSQau aP0uYXQeNj7JAedWRfc9LAJy0BkYp7NPyUXtE0RKQWdbHjgGS1IFMHY6YHFV5of2PAP3ESi8c YiQDxKV1sRf7m0JEY3bfQrkHlOiVKTimyNqKZTGjzn0rHsm1qY/dZNdeZ2MtVQFxN+3aOs1em 3AdJQ1gQuMP1zwMuTZKRcgJx9nceT8ax8R1XH90T0/VvW1xfThzULxmKGPJSMSzi2UIfy7clV LPwFdkzu1Snb8//YZbKNpJdIaEAnYmT3odN+f9XJxARHbozy5J6wkreF2WgOHX4dee/7SL+JM dOZyLcqbLOnzxdpv+x3L1E8NnngFq6hnqYqzPIPTJ0uZLxTt+BZD8YWprF1wPy03iJ1OD4VV/ rsmA0LpGBAqFKYSrqu5A== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_071603_649533_E5F11467 X-CRM114-Status: GOOD ( 22.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 26, 2022 at 2:37 PM Yegor Yefremov wrote: > On Thu, May 26, 2022 at 10:19 AM Ard Biesheuvel wrote: > > > > On Thu, 26 May 2022 at 08:20, Tony Lindgren wrote: > > > > > > * Yegor Yefremov [220526 05:45]: > > > > On Tue, May 24, 2022 at 4:19 PM Tony Lindgren wrote: > > > > > Maybe also try with CONFIG_MUSB_PIO_ONLY=y to see if it makes things > > > > > better or worse :) > > > > > > > > PIO is always the last resort :-) And now it proves it again. With > > > > PIO_ONLY the system doesn't stall. > > > > > > OK great :) So it has something to do with drivers/dma/ti/cppi41.c, or > > > with drivers/usb/musb/cppi_dma.c or whatever the dma for am335x here > > > is. Or maybe there's something using stack for buffers being passed to > > > dma again that breaks with vmap stack. > > > > > > > In order to confirm this theory, could you please try rebuilding your > > kernel with CONFIG_VMAP_STACK disabled, and leave everything else as > > before? > > I have disabled the CONFIG_VMAP_STACK option: > > # zcat /proc/config.gz | grep VMAP_STACK > CONFIG_HAVE_ARCH_VMAP_STACK=y > # CONFIG_VMAP_STACK is not set > > The system stalls. Ok, I guess that means we can stop looking for invalid DMA buffers on stacks. Out of the original commits you listed as possible causes, we can also rule out 23d9a9280efe ("ARM: 9177/1: disable vmap'ed stacks on suspend-capable SMP configs") and cafc0eab1689 ("ARM: v7m: enable support for IRQ stacks"). It could still be 9c46929e7989 ("ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems") and 5fe41793bc78 ("ARM: 9176/1: avoid literal references in inline assembly") or possibly the merge. Can you post the whole .config file somewhere for reference? In particular, do you have CONFIG_SMP, CONFIG_LD_IS_LLD or CURRENT_POINTER_IN_TPIDRURO set? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel