From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0EBC433EF for ; Tue, 21 Sep 2021 10:42:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15DBA61050 for ; Tue, 21 Sep 2021 10:42:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15DBA61050 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ddXA9rxvMDx/4Wv+OAzROvPYEJuxIqG3UULeUbZUBE0=; b=Axwpy+9HeO2xTo K4Ol8Oup+Vz3ZQumAJqtPOyin+mU8kApN0ue3iLTezcpzgZKLM3ZLk5/IT8bK9Kp9JNsehImD7NNK 7PsIvyg4DLurPlirF+dJkfTfTj8k5kILSPVznIh7SSWpy0x6kLqM7d4fQnHv6dSHVMyeaUcNhE1Zi JQknATWLKWHqRundRGjuWXRcBNK2cWNnuPyqk83DglgR3HnpTbeEj9+s5ncI1y0IC8LtcUy8X4Jx+ Dd1yTJoIlgFtCsxK97MJVW1ADfzjjTeqf/Gv2eaOk+o8CnW7dcaWNjg8qi+HrvyiKwOQsAzczKcsZ /iALoIClM/dlsjRDF+jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSdBz-004J6X-US; Tue, 21 Sep 2021 10:40:04 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSdBw-004J4y-3U for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 10:40:01 +0000 Received: from mail-wr1-f48.google.com ([209.85.221.48]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MHX3X-1mfVLX2SFl-00DYab for ; Tue, 21 Sep 2021 12:39:54 +0200 Received: by mail-wr1-f48.google.com with SMTP id u18so35958268wrg.5 for ; Tue, 21 Sep 2021 03:39:54 -0700 (PDT) X-Gm-Message-State: AOAM530BKUq4Cx7NU+sHjo3G5pTOreLQiKRI/E+Hsc7JRQAcwP5eDnwj dVoGleAw7pc4RhbT/+TrrPU2PXY4Of3jcdqWrKc= X-Google-Smtp-Source: ABdhPJzRtsrs/ZPrQ68w2lZPsjz1Am6B95XdF9Tt5EX4aRGI+mhJNw6bwep4miWZEPjmKY1GbYNWgqrRRDg1VQXASdQ= X-Received: by 2002:a1c:4c14:: with SMTP id z20mr3774506wmf.82.1632220794205; Tue, 21 Sep 2021 03:39:54 -0700 (PDT) MIME-Version: 1.0 References: <20210921095408.133210-1-ardb@kernel.org> <20210921095408.133210-2-ardb@kernel.org> In-Reply-To: <20210921095408.133210-2-ardb@kernel.org> From: Arnd Bergmann Date: Tue, 21 Sep 2021 12:39:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/10] ARM: fix incorrect use of get_kernel_nofault() To: Ard Biesheuvel Cc: Russell King - ARM Linux , Linux ARM , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij X-Provags-ID: V03:K1:Jid0HcJ7dBUlY1yYqNssdHa3BbCyj/dI7/hjTghzW+wnO1k7O64 sbF+5mzIvyH0iINsI32ktwT68fkPb0kRwYI/4acAe9miaTQtS1NAyY7MtMY72B8/AAPEE4M qbCKCWxqFYFDPZg/2PnjXOnIlwsLuFJN++drE9UzJxXQY8Smhe+8qtPg+41+D6luX96SL+Q Ilb1mQMr9MKUjJ1Arz0+A== X-UI-Out-Filterresults: notjunk:1;V03:K0:1GYZQex9plc=:mSVW9m8xh5X+A/yY+Iipo6 gv7a9FbD36BZj82WOwpGFn6tQUj52SQLcGJqguc7b2/1O64r/0UcyXTFSoiqRvCfal9Hwxfme EhlrDBxrJneSnztqll2vp3MRhFe+u96XjJXpiMgljmHoG5DsZFGSwPpTeoPXxvIH9/NCtzVGu JtQEbQA+3weNFxwBuO9dxF4i1joUB03NPLqF+c0j5VvabHrs3YBT6cc/hPB565WHUKVqB596W 1Wg5BynJknusAGuHBU+ck7xOSt/EPwUq/OFDMZB4sp9apWToj2I6gb06JMnHtD6+TQM/PwO2J 8JuWTQ52ceGMez1FBV+cxToLfQjypusRHkPAPQcKNSvi28i0juYmCBHgM+9r4c1MmfASyBci8 mTZB7O+d1jx+x35IJ7Me3DCLJE0eUYwRK5ac7FW1d5roazHivr+eofWWHU+nCsNLrbl8Bs41L KltQfh7xrXwJFtOSjGrnrgQKZEMTTjlSy0AU2H5CP71wXJVyUSSGvFjJMqWQvy7N+mm0ANzOi bHggVZXCZFl5RwcZxVL9o2dfCNtEjzQdjUMNoF66aMKZJTpcS5MVk+ogfZM8bEZgt+RAuoIn8 967nLJj5O231pPyp06uQbSB788SRD6fd0+zUNemdxDishkknA5YJOfukBwU58EpeoWcY2YXTD Lw9b2vkpjkvtykoeO/8XNqE9GZd6cyi8BWil//c6IKYal5zZnXeL/cnxJ/R7hodlPMkFs9QKj L6mrn9EQd15TZ0qIYY1DuaNtiUOA3MFcEYMvVR7L5H/2Id7/YSlP+yypr7KML/dNKDxwsY2VV j7vIZiN2J5hDaTHAHOJ7Ub5DjoQX4pP33YZvkUW3hMIAt9LyfYy/KvOAwyf1Js9cb8XPughqr cSmaKDHvCx1RENbaiVDg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_034000_496776_281931DE X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 21, 2021 at 11:53 AM Ard Biesheuvel wrote: > > Commit 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead > of set_fs()") replaced an occurrence of __get_user() with > get_kernel_nofault(), but inverted the sense of the conditional in the > process, resulting in no values to be printed at all. > > I.e., every exception stack now looks like this: > > Exception stack(0xc18d1fb0 to 0xc18d1ff8) > 1fa0: ???????? ???????? ???????? ???????? > 1fc0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ???????? > 1fe0: ???????? ???????? ???????? ???????? ???????? ???????? > > which is rather unhelpful. > > Fixes: 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead of set_fs()") > Signed-off-by: Ard Biesheuvel Thanks for catching this! Reviewed-by: Arnd Bergmann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel