From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F09D2C28CBC for ; Wed, 6 May 2020 10:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D36072068E for ; Wed, 6 May 2020 10:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729146AbgEFK3J convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2020 06:29:09 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:60075 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728338AbgEFK3I (ORCPT ); Wed, 6 May 2020 06:29:08 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MD9Ox-1jNmq203jl-0095nl for ; Wed, 06 May 2020 12:29:07 +0200 Received: by mail-qk1-f169.google.com with SMTP id 23so1354370qkf.0 for ; Wed, 06 May 2020 03:29:06 -0700 (PDT) X-Gm-Message-State: AGi0PuZ9rqVWW2WDFNBR01tVoBGyKzybHwIZcCnfLwH67ZnSUOGZhZam TgjTtEczLpTsqEagNizFu5gV4hkb23YBInvh3gI= X-Google-Smtp-Source: APiQypLplZDjvgilEtNOvewSJ4/Rigx9zKpijezGZjbjJHJFpHNinyeAHrYJil4GkKYLbPsidhx2J3DNgSsgw1MT/WA= X-Received: by 2002:a37:aa82:: with SMTP id t124mr7608771qke.3.1588760945935; Wed, 06 May 2020 03:29:05 -0700 (PDT) MIME-Version: 1.0 References: <20200505141546.824573-1-arnd@arndb.de> <30d49e6d-570b-f6fd-3a6f-628abcc8b127@suse.com> <48893239-dde9-4e94-040d-859f4348816d@suse.com> <2c6e4b36-6618-1889-55c4-16eeb1ef6f57@suse.com> In-Reply-To: <2c6e4b36-6618-1889-55c4-16eeb1ef6f57@suse.com> From: Arnd Bergmann Date: Wed, 6 May 2020 12:28:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] xenbus: avoid stack overflow warning To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: Boris Ostrovsky , Stefano Stabellini , Yan Yankovskyi , Wei Liu , xen-devel , "linux-kernel@vger.kernel.org" , clang-built-linux Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:6DGL6ePIVowI5ADFNHUf0pHfFmh8vfXmng/tiZDheNg7HItF0uc V9nFJQKI+OY2IlkhsI7Hg+n9znchrD4Rr9BTtD/njpbhgTu27mASA5TBwweXNBc+J6cimPH uMqIENvy722zYcx95zageDUmQhf/LYhYl3J991l2fQx0+PlgzvDqOxztW6qvZQqFObhqzwU 2gImdXAy6zEhlhVvb86MQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:by0lQNdOh9A=:5m76rTrjSeCd3UnHmfkMOI bwZzCevCBF83rtZveOFMlMJoAi+PsKryA6m6jco2p0tRSrlhdeSTit+hlvQFPebx2vTOqO3eN OD6NwInbLRu3WjwloYAGZu65f0FKMwNB2KpAmniVbg+0+MVWmOmZRzHhbs7lMIXRzWUSYCtmb sJH/QMKcCWRlC4xEHcuOhNenW7qdndX2gjZrYKXma8JChmJUst5wz1J2Wa9IKf9BYXOlWvX+I jE4GXKGhbjmKPnNVgvr8x7tDK/3hzLfb5DUDAOVxC+Gp1AHbMB3Gr1cr9nlQtbsAvXDf+EXLk x9Ud7VHYeBMolir0yPH1Jss7sWU3TBWGZbpzy830p7dzCq8q4RANaRywVFsSLXkuevPsWbK+a G6pVbeyXP5qROdik6eRzoz3fnlVD9RSuLOB9teXqjxI8Vz9sFTgQlavfWd95XYyajVKPLe0kl kCukU86c9YY9jIqu0MHGBXV7HjZh0WnCjZAC5jokWs9WS/jt2QMYuVIpn+tmfiqaPntMaLPUt J1D3+6RzhwIn88A0uya04Attp6KFJBOaqJJa/U+4XGU0/LL5z9L32W0/Rdh/vA4BfH2IPUqbp TFKCJPWBxTdtC3LbmAbqdHgtmlWm4nGUNuP88q5aQvffpiU5lHvv2zJuECcgqSEoprkWdLLEl eH8VieVjDKwlTXLopLR8mjDuV9Uqavn17miO+6YsobwUWOxu5V5WcHQYEqRqyPGl0jOz5PyN2 kKK9+3fKufbLEr9WveEaTP6TkvqIMw2i7lumow18lMOxXFr5eZx3uXiKx4c9yYM7LJuAvaT0q 6v/IZbYodTHLnEBarc8KAhPr41LmueiIFppLEn9mm8Iv3qDA2s= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 6, 2020 at 7:12 AM Jürgen Groß wrote: > > On 05.05.20 22:57, Arnd Bergmann wrote: > > On Tue, May 5, 2020 at 6:02 PM Jürgen Groß wrote: > >> On 05.05.20 17:01, Arnd Bergmann wrote: > >>> On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: > >>>> On 05.05.20 16:15, Arnd Bergmann wrote: > >>> > >>> I considered that as well, and don't really mind either way. I think it does > >>> get a bit ugly whatever we do. If you prefer the union, I can respin the > >>> patch that way. > >> > >> Hmm, thinking more about it I think the real clean solution would be to > >> extend struct map_ring_valloc_hvm to cover the pv case, too, to add the > >> map and unmap arrays (possibly as a union) to it and to allocate it > >> dynamically instead of having it on the stack. > >> > >> Would you be fine doing this? > > > > This is a little more complex than I'd want to do without doing any testing > > (and no, I don't want to do the testing either) ;-) > > > > It does sound like a better approach though. > > I take this as you are fine with me writing the patch and adding you as > "Reported-by:"? Yes, definitely. Thanks! Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C09C28CBC for ; Wed, 6 May 2020 10:29:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7348B206DB for ; Wed, 6 May 2020 10:29:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7348B206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWHIc-0004Qt-Qp; Wed, 06 May 2020 10:29:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWHIb-0004Qo-LO for xen-devel@lists.xenproject.org; Wed, 06 May 2020 10:29:09 +0000 X-Inumbo-ID: 6ad4651a-8f84-11ea-9887-bc764e2007e4 Received: from mout.kundenserver.de (unknown [212.227.17.13]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6ad4651a-8f84-11ea-9887-bc764e2007e4; Wed, 06 May 2020 10:29:08 +0000 (UTC) Received: from mail-qk1-f170.google.com ([209.85.222.170]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1Mn2iP-1ip0aK0jCB-00k4J1 for ; Wed, 06 May 2020 12:29:07 +0200 Received: by mail-qk1-f170.google.com with SMTP id b6so1297684qkh.11 for ; Wed, 06 May 2020 03:29:06 -0700 (PDT) X-Gm-Message-State: AGi0PuZkYMq+fogU5Y/X54TUJuatwgT1PGwe6+/WRRIdIqE7HFRBa68H QhfU/n6gZcghIH1gXTgJ01kXRqYhQHkX3Q9UAsk= X-Google-Smtp-Source: APiQypLplZDjvgilEtNOvewSJ4/Rigx9zKpijezGZjbjJHJFpHNinyeAHrYJil4GkKYLbPsidhx2J3DNgSsgw1MT/WA= X-Received: by 2002:a37:aa82:: with SMTP id t124mr7608771qke.3.1588760945935; Wed, 06 May 2020 03:29:05 -0700 (PDT) MIME-Version: 1.0 References: <20200505141546.824573-1-arnd@arndb.de> <30d49e6d-570b-f6fd-3a6f-628abcc8b127@suse.com> <48893239-dde9-4e94-040d-859f4348816d@suse.com> <2c6e4b36-6618-1889-55c4-16eeb1ef6f57@suse.com> In-Reply-To: <2c6e4b36-6618-1889-55c4-16eeb1ef6f57@suse.com> From: Arnd Bergmann Date: Wed, 6 May 2020 12:28:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] xenbus: avoid stack overflow warning To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:no1xygskoIyr6XbP9tD+FwsVm3E8iYChYzqkU68yj5KmNi+94Kh rDcAY43aGW9TvjUt0ToyFy1pdtD+dEXA/kFLaFDyQvgXHxJW+X67v3/UWMvbrS+pTG3LXuV GhM0mvGwZGIyTKAvC4XfsK4Rt6U4Jo2DA2WgD4Kt8tu1omkpECs/zOeJfs0CeFIzRoouj1k 5IlKeoINCQZiv4jCeixWw== X-UI-Out-Filterresults: notjunk:1;V03:K0:oGesJvs0B7Y=:rUfkz73Y/00BVlFWH9iBAl qfXet7RQSK2KJsWO+X/Vh8Nnd9X48siQf9a1QeSxgfNbAVjlp6O+okklTmm9i8SAKa65pxkCt xMAsFZBRcsKcNhyq7OcZ08mU7cPgB5p3e/dn+lqAn6ImyZ/CIw5lNLtqW+9k2ytywUzFReoeK nXN9jLblTn1VaIg3wRT0WcLt49PDrhiQUSvyudAcQmlc9/tpJvcadqdqbCnd45nv4nPiCLsp6 qZtQ8Uy2pdVoLDpz/9j7+mn/maU8C1bAMyd500es+k9voAOtqn5detjZ+1NjRI0hrBxFZYyi8 JJwJXoG4aiDlRVGH/152JGnuYIiixScw8cWH21U0vXZQF1AVTTsSbzLD56gp1KBLtleDZc6h2 +WyrDuqBwuSMVzy9IGjUMQ+fwpoPlA2rBaMhx+EgFwF1lrKdPtEGM7D05JztDsishMQSk3vWv 91MBEHND373SRpf1OpOE3YsHfpJvt7LvBjrhHrUMpmL3szZCADM4Sk/qGTHV7VqrFZr/p0DHT dxvRZp9iG4VlVyXjq8dtT30Y3QDrVMZGZbSlHOiQEqHanYxEnMC7xxgegCKhQ3tWnGP71D8sM y3aXf5j/vLSfC+GNyujPfg3pQ42ybGfxfz8NV5VP5Yh/bk143xqcE3J2bCRKEf3+uSq2R+Q8j M72lID4WSeLxXyV4/bt7FeuaJwzdpIQTSdI2gAPnbPZl3aAhNQEVO/i8aGDLx67skc2E1XEL4 R3QafzT/gANnGqPW2DfIrSEFTLlLd1VP9alX7dhEN25MKO6zJucnGGpjK70hEr3uzatdp6YS0 rtYC/qh5rgBbaM4qzVl9N8jQlJ5NZS9nShZxeCMhrFvjAwHiyY= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Yan Yankovskyi , "linux-kernel@vger.kernel.org" , clang-built-linux , xen-devel , Boris Ostrovsky Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, May 6, 2020 at 7:12 AM J=C3=BCrgen Gro=C3=9F wrot= e: > > On 05.05.20 22:57, Arnd Bergmann wrote: > > On Tue, May 5, 2020 at 6:02 PM J=C3=BCrgen Gro=C3=9F = wrote: > >> On 05.05.20 17:01, Arnd Bergmann wrote: > >>> On Tue, May 5, 2020 at 4:34 PM J=C3=BCrgen Gro=C3=9F wrote: > >>>> On 05.05.20 16:15, Arnd Bergmann wrote: > >>> > >>> I considered that as well, and don't really mind either way. I think = it does > >>> get a bit ugly whatever we do. If you prefer the union, I can respin = the > >>> patch that way. > >> > >> Hmm, thinking more about it I think the real clean solution would be t= o > >> extend struct map_ring_valloc_hvm to cover the pv case, too, to add th= e > >> map and unmap arrays (possibly as a union) to it and to allocate it > >> dynamically instead of having it on the stack. > >> > >> Would you be fine doing this? > > > > This is a little more complex than I'd want to do without doing any tes= ting > > (and no, I don't want to do the testing either) ;-) > > > > It does sound like a better approach though. > > I take this as you are fine with me writing the patch and adding you as > "Reported-by:"? Yes, definitely. Thanks! Arnd