From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E81B3C4320A for ; Tue, 3 Aug 2021 18:27:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D14F860EEA for ; Tue, 3 Aug 2021 18:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238804AbhHCS1r (ORCPT ); Tue, 3 Aug 2021 14:27:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:36172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238793AbhHCS1n (ORCPT ); Tue, 3 Aug 2021 14:27:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 828EF60F38; Tue, 3 Aug 2021 18:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628015251; bh=b5coXSNVumOlwboi0Y8EY/7mMzZofAt1yR97rrjEWuo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EnOniVccHYcbPUOoldYN5TcX8f3C+JRnuXOHZxWbtWJMY1Ak5Rft8Yu9IVWd25mIX iudADck47r7/bo4UFcQvUYnq8hgDIIjzrESTJ2ktslvjw9WlMl0U28hVWKLw//VWBu d1HQGlOXqV5jyTRfDykOOCsp1cM4DsXuauWnSHlIWKyLmujnwW7Gg7191OH5tv9Ysa r6GOfrOdkaj5I9PQoVYzh6TzMNLgh8Feahn8l0jBdxFecoTVsgKs5oI/+U3jfHaBUZ e/xx8m2hml8eTRRgpcXieQrEUdQnt/C/QMfdHCIeBhVM3y7czlpbR6cVa19JB2U3FE Bn+jkASbimQIA== Received: by mail-wm1-f48.google.com with SMTP id l11-20020a7bcf0b0000b0290253545c2997so2677634wmg.4; Tue, 03 Aug 2021 11:27:31 -0700 (PDT) X-Gm-Message-State: AOAM533jmkLPA1WOaooXymw+poBR9UqPrAzNR03Qht7E92QkvtT1XYkS +claN/LL0w43SmIRYzUubf67gbIQvsq9tSVH1+Y= X-Google-Smtp-Source: ABdhPJyjyh5NW4HNDbY103glgZvlOfMtw6fuLPusi+3xAq38xsO4vRLS5MKwwQ0mEBFcXf8KsEzBXD0TMoyA7M3oU3E= X-Received: by 2002:a05:600c:414b:: with SMTP id h11mr5573870wmm.120.1628015250107; Tue, 03 Aug 2021 11:27:30 -0700 (PDT) MIME-Version: 1.0 References: <20210802145937.1155571-1-arnd@kernel.org> <20210802164907.GA9832@hoboy.vegasvil.org> <20210802230921.GA13623@hoboy.vegasvil.org> <20210803155556.GD32663@hoboy.vegasvil.org> <20210803161434.GE32663@hoboy.vegasvil.org> In-Reply-To: From: Arnd Bergmann Date: Tue, 3 Aug 2021 20:27:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies To: "Keller, Jacob E" Cc: Richard Cochran , Nicolas Pitre , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "David S. Miller" , Jakub Kicinski , Arnd Bergmann , Kurt Kanzenbach , "Saleem, Shiraz" , "Ertman, David M" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 3, 2021 at 7:19 PM Keller, Jacob E w= rote: > > On Tue, Aug 3, 2021 at 6:14 PM Richard Cochran wrote: > There is an alternative solution to fixing the imply keyword: > > Make the drivers use it properly by *actually* conditionally enabling the= feature only when IS_REACHABLE, i.e. fix ice so that it uses IS_REACHABLE = instead of IS_ENABLED, and so that its stub implementation in ice_ptp.h act= ually just silently does nothing but returns 0 to tell the rest of the driv= er things are fine. I would consider IS_REACHABLE() part of the problem, not the solution, it m= akes things magically build, but then surprises users at runtime when they do no= t get the intended behavior. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Tue, 3 Aug 2021 20:27:14 +0200 Subject: [Intel-wired-lan] [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies In-Reply-To: References: <20210802145937.1155571-1-arnd@kernel.org> <20210802164907.GA9832@hoboy.vegasvil.org> <20210802230921.GA13623@hoboy.vegasvil.org> <20210803155556.GD32663@hoboy.vegasvil.org> <20210803161434.GE32663@hoboy.vegasvil.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Tue, Aug 3, 2021 at 7:19 PM Keller, Jacob E wrote: > > On Tue, Aug 3, 2021 at 6:14 PM Richard Cochran wrote: > There is an alternative solution to fixing the imply keyword: > > Make the drivers use it properly by *actually* conditionally enabling the feature only when IS_REACHABLE, i.e. fix ice so that it uses IS_REACHABLE instead of IS_ENABLED, and so that its stub implementation in ice_ptp.h actually just silently does nothing but returns 0 to tell the rest of the driver things are fine. I would consider IS_REACHABLE() part of the problem, not the solution, it makes things magically build, but then surprises users at runtime when they do not get the intended behavior. Arnd