From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC5BC11F6B for ; Wed, 30 Jun 2021 08:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61BDE61CEF for ; Wed, 30 Jun 2021 08:39:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233532AbhF3ImV (ORCPT ); Wed, 30 Jun 2021 04:42:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:43756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232904AbhF3ImT (ORCPT ); Wed, 30 Jun 2021 04:42:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 407A461D0C; Wed, 30 Jun 2021 08:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625042391; bh=nF7bRnKiTfUwAEQZZ4y99Ifd5yL4YN8o4MyvNHrDvp4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MpqndtoVyuwdHmtwGrVrGcFJ0F6VxobYQR7k5p6T5BBM3yD7cXtMc2KrSM240IEae Mru3I2+bK5p+AAh29/LS1LvnTUGRO8ov1AV2jN8DawuaTyJyt/4onD/JEyM51Y+buD NYh8DxmbEqDYxxu1NVb1xjmwnUEqzvFM4p+m8mzendALw5bkZXQj2R+IaELz3oaGkw uHtYh/SD/6bmX729ejU/1SLfdQ78LvvZm9s4iEOi/fzNQ7UaJ/Cn6UE7Yr9Ags0Rpn WvC/AEWx0w4moWKTuveXjlvuyz59lcyeE2IaUsa3M847Cl3n0BqP+eoshBPE7VQ0Xf ZnKEDw6Z9vRvg== Received: by mail-wr1-f47.google.com with SMTP id u6so2571795wrs.5; Wed, 30 Jun 2021 01:39:51 -0700 (PDT) X-Gm-Message-State: AOAM5330lkVgszk4fuboD/FAtvRu7HHQ1x3z7zs6wgsjAZkt2pB7Amu4 cjQ3VF0gVTy0MLaqFqrzY/ESv/OAJun9YhKsG8M= X-Google-Smtp-Source: ABdhPJy5zClIXH6gfYBFh+/svLWqgI96t+bAqOlJJAIzgHK1Q/gPj3CBEHSVyEyQRwmgsqb+Od88D+57FqAsW4c5SOY= X-Received: by 2002:adf:e107:: with SMTP id t7mr37744493wrz.165.1625042389771; Wed, 30 Jun 2021 01:39:49 -0700 (PDT) MIME-Version: 1.0 References: <87a6njf0ia.fsf@disp2133> <87tulpbp19.fsf@disp2133> <87zgvgabw1.fsf@disp2133> <875yy3850g.fsf_-_@disp2133> <6e283d24-7121-ae7c-d5ad-558f85858a09@gmail.com> <7ad6c3a9-b983-46a5-fc95-f961b636d3fe@gmail.com> <36123b5d-daa0-6c2b-f2d4-a942f069fd54@gmail.com> <87sg10quue.fsf_-_@disp2133> In-Reply-To: <87sg10quue.fsf_-_@disp2133> From: Arnd Bergmann Date: Wed, 30 Jun 2021 10:37:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [CFT][PATCH] exit/bdflush: Remove the deprecated bdflush system call To: "Eric W. Biederman" Cc: Michael Schmitz , Geert Uytterhoeven , Al Viro , Linus Torvalds , linux-arch , Jens Axboe , Oleg Nesterov , Linux Kernel Mailing List , Richard Henderson , Ivan Kokshaysky , Matt Turner , alpha , linux-m68k , Tejun Heo , Kees Cook , Linux API Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 29, 2021 at 10:28 PM Eric W. Biederman wrote: > > > The bdflush system call has been deprecated for a very long time. > Recently Michael Schmitz tested[1] and found that the last known > caller of of the bdflush system call is unaffected by it's removal. > > Since the code is not needed delete it. > > [1] https://lkml.kernel.org/r/36123b5d-daa0-6c2b-f2d4-a942f069fd54@gmail.com > Signed-off-by: "Eric W. Biederman" > --- > > I think we have consensus that bdflush can be removed. Can folks please > verify I have removed it correctly? Reviewed-by: Arnd Bergmann We are traditionally somewhat inconsistent about whether to leave the __NR_bdflush macro present in asm/unistd.h or to remove it when the syscall is gone. Leaving it in place as you do is probably better here. Arnd