From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15D44C433F5 for ; Thu, 17 Feb 2022 07:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RPqQ8la46I3hYmyYAhoid/JOw/UwrS8aCjbj0WauFcg=; b=faYu7HeOvhlbZj pPsPbj9wWBbH5JGGHVKeKqp4Wj/Suepwrh+lTDTBbLGvs2EkyeAQMrTwnjBhpZ+y7qP8trNBiPzA2 EV6OLuxOY27L3/Jl+T37OuXBWCWG8pqbjoxnRA4x9wAy+OQvIF5Qxy+Yo1NtrFggMbfzSqWsIa6HD Viid+23AtTZWPRbh38WFksA01IyC3rY7EusZX3C6uuN+23vnY/OAtUkqAcA5YHmaXKvEw7x+aKMdo gZxuug3JTep0g4HM8FQ9okUaNcIGQEij2tzaU17WmLDDQ8kRxodGHl49ONUQaQeFfur1PNEsP15+O IZCMfhyGNsQhXqcauV5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKatg-009CRo-3f; Thu, 17 Feb 2022 07:08:12 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKatc-009CQz-3s for linux-arm-kernel@lists.infradead.org; Thu, 17 Feb 2022 07:08:10 +0000 Received: from mail-wr1-f43.google.com ([209.85.221.43]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N6szR-1oLJbH2cEJ-018MM3 for ; Thu, 17 Feb 2022 08:08:04 +0100 Received: by mail-wr1-f43.google.com with SMTP id w11so7288584wra.4 for ; Wed, 16 Feb 2022 23:08:04 -0800 (PST) X-Gm-Message-State: AOAM530mUT4JCwu1GN0s68DUXUF+gWaZ6atIWYxQlnovvyIh1+JKp1eI IwZQIF0QNAv/N3cRzgbwb4Ah+8IqZR9b+O+YauI= X-Google-Smtp-Source: ABdhPJz56hQ4yFgBgAFZmrCVGvaq26OxoGL97mAkpuIsaGTOfsArnu/xLDwGg2ZOqwcLNp7GMrlrc/f8PwCaU93fGwc= X-Received: by 2002:adf:ea01:0:b0:1e4:b3e6:1f52 with SMTP id q1-20020adfea01000000b001e4b3e61f52mr1152774wrm.317.1645081684017; Wed, 16 Feb 2022 23:08:04 -0800 (PST) MIME-Version: 1.0 References: <20220210232812.798387-1-nhuck@google.com> <20220210232812.798387-2-nhuck@google.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 17 Feb 2022 08:07:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 1/7] crypto: xctr - Add XCTR support To: Eric Biggers Cc: Nathan Huckleberry , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Herbert Xu , "David S. Miller" , Linux ARM , Paul Crowley , Sami Tolvanen , Ard Biesheuvel X-Provags-ID: V03:K1:/XaTYxenoRDo7ye41JGeGeuPusfEN5LhfAWTJwxFHNnz0B3PDtN lQdWNyjXNn6wKqFG2DBK/CN+ojLY6i//6KYnw24KDDzLBDXejKOYcywVlS4wY+Fn2gbDQ6d v9a97TNer2RnTOD29DaFpV5S/Y0fteeEqVFAQGmgI0uPTWgHyESrOqSE7cdiprvT335RjFs R0CRZz/FbJVMtiLTI4vWQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:xStM5Qy7Uc0=:BTcsxrN2/Pi5g1zS+90tC0 emJFeXjP5l5yim8xoMuYbPI4sgxoSY9cqIW6WOs7gY86T4r0GhxQIVgzFzNI7Fstmw1UQ+tXv sFTCvmgOBkX0zK462yTKcohSseNlnOS9yJb8o3n2RyjXF7NbGaJJwNX2v4R7RQrPwjJOnZVzp /9KL9ciRG3B41QcaodrDtefprE4q9J0ll2rkyudNFFZ1J49XXEofHEJ+EmTaMG1uI0DR4azZR snopGLLPMAehgWu6EFHPkXfZ3UquU9FLjBXvqu3kef9PHwJoL1FOh+F0PwJyBB4hlKR3QCIPZ dKS06C4KkdW8HnDXgFd4ZsUmr/EwHVOtMChp3xjPKHidvIbu8BIafzrdvr8ccz0/8Q/9bqyRm uAlIGARBAumlYgK17NFO4L9yGnTBv86D2SAAfbo0v1kg3JIuSRMaJhwOcGqo8ZMvxEGXcUvDo QdSmmQQyqw8Y5rE/mSvTYEL2jhAF/c9WAt9pkj86IHZ1vAXlOLQzcG0Q+ZTvboiMHQ5u6pJ/+ f3JKsgMXFn/dyOH0oW+L5U4MKUd4WVrCI39GA2VR4ctVmA82GxshcEHgffMAPWHoQjLKfUIpA 2jQj3OQsV++QfFJQltmAe2zpT9LS7jaRQuyF7Zl/lY1IP9BkGYP1SaSWITlWc8GGA4/Y38t2E 3XrUeMl3C07rScTaa8+E+CZ00vZnn1IOttldsOwT1ZWxnbLiTuhkdQ7JCxR1gS6LeJr8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_230808_475154_05027E1A X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 17, 2022 at 12:00 AM Eric Biggers wrote: > On Thu, Feb 10, 2022 at 11:28:06PM +0000, Nathan Huckleberry wrote: > > diff --git a/crypto/Kconfig b/crypto/Kconfig > > index fa1741bb568f..8543f34fa200 100644 > > --- a/crypto/Kconfig > > +++ b/crypto/Kconfig > > @@ -452,6 +452,15 @@ config CRYPTO_PCBC > > PCBC: Propagating Cipher Block Chaining mode > > This block cipher algorithm is required for RxRPC. > > > > +config CRYPTO_XCTR > > + tristate > > + select CRYPTO_SKCIPHER > > + select CRYPTO_MANAGER > > + help > > + XCTR: XOR Counter mode. This blockcipher mode is a variant of CTR mode > > + using XORs and little-endian addition rather than big-endian arithmetic. > > + XCTR mode is used to implement HCTR2. > > Now that this option isn't user-selectable, no one will see this help text. > I think it would be best to remove it, and make sure that the comment in > crypto/xctr.c fully explains what XCTR is (currently it's a bit inadequate). I generally prefer to have a help text in Kconfig even for hidden symbols, and I read those when trying to find my way through code I'm not familiar with. It's probably a good idea to expand the comment in the source file as well, but I would suggest leaving this one in here. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46319C433F5 for ; Thu, 17 Feb 2022 07:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232384AbiBQHN0 (ORCPT ); Thu, 17 Feb 2022 02:13:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232019AbiBQHN0 (ORCPT ); Thu, 17 Feb 2022 02:13:26 -0500 X-Greylist: delayed 304 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 16 Feb 2022 23:13:11 PST Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8480298AFA for ; Wed, 16 Feb 2022 23:13:10 -0800 (PST) Received: from mail-wr1-f53.google.com ([209.85.221.53]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MwwqB-1oDecZ1ZUJ-00ySaK for ; Thu, 17 Feb 2022 08:08:04 +0100 Received: by mail-wr1-f53.google.com with SMTP id o24so7296158wro.3 for ; Wed, 16 Feb 2022 23:08:04 -0800 (PST) X-Gm-Message-State: AOAM531MxwravBU6TDAwd3lFdN0LpauYi0jQxip+TfvPuGwxu1FR32kR 7bZ8G/MNbM1uEt/Zi77crFWqB/ngQ37oPRMvy1w= X-Google-Smtp-Source: ABdhPJz56hQ4yFgBgAFZmrCVGvaq26OxoGL97mAkpuIsaGTOfsArnu/xLDwGg2ZOqwcLNp7GMrlrc/f8PwCaU93fGwc= X-Received: by 2002:adf:ea01:0:b0:1e4:b3e6:1f52 with SMTP id q1-20020adfea01000000b001e4b3e61f52mr1152774wrm.317.1645081684017; Wed, 16 Feb 2022 23:08:04 -0800 (PST) MIME-Version: 1.0 References: <20220210232812.798387-1-nhuck@google.com> <20220210232812.798387-2-nhuck@google.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 17 Feb 2022 08:07:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 1/7] crypto: xctr - Add XCTR support To: Eric Biggers Cc: Nathan Huckleberry , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Herbert Xu , "David S. Miller" , Linux ARM , Paul Crowley , Sami Tolvanen , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:yzwIVfU0L/K/F6dyLoT6ifQ63BinEIDYvCLHuWiotTlVjMFdup0 LvsYEzX2kTfBZctqZfldPFKpsQ4J3+FkDNWBlikfXfOkR9sFBfLS5BhNCMAqoB9zWAiO2Rr +oHFJUkbJhYvmMrqXp+G8ay93Tqxl2IJZ8MUiPtUryqN0OxvALpXsv6AzCEPBOGmXc6XQSJ DlwQyZ7vOCKxJHENopvQw== X-UI-Out-Filterresults: notjunk:1;V03:K0:IfB1qRLoJHY=:cZuQYf3awOQNOt5KtNzjF8 TuSbdz26DKd6D2PUzrSf0P5nqee/0iJBrctw/fY7oKpPzPR0KQXVPdYLmO5YlkxgYD6nnfL5F KK8C9bZ21NKIwsXiD8DTb2yOu5REpkpyWsmxoDhx258/MK4EKz9ALjSA1bPvlHT30QkRAqkXO UdCG0y1Q0EzdUv48Ut4DMXDkl3Ywear0jPSjBeU4E06BsLu8YY5pgCU7njzSG9ulu7Jgw5McZ DG6AKiYM2ZfDPvjFHIW9fnpy0Fta5lYJ33sVPGqGgy4CH6AMNsVn6k2W68Sl4RLAz2G1bhrKa ijbS/gh3IoUyMtu5CmLaeSyH8lhXZpKatozrN5u3w0kJ3q376wz2EZBN9ivTNvAGLJYHCvI2X YsfmkgYGrNXhfsNA0fVTdyBiGm+JVEMx+EF+SwHjwjGu240IcFr1dqhsZlfpEyluXU02XODJk UFVH6b86tKRjlAF9pgsLo4ERNfc/RM36htBwh3bp1kt13J9XvhjyCNiG5Vv7coJjF9ZnyObop BP118/KN191Htr3EcU7WG3jhZv10vm+SgZCHJGGU14G9cq/5bXjy0GnSHUuFZB6Hx0CtDq8z+ CLzDArGUWPslcaMQEG5GLJ1dFpiVuc6P0KmX9QT99m7y+VhS0E1ebyWMChw0P+n+FQlHeIrHD UR7jqS7N7C3AW6U9WsnO94rkjLAopLjm0JtO+KJQn3C7Bt3KDVkV7UNkawJkyolIqa80= Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Feb 17, 2022 at 12:00 AM Eric Biggers wrote: > On Thu, Feb 10, 2022 at 11:28:06PM +0000, Nathan Huckleberry wrote: > > diff --git a/crypto/Kconfig b/crypto/Kconfig > > index fa1741bb568f..8543f34fa200 100644 > > --- a/crypto/Kconfig > > +++ b/crypto/Kconfig > > @@ -452,6 +452,15 @@ config CRYPTO_PCBC > > PCBC: Propagating Cipher Block Chaining mode > > This block cipher algorithm is required for RxRPC. > > > > +config CRYPTO_XCTR > > + tristate > > + select CRYPTO_SKCIPHER > > + select CRYPTO_MANAGER > > + help > > + XCTR: XOR Counter mode. This blockcipher mode is a variant of CTR mode > > + using XORs and little-endian addition rather than big-endian arithmetic. > > + XCTR mode is used to implement HCTR2. > > Now that this option isn't user-selectable, no one will see this help text. > I think it would be best to remove it, and make sure that the comment in > crypto/xctr.c fully explains what XCTR is (currently it's a bit inadequate). I generally prefer to have a help text in Kconfig even for hidden symbols, and I read those when trying to find my way through code I'm not familiar with. It's probably a good idea to expand the comment in the source file as well, but I would suggest leaving this one in here. Arnd