From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965630AbeBMTxI (ORCPT ); Tue, 13 Feb 2018 14:53:08 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:39395 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965540AbeBMTxG (ORCPT ); Tue, 13 Feb 2018 14:53:06 -0500 X-Google-Smtp-Source: AH8x227G0yQlz5hMe9gQmxOiu9ezDo0YY4Q98SEwrHmJcl+Yt/5pngdXkeSh52Qkf2Uq6KPZcDUWfRC+AcMqil1Svn4= MIME-Version: 1.0 In-Reply-To: References: <20180205235757.246758-1-brendanhiggins@google.com> <20180205235757.246758-3-brendanhiggins@google.com> From: Arnd Bergmann Date: Tue, 13 Feb 2018 20:53:05 +0100 X-Google-Sender-Auth: NqQNWPp37fbuCqXL8licFxQ8f1o Message-ID: Subject: Re: [PATCH v9 2/3] arm: dts: add Nuvoton NPCM750 device tree To: Brendan Higgins Cc: Avi Fishman , Rob Herring , Russell King - ARM Linux , Mark Rutland , Tomer Maimon , Florian Fainelli , Julien Thierry , Philippe Ombredanne , DTML , Linux Kernel Mailing List , Linux ARM , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 13, 2018 at 8:12 PM, Brendan Higgins wrote: > On Tue, Feb 13, 2018 at 1:29 AM, Avi Fishman wrote: >> On Tue, Feb 13, 2018 at 10:30 AM, Arnd Bergmann wrote: >>> On Tue, Feb 6, 2018 at 12:57 AM, Brendan Higgins >>> wrote: >>>> Add a common device tree for all Nuvoton NPCM750 BMCs and a board >>>> specific device tree for the NPCM750 (Poleg) evaluation board. >>>> >>>> Signed-off-by: Brendan Higgins >>>> Reviewed-by: Tomer Maimon >>>> Reviewed-by: Avi Fishman >>>> Reviewed-by: Joel Stanley >>>> Reviewed-by: Rob Herring >>>> Tested-by: Tomer Maimon >>>> Tested-by: Avi Fishman >>> ... >>>> + enable-method = "nuvoton,npcm7xx-smp"; >>> >>> I see this has already been reviewed quite a bit, but I'm curious >>> about the 'npcm7xx' >>> part here. Shouldn't that be a real chip name rather than a wildcard? >> >> There is a family of npcm7xx, some with SMP and some without. >> For those who has it, it is common for all to use the same >> "nuvoton,npcm7xx-smp". > > I think Arnd is right. In this case it should be "nuvoton,npcm750-smp". We can > use CPU_METHOD_OF_DECLARE to alias to as many compatible properties as needed. > > Although everything in the 7xx family currently is either single core or has the > same SMP behavior, you could paint yourself into a corner if you were to make > one SMP device in the 7xx family which behaves differently from all other > devices and then need to come up with new compatible string names just for that. Right, this is the reason for the very simple 'no wildcards in DT identifiers' rule. There simply isn't a reason to make an exception here. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4003:c0f::244; helo=mail-ot0-x244.google.com; envelope-from=arndbergmann@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="A7V5ExBy"; dkim-atps=neutral Received: from mail-ot0-x244.google.com (mail-ot0-x244.google.com [IPv6:2607:f8b0:4003:c0f::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zgtW83GvWzF1RM for ; Wed, 14 Feb 2018 06:53:08 +1100 (AEDT) Received: by mail-ot0-x244.google.com with SMTP id q12so18338281otg.10 for ; Tue, 13 Feb 2018 11:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=niagko5JAYteaoAt+aC3B8/NfR1Syt9bCfX9MJeToCs=; b=A7V5ExByQleFknXmDoiSpfPD1rKSagqZ0uyUX+7KzYQRfDij0da5somZ8f0KJIdSbG xn8nTtA2aeLXe9mEWB7L5LVzHkp8sMOP9WIvCUei+mgfDZXHs1JIfdahfUJdH/aikmRd dxNimOSjLQZXVWkYECzeCq/9fkfQxF3/Gih1uKKdVosxNN79PwlgsGCM5fKP/8aOn1bs FVW3R/S/wxpQXyfLrgVBFzYAzGuekXAroBD0eH2zGR9BJn2bWtAMapq1yqWFDfkbwXyR ARd++HUp/Dfbm4ozlHIXTQMsp0jz+BhkFfqA9e9A7yZnsyidPMuiBqOlr3HFpVZHkd+X R6lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=niagko5JAYteaoAt+aC3B8/NfR1Syt9bCfX9MJeToCs=; b=EtIsSTcdbP3G2L2JKLK67HI4GV/RBYQAFyjTfjz8vMpydAUOKYmAk/l3gHnM1tpTlZ aTCou9FRc9Puf+2zPwLdgDq9sk9ukt9uH4SS2NLzrMXaWmHPbnf1lAyVnKKDwfZFE5KM lCpALaeBDiC5TiN6hh3ziVrPP5a2vzIVQ3pI7RNTOJ6hNCAIQAsf1mCKqedqhspDVy9c +qeW/Acnd89vSEjmo+fVGhkxBl1dGLZH3SoiA3fRCdlxvRf89AbLo6HOZq4kis1N1W6r VXfpaEQMVTHq7Fc+VuWWI57FBI2FNzjhyGyv7O/olPg4ciSOuMT+5F5YVpZf87pXMG+9 /LDg== X-Gm-Message-State: APf1xPCwBhDaNrDVvl1gbxUwyqRlNj/sB/8VzdbbKUdoXM2ECOI9iZZe KNeZaZ0exbtYqSjJY0lgTP7wbeGA+mrjZeXucr4= X-Google-Smtp-Source: AH8x227G0yQlz5hMe9gQmxOiu9ezDo0YY4Q98SEwrHmJcl+Yt/5pngdXkeSh52Qkf2Uq6KPZcDUWfRC+AcMqil1Svn4= X-Received: by 10.157.26.44 with SMTP id a41mr1681302ote.108.1518551586237; Tue, 13 Feb 2018 11:53:06 -0800 (PST) MIME-Version: 1.0 Sender: arndbergmann@gmail.com Received: by 10.168.66.10 with HTTP; Tue, 13 Feb 2018 11:53:05 -0800 (PST) In-Reply-To: References: <20180205235757.246758-1-brendanhiggins@google.com> <20180205235757.246758-3-brendanhiggins@google.com> From: Arnd Bergmann Date: Tue, 13 Feb 2018 20:53:05 +0100 X-Google-Sender-Auth: NqQNWPp37fbuCqXL8licFxQ8f1o Message-ID: Subject: Re: [PATCH v9 2/3] arm: dts: add Nuvoton NPCM750 device tree To: Brendan Higgins Cc: Avi Fishman , Rob Herring , Russell King - ARM Linux , Mark Rutland , Tomer Maimon , Florian Fainelli , Julien Thierry , Philippe Ombredanne , DTML , Linux Kernel Mailing List , Linux ARM , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 19:53:09 -0000 On Tue, Feb 13, 2018 at 8:12 PM, Brendan Higgins wrote: > On Tue, Feb 13, 2018 at 1:29 AM, Avi Fishman wrote: >> On Tue, Feb 13, 2018 at 10:30 AM, Arnd Bergmann wrote: >>> On Tue, Feb 6, 2018 at 12:57 AM, Brendan Higgins >>> wrote: >>>> Add a common device tree for all Nuvoton NPCM750 BMCs and a board >>>> specific device tree for the NPCM750 (Poleg) evaluation board. >>>> >>>> Signed-off-by: Brendan Higgins >>>> Reviewed-by: Tomer Maimon >>>> Reviewed-by: Avi Fishman >>>> Reviewed-by: Joel Stanley >>>> Reviewed-by: Rob Herring >>>> Tested-by: Tomer Maimon >>>> Tested-by: Avi Fishman >>> ... >>>> + enable-method = "nuvoton,npcm7xx-smp"; >>> >>> I see this has already been reviewed quite a bit, but I'm curious >>> about the 'npcm7xx' >>> part here. Shouldn't that be a real chip name rather than a wildcard? >> >> There is a family of npcm7xx, some with SMP and some without. >> For those who has it, it is common for all to use the same >> "nuvoton,npcm7xx-smp". > > I think Arnd is right. In this case it should be "nuvoton,npcm750-smp". We can > use CPU_METHOD_OF_DECLARE to alias to as many compatible properties as needed. > > Although everything in the 7xx family currently is either single core or has the > same SMP behavior, you could paint yourself into a corner if you were to make > one SMP device in the 7xx family which behaves differently from all other > devices and then need to come up with new compatible string names just for that. Right, this is the reason for the very simple 'no wildcards in DT identifiers' rule. There simply isn't a reason to make an exception here. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 13 Feb 2018 20:53:05 +0100 Subject: [PATCH v9 2/3] arm: dts: add Nuvoton NPCM750 device tree In-Reply-To: References: <20180205235757.246758-1-brendanhiggins@google.com> <20180205235757.246758-3-brendanhiggins@google.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 13, 2018 at 8:12 PM, Brendan Higgins wrote: > On Tue, Feb 13, 2018 at 1:29 AM, Avi Fishman wrote: >> On Tue, Feb 13, 2018 at 10:30 AM, Arnd Bergmann wrote: >>> On Tue, Feb 6, 2018 at 12:57 AM, Brendan Higgins >>> wrote: >>>> Add a common device tree for all Nuvoton NPCM750 BMCs and a board >>>> specific device tree for the NPCM750 (Poleg) evaluation board. >>>> >>>> Signed-off-by: Brendan Higgins >>>> Reviewed-by: Tomer Maimon >>>> Reviewed-by: Avi Fishman >>>> Reviewed-by: Joel Stanley >>>> Reviewed-by: Rob Herring >>>> Tested-by: Tomer Maimon >>>> Tested-by: Avi Fishman >>> ... >>>> + enable-method = "nuvoton,npcm7xx-smp"; >>> >>> I see this has already been reviewed quite a bit, but I'm curious >>> about the 'npcm7xx' >>> part here. Shouldn't that be a real chip name rather than a wildcard? >> >> There is a family of npcm7xx, some with SMP and some without. >> For those who has it, it is common for all to use the same >> "nuvoton,npcm7xx-smp". > > I think Arnd is right. In this case it should be "nuvoton,npcm750-smp". We can > use CPU_METHOD_OF_DECLARE to alias to as many compatible properties as needed. > > Although everything in the 7xx family currently is either single core or has the > same SMP behavior, you could paint yourself into a corner if you were to make > one SMP device in the 7xx family which behaves differently from all other > devices and then need to come up with new compatible string names just for that. Right, this is the reason for the very simple 'no wildcards in DT identifiers' rule. There simply isn't a reason to make an exception here. Arnd