From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B14CC433EF for ; Fri, 22 Apr 2022 13:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234087AbiDVNXb (ORCPT ); Fri, 22 Apr 2022 09:23:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234077AbiDVNXZ (ORCPT ); Fri, 22 Apr 2022 09:23:25 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 706C55675F for ; Fri, 22 Apr 2022 06:20:28 -0700 (PDT) Received: from mail-wm1-f52.google.com ([209.85.128.52]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MDykM-1na9z52EGS-009w2s for ; Fri, 22 Apr 2022 15:20:27 +0200 Received: by mail-wm1-f52.google.com with SMTP id 17-20020a05600c021100b00393a19f8f98so2342709wmi.4 for ; Fri, 22 Apr 2022 06:20:27 -0700 (PDT) X-Gm-Message-State: AOAM532t0cXsi4jBUQKB+WLq9mN0ZqKTfwHv/4OVRDOecOkG+CVrReig aNGeOmxuSc54arV/SetezmN5i3Dtc2Luek785rg= X-Google-Smtp-Source: ABdhPJzf/DWY7IjQmD9EMZpdSip3IO7TepL3hX4HNfMH3eMN5Wr1vB5Co+iKQNZfzMg9VSbLcZ66wrZAMeetcjbrF3c= X-Received: by 2002:a05:600c:4ed4:b0:392:90a5:b7e6 with SMTP id g20-20020a05600c4ed400b0039290a5b7e6mr13716628wmq.33.1650633627153; Fri, 22 Apr 2022 06:20:27 -0700 (PDT) MIME-Version: 1.0 References: <20220421192132.109954-1-nick.hawkins@hpe.com> <20220421192132.109954-2-nick.hawkins@hpe.com> In-Reply-To: <20220421192132.109954-2-nick.hawkins@hpe.com> From: Arnd Bergmann Date: Fri, 22 Apr 2022 15:20:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 01/11] archh: arm: mach-hpe: Introduce the HPE GXP architecture To: "Hawkins, Nick" Cc: "Verdun, Jean-Marie" , Joel Stanley , Arnd Bergmann , OpenBMC Maillist , Russell King , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:HHZb/dSf2uI0vlbQ6e8ER49qDtomMK8A0heqJ1xj8Mbg3Oe9fpZ umAbwrQddJkUHuLUVOyd6v3gs5WxGsfwQNIuJVWsIfZU/z7XTOJfZmzngWnCL+31DrPzOpq xUeDzhY8V9Jbgk4IlJNin65q84t/st8l6AP0C7bnbWfa3MkkQanR73NOGG40neKkbcqiJ85 uCvyzTunC2mwgkq6AkOog== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZfFoGBGji6Q=:5rEyGioGbRetw+KE3HlOqf 7593IfLxMaL4Jrn/qHDoJucyEFGdqVmiS8sWDr9BzWNWFGok+Qt1TMMj1sqSSp2URmzxbrwky zu7TKoeCbGhMA6htqEzujRp4WqSO9ORbsxsaPNBP3Ms3lFTdhUhiu36pbkqBtIqP6kv7dtdg/ rt/201dVbSOCr2auhOEkyf0JzUI0gBXBcYLTWvKgJ3eVRTZH16OCnCPXqKSCZSofi2q0BILEu ThcpFg0YXf2qQsE5eofJrkynXq+inUImxPthggst1sYBYtbc7nUNGy2YHmPFKaTSaY6HTU1be F6H15DHJosyOGQXgxBUFBPhcggGhe1M+wgwTAgZ+/sm/OLHi7K0rlCXwG95xQaGGe74l2nJSi 08mZXTQ3KKGyCDn4gMHo7YJ6vlYUa5EC9b9bXHT+LpLUmvOuuq6h6r5ZrTceVNn2EYUi1EykJ tC0496DMOXeOuyJvpuGbTQo9V4TNdAAL7v6RoCXNEaJC7ThLPijzQo7f537QDHU3EG/Y/sSNZ Q/TAz1QZpl0HnYNhPjhTsgOBXgaoMOYlpc+MQL99cPIX46ogwQCUhFbdC7nuGGeAbPz0FQJYB UIpMH058USPoiEAUhsuOGzQwqTWJE9jZN5P/p2uwVfY3sYmSh/pFWd2XPfTXJsglSV09Jy2I0 ztxWmJs6Qmw+4JnIS7nq4eleyPB6fvrnJhBJQZJwqHSoL6n9+vrXQ/lK1/L/DzKVN+0DkbWsh GfBKUDCKvO2gpfLYMKQlQXl+YEGiB2Uc1LlkrR6YwSo9EF3vrZ/7NDUB77B2jMg+k2QlPV6Jw 1sBFMYwWRaS+8i9ibUCzf02WsE/NgJqV/gZpHr+eAldLMP5zm0= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 9:21 PM wrote: > + > +DT_MACHINE_START(GXP_DT, "HPE GXP") > + .dt_compat = gxp_board_dt_compat, > + .l2c_aux_val = 0, > + .l2c_aux_mask = 0, > +MACHINE_END Ther l2c initialization looks wrong here, where you are saying here is that all the bits of the aux register must be set to zero. I also see that you don't have a device node for the cache controller, so this is probably not actually used, but in general there should be one with the correct properties. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FB83C433F5 for ; Fri, 22 Apr 2022 13:20:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KlFQv30fxz3bdP for ; Fri, 22 Apr 2022 23:20:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=217.72.192.75; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KlFQR3XS3z2xnP for ; Fri, 22 Apr 2022 23:20:31 +1000 (AEST) Received: from mail-wm1-f50.google.com ([209.85.128.50]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MGyl3-1ndC7E27oB-00E5JZ for ; Fri, 22 Apr 2022 15:20:27 +0200 Received: by mail-wm1-f50.google.com with SMTP id l62-20020a1c2541000000b0038e4570af2fso5354015wml.5 for ; Fri, 22 Apr 2022 06:20:27 -0700 (PDT) X-Gm-Message-State: AOAM531nWhh2zbf7dyQXtgwq2LIAWHSV/fk9T/LVS3V7Vk5w4UagOPKE et6R6d4bjghCGzouIR8WgsYVKYxlze/oQSL/dUU= X-Google-Smtp-Source: ABdhPJzf/DWY7IjQmD9EMZpdSip3IO7TepL3hX4HNfMH3eMN5Wr1vB5Co+iKQNZfzMg9VSbLcZ66wrZAMeetcjbrF3c= X-Received: by 2002:a05:600c:4ed4:b0:392:90a5:b7e6 with SMTP id g20-20020a05600c4ed400b0039290a5b7e6mr13716628wmq.33.1650633627153; Fri, 22 Apr 2022 06:20:27 -0700 (PDT) MIME-Version: 1.0 References: <20220421192132.109954-1-nick.hawkins@hpe.com> <20220421192132.109954-2-nick.hawkins@hpe.com> In-Reply-To: <20220421192132.109954-2-nick.hawkins@hpe.com> From: Arnd Bergmann Date: Fri, 22 Apr 2022 15:20:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 01/11] archh: arm: mach-hpe: Introduce the HPE GXP architecture To: "Hawkins, Nick" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:bypOUT2wkwn++f6YwjHV3JxgINLX4hRK4bF26T4uHuZsLFNSsLk E37AkHJoyQjQhBqWKKKwDKjvLI8edQbNOszsKUtLJvSkdybEg3Myqq5j2xqlxD3T1IOc7Q2 52EzZJGYErtPq7ZD6Avrw7U8jYTsn638PBrFJ4afIPlHKNYykHmjZBW04M47sXtu/CgBdXy LksThd2bt1VoYQlV5Ar4g== X-UI-Out-Filterresults: notjunk:1;V03:K0:MfN4N6I79kI=:9OZBe2nX1fgopDNENgHgsf Dha+WYUWzz2FAq3iNCJTCRenTCub+jctH+qaA9OmFkorrBYwAoRPdcqxJJfSe7u9OjS8R51vy ykVFaV9ca7tNFps1IGuPlkQ0mCpqISyiWCn3/AWv+SxuClfnu1c5wcr1/Iz/XUMxemP8FdtJX EYWet52JYZ+R8RXp0jgg+Ogkphv/nqn5rd+HwUEabAeWitOVOQ/krcv3ZIVIcp81VLGmXxDvf fi4PT6PWpHsH5hKKwvyFuDptu+pNBoMdy8suGYQ7bCLRatPDIgF1/+8z1+dTmkHSseWWhOMc5 HjcT9HhOncAHy3hgms/EPXGPUR3phR0nGoazkHFgl84q11SZdXtDHaIA7XJ69a3wCleXf/TAJ ROho5OvrGfR5Lgl2ZnNtX0CGXIaCCltbt8RfGYFNDqb3oSs48htnkVPyvyrY8fPMNG/GtkB3G 87j4IdBsy51UYWpDb6DgCNU839HbUuN5PCokzjHI89Im4nve4AzjAX8MDEeM+apA8W1KXEOuD kfuhAO7XL5tqD670D+GbCti/IPQFNR4iQ3Kwpk7iofL9C0M+EfAGqtJzdUIWgsGPG08NLcupi lHpdmfOeakb7PxODBgkBgqviHvSmpELkP/1ZYcPUJxqv7dV8wg7XO6H4GtTD5EciC5hF1GlQj zyLUBZ7SeyAGT/KUBiWJCtZAz3oY2qTBQsYT2jzLLXp6DrGFI1qxVBcwr9J9xcxC34oQXrsPu Wu2fsG3jkAd5UDrYeS/XxfzIIxK0A3Y3WrPlbHPqBzhuoMTQ0KjAvpNDYggP26lhPzwXxo24l cAYQ268vxsLmXhM8fkFfdkBF7IZerGj4Up8tR1NBbQl1h5vQC0= X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , "Verdun, Jean-Marie" , Russell King , Linux Kernel Mailing List , Joel Stanley , OpenBMC Maillist , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Apr 21, 2022 at 9:21 PM wrote: > + > +DT_MACHINE_START(GXP_DT, "HPE GXP") > + .dt_compat = gxp_board_dt_compat, > + .l2c_aux_val = 0, > + .l2c_aux_mask = 0, > +MACHINE_END Ther l2c initialization looks wrong here, where you are saying here is that all the bits of the aux register must be set to zero. I also see that you don't have a device node for the cache controller, so this is probably not actually used, but in general there should be one with the correct properties. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D33E7C433F5 for ; Fri, 22 Apr 2022 13:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7qjVDxfXaO/L78bWpBDRL9ov81KGSryzrZ65cAI7nmc=; b=zbLh7Psoeo5LEI v3voyCPTQx4QzY5G7FPMFpXAK+cNBDOSfm6Hua1OW/D7WEEdSvc9RmqMBjRBY85IFYD2GH1eT/Eym TTfcpxZ/0Egc435fUTDE+o4/NuR8E6UEohUK4gpiP/9TojPhcJh9Iorovx/4LIYaNOUNTpgaSEs7B hqxM9x0VfUx8OSnUCB3l2lhmZfLrx3hsmUKkghsQf39r8M3N8omZYsVIov7Hkr7dAlx3Wlmh+ojXP PkRUGjkmoO8mmGPxbIGmCvnBLjac+6z8NwZyGKbniG4eUnbPwHcc3kPSBp9Xtp3Vrl427U80zIk62 0fxW2YdqJCnkfh1baA+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhtDA-000Zr5-QE; Fri, 22 Apr 2022 13:20:36 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhtD7-000ZqF-Jj for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 13:20:35 +0000 Received: from mail-wm1-f43.google.com ([209.85.128.43]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MCayD-1nYmGu2TiN-009fDz for ; Fri, 22 Apr 2022 15:20:27 +0200 Received: by mail-wm1-f43.google.com with SMTP id r19so5093599wmq.0 for ; Fri, 22 Apr 2022 06:20:27 -0700 (PDT) X-Gm-Message-State: AOAM530eX4Ucoo7i2cU+69AcHNHDVivd7OTyUPTSdGLfumYR4WjkuzT9 dm7w/aLxsZ0FxA9Sy5KJzUCMP5p4YDZaQKUW6bk= X-Google-Smtp-Source: ABdhPJzf/DWY7IjQmD9EMZpdSip3IO7TepL3hX4HNfMH3eMN5Wr1vB5Co+iKQNZfzMg9VSbLcZ66wrZAMeetcjbrF3c= X-Received: by 2002:a05:600c:4ed4:b0:392:90a5:b7e6 with SMTP id g20-20020a05600c4ed400b0039290a5b7e6mr13716628wmq.33.1650633627153; Fri, 22 Apr 2022 06:20:27 -0700 (PDT) MIME-Version: 1.0 References: <20220421192132.109954-1-nick.hawkins@hpe.com> <20220421192132.109954-2-nick.hawkins@hpe.com> In-Reply-To: <20220421192132.109954-2-nick.hawkins@hpe.com> From: Arnd Bergmann Date: Fri, 22 Apr 2022 15:20:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 01/11] archh: arm: mach-hpe: Introduce the HPE GXP architecture To: "Hawkins, Nick" Cc: "Verdun, Jean-Marie" , Joel Stanley , Arnd Bergmann , OpenBMC Maillist , Russell King , Linux ARM , Linux Kernel Mailing List X-Provags-ID: V03:K1:5MDwxm7Q2ypJZea304/fCg7hA6Jz0oPOwVDSK9hvDMwkA9AOmV9 aLt9PeaeTjaOwqUDFEieDwKlYumUQAguqY8bZvwf34xXmP2BbrLBWeYUSqtO0zSUhF5nASw VWTGOp47nIuWOQiLvGayUzRdPDVJadMeLUEwiLH+hQUPyTjNRo6Uxtxn6OM9j9V0OGqymDd IiEyUfPvPJL8kRBuW3gIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:OC8ZJ6QCArQ=:2MXRp0BBtOqsj43H5WNSf5 BZcsTkfhEL0r8ELgBFSie90AbFdYwT6vwKXfixXfCDu1qL1ZVFu82/R26TnHRrTYZOVgLk9VM OTkps6jG68dVi45Rk3GuB3gHL7yCRRE4nWgcoZCZ+fLMYyqUfsPRL7OXCimjYJv1piKJJQj0u VL2Wji3nCQOUMxLJ/WpL98GFQV1jXSJFSbv0oBZ6Cosq/eVOA7pi9B3bzGQ2Bssn28I0K8h4f la0lF3t+tYr4ihegn6sRve2msZf5NW8uUnim0Hr3IyNfCQE5QDQo1Iqa8QdkLaRqruHochyIn FKfP+KnZQQLjle1COo1+TXX11TZXgNpC7M+RdAeT5KhAItI+ZLGD+gYXkqQiJTMZFCX3u5Q1+ 3YYCfbJDCS2eq6Ily/u9E81jx3i/IJ+oqSi8ChtmZt6TOcONaCsPhSAh9fklx8B73OQwRQECz 2ceP7fe/wewtj8LcmbaOj3fR6aaQTBARLdj2PvBgS+8umbTrvn5URt4v1gG2RF8q6runGGiRj 1CBuwm75aWAUc/h0SPns190ypZBmfA7UdZQatmgPXz648ehaXcCRGXE1muPemf+bY+SfKYB2v XnlKW9mzdZmt/L5C9L11v3xUfEumFBw/QaHmUqtqMhtHt612wqAyWYh/qQVOYyNpW9OeYv1fE hKifG1dKcZUBW7AIPI7+RL7T0o0BF2jEiWMvcT2D+25eRb/Ow1YPQfCJGXmhzNzbn+qxQhPO9 feSEdR8iudT/+YiOhOcSAtEVcTayG7sFWEuxxazGkqB6sZ7chv5GrPZcTy/trx2d7gfU7EfBU jRvqv7c9kfjv6aMntC6h2TrIsHY52fF87MOb/UV/YpUgck/Z2I= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_062033_980403_A22CB00B X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 21, 2022 at 9:21 PM wrote: > + > +DT_MACHINE_START(GXP_DT, "HPE GXP") > + .dt_compat = gxp_board_dt_compat, > + .l2c_aux_val = 0, > + .l2c_aux_mask = 0, > +MACHINE_END Ther l2c initialization looks wrong here, where you are saying here is that all the bits of the aux register must be set to zero. I also see that you don't have a device node for the cache controller, so this is probably not actually used, but in general there should be one with the correct properties. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel