From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0FDC433E0 for ; Thu, 28 Jan 2021 16:17:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 413DE64DEF for ; Thu, 28 Jan 2021 16:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232439AbhA1QQu (ORCPT ); Thu, 28 Jan 2021 11:16:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:38274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231233AbhA1QQM (ORCPT ); Thu, 28 Jan 2021 11:16:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC2E164E07 for ; Thu, 28 Jan 2021 16:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611850531; bh=Bf8FGjgHMZZQbBqF/RyoAVCwsQFjmzA+aLlGG8ewick=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LQx+MfLkWxwe8AEdJqQ7+nZXcQ56oMK22Mf7TduQYvPyXWM2yKrgVC7jVy3P9p+8D a8yMj+pJ7MtdeovESRJ1lqyVOthIRxXPwyhvUke9FrbD0yuU4LhgFTbtC7MR9BzEWR L9d0v1KR3u43WjhocoiVfpJhdlvkiNMDc4rrUpMmyvn9fkTSIdQcG0/P1xWdtqlZ5f ZEU0eAPeRMUQuJdRTCVlaRJ3Xe7GDMvOE1Y5y1exvpWJIMxhYGf+uUWxD+qcEFIh21 jXaPK+ZrrX4s3KYdJ4AHSpQXnsQ8OxM+9Lz3L8APXKVIWDKnjtAINsixdXnpPww1fz Up7mUMin2FupA== Received: by mail-oo1-f47.google.com with SMTP id u7so1554908ooq.0 for ; Thu, 28 Jan 2021 08:15:30 -0800 (PST) X-Gm-Message-State: AOAM530Cx+kzR7CaQVxjZjdmNwDtWtZPXtCzIQGDd8zel7acpsnq79FN jdMH0Cm32NxurljP8j9su5nMFXwmWMP4YZvkMoQ= X-Google-Smtp-Source: ABdhPJztAGHg/Ija/0BNN0/p16vx3WFptcgZ+GPHCTPTPxaZHtGJVx0dTrhlcnnxi5C9+7ujlXgl3Q3hmZSUvC8sSa4= X-Received: by 2002:a4a:88c9:: with SMTP id q9mr237072ooh.26.1611850530253; Thu, 28 Jan 2021 08:15:30 -0800 (PST) MIME-Version: 1.0 References: <20210128044356.38419-1-ndesaulniers@google.com> In-Reply-To: <20210128044356.38419-1-ndesaulniers@google.com> From: Arnd Bergmann Date: Thu, 28 Jan 2021 17:15:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: kprobes: rewrite in UAL To: Nick Desaulniers Cc: Russell King , Arnd Bergmann , Ard Biesheuvel , Nathan Chancellor , Linux ARM , "linux-kernel@vger.kernel.org" , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 5:44 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > Clang's integrated assembler only accepts UAL syntax, rewrite the > instructions that were changed by RVCTv2.1. > > The document "Assembly language changes after RVCTv2.1" was very > helpful. > > This exposed a bug in Clang's integrated assembler, which hopefully will > land in clang-12, but is required to test this patch with LLVM_IAS=1. > > Link: https://developer.arm.com/documentation/dui0473/c/writing-arm-assembly-language/assembly-language-changes-after-rvctv2-1 > Link: https://github.com/ClangBuiltLinux/linux/issues/1271 > Link: https://reviews.llvm.org/D95586 > Reported-by: Arnd Bergmann > Signed-off-by: Nick Desaulniers > --- > arch/arm/probes/kprobes/test-arm.c | 288 ++++++++++++++--------------- > 1 file changed, 144 insertions(+), 144 deletions(-) This mostly works, but I see one extra case in some configurations: arch/arm/probes/kprobes/test-arm.c:453:2: error: invalid instruction, did you mean: swpb? TEST_R( "swpvsb r0, r",1,VAL1,", [sp]") ^ arch/arm/probes/kprobes/test-core.h:235:2: note: expanded from macro 'TEST_R' TEST_INSTRUCTION(code1 #reg code2) \ ^ arch/arm/probes/kprobes/test-core.h:155:17: note: expanded from macro 'TEST_INSTRUCTION' "50: nop \n\t" \ ^ :20:5: note: instantiated into assembly here 1: swpvsb r0, r1, [sp] ^~~~~~ Plus a lot of extra errors when building with CONFIG_THUMB2_KERNEL, as that uses tests in arch/arm/probes/kprobes/test-thumb.c. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECCB7C433DB for ; Thu, 28 Jan 2021 16:17:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AAC764E07 for ; Thu, 28 Jan 2021 16:17:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AAC764E07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HasyaHDw1ib4n6Ft6ON9L340jdIBs0xWBLs5gXddOGQ=; b=S3UrIImgMXfoU/FptmWWiOl87 TAv58GXW+qODSzPnGvMLPRZbnyvJLrUundCDHloqYx/hnEYKqoFI0GOLRm/ZNIPokOzi0yrdGCAil C5MKRb8QHC+IEJFdtrlNZTN1D/gMqft1YaRF9W/+P2+EtRt4tX2r3BYWOzAudYlXbaJGgUdvvdYTr fIKTc9DDOZvz/u0JXwBJba4+Y24YeLYMGWWDBH5WOxHdqaYIIbzxa4EM/lCbgKXUAxHxfTo6x6lxB lDSG2Br2oy6V2pHRqpwUwwdE5DJ8LKtC68jSiS69d1eX9bH9DAhX+WfdaKA0Kwa8lYdQJzP6iA5OH br40bGIZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l59xI-0003Wq-59; Thu, 28 Jan 2021 16:15:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l59xE-0003WX-1q for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 16:15:33 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E960864E0B for ; Thu, 28 Jan 2021 16:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611850531; bh=Bf8FGjgHMZZQbBqF/RyoAVCwsQFjmzA+aLlGG8ewick=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LQx+MfLkWxwe8AEdJqQ7+nZXcQ56oMK22Mf7TduQYvPyXWM2yKrgVC7jVy3P9p+8D a8yMj+pJ7MtdeovESRJ1lqyVOthIRxXPwyhvUke9FrbD0yuU4LhgFTbtC7MR9BzEWR L9d0v1KR3u43WjhocoiVfpJhdlvkiNMDc4rrUpMmyvn9fkTSIdQcG0/P1xWdtqlZ5f ZEU0eAPeRMUQuJdRTCVlaRJ3Xe7GDMvOE1Y5y1exvpWJIMxhYGf+uUWxD+qcEFIh21 jXaPK+ZrrX4s3KYdJ4AHSpQXnsQ8OxM+9Lz3L8APXKVIWDKnjtAINsixdXnpPww1fz Up7mUMin2FupA== Received: by mail-oo1-f47.google.com with SMTP id q6so1546362ooo.8 for ; Thu, 28 Jan 2021 08:15:30 -0800 (PST) X-Gm-Message-State: AOAM531n84yxH4YH4m152KU1jrzW9q9AuaiTKssVpYQcYOFFyJu8AexP 3OHokKYcrLamczhiuiuc6Tk3D4py0rxIJ7KF32s= X-Google-Smtp-Source: ABdhPJztAGHg/Ija/0BNN0/p16vx3WFptcgZ+GPHCTPTPxaZHtGJVx0dTrhlcnnxi5C9+7ujlXgl3Q3hmZSUvC8sSa4= X-Received: by 2002:a4a:88c9:: with SMTP id q9mr237072ooh.26.1611850530253; Thu, 28 Jan 2021 08:15:30 -0800 (PST) MIME-Version: 1.0 References: <20210128044356.38419-1-ndesaulniers@google.com> In-Reply-To: <20210128044356.38419-1-ndesaulniers@google.com> From: Arnd Bergmann Date: Thu, 28 Jan 2021 17:15:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: kprobes: rewrite in UAL To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_111532_676856_7AEEC212 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , "linux-kernel@vger.kernel.org" , Russell King , clang-built-linux , Nathan Chancellor , Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 28, 2021 at 5:44 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > Clang's integrated assembler only accepts UAL syntax, rewrite the > instructions that were changed by RVCTv2.1. > > The document "Assembly language changes after RVCTv2.1" was very > helpful. > > This exposed a bug in Clang's integrated assembler, which hopefully will > land in clang-12, but is required to test this patch with LLVM_IAS=1. > > Link: https://developer.arm.com/documentation/dui0473/c/writing-arm-assembly-language/assembly-language-changes-after-rvctv2-1 > Link: https://github.com/ClangBuiltLinux/linux/issues/1271 > Link: https://reviews.llvm.org/D95586 > Reported-by: Arnd Bergmann > Signed-off-by: Nick Desaulniers > --- > arch/arm/probes/kprobes/test-arm.c | 288 ++++++++++++++--------------- > 1 file changed, 144 insertions(+), 144 deletions(-) This mostly works, but I see one extra case in some configurations: arch/arm/probes/kprobes/test-arm.c:453:2: error: invalid instruction, did you mean: swpb? TEST_R( "swpvsb r0, r",1,VAL1,", [sp]") ^ arch/arm/probes/kprobes/test-core.h:235:2: note: expanded from macro 'TEST_R' TEST_INSTRUCTION(code1 #reg code2) \ ^ arch/arm/probes/kprobes/test-core.h:155:17: note: expanded from macro 'TEST_INSTRUCTION' "50: nop \n\t" \ ^ :20:5: note: instantiated into assembly here 1: swpvsb r0, r1, [sp] ^~~~~~ Plus a lot of extra errors when building with CONFIG_THUMB2_KERNEL, as that uses tests in arch/arm/probes/kprobes/test-thumb.c. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel