From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB157C433F5 for ; Mon, 23 May 2022 11:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235096AbiEWLnh (ORCPT ); Mon, 23 May 2022 07:43:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235074AbiEWLnf (ORCPT ); Mon, 23 May 2022 07:43:35 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06F31506DA; Mon, 23 May 2022 04:43:33 -0700 (PDT) Received: from mail-ot1-f42.google.com ([209.85.210.42]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M8yPu-1ny2QH3nh0-0066ng; Mon, 23 May 2022 13:43:32 +0200 Received: by mail-ot1-f42.google.com with SMTP id e11-20020a9d6e0b000000b0060afcbafa80so4418465otr.3; Mon, 23 May 2022 04:43:31 -0700 (PDT) X-Gm-Message-State: AOAM530VEDwel10v6P42dzQ6EV0W/ImJ2lYBPfS2Ob6jT5cD6s9b3rRk rep+Z18t15/VrxXwa2LB9oh6NBm7p3HONc7O7mM= X-Google-Smtp-Source: ABdhPJxpUCa94Kh6HQKuK56biKlb3vDJKuICvFZFBgpVEpCuri5EfGLbRA6cBhu22Na5oqGEdTcIEn9+H34udGZY6o0= X-Received: by 2002:a25:75c5:0:b0:648:dccd:e1c with SMTP id q188-20020a2575c5000000b00648dccd0e1cmr21094709ybc.452.1653299785602; Mon, 23 May 2022 02:56:25 -0700 (PDT) MIME-Version: 1.0 References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-5-tmaimon77@gmail.com> In-Reply-To: <20220522155046.260146-5-tmaimon77@gmail.com> From: Arnd Bergmann Date: Mon, 23 May 2022 11:56:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , gregkh , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , robert.hancock@calian.com, "nathan=20Neusch=C3=A4fer?=" , Lubomir Rintel , SoC Team , DTML , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Eh/qW2KznBfSE/OEBWqMPrKe6wGQVBqS5SXsFUcXmZEqSSuDHwT 72VMZAhZPMIqmh+H6lMwP5qwnaEjve33ZMwxkio1HwuhLe3vPgbpqAog7NGZVs3/TT2oIMr eLUmXk8B4w648y9F7Bu1gvCHI+0N3M/eyZ0k53KwRmUDovnzg2msAvsumZTmJi6s5Ya1U3b XfeBYBqjpRFHOFSgvC5YQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:MX/kDM8qFJQ=:CvgCpZv4G2zKoUj2z9ehBD q317uwNL18N9Picka94IqPCTYd3CmtXvDVrZ9rwdHuwNOfOByunvQOyYEl5G8UQfzgImVWQBY D2Yk6dIUB06pWAOExUyI9NYclahQzC4GJDaRKjYHAZu+iYEzlL52xKUvBX6ZZGlmZHTPGN8YX Y/5RUBanuZtJvJ3iqaVWmUtMVIHC1WfhHtvERDNttfphhBU/c3itCrYebF2hY4d41zw4KBDkT VwFMXAaE1xna2GBc+ty/P+JeIl+zwKF3spkzznm8v3zF0gKEkK96NRflU70ymEbIXkMlosfa4 /L7WeQkkTK3JvD6BDaeGnZMFBbTCwZHTtAefhAKghRvOBIPwyn+k5Xf+ohYGEMt6HOWRLJoLV sMYIWGyABqjBjoF2fu8Bhd4Z/GzoffvZlG5hEUyOiOaXt+LbNNxrFHXrn2ac34cWnfFoQKO7b G/j4oZ1S89kseAeIDBc3zq2pjCdnmeh2aT5VBDIO9EqV7QQNBsGLqHCq6Br+bSWTqOgNqFRiI GYuJRIitstsn3UA3Mg3fSmvVvA5S8zK34xsP4Ig9SNK1InEcSdsHPntJvV0R5CDVYUFHVzpLW 5TL6tb0Qt79u4jxBCx/txPyQ4vCoPHVuj6/UyE13epLYHMwsTW/lbdmg6GxFOoVpPNtKTs2Dt rCVhULYuwi2udYEMOPaNzoEEUAAzZp2AgFWVYAXgWuddQ5uBtMvy3DbQEtX8YYqNOwskHC9Tu ZESP5no+BZ2x6s/vpQD5d2oZmYZ4wWiTMydWlWTqt8UDE1ugbhNkqcKztxF/zTHf/0BIFZrRp 6kpLar02NBXVZfofCQH0YywcWqyCSP+dynb/W3vwBXGDi7cXGOCLkfF8ak/RImCcA+meyBaWP epvJo17x6SJ9CA+eTjtQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 22, 2022 at 5:50 PM Tomer Maimon wrote: > +++ b/drivers/tty/serial/8250/8250_of.c > @@ -333,6 +333,7 @@ static const struct of_device_id of_platform_serial_table[] = { > { .compatible = "ti,da830-uart", .data = (void *)PORT_DA830, }, > { .compatible = "nuvoton,wpcm450-uart", .data = (void *)PORT_NPCM, }, > { .compatible = "nuvoton,npcm750-uart", .data = (void *)PORT_NPCM, }, > + { .compatible = "nuvoton,npcm845-uart", .data = (void *)PORT_NPCM, }, > { /* end of list */ }, If these are compatible devices, it's usually easier to claim compatibility with both the specific chip and the older model as a fallback, to avoid driver changes. This seems to apply to the timer and watchdog devices as well. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BA7AC433EF for ; Mon, 23 May 2022 12:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WSINCBFKfmeI2Ha293JSR8qnr0MUhoJOO9ktV7R01OA=; b=ib92gxMnz/ghcL 29N2cy21oFhtyp8jJWGTvixispzv2uuJVr0TWqG6bJ6t2T+9w/6gmYpKPdIzI5b/CCLRQeth4ki3i /YvECXFEhhmE2Wwlot1ZJWPgQGidbuJO1W474mI490WEttkTduw/IXek6uvmtx/5fGW0Dz1Xi4zOJ XQu8PoJyqe9SouiDXeeTCbyjoQp6McE/Qm7CoGdNdmfBSuxAemcH68hUZinTnxV/ADTXQ9b7pJC5q snxliKj0p08HnSqAPFUcbl1OP7j1VW8MTWutLLaju2UTzSV/eB8omiLnLCXq/tcqcIuXxd0JkoUjX O1QPL3sN6T9xpCn8cK+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt7PP-004Fyn-OD; Mon, 23 May 2022 12:43:39 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt7PM-004FxI-SO for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 12:43:38 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mj8iJ-1nP1qT1x6z-00f9jh for ; Mon, 23 May 2022 14:43:32 +0200 Received: by mail-ot1-f52.google.com with SMTP id t14-20020a9d66ce000000b0060af9ed4b87so4867633otm.9 for ; Mon, 23 May 2022 05:43:29 -0700 (PDT) X-Gm-Message-State: AOAM533gA7hmtjwEqK2IKO2HQnvlU5QK9uU9Tj03atHgUeg7W07EihV4 Vkz0usxhMiPFBzQIkRmj0AIFB309U6uHPGUGSws= X-Google-Smtp-Source: ABdhPJxpUCa94Kh6HQKuK56biKlb3vDJKuICvFZFBgpVEpCuri5EfGLbRA6cBhu22Na5oqGEdTcIEn9+H34udGZY6o0= X-Received: by 2002:a25:75c5:0:b0:648:dccd:e1c with SMTP id q188-20020a2575c5000000b00648dccd0e1cmr21094709ybc.452.1653299785602; Mon, 23 May 2022 02:56:25 -0700 (PDT) MIME-Version: 1.0 References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-5-tmaimon77@gmail.com> In-Reply-To: <20220522155046.260146-5-tmaimon77@gmail.com> From: Arnd Bergmann Date: Mon, 23 May 2022 11:56:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , gregkh , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , robert.hancock@calian.com, "nathan=20Neusch=C3=A4fer?=" , Lubomir Rintel , SoC Team , DTML , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM X-Provags-ID: V03:K1:QjDAcWDUvGLy2B7ZV1NS81LhPDINtMxGGI+JxCvaX6Hr8U5DUUA bfMey3FRYsMWad814VhUnkt5mryluNQEy5TrcM/QmAg/Y/Xx12zUOws43r7tNucgH5KGbJJ 3VjvcA9CYwAUH7W0zp+61BXYJT5woYmzg7wfm3x+EsGl7PygK0QNl3DX6CYvrAi+Z5CMCzy OhIFUPNdzmIA1zYGhOoPA== X-UI-Out-Filterresults: notjunk:1;V03:K0:t4KFiNatkVY=:yssI67cNYWnGCA8hCXsK1g TOym4Xr3GVpKl8Y2YvsKvrn2aXxi4hSzi7ZICvRjtuLGN8+zEX+k+aYiRSRmsXHOClJi+4nEg QhhQGOFat6bIT3hdIEBlztz0lF75x2rvWZtN0mwsYEBSxUXbfkJwRFy/HKsASPH1OZerYc+mL yFt9AJ8dz4/qMWnfz9td5J1fSC/Wmi/Mj+VPEYW11qPaVIWUX6ySxk68LEKjVJY0F/PmfdFxB zu1qJ2dkSdr1z8EfMU0cy620HmG/wJFDRNgTP5B6oLhMb64enPZs0XpTQqM9jVdrDvx3s2snI nStWFwFn2UGom7cHt29GnfrgZ459vbLGoF8U7LRaFU8PQoJSUqPNcskZ+/oS8g9r67LZxQDZ2 +y8TbrOszChP2xqj+yL/YR3xfGaOboTtD5cKKidjZ+IdF1I4pJV0aglcjmlsaLH89qZgkNnwO 3c8JKFs65U4GI3UgJsUgPccF8zkOpP8HpN6c3P27Q/24c1RYNzbm5x91IXkieUet2Ng6RW8+R NvvyHv7Sr67A6wsvs7DDIrNtf5VVw8bWJfJyzGWoIm2EhphlQb+BGEZF1Ef8BIlLJBzuxTuWB t8py83rSH+sK+FPtyChh13O0mF9x3VuR6udydSRC6Nm+wpR1vCwAT3CATDukJ4209E66Pay0m Itcoo36huLx9C0GTMkWujbBQXII3KSzAw9xn+81xOsoZlC1kOxHE/X1+olVdShApfYp2rtQLD 1rCwScSQi61AoK5WSO1+eI0nRsXHI9oszeefN87tv2RI7H6uU0i4siy0aBw7T9R6+AqOH7CH3 c+AT8ySDffWiCaXy+VWXcB0ula8lMoXCfWBI5tT1Twne/H8zNOnLTlEQGsMEv+Co0c7vSSbck 1clLp1TF5KIlDhneIDiA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_054337_244613_58DE1560 X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 22, 2022 at 5:50 PM Tomer Maimon wrote: > +++ b/drivers/tty/serial/8250/8250_of.c > @@ -333,6 +333,7 @@ static const struct of_device_id of_platform_serial_table[] = { > { .compatible = "ti,da830-uart", .data = (void *)PORT_DA830, }, > { .compatible = "nuvoton,wpcm450-uart", .data = (void *)PORT_NPCM, }, > { .compatible = "nuvoton,npcm750-uart", .data = (void *)PORT_NPCM, }, > + { .compatible = "nuvoton,npcm845-uart", .data = (void *)PORT_NPCM, }, > { /* end of list */ }, If these are compatible devices, it's usually easier to claim compatibility with both the specific chip and the older model as a fallback, to avoid driver changes. This seems to apply to the timer and watchdog devices as well. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel