From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DDBC433F5 for ; Wed, 1 Jun 2022 07:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350455AbiFAH7s (ORCPT ); Wed, 1 Jun 2022 03:59:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350449AbiFAH7r (ORCPT ); Wed, 1 Jun 2022 03:59:47 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62BF58B08C; Wed, 1 Jun 2022 00:59:44 -0700 (PDT) Received: from mail-yb1-f172.google.com ([209.85.219.172]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MlfCm-1nVXHp0VwQ-00ioNe; Wed, 01 Jun 2022 09:59:43 +0200 Received: by mail-yb1-f172.google.com with SMTP id z186so1533387ybz.3; Wed, 01 Jun 2022 00:59:42 -0700 (PDT) X-Gm-Message-State: AOAM533uDDlKAiJvtiPnLfcWiu7XEv8ZMgcCb5XiR8Yw8nM1+6e1Uh2D XeazRkhtHhMMCDYqqSCTS2l31eQ3M66h8PL6t5c= X-Google-Smtp-Source: ABdhPJzoWPaCkT1VZk6Y6xdPwsZG7YGq4YdyqYdk9hnpO8XDD4fVWG6RMcr3k33Ge326LgxfboYwcTuMLxQdt36KBvI= X-Received: by 2002:a25:4f0a:0:b0:64f:6a76:3d8f with SMTP id d10-20020a254f0a000000b0064f6a763d8fmr52296373ybb.134.1654070381814; Wed, 01 Jun 2022 00:59:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Wed, 1 Jun 2022 09:59:24 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Yegor Yefremov Cc: Arnd Bergmann , Ard Biesheuvel , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:b9ASgxEDgqZ8ii6ib33MpCJCchT4gApGIl6hJpXQkZxL19nTNn5 qBv1LR5oi0gJ3Oatwh5ZRa7C7V5IwQ8VKdIy+LcmmrGJSVLw3Cfy4nCGcrUftkMgowZhZw7 vLWbPZZSFDdWnS3HrmYmFWDs7WdplVvfKBoy3rjw1JoUQoEzO0gOMmT0XNWn6BnYmkvadGN x8DwSdXK6uQDo9oJBNtCQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:J7AHqQzNyl8=:4qgbc1LXw0qHAMXwqp1VbV xtBKmdy//u7/kvw3cYUGC/RnoVNarlY9gy91VSl94iO5uLjZrrYaRgjq6NvU41RDnVNozbBR9 LjWB4A2hWTJXgxx9d6NBNJt/0vIUAx4hFFZyo36uR4oKWX9KqHvT8zZNk2d595T1bgiDoX/ID a3fsicIYSroE48A1fAvWyIHwEj2XBVEMa3XgDFnNiIjx7lqUnWRyasBP867UUx3Twa8HoimOU ULVtX514v5/95Iy1tdsrl5GaPpxFpPwm/C1KMoNQ/0oKLQ8fi4ahz+sULaJFWK0oZ9fxOpVM2 lcfPVep4yFwqSZpT+JPRT34V5ciJKs7f+5ukDiYF7jLgvF6ngsxyffCAiTszHuVnUZ4n7859e KVI1Y06bz7ZP1bQAsFCqEOzddQgqfHKmlFBPnsT5m+TuVjrV/v/Fz72I0Q9ypS4OBQiI4wK8a RmNvUGTIm+Pqxb+FVNdHpCZ3LMCMerF/56qQuB7e7HLZIYUVStcl1X87KnqgnmwW3bvYeLKYE +LfSY+fmXecq9RxDgDwYBQtIbgehKipbnJ5CdOgjOZfEChqJ7kUMFWZTept081JHQeiiEDZPB ajIkbaOgBGdljFofwhNOGjqPBN/FD7zplBsyhJOxI/O364/XTvkvgOA31dAhQ6TmyDF8K5gRM o2Hp3pA/Gl5fHGAGr5GxYYOn4Hy9buaq4yvWjsrNVesWnEiNVFh+dg6/74y1BnvFYP7jBJvHJ rSggpRxIBnHa4IAtoKPJF+ico5Yr7nyhUVWgTedbEK7OmdS5ES9Mk3DcL5wkG538je5DdT7cb D2XdB2fiVx6pazJTFUvk3HcXwV0+9ENdw3gNm2XgaE5p1FwJRXmLEugnDnpKhfc7d9hUfU9gc W2HEtEzaFxzYTqG65/vw== Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, Jun 1, 2022 at 9:36 AM Yegor Yefremov wrote: > On Tue, May 31, 2022 at 5:23 PM Arnd Bergmann wrote: > > I've pushed a modified branch now, with that fix on the broken commit, > > and another change to make CONFIG_IRQSTACKS user-selectable rather > > than always enabled. That should tell us if the problem is in the SMP > > patching or in the irqstacks. > > > > Can you test the top of this branch with CONFIG_IRQSTACKS disabled, > > and (if that still stalls) retest the fixed commit f0191ea5c2e5 ("[PART 1] > > ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems")? > > 1. the top of this branch with CONFIG_IRQSTACKS disabled stalls > 2. f0191ea5c2e5 with the same config - not Ok, perfect, that does narrow down the problem quite a bit: The final patch has seven changes, all of which can be done individually because in each case the simplified version in f0191ea5c2e5 is meant to run the exact same instructions as the version after the change, when running on a uniprocessor machine such as your am335x. You have already shown earlier that the get_current() and __my_cpu_offset() functions are not to blame here, as reverting only those does not change the behavior. This leaves the is_smp() check in set_current(), and the four macros in . I don't see anything obviously wrong with any of those five, but I would bet on the macros here. Can you try bisecting into this commit, maybe reverting the changes to set_current and get_current first, and then narrowing it down to (hopefully) a single macro that causes the problem? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D3FAC433F5 for ; Wed, 1 Jun 2022 08:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hDa12hQ6wltmbFypgZZfdS3U6kE7kfyW2zkSHHyWoPI=; b=CI7ZZgbm+RJUND y8f1/LUzjFiPMk3j3PA3jhGGeEQsTVN3iX/ZTmP7fHBG7N5RCc/WUU17owjGfvfhwcUUkPMUB4dL4 A/kWLgTPBZcGo/430VbPWlcA+pqg7CIUxiheS34i9E8XJ9i8uRv1lsY7ZgeLdDd4Njedvy+SSa0Tk txnUKQ9RRXl+Z2TnvjfVqlNQY36a7Cbut/pNjsm7evBPAA2BbV7VYphv8m3duV2zoICsxWzT+6qxF jWo6E/jArRLN4fmPZtF7iZuVgCc3+FaKA+2H6dsi+oFEd3mwRooUEHeVF4euAKAuLtjlydZwmeahs qBgdkMoBVZhFEr+Wo+NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJGw-00EVWm-Ip; Wed, 01 Jun 2022 08:00:06 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJGu-00EVVv-HJ for linux-arm-kernel@bombadil.infradead.org; Wed, 01 Jun 2022 08:00:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Cc:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PN5zCY3jsDkjnIBqNOk8fqdIUqB7s4NTRijZX8mzMOg=; b=fUHtwNvd4okTxBrCU06xxm8Ggx X3UTseqcoaiXS+Qi4e7FtDse/akipNRImRI1Jxcb2VP/s7EOn9NuSjKdAMi+OL6H9v9z3s8/XQf6f 7xv8UD5OKiVP1kyJrYRG79emr8u/4A6vSF8D7n3Xmu/ONTVaB/735h8Qwx1/0qNJkS/Kg68CjBjs7 eNvPFhDr8g9n8E2JtuCTStokTe/8SaI/woZgP8eq17OpBD9xD76bD+d9vH52oFGPbzbLIEcNfgzpl ed2EHuh0UJr0SOb1OdGCKeV25JzOKbOYJQ8/or9GhCr4QfVf2duqmLWpfSn/tZh2RyciJ+XOVZWzM V7zQL3mA==; Received: from mout.kundenserver.de ([217.72.192.74]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJGn-003i9s-UW for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 08:00:00 +0000 Received: from mail-yb1-f170.google.com ([209.85.219.170]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MryKp-1nQHxj4BZl-00o1ZV for ; Wed, 01 Jun 2022 09:59:43 +0200 Received: by mail-yb1-f170.google.com with SMTP id w2so1507864ybi.7 for ; Wed, 01 Jun 2022 00:59:42 -0700 (PDT) X-Gm-Message-State: AOAM53384WIonVMXMESuWMO8Fq+6mA1zDz14wlgCIyMJFJHeFnvboFwr rJOnY6FxsFr6bi8KI5pq6xEqCd0Fe4rPbNz+ljE= X-Google-Smtp-Source: ABdhPJzoWPaCkT1VZk6Y6xdPwsZG7YGq4YdyqYdk9hnpO8XDD4fVWG6RMcr3k33Ge326LgxfboYwcTuMLxQdt36KBvI= X-Received: by 2002:a25:4f0a:0:b0:64f:6a76:3d8f with SMTP id d10-20020a254f0a000000b0064f6a763d8fmr52296373ybb.134.1654070381814; Wed, 01 Jun 2022 00:59:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Wed, 1 Jun 2022 09:59:24 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Yegor Yefremov Cc: Arnd Bergmann , Ard Biesheuvel , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM X-Provags-ID: V03:K1:6YU4ttTOm7Y3lEAiCd8cm8VvaqMTghGFp0lmtxIKPsLkhk+iDiD tQufwIYyBouizaIWUJ/jDoiGIhljY8skgF8vbWicuUBjN2O/Tej/DU7b5ClT63blkf2p5JI Nzzys2OLrK8cIsliQ38s54Neq/Bz02WXnvwawzP7VPRb3zpuKpkKd+IUj7QDaBQ7e5hVSJH kEcrzmCT+5WAPXobECUzw== X-UI-Out-Filterresults: notjunk:1;V03:K0:CSQkTZt8SB4=:gjsqZr/+Ot8HVtkTJzURUG Y53aPR1WOxvRk0cDugT8pZSvs+H9hAV4oqSYP6x9bVgRijFzjjskRNQ1eYakBQnbbMHGZi97m OemhUdXxX4TpKobVXnyAEGFRFkklN3GoNcjWDCg7dQuv/38d72q8Ayxj03Cru9OYsQTD7f8U9 Pw15TN5ZyOYbW8q3RteydOIicyJMnxlOSO1N70dWyrF0JFQo0LJi0iyXkPIjtXjDRmJ+g/rqT iPpWdfgLBPXSeyUJYdeeQrP3V2rhb8Mw5wvKqVqVpP6u8Xb/yi+zhTUxPpu5UKlXj+PtHrSzt YAMRf/j2VrATezmU1XdNfxNJSUpCI1es1EF0spSAKjgbu8a10w0pS3q0dr0U4+4BSvAa6hP6T tSY7ISF+25et/zZorjREgpHU0iYAXcfXFxPUp1Z1qMYfxjULhjB5Q1qBu0vfsjokY1E7htC95 hnx0XY0DXTcY9yYLXs/eMpUTlUVyj/vFK6325+XHjFFk40jqBZnZ4doQdasiqgR7WrQ88MOhn YZCdnH6EGYudQdZETPBe3B/TAZvsW+NcwXvlUMlkdkK3ggLL1nWwmfFphUMQFjapHWHNK6FI+ RfiZU+lTovGGGVAiW6VkQaSjgcnK+7YNd0DmvKHua9iecix3AaqVDD55r8pmWXDSSo7qvQC7m 0uSi99Akuq5+Fnn2BiK+1GBxQVqNdbs6CNcMuFXY++AV4srwMNBnou8EgxHMOo2f2cDYvvrmb FHnmnlfYI9ZL3BqjAl8oa4QEzGqAO1ppu3LISA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_085959_124808_060FEBDB X-CRM114-Status: GOOD ( 21.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 1, 2022 at 9:36 AM Yegor Yefremov wrote: > On Tue, May 31, 2022 at 5:23 PM Arnd Bergmann wrote: > > I've pushed a modified branch now, with that fix on the broken commit, > > and another change to make CONFIG_IRQSTACKS user-selectable rather > > than always enabled. That should tell us if the problem is in the SMP > > patching or in the irqstacks. > > > > Can you test the top of this branch with CONFIG_IRQSTACKS disabled, > > and (if that still stalls) retest the fixed commit f0191ea5c2e5 ("[PART 1] > > ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems")? > > 1. the top of this branch with CONFIG_IRQSTACKS disabled stalls > 2. f0191ea5c2e5 with the same config - not Ok, perfect, that does narrow down the problem quite a bit: The final patch has seven changes, all of which can be done individually because in each case the simplified version in f0191ea5c2e5 is meant to run the exact same instructions as the version after the change, when running on a uniprocessor machine such as your am335x. You have already shown earlier that the get_current() and __my_cpu_offset() functions are not to blame here, as reverting only those does not change the behavior. This leaves the is_smp() check in set_current(), and the four macros in . I don't see anything obviously wrong with any of those five, but I would bet on the macros here. Can you try bisecting into this commit, maybe reverting the changes to set_current and get_current first, and then narrowing it down to (hopefully) a single macro that causes the problem? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel