From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5835FC433E0 for ; Wed, 8 Jul 2020 20:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F69F2065D for ; Wed, 8 Jul 2020 20:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726142AbgGHUkQ (ORCPT ); Wed, 8 Jul 2020 16:40:16 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:49249 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgGHUkQ (ORCPT ); Wed, 8 Jul 2020 16:40:16 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1M2gt5-1ju50T3qcZ-004A83 for ; Wed, 08 Jul 2020 22:40:15 +0200 Received: by mail-qt1-f181.google.com with SMTP id o38so35677203qtf.6 for ; Wed, 08 Jul 2020 13:40:14 -0700 (PDT) X-Gm-Message-State: AOAM5324GAEK2H2XCcZP1DPEmZD/gL/bRzJUDhoS6DB7JL9ftC8USyj3 Ulj7a90X3SsnByClmaa/WoQOlLmJOnMYMoWIh6M= X-Google-Smtp-Source: ABdhPJxVshF+U3r0gn5rmOST+fkT/QJKFu6gn6v4QeGU1ba/2/kikiYWoKzhATrXM/rm062mwwxkFjzR8eqJ/4aZ2s0= X-Received: by 2002:ac8:4ccb:: with SMTP id l11mr60572390qtv.18.1594240813840; Wed, 08 Jul 2020 13:40:13 -0700 (PDT) MIME-Version: 1.0 References: <20200708122248.52771-1-cristian.marussi@arm.com> <20200708122248.52771-4-cristian.marussi@arm.com> In-Reply-To: <20200708122248.52771-4-cristian.marussi@arm.com> From: Arnd Bergmann Date: Wed, 8 Jul 2020 22:39:57 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] firmware: arm_scmi: Remove fixed size typing from event reports To: Cristian Marussi Cc: "linux-kernel@vger.kernel.org" , Linux ARM , Sudeep Holla Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:0MjAE0t/nh+RyghLxR/wjXHTqkQJSIGRcLNs9/H4bZI95qLvYd/ hdWyisNxffDD+dkEvFFNZekRx4/lqY61C3BMfgJFYFBlcodPpckwriTSL7uYS/ZWta+vUGa C3D3n13MkjEAdtTVcKsUZ7aG7nwWt5ZkqPDTpJyCvyAzTtzC8KhFLQnB+PcTxOUr6HbmH4H IcQLUVbnihoZqj1ODQeUA== X-UI-Out-Filterresults: notjunk:1;V03:K0:/oZYBYYJcms=:HH6JwJOM2NXdGts46aohGQ 48km0dpc1OtSPAJzhXnaWwdhTVc/0XwUCDMsOcs9AP+X2RU0zplz4q4QiKI8m6mNKFJ1sYTwS 1CWjRVXUAzyDgkyc4LjooHQ74+ODJ7ak+Tsr1/QizlquyYRivnhZTn4GuGbTrQN2cs1dFcSuR Z4jcMI5FwCoD7eqk6rV86JPbfViI+1PKZnnICqXKLzojmBIy6BIl+yrY59P3pkhx865zuFRav wXjS2kVNwQfS7F0ulYgv2r1QG+zAsFdFAYurdKioXut2VJ9MpWN3Nv9TI6QoPZxMOqKE15Vk8 bnxksMhG/Jci8dkQwpJxD79SD3F12BPOCmE6t4HDpaMLfOW/TO3VcvyqZTkuZ3l0pH2kdlpBA ntvPzh0ihjbPk/Mh/4+3T85/JRKc/7/qjC75vbdDcCYS/WFfLRboUohViXmcwqjSeQ3l2zDvt OgwFA9VqcU2P68QKQ+17BB35BsBepLVQc4H4MnukJITLlc6TvjG6IMeHNTWzND6g2sDXdv0bt lAhSlpp5hT8mfTkVh9Eea/WEDec8bZvl+Jkkt3uVyAxlK9fnXvVBjcIkeyweRF46Y0qvmxuX7 olx92DBvs7aGOM3ZPqwPxpagFFB2TZAMrtGazvAl+u+mv6Bx8idEnEsRD9Tqk/kl+VjCVKct8 U+INDmlEIyvBkKaP04wz+sZjN1wRWuRQSlD0aB6HUbvwmUM72iWdRV5DJAjovPD4qrFsPyP89 TN3Jn+PJ+hp35BlQnhREUNDwDnPrxuYHtkPYdYmDnOMWvKaquFIV8Nikjn9P8aRGNDMFjTsUV Eq2xCkIn8uCrQnC1Q/5sxceklm/BOoS0lVsQJNpAjQ9clTQDePyDKuGWr7r6h1yLCyv+pqS Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 8, 2020 at 2:25 PM Cristian Marussi wrote: > > Event reports are used to convey information describing events to the > registered user-callbacks: they are necessarily derived from the underlying > raw SCMI events' messages but they are not meant to expose or directly > mirror any of those messages data layout, which belong to the protocol > layer. > > Using fixed size fields mirroring messages structure is at odd with this: > get rid of them using more generic, equivalent, typing. > > Signed-off-by: Cristian Marussi Ok, I was expecting you would go with fixed-size structures without implied padding, but either way makes it more consistent, so this version is good, too. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C20D7C433E0 for ; Wed, 8 Jul 2020 20:47:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9659420708 for ; Wed, 8 Jul 2020 20:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xqaNMiD/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9659420708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WfJtG5fBuySI8XgwoEGywfWVcd2Vcu0HL/AdHitWKsg=; b=xqaNMiD/j53u9LTV99ds+ffAU gu7+MQZGSKMICBNCLVaj9oULC0rvcX8Rhw3VvLXuLrSOq5+y8CF8lgBBs99l3YbrwYacVpgdDPSIc NppVrnsguVk9rQohMpEXL0/7rutwhIK7XaFKU61FUuYtfNF59cmGcIFhPTWdb1s228YHbqJNMBp2V X2BEGSl+Kxi89y5LAJLeb/0F3+oOIRsKEg70cShP05sQ4L+W2NlAPsFryvBwEpWiHMFOS0rDT1mmI 5yGsvA1Wyms2+bDKPxDnwP64w1FBvmgBSf6iIT9nzUMz4Bg773oiUx2q08O2FYeiqJTwYNtv37Dpf Z+6auklag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtGxT-00025z-4A; Wed, 08 Jul 2020 20:46:23 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtGxP-00025W-V6 for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 20:46:20 +0000 Received: from mail-qt1-f178.google.com ([209.85.160.178]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MEVFi-1k854M0gEk-00FwzI for ; Wed, 08 Jul 2020 22:46:16 +0200 Received: by mail-qt1-f178.google.com with SMTP id w34so33858qte.1 for ; Wed, 08 Jul 2020 13:46:14 -0700 (PDT) X-Gm-Message-State: AOAM533ckHSxTo5GhQ+rWysugMBEC4nsJmb4KOjwyXFSNMZ11lss+qvB L+yWYHLkbWuTbVpExY2PhgfWnn8gC3NeH15md54= X-Google-Smtp-Source: ABdhPJxVshF+U3r0gn5rmOST+fkT/QJKFu6gn6v4QeGU1ba/2/kikiYWoKzhATrXM/rm062mwwxkFjzR8eqJ/4aZ2s0= X-Received: by 2002:ac8:4ccb:: with SMTP id l11mr60572390qtv.18.1594240813840; Wed, 08 Jul 2020 13:40:13 -0700 (PDT) MIME-Version: 1.0 References: <20200708122248.52771-1-cristian.marussi@arm.com> <20200708122248.52771-4-cristian.marussi@arm.com> In-Reply-To: <20200708122248.52771-4-cristian.marussi@arm.com> From: Arnd Bergmann Date: Wed, 8 Jul 2020 22:39:57 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] firmware: arm_scmi: Remove fixed size typing from event reports To: Cristian Marussi X-Provags-ID: V03:K1:DrVvm7632vwEADkpjr6K+AUUto8a9bQlZKd2XdUFajR8sLYVYIr ukDUxicDts2zys1xl9PPvcrq8CuGIXKnnfwGHO3qtXWclRJD2C3M5bVZhUytL8/a0Uht0Yv EIzHtcojVb4HejFtyeg/G6B0TjfDJFcndW89DSUhGAU6/2os+QJd8WIe7kXWi+5nYpgf4OA RFpuaJAumvhXkjAUhQ2zg== X-UI-Out-Filterresults: notjunk:1;V03:K0:X9TeE4rBZUA=:nbuFxIggv3ilbBEgmQqL6H 00F1AXbl1NunBDnDNdANpIzgk1hqmJfQKFFMmxkh/s5xxRtrmGBO0jIwM8mvIFTMxbtrMpKjf FxhR5/65SuoNmupD1sXYGR22eeu/bdjcGSGQqgnQdn1Gwb5opKrDbD7rgYn8owOezjqxYAMap vzBzuzFsXmXo/w27iLNcwvFy4dw6TkbG0CuBz1olY1tblkVWvN1kmmrtwbbvQFYgzqLkRfc2x L1U9X/9d/WVLU7lrw9jqaR7EqSSgR8G/ks48wiuZsnNd3fT2F8XbafISZ3Hj3sNpw1h33k3zB 4Eqg2+7NdHda+1ai3NSc3ppDIc+9pODCoZ9UcgCQ4aQ6J9yjkL0uM0mOhm1SmyZcO0TQNCOLj 6U1DoAXwOC/vnKpjOQjQ4eEyTxPvMm2KCf3BGc2b/mzIoT4gygjxj9a93LnjYGoHTl+dGbKJ3 eB7ISKaC6Y4cSj7FBYcnLV/t/AcsnRS8BOnwJADpWa1Rl9sAvtYi1YLrDg338TJU7eTR5KGZz cLtNDGgoreQ2HnFgEwc/lOUH9BL+h2mySJbUtoD3tNGLItAxjh7Dj+FtjVGLgZ31ZoITvjf0+ QQ4sV7YRCwoamTyjcYlFpx8NrdqLGDW5FTwI2mGBtrgSmdINtpcO/ck6EuiQYJSZsEbKO6dGQ boceL4tmgUWu6jj98Ngkam13+Rh4UKdZ5uJHLjk/PTaEx65mj3ZskCGkycMNzzevOPQbF1hNN cg+N+Jl0xfz+FGp6h6WvwAczqJ/n3/ijWZX2OgUSX4bg7BMiyzexw311zvQVITcQF17+pAp5u X8vZxdLxlAiA2gl9Pp2PaUrKFXUscuuzYM5f4t2u1YP/MeYnmiKkHJjIyNgrFLlGGnO4Fv0+e Dh4sETfJOFiK31D8bZx11AUyoS27dVkAplfzEOFJ7n/GfEWOnsZdItnr97jzNTlH5pcxAH2US WIjX1tixk4zbCJaBUEx+5WZQO7UA6dzJ0eAobEJywLtUCnNMpEI44 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_164620_221122_7B703BBB X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Linux ARM , Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 8, 2020 at 2:25 PM Cristian Marussi wrote: > > Event reports are used to convey information describing events to the > registered user-callbacks: they are necessarily derived from the underlying > raw SCMI events' messages but they are not meant to expose or directly > mirror any of those messages data layout, which belong to the protocol > layer. > > Using fixed size fields mirroring messages structure is at odd with this: > get rid of them using more generic, equivalent, typing. > > Signed-off-by: Cristian Marussi Ok, I was expecting you would go with fixed-size structures without implied padding, but either way makes it more consistent, so this version is good, too. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel