From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED42DC433DB for ; Thu, 4 Mar 2021 09:37:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDECB64E12 for ; Thu, 4 Mar 2021 09:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237651AbhCDJhD (ORCPT ); Thu, 4 Mar 2021 04:37:03 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:48449 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237653AbhCDJgo (ORCPT ); Thu, 4 Mar 2021 04:36:44 -0500 Received: from mail-ot1-f51.google.com ([209.85.210.51]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N30VJ-1llby93tLJ-013P6q; Thu, 04 Mar 2021 10:34:09 +0100 Received: by mail-ot1-f51.google.com with SMTP id v12so25508865ott.10; Thu, 04 Mar 2021 01:34:08 -0800 (PST) X-Gm-Message-State: AOAM531K6U4Pz/T2CG3GZQplToTbh/nZo/W2EWUFwx7iNrwMhobKsdkZ +nIq13nIr7vthMybEJHBToovOmPv2S6Tj5zW9+0= X-Google-Smtp-Source: ABdhPJzdWUmRHp4/lKLXv6+q2Thn0Sc0nr1QD99ZxxURYeZleIgI699G+WxW+sTjwSsYr4dfIETXbVshldOB36R2nMg= X-Received: by 2002:a9d:6b8b:: with SMTP id b11mr2798119otq.210.1614850447259; Thu, 04 Mar 2021 01:34:07 -0800 (PST) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-5-brad@pensando.io> In-Reply-To: <20210304034141.7062-5-brad@pensando.io> From: Arnd Bergmann Date: Thu, 4 Mar 2021 10:33:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/8] spidev: Add Pensando CPLD compatible To: Brad Larson Cc: Linux ARM , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , DTML , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:seRvg0yhGSVe9OKFJx/AdzC6Z6J8W7Yhhtv/pNsPzHNCOpa2R8R pTnmKCxJLaq3piXSLbEnZz7mAd0jrIaqYbktGLZIaFX8EnXHi9blsl854kTWlCfaAxnCjrq jmmA1KZ55lEIR4Vrmynv6H9fFTgvgj2eecHwhMXNEvpANqv9IDV2IhqodpAFs8kKNV+EmPx inae/8YJeTb6T6VIgX+tQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:3JkiklS7VkA=:JoShOBsLn/zRSJOhd3kGMH +W+e8xEZ/rGtTFkcsHuoCYTRpHai47x2AgPTZ4q/VFJMsgIDfJwhBGaZAI8ZqSFGfmIh+drD7 xQmkCMKOeMyVNELSR6vYcr9P39qsaWDQu2WsPumzan5UNnRmBCdiIK9XswCe4I5yqhhBD0KTk mEauzZ7k398LG7O6CByBeUfFJEPqiRB8v2mLrkS9jkPE1dw9ZFVWw6t+nnE8RqNh9fROLcwgl +J/7LsPASVnJNecoHsCLv3m3YkYcFWZldgA7BgcsQDlyv5cir77p6/qCn2ZpsFLeTlHoif32m BQTbgf55gNmWDhrs0YmEatIAPtCRuMvBxQ2br6PllQWwqdMPzrIH0l5a1GJSQ3B/AILVg+6rD nXmLsaNzvY2oRZIDK8trqA+GwfKoXiPLdOC9zUlouOxX8ymWOLExvXmVGiFJt6YDdPpmy+7Iu LW5yk53WfbN+UbiHTyQoLZXvsGAAWmWQF6wmamqhkJNwnEinWTDoOypW0nOnyIQ/pBNRv2f/l D5hYetov2nd1exf9wJR/vM1Qi3vFPgSxROGjmxoQurZSBwnS7OKR+TyRsgqXJzpwg== Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Mar 4, 2021 at 4:41 AM Brad Larson wrote: > > Pensando Elba SoC platforms have a SPI connected CPLD > for platform management. > > Signed-off-by: Brad Larson > --- > drivers/spi/spidev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c > index 8cb4d923aeaa..8b285852ce82 100644 > --- a/drivers/spi/spidev.c > +++ b/drivers/spi/spidev.c > @@ -683,6 +683,7 @@ static const struct of_device_id spidev_dt_ids[] = { > { .compatible = "dh,dhcom-board" }, > { .compatible = "menlo,m53cpld" }, > { .compatible = "cisco,spi-petra" }, > + { .compatible = "pensando,cpld" }, > {}, > }; This does not seem appropriate, I think a platform management driver should have a proper kernel abstraction instead of a user passthrough. As mentioned elsewhere, it also needs to be way more specific. If this is a programmable block, the compatible string might in fact need to contain both a board identifier and a revision number for the programmable logic, to ensure that the driver knows how to talk to it. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221BFC433DB for ; Thu, 4 Mar 2021 09:38:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B37A764F20 for ; Thu, 4 Mar 2021 09:38:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B37A764F20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mu+9SrfEtdIHRzmNephOys5xGjrKMWkz7l5CfZI/O2M=; b=RoXkldbxmgqMPWQ/sYTACNj+x 6EeTLxXpcojJlmGYE/Z3Y5D7sBa9JviQ56Px63is4Ldc+BTIaaZXJHegzmSEYn2guXY5tH7XBBFhX +6oTTJjtgpmOr9dRw+D2ZTCfauSq0dLle+qxs3eZ1sQNnaXbP9YC3YIu3UCbCZW8kkUsJtmUjOS8m z3+TkHJ9oDzn2secZnkpufcFm+7Ml/etlA3OB7zwYz1ysZH3frrVcSyvV6n3BxX6ikAXMi4x+xWsL Oc3PUGFlUkasRu/P8NmsNbh6klEFby1zzeFK8hR5dxxmPB3znYlFuraT6WK0lmsMhemHTMw/ldQks fgkUvOfVQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHkP8-008Hlx-3D; Thu, 04 Mar 2021 09:36:22 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHkN2-008Hdr-GC for linux-arm-kernel@lists.infradead.org; Thu, 04 Mar 2021 09:34:25 +0000 Received: from mail-ot1-f47.google.com ([209.85.210.47]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N2VKr-1lmACU1IuV-013zcg for ; Thu, 04 Mar 2021 10:34:09 +0100 Received: by mail-ot1-f47.google.com with SMTP id j8so1175897otc.0 for ; Thu, 04 Mar 2021 01:34:08 -0800 (PST) X-Gm-Message-State: AOAM532l6ILDp9ymlj73Vhxko3Z1847RZLeQO7bAI/HnhXKmKwRKvO9b D85DLYb+RT0femHpNSWbp3azcc4/KxiGuMsBnwI= X-Google-Smtp-Source: ABdhPJzdWUmRHp4/lKLXv6+q2Thn0Sc0nr1QD99ZxxURYeZleIgI699G+WxW+sTjwSsYr4dfIETXbVshldOB36R2nMg= X-Received: by 2002:a9d:6b8b:: with SMTP id b11mr2798119otq.210.1614850447259; Thu, 04 Mar 2021 01:34:07 -0800 (PST) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-5-brad@pensando.io> In-Reply-To: <20210304034141.7062-5-brad@pensando.io> From: Arnd Bergmann Date: Thu, 4 Mar 2021 10:33:51 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/8] spidev: Add Pensando CPLD compatible To: Brad Larson Cc: Linux ARM , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , DTML , "linux-kernel@vger.kernel.org" X-Provags-ID: V03:K1:chfBil34+0VpqUjgKrzV1CkAuKDoNBi/e60xKxuAfoBGb6/Osrs rznNC7LFVaqlUD2iLLlJvGJ41LxPzxGQRjlfN/PXqK2eUIHstY1QMfzm3BVCDtm3fh2LQ/P JUTENZqT3hExBaQy6fJMu3aWJZkP3PuUrkrX0GByN/qfILEkpndZNGiG/HO3FHiHgxheMSL C5DLfzOQ93blVDqYwuO5w== X-UI-Out-Filterresults: notjunk:1;V03:K0:xAW/FOb9UF8=:rdCObaRVuO8IOJAewb5IvU MkjxXSxu3JBRAv9U8N8LmKj7hiKTIC8PG2EOFuHHvEBbR6GZw6xGhfq8TLsjwXU9mboZEzb6O jijNBlvmiy381WzPStSJ0kW90U3iQGxYK8yc4UHk66Bm4pnjAcJHT3pRfH+uUOnDu6h0SJccb jnZC1n8QlABRNVd/oUUefss968BDJW0BehpGW7PHDxm382+fdeZy9o4swAjJ2soGT+1hX/IpM 6kg41M8CdXfdFXW7kH6h9EarOyypI+U3N8//GgvK/Z4/l88CMCXICprvG/42fUmzra/uHBa+g 9eh7jWFYZNxa1z4oNIYPRRdDsNrU28oiSQnTH9iDd4mL8MM9jbvM12EtZ8AZm372VAX0pBeb1 211t6dTqUIjBKLBaQ5qgu5574eGIPh6wMBYffIaDg8nEe95iFHMhpc6okRsT7l+w0wRdIYVQ+ cprgMimUjRRM2YXjemTtKTMhSVFIKf6lzSkmBZxY+U5g2KOXalBA2uhyOABVZcFmVy/R9SRWI +yd9xoLJR9NItbXuIuFA/Gxtxwru9Otx/R6Cxq72WRhCQZ/M1InsIfkNwQi1IHc8A== X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 4, 2021 at 4:41 AM Brad Larson wrote: > > Pensando Elba SoC platforms have a SPI connected CPLD > for platform management. > > Signed-off-by: Brad Larson > --- > drivers/spi/spidev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c > index 8cb4d923aeaa..8b285852ce82 100644 > --- a/drivers/spi/spidev.c > +++ b/drivers/spi/spidev.c > @@ -683,6 +683,7 @@ static const struct of_device_id spidev_dt_ids[] = { > { .compatible = "dh,dhcom-board" }, > { .compatible = "menlo,m53cpld" }, > { .compatible = "cisco,spi-petra" }, > + { .compatible = "pensando,cpld" }, > {}, > }; This does not seem appropriate, I think a platform management driver should have a proper kernel abstraction instead of a user passthrough. As mentioned elsewhere, it also needs to be way more specific. If this is a programmable block, the compatible string might in fact need to contain both a board identifier and a revision number for the programmable logic, to ensure that the driver knows how to talk to it. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel