From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762241AbdEVUeu (ORCPT ); Mon, 22 May 2017 16:34:50 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:32867 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbdEVUeq (ORCPT ); Mon, 22 May 2017 16:34:46 -0400 MIME-Version: 1.0 In-Reply-To: <20170522162555.4313-1-punit.agrawal@arm.com> References: <20170522133604.11392-5-punit.agrawal@arm.com> <20170522162555.4313-1-punit.agrawal@arm.com> From: Arnd Bergmann Date: Mon, 22 May 2017 22:34:45 +0200 X-Google-Sender-Auth: 5PXB4vu5roVvM-HdAKnhI8-BgoU Message-ID: Subject: Re: [PATCH v3.1 4/6] mm/hugetlb: Allow architectures to override huge_pte_clear() To: Punit Agrawal Cc: Andrew Morton , Linux-MM , Linux Kernel Mailing List , Linux ARM , Catalin Marinas , Will Deacon , n-horiguchi@ah.jp.nec.com, "Kirill A . Shutemov" , mike.kravetz@oracle.com, steve.capper@arm.com, Mark Rutland , linux-arch , "Aneesh Kumar K.V" , Martin Schwidefsky , Heiko Carstens Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 6:25 PM, Punit Agrawal wrote: > When unmapping a hugepage range, huge_pte_clear() is used to clear the > page table entries that are marked as not present. huge_pte_clear() > internally just ends up calling pte_clear() which does not correctly > deal with hugepages consisting of contiguous page table entries. > > Add a size argument to address this issue and allow architectures to > override huge_pte_clear() by wrapping it in a #ifndef block. > > Update s390 implementation with the size parameter as well. > > Note that the change only affects huge_pte_clear() - the other generic > hugetlb functions don't need any change. > > Signed-off-by: Punit Agrawal > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Arnd Bergmann > Cc: "Aneesh Kumar K.V" > Cc: Mike Kravetz Acked-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3.1 4/6] mm/hugetlb: Allow architectures to override huge_pte_clear() Date: Mon, 22 May 2017 22:34:45 +0200 Message-ID: References: <20170522133604.11392-5-punit.agrawal@arm.com> <20170522162555.4313-1-punit.agrawal@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170522162555.4313-1-punit.agrawal@arm.com> Sender: owner-linux-mm@kvack.org To: Punit Agrawal Cc: Andrew Morton , Linux-MM , Linux Kernel Mailing List , Linux ARM , Catalin Marinas , Will Deacon , n-horiguchi@ah.jp.nec.com, "Kirill A . Shutemov" , mike.kravetz@oracle.com, steve.capper@arm.com, Mark Rutland , linux-arch , "Aneesh Kumar K.V" , Martin Schwidefsky , Heiko Carstens List-Id: linux-arch.vger.kernel.org On Mon, May 22, 2017 at 6:25 PM, Punit Agrawal wrote: > When unmapping a hugepage range, huge_pte_clear() is used to clear the > page table entries that are marked as not present. huge_pte_clear() > internally just ends up calling pte_clear() which does not correctly > deal with hugepages consisting of contiguous page table entries. > > Add a size argument to address this issue and allow architectures to > override huge_pte_clear() by wrapping it in a #ifndef block. > > Update s390 implementation with the size parameter as well. > > Note that the change only affects huge_pte_clear() - the other generic > hugetlb functions don't need any change. > > Signed-off-by: Punit Agrawal > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Arnd Bergmann > Cc: "Aneesh Kumar K.V" > Cc: Mike Kravetz Acked-by: Arnd Bergmann -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 22 May 2017 22:34:45 +0200 Subject: [PATCH v3.1 4/6] mm/hugetlb: Allow architectures to override huge_pte_clear() In-Reply-To: <20170522162555.4313-1-punit.agrawal@arm.com> References: <20170522133604.11392-5-punit.agrawal@arm.com> <20170522162555.4313-1-punit.agrawal@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 22, 2017 at 6:25 PM, Punit Agrawal wrote: > When unmapping a hugepage range, huge_pte_clear() is used to clear the > page table entries that are marked as not present. huge_pte_clear() > internally just ends up calling pte_clear() which does not correctly > deal with hugepages consisting of contiguous page table entries. > > Add a size argument to address this issue and allow architectures to > override huge_pte_clear() by wrapping it in a #ifndef block. > > Update s390 implementation with the size parameter as well. > > Note that the change only affects huge_pte_clear() - the other generic > hugetlb functions don't need any change. > > Signed-off-by: Punit Agrawal > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Arnd Bergmann > Cc: "Aneesh Kumar K.V" > Cc: Mike Kravetz Acked-by: Arnd Bergmann