From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFD2070 for ; Mon, 7 Jun 2021 07:34:20 +0000 (UTC) Received: from mail-wm1-f52.google.com ([209.85.128.52]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M1HmG-1loUjm1INu-002rQJ for ; Mon, 07 Jun 2021 09:29:08 +0200 Received: by mail-wm1-f52.google.com with SMTP id h22-20020a05600c3516b02901a826f84095so4457742wmq.5 for ; Mon, 07 Jun 2021 00:29:08 -0700 (PDT) X-Gm-Message-State: AOAM531xPkWt+JwATnZDZBqN/z6LcKRSABVSvvmibLNubW7HakjLapA5 PRNIb8nsMjHVUId5Gihnh+uy+GjnTDHtCfQXKn0= X-Google-Smtp-Source: ABdhPJx1sZM7+jb/Er05kwck+NjL97VzTgij1Tl9s8181a57Xul7USu5v5ud860aYtGnhwYz/l+yS+/2ilFrTbwmUPQ= X-Received: by 2002:a1c:c90f:: with SMTP id f15mr15633427wmb.142.1623050947892; Mon, 07 Jun 2021 00:29:07 -0700 (PDT) X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <1622970249-50770-1-git-send-email-guoren@kernel.org> <1622970249-50770-14-git-send-email-guoren@kernel.org> <20210607071916.kwdbtafbqp3icgia@gilmour> In-Reply-To: <20210607071916.kwdbtafbqp3icgia@gilmour> From: Arnd Bergmann Date: Mon, 7 Jun 2021 09:27:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 10/11] riscv: soc: Add Allwinner SoC kconfig option To: Maxime Ripard Cc: Guo Ren , Anup Patel , Palmer Dabbelt , Chen-Yu Tsai , Drew Fustini , liush@allwinnertech.com, lazyparser@gmail.com, wefu@redhat.com, linux-riscv , Linux Kernel Mailing List , linux-arch , linux-sunxi@lists.linux.dev, Guo Ren , Atish Patra , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:wGArjuYm0AxZPha0bqaXIo1lUocsYMof2RCoAK3xhGbK8Ihucm5 9a8hNnuJk+0wLvsxWyFVGcrOepztIc5nrR+ABBoMJK3UorrtHYaoGdkT4rEl/C5MjbbcQGj 4lmQWHuqWi76NBd9xIATq7Gkv6dKcMRwqK/VEIplVtiZO00EY7CYx3Y4r4O2FJxd3bwA6Ht yQpfuREJTRGK37W/I7Ykg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:IRX3lizS7g4=:btvhrvnGYdZWghdIRYbDk2 vpA9zxBcW78aoi4UeOATuLztAkWIV7gGNn9KQx9iKgmO1c03CeaBDTLg1J7q9ISxro2lyGVz5 9g9BlYbLk2FApQytGWlrNETnnJZv7rXNMihWuk6ubkZrEaqO4lQm+lGdrQsW8/CPgqrxydgg+ LJTfsipxZQN3FdjxbLUbQQjyBmYXlZazNMLgbCpXlaRLDMYm0U+NcUPJ2bF3i/z75Buxtnb3X +UpXW1dBWYr5HtSXOopn7gzc9Ypf6xtJEkr6MB/STu7ZUO4c1LQTT8TBL3EhryWuEbOavvBUi nl9o9ggr7DJtEd5Z60Yo4Se4juGPOaZ/fyoMjQPLvGPevMaoy3Fk4jN1o1nlpPEdyFw35ZWeA GL+AwK92QvChIv3iBXLiNFEL2u0fZ75yB4xLdZK57qpPBL43LowymnlOdL1C2gfu13DfRzTJL zixMK1s5p2rGgfVjMprr+Qnry0LdPhcvXtB0urteuMP2dbuRkZTQOttSKNj311n7DOpRErTX+ 2bCU2sySACiyPQ5YOHDDv6RaHCYL5lSMmVzl8U/lnLI7ozo2sAq3UtzDBMLqcKBDCjlsvEdyS GtE2j+mu8+Th6rCEKkWsBR2J30uvVZr4F2QBy/27XVfF/kq8J+vDEdAsAcWeLse5uGLvP3TsZ 9cxU= On Mon, Jun 7, 2021 at 9:20 AM Maxime Ripard wrote: > On Sun, Jun 06, 2021 at 09:04:08AM +0000, guoren@kernel.org wrote: > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > > index ed96376..055fb3e 100644 > > --- a/arch/riscv/Kconfig.socs > > +++ b/arch/riscv/Kconfig.socs > > @@ -69,4 +69,16 @@ config SOC_CANAAN_K210_DTB_SOURCE > > > > endif > > > > +config SOC_SUNXI > > + bool "Allwinner SoCs" > > + depends on MMU > > + select DWMAC_GENERIC > > + select SERIAL_8250 > > + select SERIAL_8250_CONSOLE > > + select SERIAL_8250_DW > > + select SIFIVE_PLIC > > + select STMMAC_ETH > > + help > > + This enables support for Allwinner SoC platforms like the D1. > > + > > We probably don't want to select DWMAC, STMMAC_ETH and the 8250 options, > looks good otherwise. Correct: those subsystems may be completely disabled, which would lead to a build failure, and a platform should not force-enable drivers or subsystems unless those are build time dependencies. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592C2C4743C for ; Mon, 7 Jun 2021 07:29:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4236260E08 for ; Mon, 7 Jun 2021 07:29:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230231AbhFGHbB (ORCPT ); Mon, 7 Jun 2021 03:31:01 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:48689 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbhFGHbA (ORCPT ); Mon, 7 Jun 2021 03:31:00 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MC3L9-1ldoQz0pDx-00CTKF; Mon, 07 Jun 2021 09:29:08 +0200 Received: by mail-wm1-f48.google.com with SMTP id l7-20020a05600c1d07b02901b0e2ebd6deso1193106wms.1; Mon, 07 Jun 2021 00:29:08 -0700 (PDT) X-Gm-Message-State: AOAM531BZmiG3BBkO1ugwt2mFupnLmbH3U1YdziQqKp7pN643959Kl0B rtp7AEjtIUdEjtG2xDJ9FyrAqcrTdy5EkpKSOk4= X-Google-Smtp-Source: ABdhPJx1sZM7+jb/Er05kwck+NjL97VzTgij1Tl9s8181a57Xul7USu5v5ud860aYtGnhwYz/l+yS+/2ilFrTbwmUPQ= X-Received: by 2002:a1c:c90f:: with SMTP id f15mr15633427wmb.142.1623050947892; Mon, 07 Jun 2021 00:29:07 -0700 (PDT) MIME-Version: 1.0 References: <1622970249-50770-1-git-send-email-guoren@kernel.org> <1622970249-50770-14-git-send-email-guoren@kernel.org> <20210607071916.kwdbtafbqp3icgia@gilmour> In-Reply-To: <20210607071916.kwdbtafbqp3icgia@gilmour> From: Arnd Bergmann Date: Mon, 7 Jun 2021 09:27:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 10/11] riscv: soc: Add Allwinner SoC kconfig option To: Maxime Ripard Cc: Guo Ren , Anup Patel , Palmer Dabbelt , Chen-Yu Tsai , Drew Fustini , liush@allwinnertech.com, lazyparser@gmail.com, wefu@redhat.com, linux-riscv , Linux Kernel Mailing List , linux-arch , linux-sunxi@lists.linux.dev, Guo Ren , Atish Patra , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:aPORLvlDH2w1f7tqUEyZq9BKSn4Ke4GvGyAB0NAbwN/1c+7HBli 5MsSf94ln9B6Wd0Ft6H5lQnka0dfZpn7qO9o5DGjBFU72G42HJ5insnQvwfqZBUDz2c2nzI f+a0CvwSh0nVcRibRdkcVTQ/utCUWKUgYLcVZ8+5fXhRbdPGD+eisz49An4VgmBpYNT0i7h TqdBAO81qikdIkv1Snx1g== X-UI-Out-Filterresults: notjunk:1;V03:K0:MWdlhbDtBRM=:d0hcH6YAbdet5Q3OmXW0BJ C32ztU+0DGgK+p5d/VbcZBcikRaJXRixLIp69CnaepxXucsVlQzo0QGFPiRr+cko71dtZm02x c5Au5Du5BklwGXW1WVZgAIsNUIhOc03zRnYrGEkrlOM+E7Ldrcq6cQSd101DFuveBqJzobuyf o2ATD21SIkUCpmKMJD25f/euyNXjSsSeK0cGvh/zh8h7nXwrzlTxGbSw2Sot7W/XenJpiHRXc MwSUSLidPJCvsB1T19wDskvF/5ihto3tZm0a+pHcNoYu2b/YbNC+/KUtrcDgytCNKG2vFTcFd UENHM0DHY2Dlh2CCPjFGRDu3iZdaJQQRuqFBU6gspLLbuvVUYLONra/YmtL2XZ1q3hN7IGAUN BDvwzF1D+cQIj/iwJSmNDQtoS+LXQ5OXM5deV0FwUPEm75ob3FGUdjfoovRPwgHGZZ5IFs6m+ 4N1LTA7UbPHQLv2CRpuWKW5nz7KbNpfexs6riXirdioj/NxQrPy+0nvG8OeghtJMTZf/JvCH2 iMZmakLV4ywE6Ihq8O0S9DVTFugR8KAjQGbbq9hIGSnV9eITPd1JYxuWA3IjTWyFJsbW2oRxo PWzm+eMM5FrAfW0F5+tCsvgOsPjET2VkRoTJgr5s2g75T0YoaantdVI8Zr0374XpEnvsv8EpY 3a7o= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 7, 2021 at 9:20 AM Maxime Ripard wrote: > On Sun, Jun 06, 2021 at 09:04:08AM +0000, guoren@kernel.org wrote: > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > > index ed96376..055fb3e 100644 > > --- a/arch/riscv/Kconfig.socs > > +++ b/arch/riscv/Kconfig.socs > > @@ -69,4 +69,16 @@ config SOC_CANAAN_K210_DTB_SOURCE > > > > endif > > > > +config SOC_SUNXI > > + bool "Allwinner SoCs" > > + depends on MMU > > + select DWMAC_GENERIC > > + select SERIAL_8250 > > + select SERIAL_8250_CONSOLE > > + select SERIAL_8250_DW > > + select SIFIVE_PLIC > > + select STMMAC_ETH > > + help > > + This enables support for Allwinner SoC platforms like the D1. > > + > > We probably don't want to select DWMAC, STMMAC_ETH and the 8250 options, > looks good otherwise. Correct: those subsystems may be completely disabled, which would lead to a build failure, and a platform should not force-enable drivers or subsystems unless those are build time dependencies. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F05C4743F for ; Mon, 7 Jun 2021 07:29:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41B6E61185 for ; Mon, 7 Jun 2021 07:29:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41B6E61185 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E0pXKOCnH0szffjh0i+9ft+ncAPm1+P1ac4CVp5Ocqc=; b=MideDDHPcQmveI lKPPTUEnlMXJ2WfnfJAT89qITZxaeqKbcfayu7A5RsWnzFTPmbLwRV8ynULGDP7AsA1olvm3ZSqLa t7xpw7IlMgpFFAXfWf1ocfsKr/xbcrthxz9j+znhLbdnGvIdkfzD3DQCo9vecYErEOD4wT5I+Sne3 KW69JY2ow/Vyi1QXz2rwLEr/MGy5S+ATx11IkTTk2xW/blKOT4WlL9PXrVyuvxb5eCSMFrkiI4VgO MSzX6Gms1ugmTXM9v1b2s1HelmOnW4S0G/vH+rwBP2JhvwYnAeuIQz9kjpQyvmJ1p1xnoRaQlYJAs NrUs+sWZryYK+jPUuSow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lq9hD-0024Pi-Mi; Mon, 07 Jun 2021 07:29:15 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lq9h8-0024MM-RR for linux-riscv@lists.infradead.org; Mon, 07 Jun 2021 07:29:14 +0000 Received: from mail-wm1-f48.google.com ([209.85.128.48]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MBDzc-1ledNi1QeU-00CkFy for ; Mon, 07 Jun 2021 09:29:08 +0200 Received: by mail-wm1-f48.google.com with SMTP id f17so9338129wmf.2 for ; Mon, 07 Jun 2021 00:29:08 -0700 (PDT) X-Gm-Message-State: AOAM530pF/nrLrQdaR71t8SXkYrUL2ASYLdhWqxaubmvONyoUYkylrI8 CcU06uNpQWABFToH1FYDEfIf2UjoFSRdpdArr0c= X-Google-Smtp-Source: ABdhPJx1sZM7+jb/Er05kwck+NjL97VzTgij1Tl9s8181a57Xul7USu5v5ud860aYtGnhwYz/l+yS+/2ilFrTbwmUPQ= X-Received: by 2002:a1c:c90f:: with SMTP id f15mr15633427wmb.142.1623050947892; Mon, 07 Jun 2021 00:29:07 -0700 (PDT) MIME-Version: 1.0 References: <1622970249-50770-1-git-send-email-guoren@kernel.org> <1622970249-50770-14-git-send-email-guoren@kernel.org> <20210607071916.kwdbtafbqp3icgia@gilmour> In-Reply-To: <20210607071916.kwdbtafbqp3icgia@gilmour> From: Arnd Bergmann Date: Mon, 7 Jun 2021 09:27:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 10/11] riscv: soc: Add Allwinner SoC kconfig option To: Maxime Ripard Cc: Guo Ren , Anup Patel , Palmer Dabbelt , Chen-Yu Tsai , Drew Fustini , liush@allwinnertech.com, lazyparser@gmail.com, wefu@redhat.com, linux-riscv , Linux Kernel Mailing List , linux-arch , linux-sunxi@lists.linux.dev, Guo Ren , Atish Patra , Christoph Hellwig X-Provags-ID: V03:K1:AqSBZ0RuCSz5s1oitSkKxm8bkMJ67g9YTYjbkvPD2hmPmb+Q2No AuFPOH0wfJbevQLUxt0ERHrUZpA0ouAg0o+8bozHwX8MCpQRW5B/UprnQIV5flXrvO8Nzof qDTH2vSeMzdD9wk/4d07Sewr2h+qK/YeXMqyinbuf6FMjCIYiHvBG2fux8LuH8Ex4zaGHkA CBI33PMJZ7elaYSsTNzGg== X-UI-Out-Filterresults: notjunk:1;V03:K0:DoTVD2WLfgc=:0VhHegNE1fl99pao+M/s1g g+eh3wr7mXhJ359bnuWOuyAMv37nXo/zIrpFvSdjODUVZ9sqv5eHSy23zPLbUONnFLc/hLLyn vqMqAOpABEvU1PZPlCTnavyrPzFIdGlzguDyLekAlVNjghpdCSvGN+QfYJ3gDLqfZjvWdbg82 WQxe2bdpdSonIyLsShBtGmTLAkqiMIy9HcpNzgxsfzIhaZm+z2iORL64xaXNIfPynHJyDA/Ru vGsJL50FmEcHw6rLDUfqa35dSSW09JPCQ26yagsZx+f1KLuGKLoNdSQGenDP5VA3SW8ZK4vIf AidOwvoG6/Ple4I61j0fkWHHBS8urfTqobaSaca85vDgHOoG1i4ADmgxYo+C88gnAplOkaSYR Chcr9XGDG9Pyi/GxxOrRPuYByaA9f11BCF8CvP0yqSZdvCzJisnZpRPlnE/vxWv4xJ9CCzztF 8si+7+aiuLFfUmCcnvl6UsXIFmM7UA7x8/sSmvrseKD/ta/gl5LZrg6Gq8C0ID4D8DOQTTm2E Rn+AQ0lfZsQcMn4QCLbkguXFd0UkXZltRCz3xrPssAD9eOjdHQ3IK8D+NbtO8874z1UxzKniL 0jJgCYbLoh1c26xj7BYiAtIjGTqAgb3uF0ctXQQqWjxTVJlc+70rxLePOM3/o80FSIMt8f2+N qSu0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_002911_232393_343EBDCE X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Jun 7, 2021 at 9:20 AM Maxime Ripard wrote: > On Sun, Jun 06, 2021 at 09:04:08AM +0000, guoren@kernel.org wrote: > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > > index ed96376..055fb3e 100644 > > --- a/arch/riscv/Kconfig.socs > > +++ b/arch/riscv/Kconfig.socs > > @@ -69,4 +69,16 @@ config SOC_CANAAN_K210_DTB_SOURCE > > > > endif > > > > +config SOC_SUNXI > > + bool "Allwinner SoCs" > > + depends on MMU > > + select DWMAC_GENERIC > > + select SERIAL_8250 > > + select SERIAL_8250_CONSOLE > > + select SERIAL_8250_DW > > + select SIFIVE_PLIC > > + select STMMAC_ETH > > + help > > + This enables support for Allwinner SoC platforms like the D1. > > + > > We probably don't want to select DWMAC, STMMAC_ETH and the 8250 options, > looks good otherwise. Correct: those subsystems may be completely disabled, which would lead to a build failure, and a platform should not force-enable drivers or subsystems unless those are build time dependencies. Arnd _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv