From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88F8C433EF for ; Tue, 19 Oct 2021 14:24:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC61961212 for ; Tue, 19 Oct 2021 14:24:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbhJSO0R (ORCPT ); Tue, 19 Oct 2021 10:26:17 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:50271 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhJSO0P (ORCPT ); Tue, 19 Oct 2021 10:26:15 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N5mSj-1mnNso2I39-017BS8 for ; Tue, 19 Oct 2021 16:24:01 +0200 Received: by mail-wm1-f52.google.com with SMTP id 63-20020a1c0042000000b0030d60716239so2901310wma.4 for ; Tue, 19 Oct 2021 07:24:01 -0700 (PDT) X-Gm-Message-State: AOAM5318AaCyK00xaB1JSVDxm4jz0c2Zy8zI7GhPwnTSpqAKkMQyQZeA sjUlQr3O3LgmJEATJsQEqZIVOkq0uYftvhrBLhc= X-Google-Smtp-Source: ABdhPJwKQW7tgBaH6kTW0rrTX50ypr3eK+Ahefc5knwle6M9G57uWXIVrYYyqptMm0i3QO8nZ4vcPCD26aJqtexE85s= X-Received: by 2002:a1c:4b08:: with SMTP id y8mr6692599wma.98.1634653441129; Tue, 19 Oct 2021 07:24:01 -0700 (PDT) MIME-Version: 1.0 References: <20211008120736.GF7074@brightrain.aerifal.cx> <20211018144259.GK7074@brightrain.aerifal.cx> <20211018150824.GL7074@brightrain.aerifal.cx> <20211018204203.GM7074@brightrain.aerifal.cx> <20211019141622.GN7074@brightrain.aerifal.cx> In-Reply-To: <20211019141622.GN7074@brightrain.aerifal.cx> From: Arnd Bergmann Date: Tue, 19 Oct 2021 16:23:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [musl] Re: [alsa-devel] [PATCH v7 8/9] ALSA: add new 32-bit layout for snd_pcm_mmap_status/control To: musl@lists.openwall.com Cc: Arnd Bergmann , Takashi Iwai , Michael Forney , ALSA Development Mailing List , Takashi Iwai , Baolin Wang , y2038 Mailman List , Linux Kernel Mailing List , Mark Brown , Baolin Wang Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:1irHjch2F/mNA9GpXu85IvRzFXMfAVt+FnPaqgOGwDXlHnb8pv3 JDAXGN/FeNlds4wjApCyYJZ4LvjLvXC/j8B2Rqs8h/qFulrCV1NoIj2PLMXOdEho2mDQJzE sKawAaXoWoQSllHlVAYFbCF6GpeiwnztuVuJLd6JTHhetgBunu2S+EyeGE8h7l+nnnGHsL6 HQWCpVZa+kDm3YDRpYbFA== X-UI-Out-Filterresults: notjunk:1;V03:K0:ae2ExS+Eqfg=:VqFY28NcztfJHf675fQiah b8e8rr0tUpXnuJg2X/poEoTFiQA4VzuL8IIu9NgH2RLV+w8/7GKa2bAnUL3jtGfZfYBEXDtUa 35ddvQ6gxaL/RNGhuuisBsDRrd3vySlg8ST1aEuZqxcRSTgrzbpdoodiZKLDnQJ3tVS+7Xc8I TVyuvV1ptZG/nuIwxP6vsHuZzTFjTLXTVSZXJ++KW8imvv/T8OfueYWGVj9eLWQVvMTT3cCoI F+8Qo4ELVURZ2D++enHA7j5k6muOC/NSp4vTUg+P4jMDbsthPCeJJSPL24atYGph6sEyN2tlb qyI6SshK58UAc4Dk4jEUx9gpyvDWX4A6qQc0pE1Wh/ME4ZDZ1QYXUusj68MFn8BWc7QDHcygd zS78ClqD3R8lO7RqjizSzOCuiU5a/NQx5Mrlnk2PchSJmA6EbxUQ+a7+BaIPMqLcC7DARynQC VpGEhkoIBXL1Ogf9vmmwY8EOx3Cwc/kF9Kt57ZGIJtsFoIafu4OwDUU5WlHKePNr6udrZXS7Z P99Nev3qrMkaMI0eT3t/RnrfA/mLNQNHKqjapmLgJUSh9GOamOyw4Zzs4aDrRa8/yEQXV45O1 vFK5h9ZH/9j7o/bjszyhzzdEjLhaXQi67moYLcBXsv2ss+o2MyPH9No16nJcsR2VB0zNdTrqE E1iOEdPXpyVC8U7QnbmHQTsLErx5VoU4YzJmEldTLDNaAFPrpBTqUjtb/Bo6efQffPTifxfsc 2tZyi45Q2FVsYntxzW2/zYn48Ok0uamF39do1t+dEJ8YShs/blbsHf8b2dewOkcgljzCzfxzC qn8Z/KenToyUCcBcj18GtKKLmM+AncWaTTHQFZNKmsI3XG0phtpmeXvH1GTtQ18/3VAq90uyv +gMQhWSh1lvP8WUM1JfQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 19, 2021 at 4:16 PM Rich Felker wrote: > On Mon, Oct 18, 2021 at 04:42:04PM -0400, Rich Felker wrote: > > > > Well for little endian either would work (because adj is 0 :) but yes > > there are 3 such paddings before the second member on big endian, so > > it should be 3. > > How about this? It avoids open coding the logic and handles it as 2 > 4-byte substructures with endian-specific offsets. Looks good to me. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD005C433EF for ; Tue, 19 Oct 2021 14:25:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96E8C60F9E for ; Tue, 19 Oct 2021 14:25:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 96E8C60F9E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8FA2C16A3; Tue, 19 Oct 2021 16:24:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8FA2C16A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1634653501; bh=7PfyY+uUV/Iq/NzXsXwthKzyTThqOVK+mSufuednp4A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fNP7ZVwtfcAxBsR4Wcvlitr5IwLie3MxhmlHM22gcG3tiw0WzZNdS/AfZprfvS0sM dUzWlg7xH2f7SjKH/Bo/ygOcR2IIE3KcoqJpmp7xky0kuyP8WPxyfNq8HLVDVNx6D/ jcpiTK1FdubMShrRWiD00MjCwgdqKgIJiMklNcZw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1E2DDF8019B; Tue, 19 Oct 2021 16:24:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1E935F80240; Tue, 19 Oct 2021 16:24:10 +0200 (CEST) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E826EF80155 for ; Tue, 19 Oct 2021 16:24:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E826EF80155 Received: from mail-wm1-f42.google.com ([209.85.128.42]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MzQbw-1myc9B37qq-00vNNc for ; Tue, 19 Oct 2021 16:24:01 +0200 Received: by mail-wm1-f42.google.com with SMTP id y16-20020a05600c17d000b0030db7a51ee2so2122049wmo.0 for ; Tue, 19 Oct 2021 07:24:01 -0700 (PDT) X-Gm-Message-State: AOAM531fzQsPFGJDFdl7s+KrBhi9wQ8tjGkKQE/UWmRyqcE9WSHKkLiE iEXjQlo5EinedxDwnPIhaP2mPO8qbCuhpkgrjKo= X-Google-Smtp-Source: ABdhPJwKQW7tgBaH6kTW0rrTX50ypr3eK+Ahefc5knwle6M9G57uWXIVrYYyqptMm0i3QO8nZ4vcPCD26aJqtexE85s= X-Received: by 2002:a1c:4b08:: with SMTP id y8mr6692599wma.98.1634653441129; Tue, 19 Oct 2021 07:24:01 -0700 (PDT) MIME-Version: 1.0 References: <20211008120736.GF7074@brightrain.aerifal.cx> <20211018144259.GK7074@brightrain.aerifal.cx> <20211018150824.GL7074@brightrain.aerifal.cx> <20211018204203.GM7074@brightrain.aerifal.cx> <20211019141622.GN7074@brightrain.aerifal.cx> In-Reply-To: <20211019141622.GN7074@brightrain.aerifal.cx> From: Arnd Bergmann Date: Tue, 19 Oct 2021 16:23:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [musl] Re: [alsa-devel] [PATCH v7 8/9] ALSA: add new 32-bit layout for snd_pcm_mmap_status/control To: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:TOtWe6KZEQ1rSusfN+fBFNJ6Ldh1wsQNErotCe380D385bigU04 jNvxN1e0AQ9AmeBcRdJ28YOToAb2norbreEZDgdCbet7aXMWOgPEbmAv10aQ97EKssbLB8K jTBh022c3QzgQY9Zz4J05crREj+PXixQYTDQpk/K1+uEgsg99K5zUC5oO8NmA6LxFLZsCI5 uMFKZ60gwmqSd///PaPjg== X-UI-Out-Filterresults: notjunk:1;V03:K0:H5+hiMfT/+M=:T4NZ//cZx3vAFwgL5ge2/Z XBcZr+Lc4HwhI5dUkHaxCmL755A6UUwFygZ++sjQdwOJ+twrFAdUWQZbuubzSEQfzeLERpApk TnGb5FbsKjhzGNyqvT6RtkDIiE0TG63TofgYlRTf4gP8TvVF73Sk5mDHVrW/YaoHGKV6K8BPn riqXUfHAg2BgChXbxgPlYqZ/oGQ9+BkeUUrHewpa/ZyLt6KVOSqLsFNerRpJGzOaoos+ciAdg dcnwo1f+5j/zODu2gn+54M0uxfvUTtEmFf2mMLt8kftlg61jTnH3YIOHDbW/h//7qvQaJBc+F OPb2WguCFlWI5JN8BcrTGXLy1PlkrwElIRzYCJ9lbeCvvs+nQlT8hvZEETQ8bQXfKAdfrgmIR JPRNuOq3VgGc/qcT9zddlyu7cgVBgQk9KwWvf0xIgZfAmYKEewkoQzGH/ImlFcp+fYwREjK6R DPgNbO+Qxi40Hve6Mn2nJQ1lmLTD3fkDzMAhcCrWwm92yrvh+hpyIIzTVAt4UOjfoU3TAIdNq GAkb2U6e8LqH9P/DEwKAtHCMD+/5MIA3/YyBWrRcmgBkmVBDuspr4RcHCK7WzHzL6OohZhiDX soEYdMvKd5KVL9k42VNHI0VL5F+xBTGdaxiTGDhb7AhdnbNJQTpSFZ4SYQ5tWV7wo+Y2ahQVD /xvWrlHQ0DFaAVAiejsy1jZ0WiPnbkBOtfDFx6SwMeGGyw5YbRLebA6w5fa0SOUj7lZoeedfK ALjZJxhGc6Fp3A7m8ooXNMMtmSIzySkeJ5XX9MTBjTSZzyHx5t3bMg45T+gGZj1R13105qL8x Dz02CDb9FmMe1c62XHS9S9zGkjuCIY+W3k7yWn8pmS2/im/k3Ml6xt4o9u+LAoo/U4rbYuNdw N4CdMO2hVHQnVP81AVVg== Cc: ALSA Development Mailing List , Arnd Bergmann , Baolin Wang , Takashi Iwai , Linux Kernel Mailing List , Takashi Iwai , Michael Forney , y2038 Mailman List , Mark Brown , Baolin Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Oct 19, 2021 at 4:16 PM Rich Felker wrote: > On Mon, Oct 18, 2021 at 04:42:04PM -0400, Rich Felker wrote: > > > > Well for little endian either would work (because adj is 0 :) but yes > > there are 3 such paddings before the second member on big endian, so > > it should be 3. > > How about this? It avoids open coding the logic and handles it as 2 > 4-byte substructures with endian-specific offsets. Looks good to me. Arnd