All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Dave Airlie <airlied@redhat.com>,
	Keith Packard <keithp@keithp.com>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vblank: Fix vblank timestamp debugs
Date: Mon, 13 Nov 2017 16:16:32 +0100	[thread overview]
Message-ID: <CAK8P3a0Zy7O5oO2Fk5wJXJU+dQN4bT=ndSmnRy_tG+Aa9DYQKA@mail.gmail.com> (raw)
In-Reply-To: <20171113150210.11311-1-ville.syrjala@linux.intel.com>

On Mon, Nov 13, 2017 at 4:02 PM, Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We're currently calling ktime_to_timespec64() on stack garbage
> hence the debug output for vblank timestamps also contains garbage.
> Let's assing something to the ktime_t first before we go converting
> it to a timespec.
>
> While at it micro-optimize the ktime_to_timespec64() calls away
> when vblank debugging isn't enabled.
>
> Fixes: 67680d3c0464 ("drm: vblank: use ktime_t instead of timeval")

Acked-by: Arnd Bergmann <arnd@arndb.de>

Sorry about the mess and thanks for cleaning up behind me.

       Arnd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2017-11-13 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 15:02 [PATCH] drm/vblank: Fix vblank timestamp debugs Ville Syrjala
2017-11-13 15:16 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a0Zy7O5oO2Fk5wJXJU+dQN4bT=ndSmnRy_tG+Aa9DYQKA@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.