All of
 help / color / mirror / Atom feed
From: Arnd Bergmann <>
To: "Marek Behún" <>
Cc: Linux Kbuild mailing list <>,
	Nathan Chancellor <>,
	Masahiro Yamada <>,
	Andrew Lunn <>, Networking <>
Subject: Re: [PATCH kbuild] Makefile.extrawarn: disable -Woverride-init in W=1
Date: Wed, 7 Apr 2021 09:14:29 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Apr 7, 2021 at 2:24 AM Marek Behún <> wrote:
> The -Wextra flag enables -Woverride-init in newer versions of GCC.
> This causes the compiler to warn when a value is written twice in a
> designated initializer, for example:
>   int x[1] = {
>     [0] = 3,
>     [0] = 3,
>   };
> Note that for clang, this was disabled from the beginning with
> -Wno-initializer-overrides in commit a1494304346a3 ("kbuild: add all
> Clang-specific flags unconditionally").
> This prevents us from implementing complex macros for compile-time
> initializers.

I think this is generally a useful warning, and it has found a number
of real bugs. I would want this to be enabled in both gcc and clang
by default, and I have previously sent both bugfixes and patches to
disable it locally.

> For example a macro of the form INITIALIZE_BITMAP(bits...) that can be
> used as
>   static DECLARE_BITMAP(bm, 64) = INITIALIZE_BITMAP(0, 1, 32, 33);
> can only be implemented by allowing a designated initializer to
> initialize the same members multiple times (because the compiler
> complains even if the multiple initializations initialize to the same
> value).

We don't have this kind of macro at the moment, and this may just mean
you need to try harder to come up with a definition that only initializes
each member once if you want to add this.

How do you currently define it?


  reply	other threads:[~2021-04-07  7:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  0:24 Marek Behún
2021-04-07  7:14 ` Arnd Bergmann [this message]
2021-04-07 14:49   ` Marek Behún
2021-04-07 20:44   ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH kbuild] Makefile.extrawarn: disable -Woverride-init in W=1' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.