From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934335AbeDXN3o (ORCPT ); Tue, 24 Apr 2018 09:29:44 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:38145 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934322AbeDXN3j (ORCPT ); Tue, 24 Apr 2018 09:29:39 -0400 X-Google-Smtp-Source: AB8JxZoIO+EnPfN8JlKsxBlyVqUefaqChmi3UPK87jXVXhgFeFOD3IOTKsSlsA6pnFMZ5qC9vxh5bR/MGK5sQSp7Q/U= MIME-Version: 1.0 In-Reply-To: References: From: Arnd Bergmann Date: Tue, 24 Apr 2018 15:29:38 +0200 X-Google-Sender-Auth: Wz7kbLdVwmodBAeAChJnt0YZwao Message-ID: Subject: Re: [PATCH 0/8] Fix year 2038 issue for sound subsystem To: Baolin Wang Cc: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Takashi Sakamoto , Ingo Molnar , SF Markus Elfring , Dan Carpenter , jeeja.kp@intel.com, Vinod Koul , Guneshwor Singh , subhransu.s.prusty@intel.com, Bhumika Goyal , gudishax.kranthikumar@intel.com, Naveen M , hardik.t.shah@intel.com, Arvind Yadav , Fabian Frederick , alsa-devel@alsa-project.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2018 at 2:06 PM, Baolin Wang wrote: > Since many structures will use timespec type variables to record time stamp > in uapi/asound.h, which are not year 2038 safe on 32bit system. This patchset > tries to introduce new structures removing timespec type to compatible native > mode and compat mode. > > Moreover this patchset also converts the internal structrures to use timespec64 > type and related APIs. > > Arnd Bergmann (2): > ALSA: move snd_pcm_ioctl_sync_ptr_compat into pcm_native.c > ALSA: add new 32-bit layout for snd_pcm_mmap_status/control > > Baolin Wang (6): > ALSA: Replace timespec with timespec64 > ALSA: Avoid using timespec for struct snd_timer_status > ALSA: Avoid using timespec for struct snd_ctl_elem_value > ALSA: Avoid using timespec for struct snd_pcm_status > ALSA: Avoid using timespec for struct snd_rawmidi_status > ALSA: Avoid using timespec for struct snd_timer_tread Thanks a lot for picking this up again and including my two patches! I've done a private review yesterday, but will have another look either today or tomorrow to see if I missed anything. I've also applied the series to my randconfig build tree and will see if that finds any new bugs. The builder has already found a bug in one of my two patches, so there might be more. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 0/8] Fix year 2038 issue for sound subsystem Date: Tue, 24 Apr 2018 15:29:38 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) by alsa0.perex.cz (Postfix) with ESMTP id 312502676A6 for ; Tue, 24 Apr 2018 15:29:39 +0200 (CEST) Received: by mail-qk0-f196.google.com with SMTP id h19so329353qkj.10 for ; Tue, 24 Apr 2018 06:29:39 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Baolin Wang Cc: Fabian Frederick , Arvind Yadav , Linux Kernel Mailing List , alsa-devel@alsa-project.org, Vinod Koul , hardik.t.shah@intel.com, Takashi Iwai , Guneshwor Singh , Liam Girdwood , Takashi Sakamoto , gudishax.kranthikumar@intel.com, Mark Brown , Bhumika Goyal , Naveen M , SF Markus Elfring , jeeja.kp@intel.com, subhransu.s.prusty@intel.com, Ingo Molnar , Dan Carpenter List-Id: alsa-devel@alsa-project.org On Tue, Apr 24, 2018 at 2:06 PM, Baolin Wang wrote: > Since many structures will use timespec type variables to record time stamp > in uapi/asound.h, which are not year 2038 safe on 32bit system. This patchset > tries to introduce new structures removing timespec type to compatible native > mode and compat mode. > > Moreover this patchset also converts the internal structrures to use timespec64 > type and related APIs. > > Arnd Bergmann (2): > ALSA: move snd_pcm_ioctl_sync_ptr_compat into pcm_native.c > ALSA: add new 32-bit layout for snd_pcm_mmap_status/control > > Baolin Wang (6): > ALSA: Replace timespec with timespec64 > ALSA: Avoid using timespec for struct snd_timer_status > ALSA: Avoid using timespec for struct snd_ctl_elem_value > ALSA: Avoid using timespec for struct snd_pcm_status > ALSA: Avoid using timespec for struct snd_rawmidi_status > ALSA: Avoid using timespec for struct snd_timer_tread Thanks a lot for picking this up again and including my two patches! I've done a private review yesterday, but will have another look either today or tomorrow to see if I missed anything. I've also applied the series to my randconfig build tree and will see if that finds any new bugs. The builder has already found a bug in one of my two patches, so there might be more. Arnd