From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED3FC43381 for ; Tue, 19 Feb 2019 09:04:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58B2721905 for ; Tue, 19 Feb 2019 09:04:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbfBSJER (ORCPT ); Tue, 19 Feb 2019 04:04:17 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:39622 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbfBSJEQ (ORCPT ); Tue, 19 Feb 2019 04:04:16 -0500 Received: by mail-qt1-f194.google.com with SMTP id o6so22282889qtk.6; Tue, 19 Feb 2019 01:04:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=duVmfkmCaKyI9suah2ZRlGhjzmTZPtPlQOQquFJ631U=; b=EnRFgFdmn9XenRJpMZ/CB5jutodFxn02DGa921mfPSBMjHc41Zzwrt5Whm3eEqr8l7 eBX3G+Ny2bE8QstzTzTTP1b0IOE/96F8H7YTyNqQz5v5cQ85QX9MUOFFxXA+9q2PvHeE z4+CHBd3pmx/vs61vTb64bDy+VSfiKN0uqo7e2ySyHAXezdtPalhcUNZFBkWrkEQgV80 vyFAqary2ydpmQ5iTy3lGn/O8MYJIguivfk5/CnZ2in7/lmNvHzpLdy94PuWCbRm/CKm 4/CuGd8atcu8K5gIOmkN7XD+7gkbrCg1xNP11CfPzbhn2pHIPjpEaXpmcGBTBrzts+cU h+6w== X-Gm-Message-State: AHQUAuYwqePeWN7stm+BV9TPVbssiHt7dY8wtqF2oZ3qnxq5Q4+Udjd5 XGIGIJ2eOi2eQtsHKQgiT1NZckcu1snKqPw8TVM= X-Google-Smtp-Source: AHgI3IYg19qI+e8SxIgEcwghsNphBBbOMbd8JoAMf2bRV3g+BmWK61s3iETvwplmqz4xYFhpqC5f1IE2GTFoPjzowzg= X-Received: by 2002:a0c:e98f:: with SMTP id z15mr20909616qvn.115.1550567054789; Tue, 19 Feb 2019 01:04:14 -0800 (PST) MIME-Version: 1.0 References: <20190218210712.3503891-1-arnd@arndb.de> <20190218210712.3503891-8-arnd@arndb.de> <20190219021834.GA4495@guoren-Inspiron-7460> In-Reply-To: <20190219021834.GA4495@guoren-Inspiron-7460> From: Arnd Bergmann Date: Tue, 19 Feb 2019 10:03:57 +0100 Message-ID: Subject: Re: [PATCH 7/8] csky: Use latest system call ABI To: Guo Ren Cc: Mao Han , y2038 Mailman List , Thomas Gleixner , linux-arch , Linux API , Linux Kernel Mailing List , Yury Norov , Linux ARM , "open list:QUALCOMM HEXAGON..." , "moderated list:H8/300 ARCHITECTURE" , Stafford Horne , Vineet Gupta , Palmer Dabbelt , Greentime Hu , linux-riscv@lists.infradead.org, Guan Xuetao , Joseph Myers Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 18, 2019 at 11:40 PM Joseph Myers wrote: > > On Mon, 18 Feb 2019, Arnd Bergmann wrote: > > > We don't yet have an upstream glibc port for csky, so there is no user > > We do. It's in 2.29. ... On Tue, Feb 19, 2019 at 3:18 AM Guo Ren wrote: > > Mao Han has merged csky port into glibc 2.29, so we should keep the > __ARCH_WANT_TIME32_SYSCALLS. My mistake. I've dropped patch 7/8 from this series now. > > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig > > index 6959e0b1e956..398113c845f5 100644 > > --- a/arch/csky/Kconfig > > +++ b/arch/csky/Kconfig > > @@ -1,6 +1,5 @@ > > config CSKY > > def_bool y > > - select ARCH_32BIT_OFF_T > > select ARCH_HAS_SYNC_DMA_FOR_CPU > > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > > select ARCH_USE_BUILTIN_BSWAP > > diff --git a/arch/csky/include/uapi/asm/unistd.h b/arch/csky/include/uapi/asm/unistd.h > > index ec60e49cea66..224c9a9ab45b 100644 > > --- a/arch/csky/include/uapi/asm/unistd.h > > +++ b/arch/csky/include/uapi/asm/unistd.h > > @@ -2,8 +2,6 @@ > > // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > > > > #define __ARCH_WANT_SYS_CLONE > > -#define __ARCH_WANT_SET_GET_RLIMIT > Seems it's not related to y2038 issue. Is __ARCH_WANT_SET_GET_RLIMIT no > use ? In new architectures, we do not need to set CONFIG_ARCH_32BIT_OFF_T or __ARCH_WANT_SET_GET_RLIMIT, since we can assume that user space always uses a 64-bit off_t and a 'struct rlimit' matching the kernel's rlimit64, with the prlimit64() system call replacing both getrlimit and setrlimit on the kernel/user ABI side. I don't know if glibc still uses the 32-bit off_t behavior or the old getrlimit/setrlimit, but if we're not also changing the time32 interfaces, the safest option seems to be to leave all three in place. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 7/8] csky: Use latest system call ABI Date: Tue, 19 Feb 2019 10:03:57 +0100 Message-ID: References: <20190218210712.3503891-1-arnd@arndb.de> <20190218210712.3503891-8-arnd@arndb.de> <20190219021834.GA4495@guoren-Inspiron-7460> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190219021834.GA4495@guoren-Inspiron-7460> Sender: linux-kernel-owner@vger.kernel.org To: Guo Ren Cc: Mao Han , y2038 Mailman List , Thomas Gleixner , linux-arch , Linux API , Linux Kernel Mailing List , Yury Norov , Linux ARM , "open list:QUALCOMM HEXAGON..." , "moderated list:H8/300 ARCHITECTURE" , Stafford Horne , Vineet Gupta , Palmer Dabbelt , Greentime Hu , linux-riscv@lists.infradead.org, Guan Xuetao , Joseph Myers List-Id: linux-api@vger.kernel.org On Mon, Feb 18, 2019 at 11:40 PM Joseph Myers wrote: > > On Mon, 18 Feb 2019, Arnd Bergmann wrote: > > > We don't yet have an upstream glibc port for csky, so there is no user > > We do. It's in 2.29. ... On Tue, Feb 19, 2019 at 3:18 AM Guo Ren wrote: > > Mao Han has merged csky port into glibc 2.29, so we should keep the > __ARCH_WANT_TIME32_SYSCALLS. My mistake. I've dropped patch 7/8 from this series now. > > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig > > index 6959e0b1e956..398113c845f5 100644 > > --- a/arch/csky/Kconfig > > +++ b/arch/csky/Kconfig > > @@ -1,6 +1,5 @@ > > config CSKY > > def_bool y > > - select ARCH_32BIT_OFF_T > > select ARCH_HAS_SYNC_DMA_FOR_CPU > > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > > select ARCH_USE_BUILTIN_BSWAP > > diff --git a/arch/csky/include/uapi/asm/unistd.h b/arch/csky/include/uapi/asm/unistd.h > > index ec60e49cea66..224c9a9ab45b 100644 > > --- a/arch/csky/include/uapi/asm/unistd.h > > +++ b/arch/csky/include/uapi/asm/unistd.h > > @@ -2,8 +2,6 @@ > > // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > > > > #define __ARCH_WANT_SYS_CLONE > > -#define __ARCH_WANT_SET_GET_RLIMIT > Seems it's not related to y2038 issue. Is __ARCH_WANT_SET_GET_RLIMIT no > use ? In new architectures, we do not need to set CONFIG_ARCH_32BIT_OFF_T or __ARCH_WANT_SET_GET_RLIMIT, since we can assume that user space always uses a 64-bit off_t and a 'struct rlimit' matching the kernel's rlimit64, with the prlimit64() system call replacing both getrlimit and setrlimit on the kernel/user ABI side. I don't know if glibc still uses the 32-bit off_t behavior or the old getrlimit/setrlimit, but if we're not also changing the time32 interfaces, the safest option seems to be to leave all three in place. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF89EC43381 for ; Tue, 19 Feb 2019 09:04:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B15932146F for ; Tue, 19 Feb 2019 09:04:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jDg0NEWR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B15932146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6vKLmzd5Tr4i2vppymBNiLum5sWaj66/2x+jHhQlykk=; b=jDg0NEWRpEP5kL XIzk8VbuMbIm6X81bx7M+gWSGR15RmmcLFdcUdGC4Xopw1uiZxD4dpkIVTaaxuERhQPyBeDgQ/alI bSyQnBdV03bzzmBJ7dQypgqdQmknXrGxcUSFssChxIxRj0+92TXgWEXKpvPgix00Zza/bpSy9ynnM AGWJueU90F+TmloHWSgPGHw3d4LyPO+5x4qTSq6fWdwx4GDp0jnEixJxyLAGwCig240KEv4rz7dMt ITiwkw0ZF0E3sCLff6TIoUoiFAZPYBBNH3omnha/6PlsnjaxgSsrbGmJ+HpO/WpajHlODBIRU8GbI LLonWbx/poeRrwqFX+Aw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw1KX-0001TW-FW; Tue, 19 Feb 2019 09:04:45 +0000 Received: from mail-qt1-f193.google.com ([209.85.160.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw1K3-0000yP-Sk; Tue, 19 Feb 2019 09:04:19 +0000 Received: by mail-qt1-f193.google.com with SMTP id v10so22293168qtp.8; Tue, 19 Feb 2019 01:04:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=duVmfkmCaKyI9suah2ZRlGhjzmTZPtPlQOQquFJ631U=; b=WU12qNlN1SeyyckLKRcYhAjfrXMw6vimRvVIUrqXIgKxzGtH4zb/cRl6hTY3xeSewB GksM8bFjsETPLWNpoBjUvoE5gpVfuiuG3SNPQTn5DDkqmTZULRXoH8kv36qzj6lhTO42 vCzUDJnnek9sSUC/cH5KZk0KZnv7H24CfLMaJ9EvlsKf75nsYqcGlvnhWUfMqOmSK6sF GvW9XNrJ/lcgUObVA7KgpEHUk7VNaOeKRMsMYH9cSVTDemchOWDXc6MGyPWhncSxeigL s4x3xs8rKIWdKXiblzlsxtoldEzp4v0YtW+rcUWzihu8Q7zl80YFF4sIycD1/LmzIQBe crZQ== X-Gm-Message-State: AHQUAubedfBJuV3fcmdrYoSjkDzoexjSgWrTXX4FdEkVu13B9gDij5JB tkQbgq4amfkrcJoM+oRyyi3vW+a27zVEICMinn0= X-Google-Smtp-Source: AHgI3IYg19qI+e8SxIgEcwghsNphBBbOMbd8JoAMf2bRV3g+BmWK61s3iETvwplmqz4xYFhpqC5f1IE2GTFoPjzowzg= X-Received: by 2002:a0c:e98f:: with SMTP id z15mr20909616qvn.115.1550567054789; Tue, 19 Feb 2019 01:04:14 -0800 (PST) MIME-Version: 1.0 References: <20190218210712.3503891-1-arnd@arndb.de> <20190218210712.3503891-8-arnd@arndb.de> <20190219021834.GA4495@guoren-Inspiron-7460> In-Reply-To: <20190219021834.GA4495@guoren-Inspiron-7460> From: Arnd Bergmann Date: Tue, 19 Feb 2019 10:03:57 +0100 Message-ID: Subject: Re: [PATCH 7/8] csky: Use latest system call ABI To: Guo Ren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190219_010416_180339_13970982 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , "moderated list:H8/300 ARCHITECTURE" , Yury Norov , y2038 Mailman List , Linux API , Joseph Myers , Palmer Dabbelt , Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Vineet Gupta , Linux ARM , "open list:QUALCOMM HEXAGON..." , Thomas Gleixner , Guan Xuetao , Stafford Horne , Mao Han , Greentime Hu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Feb 18, 2019 at 11:40 PM Joseph Myers wrote: > > On Mon, 18 Feb 2019, Arnd Bergmann wrote: > > > We don't yet have an upstream glibc port for csky, so there is no user > > We do. It's in 2.29. ... On Tue, Feb 19, 2019 at 3:18 AM Guo Ren wrote: > > Mao Han has merged csky port into glibc 2.29, so we should keep the > __ARCH_WANT_TIME32_SYSCALLS. My mistake. I've dropped patch 7/8 from this series now. > > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig > > index 6959e0b1e956..398113c845f5 100644 > > --- a/arch/csky/Kconfig > > +++ b/arch/csky/Kconfig > > @@ -1,6 +1,5 @@ > > config CSKY > > def_bool y > > - select ARCH_32BIT_OFF_T > > select ARCH_HAS_SYNC_DMA_FOR_CPU > > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > > select ARCH_USE_BUILTIN_BSWAP > > diff --git a/arch/csky/include/uapi/asm/unistd.h b/arch/csky/include/uapi/asm/unistd.h > > index ec60e49cea66..224c9a9ab45b 100644 > > --- a/arch/csky/include/uapi/asm/unistd.h > > +++ b/arch/csky/include/uapi/asm/unistd.h > > @@ -2,8 +2,6 @@ > > // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > > > > #define __ARCH_WANT_SYS_CLONE > > -#define __ARCH_WANT_SET_GET_RLIMIT > Seems it's not related to y2038 issue. Is __ARCH_WANT_SET_GET_RLIMIT no > use ? In new architectures, we do not need to set CONFIG_ARCH_32BIT_OFF_T or __ARCH_WANT_SET_GET_RLIMIT, since we can assume that user space always uses a 64-bit off_t and a 'struct rlimit' matching the kernel's rlimit64, with the prlimit64() system call replacing both getrlimit and setrlimit on the kernel/user ABI side. I don't know if glibc still uses the 32-bit off_t behavior or the old getrlimit/setrlimit, but if we're not also changing the time32 interfaces, the safest option seems to be to leave all three in place. Arnd _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD5FC43381 for ; Tue, 19 Feb 2019 09:04:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F06962146F for ; Tue, 19 Feb 2019 09:04:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uKX8usTi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F06962146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OAbBrCA1W4ouiBq4gGFoLhi7lzpoGP8UlHSwkYMj8PM=; b=uKX8usTifDnUtF +xmkM+6Q4OFxaqfZPrf5jGnftb+337c3njUo4+dBYkFr6Kzid0T/XkECPYE9yWg55liVBKMcLiOjS oH8oqYlakXHigcWQv7Dkf89+s3ei3Y6RBDsGKpJAs6y1tkll5ghEV9TI3Vnjq0JsxT0Zkwba7l2pw dmRMQwlAK45R3VC2+MjUfzIwk8lWMO1+Yho9MnIu1GbtdhvSVFLgFt4XCQKKoSBS1dIQ/V137x1Jo zGEDNnc9c0StwV6myotVVuBULY72zFP7HJte3sV2n5I2NP8cPJI9O6Vy7N/bruyVQylnA9dVgaXhj MBZrI60ckStB/n2o4Lcg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw1KP-0001Gh-E7; Tue, 19 Feb 2019 09:04:37 +0000 Received: from mail-qt1-f193.google.com ([209.85.160.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw1K3-0000yP-Sk; Tue, 19 Feb 2019 09:04:19 +0000 Received: by mail-qt1-f193.google.com with SMTP id v10so22293168qtp.8; Tue, 19 Feb 2019 01:04:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=duVmfkmCaKyI9suah2ZRlGhjzmTZPtPlQOQquFJ631U=; b=WU12qNlN1SeyyckLKRcYhAjfrXMw6vimRvVIUrqXIgKxzGtH4zb/cRl6hTY3xeSewB GksM8bFjsETPLWNpoBjUvoE5gpVfuiuG3SNPQTn5DDkqmTZULRXoH8kv36qzj6lhTO42 vCzUDJnnek9sSUC/cH5KZk0KZnv7H24CfLMaJ9EvlsKf75nsYqcGlvnhWUfMqOmSK6sF GvW9XNrJ/lcgUObVA7KgpEHUk7VNaOeKRMsMYH9cSVTDemchOWDXc6MGyPWhncSxeigL s4x3xs8rKIWdKXiblzlsxtoldEzp4v0YtW+rcUWzihu8Q7zl80YFF4sIycD1/LmzIQBe crZQ== X-Gm-Message-State: AHQUAubedfBJuV3fcmdrYoSjkDzoexjSgWrTXX4FdEkVu13B9gDij5JB tkQbgq4amfkrcJoM+oRyyi3vW+a27zVEICMinn0= X-Google-Smtp-Source: AHgI3IYg19qI+e8SxIgEcwghsNphBBbOMbd8JoAMf2bRV3g+BmWK61s3iETvwplmqz4xYFhpqC5f1IE2GTFoPjzowzg= X-Received: by 2002:a0c:e98f:: with SMTP id z15mr20909616qvn.115.1550567054789; Tue, 19 Feb 2019 01:04:14 -0800 (PST) MIME-Version: 1.0 References: <20190218210712.3503891-1-arnd@arndb.de> <20190218210712.3503891-8-arnd@arndb.de> <20190219021834.GA4495@guoren-Inspiron-7460> In-Reply-To: <20190219021834.GA4495@guoren-Inspiron-7460> From: Arnd Bergmann Date: Tue, 19 Feb 2019 10:03:57 +0100 Message-ID: Subject: Re: [PATCH 7/8] csky: Use latest system call ABI To: Guo Ren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190219_010416_180339_13970982 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , "moderated list:H8/300 ARCHITECTURE" , Yury Norov , y2038 Mailman List , Linux API , Joseph Myers , Palmer Dabbelt , Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Vineet Gupta , Linux ARM , "open list:QUALCOMM HEXAGON..." , Thomas Gleixner , Guan Xuetao , Stafford Horne , Mao Han , Greentime Hu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 18, 2019 at 11:40 PM Joseph Myers wrote: > > On Mon, 18 Feb 2019, Arnd Bergmann wrote: > > > We don't yet have an upstream glibc port for csky, so there is no user > > We do. It's in 2.29. ... On Tue, Feb 19, 2019 at 3:18 AM Guo Ren wrote: > > Mao Han has merged csky port into glibc 2.29, so we should keep the > __ARCH_WANT_TIME32_SYSCALLS. My mistake. I've dropped patch 7/8 from this series now. > > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig > > index 6959e0b1e956..398113c845f5 100644 > > --- a/arch/csky/Kconfig > > +++ b/arch/csky/Kconfig > > @@ -1,6 +1,5 @@ > > config CSKY > > def_bool y > > - select ARCH_32BIT_OFF_T > > select ARCH_HAS_SYNC_DMA_FOR_CPU > > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > > select ARCH_USE_BUILTIN_BSWAP > > diff --git a/arch/csky/include/uapi/asm/unistd.h b/arch/csky/include/uapi/asm/unistd.h > > index ec60e49cea66..224c9a9ab45b 100644 > > --- a/arch/csky/include/uapi/asm/unistd.h > > +++ b/arch/csky/include/uapi/asm/unistd.h > > @@ -2,8 +2,6 @@ > > // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > > > > #define __ARCH_WANT_SYS_CLONE > > -#define __ARCH_WANT_SET_GET_RLIMIT > Seems it's not related to y2038 issue. Is __ARCH_WANT_SET_GET_RLIMIT no > use ? In new architectures, we do not need to set CONFIG_ARCH_32BIT_OFF_T or __ARCH_WANT_SET_GET_RLIMIT, since we can assume that user space always uses a 64-bit off_t and a 'struct rlimit' matching the kernel's rlimit64, with the prlimit64() system call replacing both getrlimit and setrlimit on the kernel/user ABI side. I don't know if glibc still uses the 32-bit off_t behavior or the old getrlimit/setrlimit, but if we're not also changing the time32 interfaces, the safest option seems to be to leave all three in place. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel