From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BE67C433FE for ; Thu, 13 Jan 2022 14:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235637AbiAMOYR (ORCPT ); Thu, 13 Jan 2022 09:24:17 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:42539 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230165AbiAMOYP (ORCPT ); Thu, 13 Jan 2022 09:24:15 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MBjA4-1n2UBW0DSm-00C9MI; Thu, 13 Jan 2022 15:24:14 +0100 Received: by mail-wr1-f48.google.com with SMTP id k18so10355889wrg.11; Thu, 13 Jan 2022 06:24:13 -0800 (PST) X-Gm-Message-State: AOAM533tEZAwRlPx4iIUeWVpit2fa8o/mS27pINOdlThUZ7S/RiVKHz2 V8MmMrWiunOqBsZrvU8fCzADPvgD4hXe2W2szV4= X-Google-Smtp-Source: ABdhPJzwdYNeuVL1yYVlSfvEK+FTNzOKpNJueoBQfapcDBGMQlXdww3vJ6mdjQ5Vf5ltdNIbHFcn1y8+QiEEWUP219Q= X-Received: by 2002:a5d:6ac7:: with SMTP id u7mr4238291wrw.219.1642083853640; Thu, 13 Jan 2022 06:24:13 -0800 (PST) MIME-Version: 1.0 References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-15-alim.akhtar@samsung.com> <55c22c3a-57ea-3320-ccb9-f03643563235@canonical.com> In-Reply-To: <55c22c3a-57ea-3320-ccb9-f03643563235@canonical.com> From: Arnd Bergmann Date: Thu, 13 Jan 2022 15:23:57 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 14/23] arm64: dts: fsd: Add initial device tree support To: Krzysztof Kozlowski Cc: Alim Akhtar , Linux ARM , Linux Kernel Mailing List , SoC Team , linux-clk , DTML , Olof Johansson , Linus Walleij , Catalin Marinas , Rob Herring , Sylwester Nawrocki , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Pankaj Dubey , linux-fsd@tesla.com, Arjun K V , Aswani Reddy , Ajay Kumar , Sriranjani P , Chandrasekar R , Shashank Prashar , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:7BPRVd2KsOfp6FWr24wAaVhirUW9rNpHQv7NpYpVUsp7tt30Dha j23Kxt68dpwB+bLGGHBrcSzKIQ4yWozz8SrjACzkvHE+i6sYk/WuegjVFQk/clMoW+sBV66 dxzEdNexgwNZQOZc72vSJlCuhYLKhfGujPiZx9AcNC8A8Yz3AQ25InyytdgH2u9UdAJ1Cnw HoL0wZwLRKqo1TtUXoTOQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:/Lf+mNMsya4=:ODGibD+HcJW7nRTYSF9hYn NnndQEhNXlcWzFS0FC5kjCBHUwmGWi3JBWpP4E3ojJjycuh+WQZF2dZ3X8pM5G1PW/Pa2q4mz h7CvoTb8whYSKYbWpcf2GqqyJS63UbdJwfrQgY+RmljmcL8O+ubi1+FLTmxAU8GKMJbZ5Y+Oe jkRpXagkJ1FvcD7T0FYD6/utdUIrsAQ0DHWmh1Q7SJ1ZGnkMwW0GQ6YB1kx9uf1nZykkBSZiq OD9S2iP4reWW7HrhZxog69dGoG1VqSNQTFBzyND4NXwwjsmmtVdhIwp3jS0P7v84rKOO0xbnT DSw8vmVMXFNXk9ND7OSCuc1t++ZuVpGN8VEA+ue4IXzXYDTWMjfIWIRRcxB572mad4LzX15UO +L26WPBEnftclnZB1FO71dq5yejhJtHOSdZygvNlpIDsg9GdN8AFCPI6wEKGbU3oCWI4ivB7J v33R/zIKq4Nd3u8NE2J+vphKXc6p8kSjoV9b/HF2v16fo7lwX5Cdw5YEw0hoezzFHnnnLpfrY H6gq2ioZCCLqyzqCuXllY7rlzZcU8AsZLigNpjUHFH6QlCjr08jeuf1re8ngqSVT6sK216tuP dyP0c+3Rxdg2tNh+0beQxAk6sact2u9B/MU9JoHthtNeHoE+DbvFdWXmvP4ssDlxaQBVv/UIL JYe2Xl10EUnvLI8wkRwVb/B/M+7d6gWPoOtWUX6Cc7Z03k4OigwIfSTUy7knrxki2fJ4= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 13, 2022 at 2:16 PM Krzysztof Kozlowski wrote: > > ARM/TETON BGA MACHINE SUPPORT > > M: "Mark F. Brown" > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > index 54e3910e8b9b..bb8a047c2359 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -267,6 +267,12 @@ config ARCH_TEGRA > > help > > This enables support for the NVIDIA Tegra SoC family. > > > > +config ARCH_TESLA_FSD > > + bool "ARMv8 based Tesla platform" > > + select ARCH_EXYNOS > > How similar it is? I think it is better to duplicate Exynos > selections/options here, instead of selecting entire ARCH. If this would > require "depends on ARCH_EXYNOS || ARCH_TESLA_FSD" everywhere in the > drivers, it's a hint that it is not a separate SoC but it is an Exynos, > so it might not need a new sub-architecture. Agreed, the SoC family options mainly exist so we can quickly enable or disable drivers based on what a kernel is built for. If most of the drivers for this SoC are shared with Exynos, I think having a single option is sufficient, but it may be worth pointing out both in the help text. If we want to have a separate option (mainly to help users find it), maybe a 'depends on ARCH_EXYNOS' would be better. How many uses of ARCH_TESLA_FSD are there? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54350C433F5 for ; Thu, 13 Jan 2022 14:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AMLn4bcyIojx4f2kaLYs2oS/bBwp45Q0UkuEAc2O7q4=; b=0FzG4ltMtYoBnM d6XkocIwRAwJR4crDh4PIpDi9nbubbU0B08zO2BKN7Zpy6KPlcSbbF68c76v3fZVv4EVurEC3lPGN pgl0WOn6fkpxLY5e7PoKL5EAyPutmqMTY04J3W3wfswjmkOyhhwpbwq1IrPDtLY9RSe4SoRhVoNlF NEdjktmvXlD8+zRLxBLshBYF0qMhCHj6GO5Ygm55LnGX+N7D0bsS5Q5AKQ7SMqrRoWlBjVt1FDtiY 0N/ex2waGcsDeSXwWORuKAK8yMtNb+l0g8x2ECrN8oe+LaOI6BCcqsR5hhjwBca4xlwf5YzAzosZe IDBzznW27bVsVBjDGOKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n811a-006ErY-Tw; Thu, 13 Jan 2022 14:24:23 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n811X-006EqH-68 for linux-arm-kernel@lists.infradead.org; Thu, 13 Jan 2022 14:24:20 +0000 Received: from mail-wr1-f50.google.com ([209.85.221.50]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1Mbzdn-1md5G32dbD-00dSYw for ; Thu, 13 Jan 2022 15:24:16 +0100 Received: by mail-wr1-f50.google.com with SMTP id h10so10436183wrb.1 for ; Thu, 13 Jan 2022 06:24:13 -0800 (PST) X-Gm-Message-State: AOAM533EAjBtGueES6x6RZgNS9C6qrFvTTt6GiUQ6A6f88fjEUflz71E YXEjCqahtcr7vXUZVqOVSpkA/RvAa5kdcDk6304= X-Google-Smtp-Source: ABdhPJzwdYNeuVL1yYVlSfvEK+FTNzOKpNJueoBQfapcDBGMQlXdww3vJ6mdjQ5Vf5ltdNIbHFcn1y8+QiEEWUP219Q= X-Received: by 2002:a5d:6ac7:: with SMTP id u7mr4238291wrw.219.1642083853640; Thu, 13 Jan 2022 06:24:13 -0800 (PST) MIME-Version: 1.0 References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-15-alim.akhtar@samsung.com> <55c22c3a-57ea-3320-ccb9-f03643563235@canonical.com> In-Reply-To: <55c22c3a-57ea-3320-ccb9-f03643563235@canonical.com> From: Arnd Bergmann Date: Thu, 13 Jan 2022 15:23:57 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 14/23] arm64: dts: fsd: Add initial device tree support To: Krzysztof Kozlowski Cc: Alim Akhtar , Linux ARM , Linux Kernel Mailing List , SoC Team , linux-clk , DTML , Olof Johansson , Linus Walleij , Catalin Marinas , Rob Herring , Sylwester Nawrocki , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Pankaj Dubey , linux-fsd@tesla.com, Arjun K V , Aswani Reddy , Ajay Kumar , Sriranjani P , Chandrasekar R , Shashank Prashar , Arnd Bergmann X-Provags-ID: V03:K1:f7RIQvpM9Cakk0cyuVAnrNEIfXPkhIj8fZJL4YtiqquxdE55P4J L6n6hDAC59SKQq9w+zHJX9wSQS+U9Gq/aUIurNAwrr4e7f8m+XpIrbl58ANsaGHESEEVh7w IxyyC66JCXX6N+3OSx9d9HnJM16w7pgiy3bv2Azdhl71359E3kdxmq88nut9fsIFosDao6D xKZhmiusd8CwfO+cjjA8w== X-UI-Out-Filterresults: notjunk:1;V03:K0:bT2rSudjpBc=:bbvDZFlYq6Bngz+Swy0/rS HBY6J7zZqE53EGGu6MQ5/eG7wptEL0Aegchw1yDpq+/Bj5reiGnqcfJN4kpbaPC2JYoFWxKX8 AQN4p7Mf+pzU+HfJLhpLZ5MchPYmuvKunw+RLTyK9zGM/aCMEYK+9l7PTXaXY4JGLpMUyXy4G OneGISos2W6kE8AOe6ecqtMpJd9l3K7MYR7VJyvbZ2hpkfOujAANu4rjpX4SL1xX/hCYgJAnO Z1a6svSmQXFMWEM+Q9F0L0yQWPQyfRgyP/DOOuIIhWfTncgT9p2AFvgqWpDpORj85Y/kfaxla EqgDMeMYTuMAXephnNayJajCr82aJatF98kuVSSXrvACQXtzYpKvWuWorL/P/WUOOQU2dF44Z QbRk0FQi2cfPpV+UZW6RTx5XvjvemseLoTffWKx9EOa70ktTzJDJGqM5lXcyVd1Z0albE8OUA Vu/AoVJd/x3AUME7lqZbaa//9mXXzR7RJWj+y48uBblgRlxmU2tTLJJUqHAS3bNZ150tqWd21 1y3RwmpSPpY2hLjuX21xCvZkB0l9WXqnbucUDr5NM1u5i6PA94VxuDXeNPcxILAuJMoeV4VuW Kywq7mcJeeifXAIElq+1JkYfQpe4x9X7oyTtDfqewpcBZTEX3zTTJGWWvMonBrZOv179r9kCv Mc9FOWCotDs/pxPk3DtWeZcbUbVTwO3zul7qAPv2ZVPIFufEIc3Yy40nLObeWHJ76768= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_062419_546241_DABE0877 X-CRM114-Status: GOOD ( 20.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 13, 2022 at 2:16 PM Krzysztof Kozlowski wrote: > > ARM/TETON BGA MACHINE SUPPORT > > M: "Mark F. Brown" > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > index 54e3910e8b9b..bb8a047c2359 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -267,6 +267,12 @@ config ARCH_TEGRA > > help > > This enables support for the NVIDIA Tegra SoC family. > > > > +config ARCH_TESLA_FSD > > + bool "ARMv8 based Tesla platform" > > + select ARCH_EXYNOS > > How similar it is? I think it is better to duplicate Exynos > selections/options here, instead of selecting entire ARCH. If this would > require "depends on ARCH_EXYNOS || ARCH_TESLA_FSD" everywhere in the > drivers, it's a hint that it is not a separate SoC but it is an Exynos, > so it might not need a new sub-architecture. Agreed, the SoC family options mainly exist so we can quickly enable or disable drivers based on what a kernel is built for. If most of the drivers for this SoC are shared with Exynos, I think having a single option is sufficient, but it may be worth pointing out both in the help text. If we want to have a separate option (mainly to help users find it), maybe a 'depends on ARCH_EXYNOS' would be better. How many uses of ARCH_TESLA_FSD are there? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel